[04:19:03] (03PS8) 10Awight: Split user schema into local, global ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [04:22:45] (03CR) 10jerkins-bot: [V: 04-1] Split user schema into local, global ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [04:32:25] (03PS9) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [04:32:27] (03PS9) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [04:34:54] (03PS9) 10Awight: Split user schema into local, global ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [04:34:56] (03PS10) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [04:34:58] (03PS10) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [04:35:23] (03CR) 10jerkins-bot: [V: 04-1] Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [04:59:04] (03PS11) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [04:59:06] (03PS11) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [04:59:27] (03CR) 10Awight: Render Judgment pages as wikitext (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [06:25:10] (03PS2) 10Awight: Write tests for PageEntityJudgmentSetStorage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 [07:57:28] (03PS3) 10Awight: Write tests for PageEntityJudgmentSetStorage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 [07:57:31] (03PS10) 10Awight: Split user schema into local, global ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [07:57:32] (03PS12) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [07:57:34] (03PS12) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [07:57:36] (03PS1) 10Awight: Remove unused class [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467632 [07:57:38] (03PS1) 10Awight: Minor test cleanup [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467633 [07:57:40] (03PS1) 10Awight: TitleHelper test coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467634 [07:57:42] (03PS1) 10Awight: Improve ApiGetJudgments tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467635 [07:57:44] (03PS1) 10Awight: Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 [10:06:50] (03CR) 10Hoo man: [C: 032] Remove unused class [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467632 (owner: 10Awight) [10:11:13] (03CR) 10Hoo man: [C: 032] Minor test cleanup [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467633 (owner: 10Awight) [10:45:22] (03CR) 10Hoo man: [C: 032] Write tests for PageEntityJudgmentSetStorage (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 (owner: 10Awight) [10:47:58] (03Merged) 10jenkins-bot: Remove unused class [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467632 (owner: 10Awight) [10:48:34] (03Merged) 10jenkins-bot: Minor test cleanup [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467633 (owner: 10Awight) [10:50:10] (03Merged) 10jenkins-bot: Write tests for PageEntityJudgmentSetStorage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 (owner: 10Awight) [10:52:44] (03CR) 10Hoo man: [C: 032] TitleHelper test coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467634 (owner: 10Awight) [10:56:25] (03CR) 10Hoo man: [C: 032] Improve ApiGetJudgments tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467635 (owner: 10Awight) [11:05:42] (03CR) 10Hoo man: Split user schema into local, global ID, and IP (032 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [11:09:26] (03Merged) 10jenkins-bot: TitleHelper test coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467634 (owner: 10Awight) [11:09:28] (03Merged) 10jenkins-bot: Improve ApiGetJudgments tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467635 (owner: 10Awight) [11:34:13] (03CR) 10jenkins-bot: Remove unused class [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467632 (owner: 10Awight) [11:52:55] (03CR) 10jenkins-bot: Write tests for PageEntityJudgmentSetStorage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 (owner: 10Awight) [11:54:58] (03CR) 10jenkins-bot: Minor test cleanup [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467633 (owner: 10Awight) [11:57:06] (03CR) 10jenkins-bot: TitleHelper test coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467634 (owner: 10Awight) [12:17:34] (03CR) 10jenkins-bot: Improve ApiGetJudgments tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467635 (owner: 10Awight) [13:10:08] 10ORES, 10Scoring-platform-team, 10Growth-Team: RC filters: Un-scored Bot edits in Namespaces displayed with ORES full-coverage filters - https://phabricator.wikimedia.org/T206271 (10SBisson) [13:20:37] PROBLEM - https://grafana.wikimedia.org/dashboard/db/ores-extension grafana alert on einsteinium is CRITICAL: CRITICAL: https://grafana.wikimedia.org/dashboard/db/ores-extension is alerting: Service hits for obtaining thresholds alert. [13:21:46] RECOVERY - https://grafana.wikimedia.org/dashboard/db/ores-extension grafana alert on einsteinium is OK: OK: https://grafana.wikimedia.org/dashboard/db/ores-extension is not alerting. [13:22:03] Amir1: I 'll merge https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/467428/1/modules/ores/manifests/web.pp [13:30:28] akosiaris: awesome thanks [14:31:44] Assigned reading: https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/43146.pdf [15:09:34] That's a very funny title. [15:13:39] heh. It's a good one. Tells a story in the title. [15:25:10] (03PS1) 10Awight: Extract bad target helper for tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467717 [15:26:01] (03CR) 10Awight: Write tests for PageEntityJudgmentSetStorage (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467007 (owner: 10Awight) [15:28:26] Amir1: I'm thinking of stacking the secondary schema patches on top of the other patch train so I can continue beating on test coverage... [15:30:34] It seems like the other train is pretty inoffensive and likely to land without problems. [15:30:51] My only real concern is that reviewers are getting spammed like crazy [15:31:01] for me it's fine :D [15:31:40] awight: btw. can you cover for me for tomorrow SoS? I have to be at WMDE quarterly meeting [15:35:00] Amir1: Sure, thanks for the heads-up! [15:35:16] * awight prepares spamfloodstorm to end all spamfloodstorms [15:41:32] (03PS47) 10Awight: Secondary schema for JADE indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) [15:41:34] (03PS4) 10Awight: PSR-4 autoload tests by namespace rather than listing each class. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466805 [15:41:36] (03PS6) 10Awight: Hooks to maintain judgment link tables [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) [15:41:38] (03PS4) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [15:41:40] (03PS2) 10Awight: Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 [15:41:56] * awight rattles window pane to make the "storm" louder than it otherwise would be [15:46:21] Amir1: Also, I realized that I'm the cause of my own grief: when I stack patches like appetizers in front of the main dish, they're getting reviewed quickly but everyone is too full to reach the main course. Then I stack up more appetizers for the next day and we're in a Sisyphean pattern [15:46:50] :D [15:46:55] don't worry [15:47:00] keep up the great work [15:48:05] I keep getting distracted by snacks, though :-) [15:48:49] btw I was up to 86% test coverage a minute ago... [15:52:32] WoW [15:52:33] nice [16:35:37] (03CR) 10Hoo man: Secondary schema for JADE indexes (032 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [16:50:32] (03PS11) 10Awight: Split user schema into local ID, central ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [16:59:44] (03CR) 10Awight: Secondary schema for JADE indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [17:04:31] (03CR) 10Hoo man: [C: 04-1] "Is there a special reason for not iterating until everything is added/removed? That would probably make this quite a bit more convenient t" (039 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [17:07:07] (03PS2) 10Awight: Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 [17:07:09] (03PS13) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [17:09:43] (03CR) 10jerkins-bot: [V: 04-1] Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [17:10:31] (03PS14) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [17:13:08] (03CR) 10jerkins-bot: [V: 04-1] Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [17:13:19] * harej is taking a sick day today [17:18:45] (03CR) 10Awight: Split user schema into local ID, central ID, and IP (032 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [17:28:57] Hey folks. Just FYI, I have meeting back to back all day today :( [17:33:08] halfak: AWESOME! http://coldsprayclub.mines-paristech.fr/CSC-Life/-22-meeting-10NOV2017/photomontage-10nov2017-club_-LR.jpg/ [17:35:12] (03CR) 10Hoo man: Secondary schema for JADE indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [17:38:55] (03CR) 10Hoo man: [C: 032] Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 (owner: 10Awight) [17:44:54] awight: Mh, thinking about the users in JADE… is this compatible with user name suppression? [17:45:37] Because if the ids are part of the content, this needs to be specifically handled [17:45:45] ids as in user ids (local or global) [17:46:41] In validation you probably want these to be valid if the users are suppressed (old data should stay valid), but in display [17:47:06] * hoo just thinking out loud, maybe this is not even a problem [17:47:09] hoo: It's been a design concern--I think I see what you mean, that the WikitextRenderer needs to suppress? [17:47:31] The content can stay unsuppressed as long as they're just IDs though, right? [17:47:41] Yeah, it would need to show the suppressed name like we do on action=history [17:47:54] yeah, ids are fine [17:47:57] thanks for catching! [17:48:08] But what about validation? Would that be valid or not [17:48:19] I'm currently looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/JADE/+/461502/11/includes/JudgmentValidator.php#208 [17:48:27] that would currently fail w/ suppressed users [17:48:32] I think [17:49:16] Okay, that's surprising. I'll dig into the mw-core implementation [17:49:43] I agree that validation should succeed, either way. [17:51:09] Ok, I'll comment then [17:52:55] (03CR) 10Hoo man: [C: 04-1] "lgtm otherwise :)" (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [17:57:49] (03CR) 10Hoo man: [C: 04-1] Split user schema into local ID, central ID, and IP (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [18:09:29] (03CR) 10Hoo man: [C: 04-1] Maintenance scripts for judgment indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:15:41] srrodlund: halfak: sorry to space the meeting! [18:17:56] Join us! [18:21:19] awight, ^ [18:23:20] (03CR) 10Hoo man: [C: 04-1] Hooks to maintain judgment link tables (036 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:25:11] hoo: Awesome, thanks for keeping me busy :-) [18:41:48] 10ORES, 10Scoring-platform-team, 10Growth-Team: RC filters: Un-scored Bot edits in Namespaces displayed with ORES full-coverage filters - https://phabricator.wikimedia.org/T206271 (10SBisson) [18:45:31] (03PS13) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [18:45:33] (03PS2) 10Awight: Extract bad target helper for tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467717 [18:45:35] (03PS48) 10Awight: Secondary schema for JADE indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) [18:45:37] (03PS5) 10Awight: PSR-4 autoload tests by namespace rather than listing each class. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466805 [18:45:39] (03PS7) 10Awight: Hooks to maintain judgment link tables [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) [18:45:41] (03PS5) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [18:45:43] (03PS3) 10Awight: Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 [18:45:45] (03PS1) 10Awight: Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 [18:46:55] (03CR) 10Awight: Maintenance scripts for judgment indexes (037 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:48:33] (03CR) 10Hoo man: [C: 04-1] "Using mustache to create Wikitext, nice :)" (035 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [18:50:01] (03PS6) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [18:50:03] (03PS4) 10Awight: Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 [18:50:06] (03CR) 10Awight: Maintenance scripts for judgment indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:53:40] (03CR) 10jerkins-bot: [V: 04-1] Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:54:08] (03CR) 10Hoo man: [C: 032] Extract bad target helper for tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467717 (owner: 10Awight) [18:55:15] (03CR) 10jerkins-bot: [V: 04-1] Hooks to maintain judgment link tables [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:55:53] (03CR) 10jerkins-bot: [V: 04-1] Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:55:57] (03CR) 10jerkins-bot: [V: 04-1] Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 (owner: 10Awight) [18:56:19] (03CR) 10jerkins-bot: [V: 04-1] Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 (owner: 10Awight) [18:59:58] (03CR) 10Hoo man: [C: 032] Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) (owner: 10Awight) [19:02:17] (03CR) 10Hoo man: [C: 031] "Looks good at a glance, but getting a DBA +1 on this would be great." [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [19:03:08] (03CR) 10Hoo man: [C: 032] PSR-4 autoload tests by namespace rather than listing each class. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466805 (owner: 10Awight) [19:05:41] (03CR) 10jerkins-bot: [V: 04-1] Hooks to maintain judgment link tables [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [19:06:34] (03PS6) 10Awight: PSR-4 autoload tests by namespace rather than listing each class. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466805 [19:06:36] (03PS3) 10Awight: Extract bad target helper for tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467717 [19:08:02] (03CR) 10jerkins-bot: [V: 04-1] Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [19:10:44] (03CR) 10jerkins-bot: [V: 04-1] Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 (owner: 10Awight) [19:13:01] (03CR) 10jerkins-bot: [V: 04-1] Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [19:14:28] (03CR) 10Hoo man: [C: 04-1] Maintenance scripts for judgment indexes (034 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [19:16:08] (03CR) 10Hoo man: [C: 032] Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 (owner: 10Awight) [19:18:46] I think I reviewed them all now… that's quite a stack :) [19:24:43] That was a huge help! [19:33:05] (03PS12) 10Awight: Split user schema into local ID, central ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [19:33:07] (03PS3) 10Awight: Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 [19:33:09] (03PS15) 10Awight: Render Judgment pages as wikitext [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) [19:33:11] (03PS14) 10Awight: Tests to demonstrate SpamBlacklist integration [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464727 (https://phabricator.wikimedia.org/T206255) [19:33:15] (03PS49) 10Awight: Secondary schema for JADE indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) [19:33:17] (03PS8) 10Awight: Hooks to maintain judgment link tables [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466806 (https://phabricator.wikimedia.org/T202596) [19:33:19] (03PS2) 10Awight: Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 [19:33:21] (03PS7) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [19:33:23] (03PS5) 10Awight: Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 [19:34:52] (03CR) 10jenkins-bot: PSR-4 autoload tests by namespace rather than listing each class. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466805 (owner: 10Awight) [19:39:35] (03CR) 10jenkins-bot: Extract bad target helper for tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467717 (owner: 10Awight) [20:05:17] halfak: Amir1: Do you have a moment to assist w/ https://phabricator.wikimedia.org/T158430#4635450 [20:15:07] Can someone give me permission to create a branch on github.com/wiki-ai/revscoring? [20:15:26] username: "notconfusing". Maybe awight? [20:31:17] o/ hoo looking for next steps? [20:31:36] halfak: Yeah :) [20:36:44] halfak: Shall I go on and make this a proper feature? (Where? How would the datasource look like and where would it be?) [20:57:27] PROBLEM - ORES worker production on ores.wikimedia.org is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 INTERNAL SERVER ERROR - 6438 bytes in 5.045 second response time [21:01:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/467798 (owner: 10L10n-bot) [21:06:17] RECOVERY - ORES worker production on ores.wikimedia.org is OK: HTTP OK: HTTP/1.1 200 OK - 889 bytes in 0.089 second response time [21:09:48] PROBLEM - ORES worker production on ores.wikimedia.org is CRITICAL: CRITICAL - Socket timeout after 10 seconds [21:10:07] hoo, sorry am in meeting after meeting. [21:10:16] I think Amir1 would be a good reference if he's around. [21:10:59] Generally, I think we'll need a new revision_oriented datasource for a revision.page.property_suggestions. [21:11:33] ^ in revscoring [21:11:54] Next we'll need to implement a way to gather that data using extractors.api.Extractor [21:11:57] RECOVERY - ORES worker production on ores.wikimedia.org is OK: HTTP OK: HTTP/1.1 200 OK - 890 bytes in 0.475 second response time [21:12:03] I'm going to look at ^ [21:14:38] I don't see anything wrong. [21:14:53] Ok :) I'll give it a shot (but probably tomorrow) [21:15:17] Sorry to not be more available, hoo :( [21:15:29] I'll try to find some time to be more specific of what I have in mind. [21:17:37] 10Scoring-platform-team (Current), 10Wikilabels: Extend wikilabels to support session-labelling - https://phabricator.wikimedia.org/T201370 (10notconfusing) Yes it is. [21:18:38] 10Scoring-platform-team (Current), 10Wikilabels: Extend wikilabels to support session-labelling - https://phabricator.wikimedia.org/T201370 (10notconfusing) 05Open>03Resolved p:05Triage>03Normal [21:22:09] 10Scoring-platform-team (Current), 10editquality-modeling, 10revscoring, 10artificial-intelligence: Create a newcomerquality meta-model for revscoring - https://phabricator.wikimedia.org/T205926 (10notconfusing) Ideas for feature engineering: + Temporal + Namespace + Reverts + Includes self-reverts +... [21:38:46] (03CR) 10Awight: "squashed" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 (owner: 10Awight) [21:38:58] (03Abandoned) 10Awight: Extract link table helpers [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467761 (owner: 10Awight) [21:39:48] Looks like the downtime was a lie. [21:44:43] halfak: I think I know why, it's either 429 OR the fact that the revision might not exist (it used to be random date and it would work but we added wp10 models that use enwiki so it would fail if the revision doesn't exist) [21:44:48] (03PS4) 10Awight: Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 [21:45:06] I think it's a 500 based on the details of the alert [21:45:23] " 500 INTERNAL SERVER ERROR" [21:47:31] We shouldn't get a 500 for a missing revid [21:53:20] it's so easy to reproduce it though (I'm being sarcastic) [21:53:21] :D [22:00:00] OK I'm out of here. I hope to sign in early tomorrow to catch up on stuff for hoo and notconfusing. Have a good one, folks. [22:10:13] o/ [22:28:32] (03PS6) 10Awight: Spaces to tabs in JSON files [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466829 [22:28:34] (03PS13) 10Awight: Split user schema into local ID, central ID, and IP [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) [22:29:18] (03CR) 10Awight: Split user schema into local ID, central ID, and IP (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [22:31:10] (03CR) 10Awight: Split user schema into local ID, central ID, and IP (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/461502 (https://phabricator.wikimedia.org/T206573) (owner: 10Awight) [22:58:09] (03CR) 10Awight: Render Judgment pages as wikitext (035 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/464737 (https://phabricator.wikimedia.org/T206346) (owner: 10Awight) [23:01:09] (03CR) 10jenkins-bot: Add and fix return type hinting [extensions/JADE] - 10https://gerrit.wikimedia.org/r/467636 (owner: 10Awight) [23:02:44] (03CR) 10Awight: Secondary schema for JADE indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight)