[05:29:24] (03CR) 10Marostegui: [C: 031] "I am not completely sure about that UNIQUE key and if it is really needed, but we can re-evaluate it once we have some example queries aro" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/456078 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [07:40:11] (03PS1) 10Thiemo Kreuz (WMDE): Fix broken condition in CleanDuplicateScores script [extensions/ORES] - 10https://gerrit.wikimedia.org/r/468523 [10:57:01] PROBLEM - ping4 on ORES-web02.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.06 ms [10:57:11] PROBLEM - ping4 on Experimental ORES Website is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.62 ms [11:08:36] PROBLEM - ping4 on ORES-worker01.experimental is CRITICAL: PING CRITICAL - DUPLICATES FOUND! Packet loss = 60%, RTA = 2.38 ms [11:11:20] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.04 ms [11:11:20] PROBLEM - ping4 on ORES-redis02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.15 ms [11:16:10] RECOVERY - ping4 on ORES-worker02.experimental is OK: PING OK - Packet loss = 0%, RTA = 1.71 ms [11:16:29] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.37 ms [11:16:49] PROBLEM - ping4 on ORES-web01.Experimental is CRITICAL: CRITICAL - Host Unreachable (ores-web-01.ores.eqiad.wmflabs) [11:18:45] PROBLEM - ping4 on ORES-web01.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.40 ms [11:26:14] PROBLEM - ping4 on ORES-worker02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.01 ms [11:26:37] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 0.95 ms [11:26:54] PROBLEM - ping4 on ORES-web01.Experimental is CRITICAL: PING CRITICAL - Packet loss = 16%, RTA = 1.36 ms [11:27:54] PROBLEM - ping4 on ORES-web02.Experimental is CRITICAL: CRITICAL - Host Unreachable (ores-web-02.ores.eqiad.wmflabs) [11:28:01] PROBLEM - ping4 on Experimental ORES Website is CRITICAL: CRITICAL - Host Unreachable (ores.wmflabs.org) [11:28:56] RECOVERY - ping4 on ORES-web01.Experimental is OK: PING OK - Packet loss = 0%, RTA = 2.46 ms [11:29:58] RECOVERY - ping4 on ORES-web02.Experimental is OK: PING OK - Packet loss = 0%, RTA = 1.97 ms [11:30:05] PROBLEM - ping4 on Experimental ORES Website is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.21 ms [11:30:39] PROBLEM - ping4 on ORES-worker01.experimental is CRITICAL: PING CRITICAL - DUPLICATES FOUND! Packet loss = 16%, RTA = 1.15 ms [11:32:39] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 2.20 ms [11:33:02] PROBLEM - ping4 on ORES-web01.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.47 ms [11:34:07] PROBLEM - ping4 on ORES-web02.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.19 ms [11:34:12] PROBLEM - ping4 on ORES-worker02.experimental is CRITICAL: CRITICAL - Host Unreachable (ores-worker-02.ores.eqiad.wmflabs) [11:34:42] PROBLEM - ping4 on ORES-worker01.experimental is CRITICAL: PING CRITICAL - DUPLICATES FOUND! Packet loss = 28%, RTA = 1.04 ms [11:35:04] RECOVERY - ping4 on ORES-web01.Experimental is OK: PING OK - Packet loss = 0%, RTA = 2.31 ms [11:36:12] PROBLEM - ping4 on ORES-worker02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 3.42 ms [11:36:57] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.39 ms [11:36:57] PROBLEM - ping4 on ORES-redis02.experimental is CRITICAL: CRITICAL - Host Unreachable (ores-redis-02.ores.eqiad.wmflabs) [11:38:14] RECOVERY - ping4 on ORES-web02.Experimental is OK: PING OK - Packet loss = 0%, RTA = 1.50 ms [11:38:59] PROBLEM - ping4 on ORES-redis02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.08 ms [11:40:54] PROBLEM - ping4 on ORES-worker01.experimental is CRITICAL: CRITICAL - Host Unreachable (ores-worker-01.ores.eqiad.wmflabs) [11:41:01] RECOVERY - ping4 on ORES-redis02.experimental is OK: PING OK - Packet loss = 0%, RTA = 0.98 ms [11:41:12] PROBLEM - ping4 on ORES-web01.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 169.34 ms [11:42:24] PROBLEM - ping4 on ORES-web02.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.06 ms [11:42:54] RECOVERY - ping4 on ORES-worker01.experimental is OK: PING OK - Packet loss = 0%, RTA = 1.47 ms [11:44:13] PROBLEM - ping4 on ORES-worker02.experimental is CRITICAL: PING CRITICAL - DUPLICATES FOUND! Packet loss = 16%, RTA = 1.52 ms [11:45:08] PROBLEM - ping4 on ORES-redis02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.29 ms [11:47:01] PROBLEM - ping4 on ORES-worker01.experimental is CRITICAL: PING CRITICAL - Packet loss = 0%, RTA = 613.73 ms [11:47:20] PROBLEM - ping4 on ORES-web01.Experimental is CRITICAL: CRITICAL - Host Unreachable (ores-web-01.ores.eqiad.wmflabs) [11:48:12] PROBLEM - ping4 on ORES-worker02.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 2.00 ms [11:49:02] PROBLEM - ping4 on ORES-worker01.experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.12 ms [11:49:22] PROBLEM - ping4 on ORES-web01.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.07 ms [11:51:02] RECOVERY - ping4 on ORES-worker01.experimental is OK: PING OK - Packet loss = 0%, RTA = 0.92 ms [11:52:42] PROBLEM - ping4 on ORES-web02.Experimental is CRITICAL: PING CRITICAL - DUPLICATES FOUND! Packet loss = 28%, RTA = 147.90 ms [11:53:17] RECOVERY - ping4 on ORES-redis02.experimental is OK: PING OK - Packet loss = 0%, RTA = 1.78 ms [11:54:45] PROBLEM - ping4 on ORES-web02.Experimental is WARNING: PING WARNING - DUPLICATES FOUND! Packet loss = 0%, RTA = 1.47 ms [11:55:30] RECOVERY - ping4 on ORES-web01.Experimental is OK: PING OK - Packet loss = 0%, RTA = 0.75 ms [11:56:12] RECOVERY - ping4 on ORES-worker02.experimental is OK: PING OK - Packet loss = 0%, RTA = 1.58 ms [11:56:49] RECOVERY - ping4 on ORES-web02.Experimental is OK: PING OK - Packet loss = 0%, RTA = 0.88 ms [11:56:50] RECOVERY - ping4 on Experimental ORES Website is OK: PING OK - Packet loss = 0%, RTA = 1.79 ms [14:17:40] Hey folks. The backscroll looks CRAZY. Is icinga2 going crazy or are we burning to the ground? [14:18:12] paladox, ^ [14:18:36] o/ Amir1 [14:18:39] halfak hi, nope it was just a wmcs cloud network change (that was reverted after i notified them of it) [14:18:50] Gotcha. Thanks :) [14:19:29] Amir1, would you have some time to talk about (1) hoo's work on PropertySuggestion features and (2) the ORES api batcher I built yesterday? [14:20:31] halfak: I'm off today to let overtime go away, already mentioned that in the staff meeting and it's in the calendar too [14:22:20] Gotcha. OK. Have a good one. [15:52:57] o/ hoo [15:53:13] Thanks for getting on the reviews over the last few days ^_^ [15:53:16] hi halfak :) [15:53:28] I'll be working on a plan for PropertySuggestor features today. [15:53:33] Nice [15:53:46] I have a meeting to run to right now, but I'll be hacking on this again in an hour. [17:17:14] awight o/ [17:17:36] Say, do you know if the ORES deployment with redis and celery logs happened? [17:17:46] I see that it was merged into master. [17:25:19] halfak: No, I checked with Amir1 and it's not in production yet [17:25:27] lemme triple-check on the cluster [17:25:28] kk thanks. [17:26:12] oh dear [17:26:30] Seems to be on production. [17:26:54] Okay, I think all that happened is that I asked the wrong question yesterday. [17:27:10] The logging changes are deployed. Task tracking changes are not. [17:32:13] halfak: ^ [17:32:26] Gotcha. Thanks. [17:32:55] I was slow and demanding in reviewing the task tracking. [17:33:04] * halfak needed clear demonstration that it was working. [17:37:28] Wish we had gotten the Redis tracking onto staging for the weekend [17:37:29] meh [17:37:48] I really want to get mwpfh 0.5.2 on for the weekend :| [17:38:05] * halfak waves the "No downtime over the weekend" sign [17:38:49] breaking staging is fair, tho [17:38:55] *though [17:39:21] agreed. [17:39:32] But not beta. [18:03:38] (03PS3) 10Awight: Better signature for link table helper [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468284 [18:03:40] (03PS9) 10Awight: [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [18:03:42] (03PS2) 10Awight: [WIP] Rename shouty classes to "Jade" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468292 [18:08:36] 10Scoring-platform-team, 10articlequality-modeling, 10JavaScript, 10artificial-intelligence: Fix ArticleQuality.js so that it doesn't violate PoolCounter constraints - https://phabricator.wikimedia.org/T207505 (10Halfak) [18:10:48] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [18:12:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Rename shouty classes to "Jade" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468292 (owner: 10Awight) [18:12:38] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [18:13:28] (03CR) 10Awight: Maintenance scripts for judgment indexes (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) (owner: 10Awight) [18:13:33] (03Abandoned) 10Awight: [WIP] Rename shouty classes to "Jade" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468292 (owner: 10Awight) [18:13:51] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10Patch-For-Review, 10User-Ladsgroup: Implement JS ORES client in mw-ORES extension - https://phabricator.wikimedia.org/T201691 (10Halfak) In T207505#4681434, I describe a complete batching approach. This differs from the specifications origi... [18:13:54] (03PS6) 10Awight: Clean up test annotations; coversNothing for integration test [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468192 [18:13:56] (03PS6) 10Awight: More MoveHooks tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468193 [18:13:58] (03PS2) 10Awight: Services tests [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468280 [18:14:00] (03PS3) 10Awight: Tests for JudgmentTarget [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468277 [18:14:02] (03PS4) 10Awight: Better signature for link table helper [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468284 [18:14:04] (03PS16) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [18:14:06] (03PS10) 10Awight: [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [18:23:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [18:42:06] (03PS5) 10Awight: Better signature for link table helper [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468284 [18:42:08] (03PS17) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [18:42:10] (03PS1) 10Awight: Test fixes and coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468625 [18:43:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [18:52:43] (03CR) 10jerkins-bot: [V: 04-1] Test fixes and coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468625 (owner: 10Awight) [18:57:58] (03PS6) 10Awight: Better signature for link table helper [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468284 [18:57:59] (03PS2) 10Awight: Test fixes and coverage [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468625 [18:58:01] (03PS18) 10Awight: Maintenance scripts for judgment indexes [extensions/JADE] - 10https://gerrit.wikimedia.org/r/466808 (https://phabricator.wikimedia.org/T202596) [18:58:03] (03PS11) 10Awight: [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [19:07:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [19:11:41] * awight glares maliciously at JudgmentContent test [19:14:32] (03PS12) 10Awight: [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [19:18:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [19:24:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [19:31:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [19:33:30] * halfak glares intently at api.Extractor and dependency.Context [19:33:56] Do we wrap everything up in the revscoring monolith? Or do we find a good way to add context to an extractor. [19:34:25] awight, interested in helping me think through a thing? [19:48:48] So, we can call apiExtractor.update({"revision.page.property_suggestions": PropertySuggestionsDoc(page, extractor)) [19:50:56] We could let a custom datasource depend on a mw api session -- or maybe the extractor itself. [19:53:09] We'd need to make it so that PropertySuggestionsDoc is a root dependency and then also so that we can inject a real strategy for solving it... [19:53:11] Hmm [19:53:25] brb [20:17:02] back [20:38:09] OK. I don't think I like the injection strategy because we'd need to add context updates to models in order to discover them. [20:38:39] Alternatively, we can just engineer the feature so that it makes an API call, but that means we'll start making API calls from inside of celery. [20:38:48] And I don't like that. [20:39:08] I'd much rather implement this in the revscoring monolith [20:39:40] So I'm going to start a patch. [20:46:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468647 (owner: 10L10n-bot) [21:40:29] OMG I just implemented PropertySuggestion extraction and it worked on the first try. [21:40:35] :muscle emoji: [21:42:12] 💪💪💪 [21:43:30] ^ thanks :) [21:43:50] Our tests must be pretty good. Once I was passing tests, it just worked ^_^ [21:44:19] On top of this, I've been writing JAVASCRIPT for the last couple of days! Switching back between languages usually results in a few... hiccups. [21:44:40] 10Scoring-platform-team, 10MediaWiki-extensions-PropertySuggester, 10Wikidata, 10artificial-intelligence: [Spike] Use suggested properties to get signal for completeness - https://phabricator.wikimedia.org/T158430 (10Halfak) I just implemented https://github.com/wikimedia/revscoring/pull/414 which will giv... [21:44:41] .done().done().done()... [21:44:45] lol [21:44:55] wikimedia/revscoring#1545 (property_suggestion - 9cf0eb5 : halfak): The build failed. https://travis-ci.org/wikimedia/revscoring/builds/443903437 [21:44:58] my hope is that you used promises instead [21:45:08] .done().fail().always().never() [21:45:41] I implemented a promise hell with a cute promise paradise in JS ealier. [21:46:27] Woops! Looks like I do have a test failing after all. Doesn't take away from my victory. [21:46:49] harej, Promise paradise: https://gist.github.com/halfak/5e0c4951c52f57ff3320aff9b51b757e [21:47:32] Promise hell: https://meta.wikimedia.org/wiki/User:EpochFail/ArticleQuality-system.js [21:47:35] :D [21:47:52] I'm really proud of it though because I managed despite some severe limitations. [21:48:03] And I got a sense for managing queue processing in JS. [21:48:17] * halfak programs fun things sometimes. [21:48:53] Not just a manager/researcher/bloviator [21:51:43] OK with that, I'm out of here. Have a good one, folks! [22:22:55] wikimedia/revscoring#1547 (property_suggestion - e36ea5b : halfak): The build was fixed. https://travis-ci.org/wikimedia/revscoring/builds/443906376 [22:33:26] Whew, for a moment I thought'd I'd missed harej's presentation, but I see it's tomorrow. [22:33:48] Unfortunately I'm not sure it's being recorded [22:33:56] I could probably rig something together with my phone. [22:35:49] awight: restorative justice! i love it! [22:36:25] <3 gotta drop those buzzwords from time to time [22:36:36] You and my therapist [22:37:01] I'd say, stay focused on the presentation though, don't worry about the satellite uplink... [22:37:28] hey do you happen to have hhvm on any of your wmflabs boxen? [22:38:00] I'm looking at a very weird test failure [22:38:13] FormatJson::decode apparently is not failing for bad JSON, but only on hhvm [22:38:21] at least, that's my only guess at the moment. [22:38:58] harej: Also, do you have any JADE tech tasks in mind that I should take on next? I'm at like 92% test coverage, so that's winding down. [22:39:51] kk I found an hhvm box. [22:40:53] ugh, I hate being right. [22:41:13] json_decode('"foo": b }') == 'foo' [22:42:34] Hmm, I probably will soon. First I'll want to explore how to expose JADE in the UI [22:43:21] :D [22:43:33] With ideas there we can make those into tasks [22:43:43] Holler any time you want to bounce ideas, I think it's a fun topic. [22:53:37] That was exciting: T207523 [22:53:38] T207523: JsonContent incorrectly reports invalid JSON is valid, only on HHVM - https://phabricator.wikimedia.org/T207523 [22:58:49] (03PS13) 10Awight: Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [23:08:10] (03CR) 10jerkins-bot: [V: 04-1] Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 (owner: 10Awight) [23:11:03] * awight slips around in the mud, grasping at jerkins-bot's collar [23:16:47] (03PS14) 10Awight: Unit tests for JudgmentContent [extensions/JADE] - 10https://gerrit.wikimedia.org/r/468180 [23:48:02] This might be a good one, https://phabricator.wikimedia.org/T206352 [23:48:24] 10JADE, 10Scoring-platform-team (Current), 10Discovery-Search, 10Elasticsearch: Extract judgment data for search indexing - https://phabricator.wikimedia.org/T206352 (10awight) a:03awight