[00:27:16] RECOVERY - puppet on ORES-worker01.experimental is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [01:58:16] (03CR) 10Hoo man: [C: 032] Fix validation for an empty list of endorsements [extensions/JADE] - 10https://gerrit.wikimedia.org/r/474774 (owner: 10Awight) [02:02:38] (03CR) 10Hoo man: [C: 031] "This is rather unusual behavior in the MediaWiki context… I guess I need further digging to fully grasp this" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476446 (owner: 10Awight) [02:03:13] (03Merged) 10jenkins-bot: Fix validation for an empty list of endorsements [extensions/JADE] - 10https://gerrit.wikimedia.org/r/474774 (owner: 10Awight) [02:07:09] (03CR) 10jenkins-bot: Fix validation for an empty list of endorsements [extensions/JADE] - 10https://gerrit.wikimedia.org/r/474774 (owner: 10Awight) [02:49:46] (03CR) 10Hoo man: "Can't thoroughly review the DB scheme, the rest looks good to me" (0310 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) (owner: 10Awight) [02:58:37] (03CR) 10Hoo man: Summarize preferred judgment values in link table (031 comment) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) (owner: 10Awight) [06:45:08] 10Scoring-platform-team, 10DBA, 10MediaWiki-Database, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [07:25:53] 10Scoring-platform-team, 10DBA, 10MediaWiki-Database, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) s2 eqiad progress [] labsdb1011 [] labsdb1010 [] labsdb1009 [] dbstore2001 [] dbstore1002 [] db2095 [] db2091 []... [07:29:21] 10Scoring-platform-team, 10DBA, 10MediaWiki-Database, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [08:40:06] 10Scoring-platform-team, 10Wikibase-Containers, 10Wikidata, 10Wikilabels, and 2 others: Stretch in docker registry forces ascii encoding - https://phabricator.wikimedia.org/T210260 (10hashar) Whaou thank you Alexandros for the details. The world of locales puzzles me everytime I have to look into it. I am... [12:00:17] o/ [12:09:17] 10Scoring-platform-team, 10Wikibase-Containers, 10Wikidata, 10Wikilabels, and 2 others: Stretch in docker registry forces ascii encoding - https://phabricator.wikimedia.org/T210260 (10akosiaris) I did just do a quick check on `wikimedia-stretch` image for this ` $ docker run --rm -it docker-registry.wikim... [12:54:06] (03PS1) 10Ladsgroup: Add ceelry4 configs back to the deploy repo [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/476847 [14:07:45] (03PS2) 10Ladsgroup: Add celery4 configs back to the deploy repo [services/ores/deploy] - 10https://gerrit.wikimedia.org/r/476847 [14:36:36] 10Scoring-platform-team, 10Wikibase-Containers, 10Wikidata, 10Wikilabels, and 2 others: Stretch in docker registry forces ascii encoding - https://phabricator.wikimedia.org/T210260 (10hashar) >>! In T210260#4788689, @akosiaris wrote: > ... > so support for C.UTF-8 already exists in our images. Yes that is... [15:48:35] 10ORES, 10Scoring-platform-team, 10Operations: ORES 500s since 2018-11-29 6:25 - https://phabricator.wikimedia.org/T210701 (10jcrespo) Related to T210610 or T210575, or nothing to do? CC @Ladsgroup [15:50:21] 10ORES, 10Scoring-platform-team, 10Operations: ORES 500s since 2018-11-29 6:25 - https://phabricator.wikimedia.org/T210701 (10Ladsgroup) That was the incident: https://wikitech.wikimedia.org/wiki/Incident_documentation/20181129-ores It's not related to T210610 or T210575. They are different issues but with... [15:51:19] 10ORES, 10Scoring-platform-team, 10Operations: ORES 500s since 2018-11-29 6:25 - https://phabricator.wikimedia.org/T210701 (10jcrespo) Thank you, then I guess this can be closed as resolved, or I will let you handle it as you prefer. [15:58:11] 10ORES, 10Scoring-platform-team (Current), 10Operations, 10User-Ladsgroup: ORES 500s since 2018-11-29 6:25 - https://phabricator.wikimedia.org/T210701 (10Ladsgroup) 05Open>03Resolved a:03Ladsgroup [16:42:20] harej: I won't be able to start work until 10am, jfyi. [16:43:21] I need to run an errand, will be back soon [16:46:05] :) [17:51:07] back now [17:51:19] awight: thanks for merging the sentinel patch, now I can test it on labs :D [18:12:40] That sounds like a fun Friday activity! [19:48:07] (03CR) 10Awight: Summarize preferred judgment values in link table (038 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) (owner: 10Awight) [19:57:43] (03CR) 10Awight: "> This is rather unusual behavior in the MediaWiki context… I guess I" [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476446 (owner: 10Awight) [20:39:39] awight: haha, it gets even better. I need to have a stand-alone puppetmaster [20:39:41] :D [20:40:15] /o\ [20:40:38] Well that's how something gets to become a standard, I guess: be too annoying to replace with something better [20:41:33] https://wikitech.wikimedia.org/wiki/Help:Standalone_puppetmaster [20:41:49] hehe@ "Help:" [20:42:04] Yeah, I really like to have something easier to handle [20:42:32] "Why would I want a local Puppetmaster" is hilarious [20:42:54] "Reasons I'm doing something so obviously masochistic" [20:43:26] LOL [20:43:55] I wrote this puppet change because we don't have any puppet for sentinel: https://gerrit.wikimedia.org/r/#/c/476891/ [20:44:08] I guess this can be used later in other projects [21:05:18] (03CR) 10Awight: Summarize preferred judgment values in link table (032 comments) [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) (owner: 10Awight) [21:06:32] (03PS9) 10Awight: Summarize preferred judgment values in link table [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) [21:07:51] (03PS6) 10Awight: Add indexes to filter by judgment value [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476447 (https://phabricator.wikimedia.org/T200297) [21:07:53] (03PS2) 10Awight: Throw a fit and s/JADE/Jade/ [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476771 [21:14:23] harej: Here's something I can't get around. The content quality scale should be customizable per-wiki. [21:14:34] But also translatable! [21:15:55] We could just leave it out on the first launch [21:16:14] Well relatedly, I want to turn the scale into an integer internally. [21:16:50] there's already this, https://phabricator.wikimedia.org/diffusion/EJAD/browse/master/extension.json$72 [21:17:35] I was imagining that each wiki would override that list, but now realizing that it won't be translatable. [21:19:26] Now I'm thinking, each wiki configures a contentquality scale name, which could match the db name or not, and message keys are generated like "jade-contentquality-scale-enwiki-2-code" and "-label", translated into "GA" and "Good article" in English. [21:19:42] So the config there would be ugh [21:20:31] um, wmgJadeContentQualityScaleName['enwiki'] = 'enwiki', maybe. [21:36:58] Better though if we could reuse across many wikis? [21:37:00] what a pain [21:39:34] The database schema really does seem like it should be integers to generalize all the scale stuff away, and make e.g. "contentquality <= 3" queries possible. [21:39:47] But that begs the question of JSON schema, should that have the string labels or integers... [21:40:04] From the machine's perspective, integers I think. [22:27:21] Sort of a terrible thought. But good to catch the schema change early? [23:24:54] (03PS1) 10Awight: Define a constant for the judgment model [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476993 [23:24:56] (03PS1) 10Awight: [WIP] Store content quality as an integer index [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476994 [23:31:02] Maybe it's just `jade-contentquality-scale-2-label` and $wgJadeContentQualityLevels = 6; [23:31:17] Wikis can localize just as well with the generic message key. [23:45:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Store content quality as an integer index [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476994 (owner: 10Awight) [23:46:04] (03PS2) 10Awight: Store content quality as an integer index [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476994 [23:46:06] (03PS10) 10Awight: Summarize preferred judgment values in link table [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) [23:46:08] (03PS7) 10Awight: Add indexes to filter by judgment value [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476447 (https://phabricator.wikimedia.org/T200297) [23:46:10] (03PS3) 10Awight: Throw a fit and s/JADE/Jade/ [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476771 [23:46:12] (03PS1) 10Awight: Rename functions to match the new model name [extensions/JADE] - 10https://gerrit.wikimedia.org/r/477000 [23:49:06] (03PS11) 10Awight: Summarize preferred judgment values in link table [extensions/JADE] - 10https://gerrit.wikimedia.org/r/475932 (https://phabricator.wikimedia.org/T200297) [23:49:08] (03PS8) 10Awight: Add indexes to filter by judgment value [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476447 (https://phabricator.wikimedia.org/T200297) [23:49:10] (03PS4) 10Awight: Throw a fit and s/JADE/Jade/ [extensions/JADE] - 10https://gerrit.wikimedia.org/r/476771