[01:02:17] PROBLEM - check disk on ORES-web02.Experimental is WARNING: DISK WARNING - free space: / 1044 MB (5% inode=91%); [02:32:21] PROBLEM - check disk on ORES-web02.Experimental is WARNING: DISK WARNING - free space: / 1008 MB (5% inode=91%); [02:33:27] wikimedia/revscoring#1627 (fix_order - 0872ba5 : Amir Sarabadani): The build passed. https://travis-ci.org/wikimedia/revscoring/builds/512687106 [04:02:24] PROBLEM - check disk on ORES-web02.Experimental is WARNING: DISK WARNING - free space: / 972 MB (5% inode=91%); [05:32:28] PROBLEM - check disk on ORES-web02.Experimental is WARNING: DISK WARNING - free space: / 937 MB (5% inode=91%); [06:26:12] RECOVERY - check disk on ORES-web02.Experimental is OK: DISK OK [06:42:30] o/ [10:22:18] akosiaris: for when you have some time: https://gerrit.wikimedia.org/r/c/operations/puppet/+/499875 [11:50:01] 10Scoring-platform-team (Current), 10Cloud-VPS, 10Data-Services, 10Wikilabels, 10cloud-services-team (Kanban): Add a DNS alias for the wikilabels database (wikilabels.db.svc.eqiad.wmflabs) - https://phabricator.wikimedia.org/T219563 (10Ladsgroup) I'm all for it. We have something similar for ores redis b... [11:59:02] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10Ladsgroup) [12:31:06] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10Ladsgroup) So I looked at this. We have [[https://github.com/wikimedia/mediawiki-extensions-ORES/blob/master/tests/phpunit/includes/Api/ApiIntegrati... [15:12:00] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10Ladsgroup) p:05Normal→03High While writing the tests I realized it's just erroring out, then tried the watchlist module in localhost and it fata... [15:15:35] (03PS1) 10Ladsgroup: Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) [15:19:15] (03CR) 10jerkins-bot: [V: 04-1] Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) (owner: 10Ladsgroup) [15:21:12] (03PS2) 10Ladsgroup: Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) [15:24:21] Amir1, want me to ping anyone in particular for review for that or do you have it handled? [15:24:41] I feel like this is a good example of a patch that we should sync with the Growth team on WRT getting you consistent review. [15:24:54] (03CR) 10Ladsgroup: "It would be great if you review this, it's giving out fatals on production: https://phabricator.wikimedia.org/T210638#5069810" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) (owner: 10Ladsgroup) [15:25:38] halfak: ^ this one is important because it's giving out fatals in production. I found it when writing tests [15:27:40] 10Scoring-platform-team, 10Cloud-VPS, 10Data-Services, 10Wikilabels, 10cloud-services-team (Kanban): Add a DNS alias for the wikilabels database (wikilabels.db.svc.eqiad.wmflabs) - https://phabricator.wikimedia.org/T219563 (10Ladsgroup) [15:28:49] Amir1, right. I saw that in your notes. [15:29:34] but there's four other tickets in review columns too [15:30:19] Right so, what do you think of the question I asked re. using the API task to reach out to the Growth team officially? [15:32:41] Amir1, ^ [15:32:43] I don't understand your question [15:32:53] " want me to ping anyone in particular for review for that or do you have it handled?" [15:33:05] "this is a good example of a patch that we should sync with the Growth team on WRT getting you consistent review. " [15:33:47] * halfak tries to figure out where the Growth team hangs out. [15:33:56] I see, I already added RoanKattouw and stephanebisson to the patch but it might fall into cracks [15:34:08] Looking [15:34:22] Thanks RoanKattouw! [15:34:52] RoanKattouw: this is the only production bit: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/500062/2/includes/WatchedItemQueryServiceExtension.php [15:35:04] LGTM but I'll let others review before merging [15:35:13] hah the ores_model table is added to the query but never used?! [15:35:51] And so I guess the query results get multiplied by all the rows in the ores_model table, is that the issue? [15:37:05] RoanKattouw: The issue is that the ores_model table was added but it was never used directly (was used by ModelLookup service so not in the query) [15:37:12] that caused the query to become this [15:37:19] Ooh and the SQL error is because it joins against the wrong table [15:37:25] Copying that onto the task [15:37:41] yup [15:40:06] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10Patch-For-Review, 10User-Ladsgroup: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10Catrope) The error from logstash: ` A database query error has occurred. Did you forget to run your application's database sch... [15:40:10] OK I've added an explanation of what's going on to the task. Going to look over the tests then +2 [15:40:37] haha phabricator edit conflict [15:40:37] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10Patch-For-Review, 10User-Ladsgroup: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10Ladsgroup) Because the ores_model table is not used directly anymore it causes this query and the subsequent error: `lang=mysq... [15:40:41] Amir1: In the meantime could you change the commit summary to say something about the query error you're fixing? [15:40:55] sure [15:44:47] (03PS3) 10Ladsgroup: Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) [15:45:33] RoanKattouw: done ^ [15:45:58] (03CR) 10Catrope: [C: 03+2] Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) (owner: 10Ladsgroup) [15:46:09] Thanks! [16:00:11] (03Merged) 10jenkins-bot: Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) (owner: 10Ladsgroup) [16:09:44] o/ Amir1 [16:09:46] Standup? [16:09:59] I completely forgot [16:10:05] wait until I find a place [16:15:29] (03CR) 10jenkins-bot: Fix watchlist API [extensions/ORES] - 10https://gerrit.wikimedia.org/r/500062 (https://phabricator.wikimedia.org/T210638) (owner: 10Ladsgroup) [17:45:19] 10Scoring-platform-team, 10Cloud-VPS, 10Data-Services, 10Wikilabels, 10cloud-services-team (Kanban): Add a DNS alias for the wikilabels database (wikilabels.db.svc.eqiad.wmflabs) - https://phabricator.wikimedia.org/T219563 (10Bstorm) Cool :) Is anyone at Wikilabels using the pgsql.eqiad.wmnet DNS? I se... [18:01:37] 10Scoring-platform-team, 10Cloud-VPS, 10Data-Services, 10Wikilabels, 10cloud-services-team (Kanban): Add a DNS alias for the wikilabels database (wikilabels.db.svc.eqiad.wmflabs) - https://phabricator.wikimedia.org/T219563 (10Halfak) I don't believe we were ever using that. [18:15:04] 10Scoring-platform-team, 10Cloud-VPS, 10Data-Services, 10Wikilabels, 10cloud-services-team (Kanban): Add a DNS alias for the wikilabels database (wikilabels.db.svc.eqiad.wmflabs) - https://phabricator.wikimedia.org/T219563 (10Bstorm) Good, I'll remove that...carefully. [19:48:19] Got out first interview set up! [19:48:23] \o/ [19:51:37] one of my recent irrational obsessions is that we are going to somehow end up hiring someone named adam [19:51:43] lol [19:51:57] There have been some applicants named Adam. [19:52:06] nooooooo [19:52:09] :P [19:52:15] I mean, it's a perfectly fine name. It'll just be weird. [19:52:39] We'd have to adopt qualifiers. "Old Adam", "New Adam", etc. [19:52:55] Could be a good IRC handle that fixes everything. [19:53:07] Like, if we hired an Aaron, y'all can just call me "halfak" [19:53:14] Or maybe "Dr. Halfaker" [19:53:16] ;) [19:58:10] New Adam and Adam Classic [19:58:25] I did once refer to a Dr. Morgan in a job interview [19:58:53] He'd love to know that :D [19:59:01] Talking to a director --> interview jitters that would've existed anyway --> err toward excess formality [19:59:24] We were all in Vienna by coincidence and this director who interviewed me wished "Dr. Morgan" a good morning. [19:59:31] I think it was one of those power moves [19:59:56] Anyways, that's how I met Toby Negrin [20:00:17] ha. [22:07:04] (03CR) 10Jdlrobson: [C: 03+2] "Hitting +2 on the basis that the Depends-On will likely land Monday. Someone should feel free to +2 if I haven't managed to do that after " [extensions/ORES] - 10https://gerrit.wikimedia.org/r/499791 (https://phabricator.wikimedia.org/T219238) (owner: 10Ladsgroup) [23:04:12] PROBLEM - check disk on ORES-web02.Experimental is WARNING: DISK WARNING - free space: / 1080 MB (5% inode=91%);