[15:20:40] 10ORES, 10Scoring-platform-team, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10Krinkle) [15:20:52] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10Krinkle) [15:21:20] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10Krinkle) (Tagging Growth-Team, the MW-integration part of this exte... [15:21:24] shoot [15:21:31] I have a meeting all morning that I forgot about [15:24:24] so I'll talk to you tomorrow [15:31:33] groceryheist, no standup for you? [15:31:38] hare, standup? [15:34:37] yeah [15:34:44] i have to get out the door [16:47:22] (03PS1) 10Kosta Harlan: Disable broken test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/513315 (https://phabricator.wikimedia.org/T224672) [16:47:50] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10kostajh) a:03kostajh I'll disable the ORES... [17:00:34] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10kostajh) So the expected value for damaging -... [17:06:47] (03CR) 10Sbisson: [C: 03+2] Disable broken test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/513315 (https://phabricator.wikimedia.org/T224672) (owner: 10Kosta Harlan) [17:10:53] (03Merged) 10jenkins-bot: Disable broken test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/513315 (https://phabricator.wikimedia.org/T224672) (owner: 10Kosta Harlan) [17:13:02] (03CR) 10jenkins-bot: Disable broken test [extensions/ORES] - 10https://gerrit.wikimedia.org/r/513315 (https://phabricator.wikimedia.org/T224672) (owner: 10Kosta Harlan) [17:27:37] ok I'm back in action [17:41:05] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10kostajh) The wikibase test fails because `tes... [18:15:42] o/ groceryheist [18:16:38] I'm hoping to ask you to do a bit of code review for me today. Do you think you could spare an hour or so? [18:16:57] I'm thinking that getting on a call together could allow us to cover some ground really quickly. [18:18:04] totally [18:18:35] Great! I'll stick something on your calendar... Hmm. Maybe at 1PM PDT? [18:18:48] sounds good [18:19:17] Thanks :) [18:20:13] want to send the code first? [18:37:27] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10MediaWiki-extensions-WikibaseClient, and 4 others: ORES/ChangesListHooksHandlerTest causing build failures in other repos (e.g. UploadWizard) - https://phabricator.wikimedia.org/T224672 (10kostajh) [19:36:25] 10Scoring-platform-team, 10revscoring, 10Chinese-Sites, 10artificial-intelligence: Tokenization of "word" things for CJK - https://phabricator.wikimedia.org/T111179 (10Halfak) See related work here: https://www.mediawiki.org/wiki/User:TJones_(WMF)/Notes/Nori_Analyzer_Analysis [20:01:51] o/ groceryheist [20:01:54] Can you hear me? [20:01:56] I can't hear you [20:15:55] (03PS1) 10Jforrester: Disable broken test [extensions/ORES] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513375 (https://phabricator.wikimedia.org/T224672) [20:16:00] (03CR) 10Jforrester: [C: 03+2] Disable broken test [extensions/ORES] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513375 (https://phabricator.wikimedia.org/T224672) (owner: 10Jforrester) [20:20:55] (03Merged) 10jenkins-bot: Disable broken test [extensions/ORES] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513375 (https://phabricator.wikimedia.org/T224672) (owner: 10Jforrester) [20:28:37] (03CR) 10jenkins-bot: Disable broken test [extensions/ORES] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513375 (https://phabricator.wikimedia.org/T224672) (owner: 10Jforrester) [21:11:54] groceryheist, see |lunch is now known as ebernhardson [21:12:10] Trying again: https://github.com/wikimedia/editquality/blob/master/editquality/utilities/autolabel.py#L182 [21:12:20] sorry ebern.hardson [21:17:07] groceryheist, forgot to say, Thanks for your help getting that reviewing done! [21:17:11] okay... taking notes [21:17:49] you're welcome [21:18:36] wikimedia/editquality#559 (min_samples_leaf - d9801c7 : halfak): The build passed. https://travis-ci.org/wikimedia/editquality/builds/539414538 [21:18:42] just discussed with marshall about ORES for german wikipedia. he is fine to have his team do the implementation but his team lacks capacity to do the consensus-building process. he asked me to be responsible for that. i agreed, by which i mean i agreed to shepherd the process with WMDE, and I ultimately think they should own that process [21:18:57] halfak, is there anything you should add that would close the loop? [21:19:48] harej, hmm. If Marshall's team is not staffed to announce a deployment, then I'm not sure they are staffed to maintain RCFilters. [21:20:07] I don't think they need to "build consensus" Just announce the deployment and respond if concerns are raised. [21:20:27] Obviously there are a bunch of German Wikipedians who want ORES -- they did a ton of labeling work! [21:20:43] Marshall assured me explicitly that the RCFilters part would be easy. The consensus part – be it identifying an existing one or forging one anew – is what they lack capacity for. [21:21:12] My point is, we figured out a split of responsibilities and I am wondering if you think my understanding is complete. [21:23:12] Or if there are other details [21:24:35] 10Scoring-platform-team, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Patch-For-Review, 10User-Harej: Enable ORES RCFilters for German Wikipedia (dewiki) - https://phabricator.wikimedia.org/T215354 (10MMiller_WMF) a:05MMiller_WMF→03Harej I discussed this with @Harej, and he is goin... [21:25:05] harej, it certainly shouldn't be our responsibility to work through this issue. It's not our UI. [21:25:23] Also. I think I just deleted all of my zhwiki work >:( [21:25:30] oh no! [21:25:34] i just went ? [21:25:49] force-pushed? [21:27:18] nl looks fine to me [21:31:41] I fixed it. Oof. [21:31:49] Must have messed up my rebase. :| [21:32:12] glad to know I'm not the only one who gets confused by rebase [21:33:00] Oh yes. They might as well name that command to "git aim-gun-at-foot" [21:35:30] groceryheist, I have to run but I'll come back later to work on reverted model stuff. [22:40:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/513455 (owner: 10L10n-bot) [23:14:22] back! [23:28:25] wikimedia/editquality#569 (revert_models - 0043d73 : halfak): The build passed. https://travis-ci.org/wikimedia/editquality/builds/539460792 [23:47:42] OK. That's some good progress. I'm out. [23:47:42] o/ [23:49:16] OK [23:49:17] later [23:50:34] want me to merge the new zhwiki config too? [23:51:34] still looks like NB is winning [23:51:37] so I guess now [23:51:39] *not [23:52:09] halfak: of note, during the hackathon, reedy fixed the issue with schema drift between master and beta clusterr [23:52:16] another jade-related thing may have happened. don’t remember [23:52:25] That's amazing! [23:53:27] I was worried it was some boondoggle! They just didn’t write migrations when changing the schema. Whoever “they” refers to. 🧐 [23:53:39] I improved the time to revert models, and still don't find anything [23:53:48] seems like a very robust null [23:54:10] i'm thinking about looking at it through an ITS lens again [23:54:31] i realized that ITS can be a better way to get at the ETT [23:55:38] i'm going to take a break [23:55:57] will look at your work soon