[00:14:58] haha, halAFK [00:32:24] 10Scoring-platform-team, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30): Contribution page: 'Hide probably good edits' displays entries that do not get ORES highlighted - https://phabricator.wikimedia.org/T176667 (10Etonkovidova) 05Open→03Resolved Checked the fix in betalabs... [14:07:59] o/ [14:27:32] wikimedia/articlequality#191 (enwiki_sfn_retrain - 2f5f18a : Aaron Halfaker): The build passed. https://travis-ci.org/wikimedia/articlequality/builds/563577408 [14:46:08] * halfak starts pulling hair. [14:46:09] https://github.com/pypa/setuptools/issues/1390 [14:46:15] This is insane. >:( [14:50:49] Getting this code into pypi is so frustrating. We had a good few years of distutils working pretty well. Now we switch to twine for *reasons* and everything is finicky. WHY? [15:44:05] OMG the issue the whole time is that I referenced the directory rather than the specific file. [15:44:44] I got "InvalidDistribution: Unknown distribution format: ''" [15:45:01] Somehow means, "You gave me a folder, but I was looking for files within that folder" [15:45:12] * halfak cries quietly. [15:49:26] OK we now have a release of a feature set for articlequality! articlequality==0.4.1 [15:50:23] wikimedia/articlequality#194 (master - 33379c3 : halfak): The build was broken. https://travis-ci.org/wikimedia/articlequality/builds/563620084 [15:51:30] no [15:51:32] lame [15:53:18] wikimedia/articlequality#195 (readme_release - ca0c2c8 : halfak): The build failed. https://travis-ci.org/wikimedia/articlequality/builds/563621440 [15:53:46] Yeah yeah. Looks like (1) pytest is broken and (2) we need to merge an old PR to fix our tests. [15:54:02] accraze, got a minute to look at https://github.com/wikimedia/articlequality/pull/86 ? [15:54:19] It just removes old examples that don't work anymore and are totally unnecessary. [15:55:07] merged! [15:55:23] Thanks. That might fix some of the issue with CI. [15:57:44] Aha. Looks like we pinned an old version of more-itertools in revscoring and it is conflicting with pytest's dependencies. [15:57:45] yay! [16:17:57] wikimedia/ores#1353 (precache_schema_field - e75655e : halfak): The build was fixed. https://travis-ci.org/wikimedia/ores/builds/563631407 [16:18:11] Damned right [16:18:40] accraze, ^ https://github.com/wikimedia/ores/pull/328 [16:29:38] nice! [16:29:40] merged [16:49:38] halfak or accraze: I'm confused about the features for a Wikidata revision... [16:49:40] https://www.wikidata.org/w/index.php?title=Q7159670&oldid=983627501 [16:49:47] https://ores.wikimedia.org/v3/scores/wikidatawiki/983627501/itemquality?features [16:50:33] ORES says 35 references and 20 unique ones, but I count only 19 total when I add up all the references on the item. [16:51:29] 10Scoring-platform-team, 10Edit-Review-Improvements-Integrated-Filters, 10editquality-modeling, 10Chinese-Sites, and 2 others: Deploy ORES filters for zhwiki - https://phabricator.wikimedia.org/T225562 (10SBisson) a:03SBisson [17:13:01] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: On en.wikipedia, ref tags inserted by the shortened footnote template, {{sfn}}, are not counted in ORES features - https://phabricator.wikimedia.org/T227153 (10Halfak) https://github.com/wikimedia/articlequality/pull/88 I also inclu... [17:13:02] 10[1] 10https://meta.wikimedia.org/wiki/Template:sfn [17:14:53] 10Scoring-platform-team (Current): Create task for Associate Engineer position - https://phabricator.wikimedia.org/T228901 (10ACraze) @Halfak This looks good, I've got nothing to add. [17:15:24] ragesoss, interesting. I'm looking now. [17:15:42] 10Scoring-platform-team (Current): Create task for Associate Engineer position - https://phabricator.wikimedia.org/T228901 (10Halfak) Great! Thank you. [17:15:51] 10Scoring-platform-team (Current): Create task for Associate Engineer position - https://phabricator.wikimedia.org/T228901 (10Halfak) 05Open→03Resolved [17:17:11] wikimedia/articlequality#198 (retrain_enwiki_sfn - e7d39ba : Aaron Halfaker): The build failed. https://travis-ci.org/wikimedia/articlequality/builds/563653775 [17:17:22] wikimedia/revscoring#1660 (nodupes_in_trim - 14ef08f : halfak): The build passed. https://travis-ci.org/wikimedia/revscoring/builds/563652184 [17:17:32] Looks like we are counting sources here: https://github.com/wikimedia/revscoring/blob/master/revscoring/features/wikibase/datasources/revision_oriented.py#L137 [17:18:01] Aha! We're counting up all of the claims in each reference! [17:18:35] Nice spot ragesoss. I think that looking at reference *claims* is fine, but we want this feature to be limited to refs themselves. Maybe we can have a different feature for ref claims. [17:20:33] 10Scoring-platform-team, 10revscoring, 10artificial-intelligence: Wikibase references is a count of ref claims, should be reference statements - https://phabricator.wikimedia.org/T229029 (10Halfak) [17:20:55] accraze, if you get bored, check out that task ^ [17:21:14] Gist is that we loop too deep. [17:21:46] sounds good halfak, i'll take a look this afternoon [17:22:22] I'll be back in a bit. I'm going to pedal to the University [17:38:06] (03PS1) 10Anomie: Update for removal of $wgActorTableSchemaMigrationStage [extensions/ORES] - 10https://gerrit.wikimedia.org/r/525602 (https://phabricator.wikimedia.org/T188327) [18:32:00] 10Scoring-platform-team, 10Community comms and outreach, 10CommRel-Specialists-Support (Jul-Sep-2019): Community Relations Specialist support for Scoring Platform - https://phabricator.wikimedia.org/T217232 (10Halfak) It just occurred to me that this work might align with @Rfarrand's work on setting up small... [19:01:20] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: trim() function returns duplicates of features - https://phabricator.wikimedia.org/T229049 (10Halfak) [19:01:29] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: trim() function returns duplicates of features - https://phabricator.wikimedia.org/T229049 (10Halfak) a:03Halfak https://github.com/wikimedia/revscoring/pull/443 [19:03:39] 10Jade, 10Scoring-platform-team (Current), 10User-Testing, 10Design: Jade Wireframes: Diff view controls - https://phabricator.wikimedia.org/T212377 (10Halfak) Looks like this wasn't ready for review after all. I'm moving it back to the "active" column so I can work on it later. [19:22:46] accraze, just updated https://www.mediawiki.org/wiki/JADE/Glossary [19:22:59] Working through API spec now. [19:24:27] cool, the spec will need to change label -> proposal [19:53:54] I'm digging into the spec now. I want to talk to you about a few changes I think *might* make sense. [19:54:02] I'll get an example chunk of data we can look at together. [19:54:07] accraze, ^ [19:59:53] sounds good [20:58:01] accraze_lunch, https://etherpad.wikimedia.org/p/jade_schema_v3 for when you get back. [21:02:36] 10Jade, 10Scoring-platform-team (Current): Write API contract for Jade - https://phabricator.wikimedia.org/T217904 (10Halfak) OK. I've created a new iteration on the schema. https://etherpad.wikimedia.org/p/jade_schema_v3 I solved a few problems where we were using "oneOf"s that would have allowed for misma... [21:02:46] Notes ^ for your review. [21:07:57] 10Jade, 10Scoring-platform-team (Current): Write API contract for Jade - https://phabricator.wikimedia.org/T217904 (10Halfak) See also updates to https://www.mediawiki.org/wiki/JADE/Glossary Biggest change is that a collection of "proposals" is now called a facet. I like the word "facet" because it means bo... [21:11:57] (03PS1) 10Sbisson: [WIP] Maintenance script to help model configuration [extensions/ORES] - 10https://gerrit.wikimedia.org/r/525655 [21:21:49] 10Jade, 10Scoring-platform-team (Current): Write API contract for Jade - https://phabricator.wikimedia.org/T217904 (10Halfak) Re. the API spec. I wonder if we can limit our endpoints and handle most of the logic for the user. E.g. if a user calls action=jadePropose, there are four possible states: 1. The en... [21:22:32] OK I figured out an example from which to make some suggestions about the API strategy. I'm curious to see if accraze_lunch thinks I'm crazy or if this proposal is a reasonable direction to go. [21:24:27] 10Jade, 10Scoring-platform-team (Current): Write API contract for Jade - https://phabricator.wikimedia.org/T217904 (10Halfak) BTW, my main motivation for this proposal is to make work for 3rd party tool devs as easy as possible. It would be nice if they could call a single endpoint with the same data and have... [21:49:11] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: Improved error logging for cv_train - https://phabricator.wikimedia.org/T229063 (10Halfak) [21:49:17] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: Improved error logging for cv_train - https://phabricator.wikimedia.org/T229063 (10Halfak) a:03Halfak https://github.com/wikimedia/revscoring/pull/440 [21:49:52] * halfak builds sphinx docs for review. [21:51:28] hmm. Hanging for a looong time on "loading intersphinx inventory from https://pythonhosted.org/revscoring/objects.inv..." [21:52:57] ahh yeah we can probably delete the intersphinx stuff in the conf.py [21:53:06] I don't think I wound up using it [21:53:16] will push up a change [21:53:48] kk [21:54:03] It's weird that it is so slow though. Hmm [21:54:10] It should work! [21:54:36] * halfak comments out and tries again [22:03:11] OK Just left a note there about my thoughts. Looks like you put a good amount of work into this and I like it very much :) [22:03:13] accraze, ^ [22:03:35] It makes me sad to look at our README in this repo. [22:03:45] You can really tell that we focused doc efforts on revscoring :| [22:04:18] I've got to hit the road, so I'll leave things here today. I put a few little things in the review column. If you get a chance, have a look. But no rush on any of them. [22:04:23] Have a good evening! [22:05:13] cool thanks halfak, i'll take a look at the review column and api spec, have a good one! [23:16:35] 10Scoring-platform-team, 10Community comms and outreach, 10CommRel-Specialists-Support (Jul-Sep-2019): Community Relations Specialist support for Scoring Platform - https://phabricator.wikimedia.org/T217232 (10mcruzWMF) >>! In T217232#5366443, @Halfak wrote: > It just occurred to me that this work might alig... [23:17:38] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: Improved error logging for cv_train - https://phabricator.wikimedia.org/T229063 (10ACraze) @Halfak looks good, merged!