[03:59:23] halfak: here is my github - https://github.com/kevinbazira [09:43:58] hello kevinbazira ! [09:44:20] hello gehel o/ [13:28:07] o/ kevinbazira! [13:28:28] halfak o/ [13:28:51] How's getting revscoring's tests running going? [13:29:37] It's going good so far! [13:30:24] I will let you know in case of any challenges [13:31:36] Great. I just sent you an invite to the Wikimedia organization on github [13:31:53] If you don't have 2FA set up, you'll want to do that ASAP. [13:34:17] kevinbazira, ^ [13:35:09] Alright thanks. Let me do that right away! [13:46:54] I have joined. Thanks for the invitation halfak. [13:48:04] Nice. [14:50:30] 10Jade, 10ORES, 10Scoring-platform-team, 10ApiFeatureUsage, and 23 others: All API help links should use `Special:MyLanguage` - https://phabricator.wikimedia.org/T231269 (10alaa_wmde) [15:54:49] 10Scoring-platform-team, 10editquality-modeling, 10artificial-intelligence: Why is jawiki's goodfaith model so bad? - https://phabricator.wikimedia.org/T230953 (10Keegan) This page isn't very active. I think we need to ask some others to look at the post, or put a notice about the post up somewhere more effe... [16:00:27] 10ORES, 10Scoring-platform-team (Current), 10Operations, 10serviceops, 10Patch-For-Review: celery-ores-worker service failed on ores100[2,4,5] without any apparent reason or significant log - https://phabricator.wikimedia.org/T230917 (10Joe) First of all, apologies for losing track of this task. What you... [16:01:15] o/ accraze [16:01:43] mornin halfak [16:02:26] Y: I worked on Kevin's onboarding documentation and a bit of session orientation. T: Meeting, onboarding, and session-orientation (pretty close to an updated PR) then I'm generating some historical data for groceryheist. [16:03:00] Feeling way better today. I slept a ton yesterday. It's weird because I also slept a ton the night before too. [16:03:43] good to hear :) [16:06:22] my update: [16:06:28] Y: Re-enabled csrf tokens for jade api modules, got tokens working with tests, did some codesniffer-related clean up, worked a bit more on testing ProposeOrEndorse [16:06:28] T: Finish up ProposeOrEndorse test (specifically the move endorsement piece). Docs/comments, more codesniffer cleanup, looks like I need to rebase my patchset too. Might clean up warning handling as well. [16:07:50] BTW accraze, I forgot to bring up moving meetings. I think it makes sense to move our meetings 1 hour earlier in the day across the board. This causes a few conflicts that I'm hoping we can work out. I hope this will make it so kevin.bazira can attend our regular standups. [16:08:12] It means every day is an 8AM day for you though :| [16:12:36] hmm that could probably work, lets see how it goes [16:14:10] Thank you for your flexibility. I certainly wouldn't be stoked to have a regular 8AM meeting so I appreciate you being accommodating. [16:18:16] 10ORES, 10Scoring-platform-team (Current), 10Operations, 10serviceops, 10Patch-For-Review: celery-ores-worker service failed on ores100[2,4,5] without any apparent reason or significant log - https://phabricator.wikimedia.org/T230917 (10Halfak) Thanks @Joe and no worries. I'm happy to move this one off... [17:17:41] 10Scoring-platform-team, 10LDAP-Access-Requests, 10Operations, 10SRE-Access-Requests: Grant LDAP to Kevinbazira - https://phabricator.wikimedia.org/T234209 (10Dzahn) [17:18:14] 10Scoring-platform-team, 10LDAP-Access-Requests, 10Operations, 10SRE-Access-Requests: Grant LDAP to Kevinbazira - https://phabricator.wikimedia.org/T234209 (10Dzahn) adding SRE-Access-Requests because it's more than just LDAP. Involves also shell access. [17:19:53] 10Scoring-platform-team, 10LDAP-Access-Requests, 10Operations, 10SRE-Access-Requests: Grant LDAP groups and deployment shell access to Kevinbazira - https://phabricator.wikimedia.org/T234209 (10Dzahn) [17:20:04] 10Scoring-platform-team, 10LDAP-Access-Requests, 10Operations, 10SRE-Access-Requests: Grant LDAP groups and deployment shell access to Kevin Bazira - https://phabricator.wikimedia.org/T234209 (10Dzahn) [17:20:57] 10Scoring-platform-team, 10LDAP-Access-Requests, 10Operations, 10SRE-Access-Requests: Grant LDAP groups and deployment shell access to Kevin Bazira - https://phabricator.wikimedia.org/T234209 (10Dzahn) p:05Triage→03Normal [18:56:08] * halfak watches tests start to pass with wide eyes. [19:32:41] 10Scoring-platform-team, 10editquality-modeling, 10artificial-intelligence: Why is jawiki's goodfaith model so bad? - https://phabricator.wikimedia.org/T230953 (10Halfak) Thanks, @Keegan! I wonder if there is a place that patrollers in jawiki gather and discuss issues of counter-vandalism. That seems like... [19:35:53] 10Scoring-platform-team, 10editquality-modeling, 10artificial-intelligence: Implement hunspell dictionary for euwiki article quality model - https://phabricator.wikimedia.org/T223788 (10Halfak) This is live. I'm hoping to make this one of the intro tasks for our new engineer, @kevinbazira. He's still just... [20:07:22] halfak: if I have about 35 students, and each of them are making about 50k article quality score requests to ORES, spread haphazardly over the next two weeks... will this impact the system in an adverse manner? [20:07:43] Hey J-Mo. I don't expect it to be an issue. [20:07:56] Are they writing python? [20:07:59] yah [20:08:08] We have a client they can use. [20:08:14] pip install ores [20:08:37] from ores.api import Session [20:10:17] nice. I'll add that to the instructions. [20:16:10] I'll write you a little script demoing [20:16:19] :D [20:20:52] J-Mo, https://gist.github.com/halfak/1da2fa804eaabe896078461c550ef3be [20:21:11] This session API will employ parallelization and batching in ways that we like. [20:21:22] 50 revid batches and 2 parallel querying threads. [20:21:37] But the API is simple so your students won't need to think about any of that, as you can see :) [20:22:07] They can give it a list of 50k revids and the session client will behave well. [20:22:44] I'll suggest that they use this option, and provide the sample code and rationale. I think that many of them will be curious enough about ORES that they'll opt to do this rather than hammering the API with individual requests. [20:23:24] My only request is you tell them not to use threads or thread pools. [20:23:44] The only way they'll run into trouble is if they spawn 1000 threads and send us 1000 parallel requests :( [20:23:57] Happily, they'll get an error from us and not cause any downtime. [20:24:15] But that error is likely to be confusing. [20:28:51] I'll deliver that message! Thanks, halfak [20:31:45] groceryheist, are all of these thresholds for enwiki? [20:32:02] Oh! Found the wiki.db column [20:36:29] * halfak compiles super old numpy [20:37:10] wikimedia/revscoring#1730 (session_orientation - 073b4bd : halfak): The build was broken. https://travis-ci.org/wikimedia/revscoring/builds/592215551 [20:37:40] Hmm. I have questions. [20:37:52] It looks like these commits are way to recent to reference these old fitness statistics. [20:37:59] I could generate them manually though. [21:02:44] halfak: o/ [21:17:03] 10ORES, 10Scoring-platform-team (Current), 10Operations, 10serviceops, 10Patch-For-Review: celery-ores-worker service failed on ores100[2,4,5] without any apparent reason or significant log - https://phabricator.wikimedia.org/T230917 (10akosiaris) 05Open→03Resolved I 'll resolve this, all workers hav... [21:38:49] Hey codezee [21:38:55] How are you doing? [21:43:59] hey groceryheist [21:44:07] What was your process for getting historical versions of model files. [21:44:18] This is the first time I've actually needed to get historically versions. [21:44:50] git reset doesn't revert the files to their historical state. [21:47:37] git checkout -f [21:48:09] and then to load the model I install the correct version of revscoring [21:48:14] and dependencies [21:49:56] halfak: thanks! [21:50:02] Aha. When i do a git reset it doesn't update the lfs files. [21:50:13] ah yeah [21:50:14] Checkout does! [21:50:30] * halfak starts over again [21:52:38] groceryheist, you only need the fields filled in that have a string like "precision_at_recall(0.9)" right? [21:52:49] And you want the probability threshold. [21:53:04] yeah [21:56:45] Cool [22:00:15] 10Scoring-platform-team, 10Analytics, 10Analytics-Kanban, 10EventBus, 10Patch-For-Review: Change event.mediawiki_revision_score schema to use map types - https://phabricator.wikimedia.org/T225211 (10Ottomata) The Hive table is looking good and new data is coming in. I moved the old data away and created... [22:05:33] Man. We had some goofy thresholds for wikidata for a while. [22:05:57] groceryheist, I just shared my work with you. [22:12:39] thanks! [22:19:07] running some errands, back in a bit