[13:38:33] o/ [13:58:23] Good morning halfak o/ [13:58:39] I made a PR: https://github.com/wikimedia/ores/pull/333 for the task you gave me yesterday: https://phabricator.wikimedia.org/T232005 [13:58:48] When you get a minute please help review. Thanks! [13:59:03] Awesome. I just had a look and left some notes. [13:59:39] 10ORES, 10Scoring-platform-team (Current), 10good first bug: Limit rev_ids in an ORES request to 50. - https://phabricator.wikimedia.org/T232005 (10Halfak) https://github.com/wikimedia/ores/pull/333 I just added some notes. [14:37:54] Thanks halfak. I've fixed it based on your notes! [14:42:15] * halfak looks again [14:46:27] kevinbazira, one more minor note and otherwise looks good. [14:51:12] Just saw a commit. looking again :) [14:52:10] kevinbazira, I think we should include a test somewhere. I'm looking for the right place to put it. [14:53:24] Ooh. We can add a test to https://github.com/wikimedia/ores/blob/master/ores/utilities/test_api.py [14:53:38] That might be the best way to ensure the error works as expected. [14:54:54] Great. Was seeing some here: https://github.com/wikimedia/ores/blob/master/tests/test_score_request.py [14:58:29] https://gist.github.com/halfak/fdfdf0c4750e0a5a162c444ba99d2699 [14:58:36] kevinbazira, that could go into test_api.py [15:00:28] 10Scoring-platform-team, 10Analytics, 10Event-Platform: Produce a ORES score event for HDFS - https://phabricator.wikimedia.org/T225210 (10Halfak) [15:00:33] 10ORES, 10Scoring-platform-team, 10Analytics, 10Analytics-Kanban, and 5 others: Emit revision-score event to EventBus and expose in EventStreams - https://phabricator.wikimedia.org/T167180 (10Halfak) [15:23:14] halfak, I've added the test. [15:23:20] Awesome. Checking it out. [15:53:19] Just finished the FAT* rebuttal. Oof. It was a heavy lift. I kind of want to publish the rebuttal now :) [17:26:42] accraze & kevinbazira: Thanks for joining! I think it'll be fun to talk more about making bringing AIs to users easier and the new models we are developing in future research group meetings. [17:29:01] I agree, definitely interesting stuff :) [17:33:05] Thanks for inviting us halfak :) [17:33:18] Am going offline. Good day to the both of you! [19:14:29] accraze, do you know if there is a nice way in OOJSUI to have an icon in a button (or any other element) where the icon has an arbitrary color applied? [19:14:58] E.g. "give me the 'edit' icon in #ac6600" [19:15:20] I'm wondering if having icons in our label data visualization is going to be a technical hurdle. [19:15:33] Or of OOUIJS just makes that easy. [19:20:01] hmm that's a good question [19:20:42] i think we would just create an additional css class with that color and apply it to the icon [19:23:06] i'm not entirely sure if that's how it works in OOUI, maybe that's something I look into during the spike [19:23:43] OK sounds good. [19:23:46] I think the rounded pill labels would be a good backup if the icons aren't working [19:23:55] OK agreed. :) [19:24:17] Would it be easiest if I delivered a set of PNGs? [19:24:31] yeah that should be fine [19:24:43] OK I'll get that together and upload 'em to phab. [19:52:01] I just realized I was missing the manual revert workflow. I'm getting some designs together for that now. [20:25:42] OK! I think I have all of the workflows accounted for. [20:25:46] * halfak checks. [20:26:07] I think we're going to need to iterate on some bits later. [21:19:29] 10Jade, 10Scoring-platform-team (Current): Design Jade entity UI - https://phabricator.wikimedia.org/T212370 (10Halfak) ## The basic UI Expanded: {F30878875} All collapsed: {F30878870} ## Basic actions Propose a label: {F30878874} Endorse a label: {F30878931} ## Advanced actions (rare) ### Labels Labe... [21:19:40] accraze, https://phabricator.wikimedia.org/T212370#5604761 [21:19:47] I give you THE MOTHERLOAD [21:20:05] Apparently it is Motherlode* [21:20:55] Which is the principal vein of an ore or mineral -- which is a datamining metaphor just like "ORES" and "Jade". Now you can tell you friends and family that you work in the "mines" ;) [21:21:47] I'm going to go lay down for a bit. Inkscape is trying to slowly destroy me [22:06:24] awesome will check it out! [22:09:55] goin to the post office, brb [23:42:13] halfak: made another tweak to the historical scorer to use model_info to get the right versions of revscoring [23:42:31] there were still a few cases where relying on wheels and deploy didn't get the right versions installed