[15:09:56] hello halfak can you help take a look at the PRs when chanced? so I can have them merged and work on other tasks I find interesting. [15:13:21] Hey haksoat! [15:14:25] Hello [15:14:45] Just merged the readme PR. It looks like the idioms PR just needs tests. [15:16:57] 10ORES, 10Scoring-platform-team (Current), 10Operations: Ores celery OOM event in codfw - https://phabricator.wikimedia.org/T242705 (10akosiaris) >>! In T242705#5860019, @Halfak wrote: > I'd like to try deploying this change on Monday's deployment window. +1. Since we have a way to reproduce, we can test... [15:20:08] haksoat, ^ [15:20:17] Any questions about where to put the test? [15:20:22] Or how to write it? [15:20:58] I have issues with writing it [15:21:19] This is because I don't fully understand what I'm going to be testing [15:22:15] haksoat I tried writing one using pre-existing tests as an example, but it failed at some point and wasn't able to fix it. [15:22:32] halfak I tried writing one using pre-existing tests as an example, but it failed at some point and wasn't able to fix it. [15:23:03] Let me make a gist [15:23:13] Thanks [15:28:23] haksoat, https://gist.github.com/halfak/dd44bf445f437cf1687a110ef0779fe0 [15:28:58] Taking a look... [15:31:24] halfak Thanks. I'll write the test and push. [17:08:14] halfak I have pushed the changes [19:12:35] haksoat, looks great. I'll merge it today. [19:16:21] Yaaaaaaaayyyyyyyyyyyyy [19:21:29] merged! [19:21:39] I need to run and grab lunch. [19:21:42] Back in an hour or so [21:20:54] Victory. ORES deployment complete. [21:21:03] Getting some recommendations together for the Growth team [21:32:07] 10Scoring-platform-team, 10Discovery-Search (Current work), 10Growth-Team (Current Sprint): Newcomer tasks: set initial thresholds for ORES articletopic - https://phabricator.wikimedia.org/T244297 (10Halfak) +1 to @tgr. "Useful threshold" depends on what you are optimizing for. I've added my python scrip... [21:38:18] accraze, I'm just about to jump into reviewing your gerrit patchset. Is now a good time? [21:45:00] yeah that patchset should be good to go! [21:48:43] 10Scoring-platform-team, 10Discovery-Search (Current work), 10Growth-Team (Current Sprint): Newcomer tasks: set initial thresholds for ORES articletopic - https://phabricator.wikimedia.org/T244297 (10Tgr) @Halfak any thoughts on how to set thresholds for the interwiki-based cross-wiki scores? Should those ju... [21:56:33] 10Scoring-platform-team, 10Discovery-Search (Current work), 10Growth-Team (Current Sprint): Newcomer tasks: set initial thresholds for ORES articletopic - https://phabricator.wikimedia.org/T244297 (10Halfak) That's a good question. If they are using the enwiki model -- even crosswiki-- they should probably... [22:07:34] Cool. [22:07:43] accraze, what is this for? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/+/552616/28/resources/api/client.js [22:08:57] it's a base client class that is inherited for each of the api module clients [22:09:36] Oh. So each operation gets it's own client? [22:11:14] yep [22:12:12] * halfak looks for where this all comes together [22:12:53] aha! require( 'jade.api' ).DeleteEndorsementClient; [22:13:38] yep all clients are in the jade.api module, there is one class for each api module [22:18:10] I'm confused about how the await syntax works with a function that merely returns a result. I thought there'd be some special API for something that could be ready to "await". [22:18:12] Looking at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/+/552616/28/resources/api/client.js#23 [22:18:31] does api.postWithEditToken block? [22:21:19] that should return a Promise, which the 'await' operator then handles [22:26:06] Oh! I see! [22:26:18] I read "res" as result and I guess in a way it is. [22:33:53] ahh yeah, i was thinking of res as resolved lol. basically once the promise gets resolved, if successful we do a page reload, otherwise an error gets resolved and we display it on the form. [22:35:15] but yeah it is more like a result in a way [23:02:21] accraze, is there a practical difference between ClassName.parent and ClassName.super? [23:04:16] I see a mix of usage. Looks like dialogs use ClassName.super and widgets use ClassName.parent [23:04:44] ahh ClassName.parent is Jquery and ClassName.super is just plain js [23:05:59] Oh! So there's a meaningful different about when each is used but they do the same thing? [23:06:10] pretty much yes [23:06:39] Say. when you say " ClassName.parent is Jquery" do you mean it is OOJSui? [23:07:24] sort of, we're working with the jquery $element inside of an OOJSui object [23:07:53] Aha. It looks like I should be more clear. [23:07:56] Compare https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/+/552616/28/resources/widgets/EndorsementWidget.js#27 [23:08:15] With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/+/552616/28/resources/dialogs/ProposeNewLabelDialog.js#20 [23:11:27] hmm good question, taking look because now i'm confused [23:13:44] Heh. I'm kind of grasping here as there's plenty of JS I'm not very familiar with. I'll try to keep geese chasing to a minimum. [23:14:08] * halfak pulls out an idiom in celebration of haksoat's work :) [23:25:11] ahh yeah so it's actually OO.ui.Widget.parent we are calling there, and in the Dialogs we're just using js's super() method to access inherited properties, methods, etc. [23:25:53] In both of these examples, you're calling the parent's constructor, right? [23:26:20] yeah it's just calling the parent's constructor, just different syntax [23:29:03] Cool. That makes sense. [23:54:04] ahh shoot, just saw the commit author on that patchset is "Vagrant Default User", will push up a fix