[00:50:34] 10Scoring-platform-team, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Define configuration for ORES drafttopic search - https://phabricator.wikimedia.org/T243359 (10Tgr) From the spreadsheet in T244192#5850209: {P10406} [00:54:21] 10Scoring-platform-team, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Define configuration for ORES articletopic search - https://phabricator.wikimedia.org/T243359 (10Tgr) [13:10:43] 10Scoring-platform-team, 10Discovery-Search, 10Growth Design, 10Growth-Team (Current Sprint): Newcomer tasks: UX changes for ORES topics - https://phabricator.wikimedia.org/T244421 (10RHo) [13:25:04] 10Scoring-platform-team (Current), 10articlequality-modeling, 10artificial-intelligence: Improve ORES articlequality feature extraction for images - https://phabricator.wikimedia.org/T180822 (10HAKSOAT) Hello @Halfak I think this task requires PRs on the revscoring and articlequality repos. I just opened on... [15:01:16] woops. Forgot to switch my username. :) [15:01:48] hey kevinbazira! How's hacking? [15:02:00] I'm slowly following you down the rabbit hole of Jade dev :) [16:02:45] kevinbazira & accraze: standup? [16:02:59] Or rather sync/retro :) [18:19:57] Hello halfak, can you help take a look at my PR when chanced? [18:20:19] wil do [18:20:21] *will [18:20:26] thanks haksoat :) [18:20:28] I'm also not sure why Travis says the tests fail. On looking at the log, it passes the tests. [18:20:32] ETA 2 hours [18:20:44] Okay. Great. Thanks. [18:20:54] I'll check on that. Could be flake8 [19:28:38] accraze|afk, here's the css I extracted from a VE page load: https://gist.github.com/halfak/8a777a9836f97aa5f6fa15145fb6a8de [19:28:53] The CSS might be different for LTR wikis. [19:28:58] *RTL [19:42:59] accraze|afk, looks like I am stuck on the issue with node versions. Any tips for installing a compatible version of node? [19:48:36] I just got v12. Fingers crossed [19:49:11] "Notice: /Stage[main]/Npm/Package[nodejs]/ensure: ensure changed '12.15.0-1nodesource1' to '6.17.1-1nodesource1'" That seems bad. [19:49:25] But the provision succeeded? [20:47:04] that node version should be fine halfak [20:47:18] it just needs to be node v10+ [20:48:24] oh wait... just looked at the notice message [20:49:17] did you do `vagrant hiera npm::node_version: 10 && vagrant provision` ? [21:01:02] Oh. ha. I did not. Just installed my own version and told it to try to provision jade again. Seemed to work :) I'm half way through clicking around review work. [21:01:13] I should probably set that so vagrant doesn't go crazy huh? [21:01:46] I missed line 5. Should have read better [21:02:29] interesting that it works though [21:05:02] accraze, I was still getting "Warning: Scope(Class[Eventgate]): eventgate requires NodeJS version 10 but was 6. To use it, set npm::node_version: 10 in hieradata/common.yaml. (Might break other services.)" even after running that command so I just manually added npm::nodeversion: 10 in hieradata/common.yaml and it is not complaining anymore. [21:05:11] "ensure: ensure changed '6.17.1-1nodesource1' to '10.19.0-1nodesource1'" [21:06:48] ahh ok gotcha, yeah I had to do something similar when I first installed [21:07:11] i think Kevin only needed to run the command [21:08:20] Heh. Well, I updated the docs just in case. I left both instructions. Maybe if I would have followed your instruction from the start, the command would have worked :) [21:16:14] accraze, I've got a bunch of notes on the UI. Would you rather get them in the review and make an iteration or should I file some follow-up tasks to fix these things after we merge? [21:16:58] * halfak is just stoked he actually completed the review today. [21:17:05] I'll go whatever direction you prefer :) [21:17:31] i think a followup task would be great since merging would help Kevin & I get our branches sorted out [21:18:12] also it's alot more cohesive once you apply kevin's styling patchset [21:18:26] Right on. I'm going to +2 and file a follow-up. OK if I stick the follow-up task in active and assign it to you? [21:18:36] I thought at least one of my notes might be addressed there :) [21:18:55] go for it! [21:20:12] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10Halfak) [21:22:10] I just did a CR+2. I'll wait on Jenkins to verify. Is that right? [21:22:35] i believe so [21:23:17] OK cool. Then I think that's the last bit. Nice work. I hope https://phabricator.wikimedia.org/T245311 is straightforward enough. [21:23:50] awesome, thanks! [21:24:21] yeah this patchset is good, some of these are addressed in kevin's patchset, and some are api related bugs that I will fix next week [21:24:33] ^ phabricator task [21:25:33] good point on indicating a wait when doing an api call [21:26:01] Solid. I'll dig through some i18n to see if I can help out with messages. I already found a missing error message so I'll propose something. [21:42:45] we could also use an official description for Edit Quality, right now I just stuck the definition of a facet from the glossary into our i18n message [21:44:15] ^ for help text popup [22:02:41] accraze, on it. [22:02:52] Oh! I need to review haksoat's PR first. [22:10:58] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10Halfak) Looks like the message we want for U1 is `jade-nochange`. For UI2, I don't see an error message in the list. Here's my proposed en and qqq: * en: `"jade-alreadyendorsed": "Cannot endor... [22:18:04] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10Halfak) For the help information for edit quality: * en: `"jade-facet-editquality-desc": "What's the quality of this edit? Productive edits are good changes that should be kept. Damaging edits a... [22:29:53] im gonna make a separate task for the diff widget to keep details together if that's cool [22:35:39] 10Jade, 10Scoring-platform-team (Current): Implement Diff view for Jade Entity UI - https://phabricator.wikimedia.org/T245316 (10ACraze) [22:37:00] 10Jade, 10Scoring-platform-team (Current): Implement Diff view for Jade Entity UI - https://phabricator.wikimedia.org/T245316 (10ACraze) [22:37:02] 10Jade, 10Scoring-platform-team (Current), 10Design: Implement Jade Entity UI - https://phabricator.wikimedia.org/T208819 (10ACraze) [22:38:32] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10ACraze) [22:38:34] 10Jade, 10Scoring-platform-team (Current), 10Design: Implement Jade Entity UI - https://phabricator.wikimedia.org/T208819 (10ACraze) [22:49:54] 10Jade, 10Scoring-platform-team (Current), 10Patch-For-Review: Implement Diff view for Jade Entity UI - https://phabricator.wikimedia.org/T245316 (10ACraze) [22:54:44] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10ACraze) Thanks for the review @Halfak. Your proposed error messages all look good to me. I believe UI4 might be solved in @kevinbazira 's styling patchset (T242648). All others seem to be API bug... [22:58:33] 10Jade, 10Scoring-platform-team (Current): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10ACraze)