[08:56:08] 10Scoring-platform-team, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint), 10Patch-For-Review: Define configuration for ORES articletopic search - https://phabricator.wikimedia.org/T243359 (10kostajh) a:03Tgr Updating status and assignee per the patch ^ [13:56:27] I've got to run the dog to the vet so I'll be a bit later today [17:07:19] wikimedia/wikilabels#519 (install_docs - eda67cd : halfak): The build failed. https://travis-ci.org/wikimedia/wikilabels/builds/654467946 [17:46:14] 10Scoring-platform-team (Current), 10Wikilabels: Wikilabels docs -- Make install docs better - https://phabricator.wikimedia.org/T244151 (10Halfak) https://github.com/wikimedia/wikilabels/pull/260 [17:54:02] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10Halfak) See related task: {T218132} [17:55:30] 10Scoring-platform-team, 10drafttopic-modeling, 10Documentation, 10good first task: Add topic information to the ores-support-checklist - https://phabricator.wikimedia.org/T245068 (10Halfak) p:05Triage→03Medium [17:58:51] 10Jade, 10Scoring-platform-team (Current), 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10Patch-For-Review: Schema drift between Beta Cluster and Jade repo - https://phabricator.wikimedia.org/T223747 (10Halfak) 05Open→03Resolved a:03Halfak Thank you for taking this on @Reedy. We'll be working with t... [18:09:21] 10Scoring-platform-team, 10Discovery-Search, 10Growth Design, 10Growth-Team (Current Sprint): Newcomer tasks: UX changes for ORES topics - https://phabricator.wikimedia.org/T244421 (10Catrope) a:03Catrope [18:47:47] Hello halfak I am considering importing the re module and doing a findall() to get the patterns of interest that indicate an image while parsing the tags. [18:48:35] Will this be a good choice to make? [18:50:11] Also, I figured that all media files that are in the gallery tags will have an image, even if it's an audio file like .ogg which will have an image generated. Hence, do we still need to track file extensions? [18:53:55] 10Jade, 10Scoring-platform-team (Current), 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25): Address Jade UI issues. - https://phabricator.wikimedia.org/T245311 (10ACraze) [19:32:38] +1 haksoat [19:33:17] if you follow the patterns from https://github.com/wikimedia/revscoring/blob/master/ipython/feature_engineering.ipynb you should be able to depend on the result of template_str and tag_str [19:41:49] 10Scoring-platform-team (Current): Handle empty Jade pages - https://phabricator.wikimedia.org/T246033 (10ACraze) [19:44:16] 10Jade, 10Scoring-platform-team (Current): Handle empty Jade pages - https://phabricator.wikimedia.org/T246033 (10ACraze) [19:50:25] lunch! [20:06:32] lunch run, back in a bit [21:02:31] back! forgot to say [21:10:07] Trying to get nodejs to run on my laptop so I can defeat these style issues is surprisingly difficult. [21:18:06] yeah halfak, it was a bit confusing for me too. i had to do something like `sudo apt-get install nodejs` and a separate `sudo apt-get install npm` to get it to work [21:18:34] Looks like I need to install the right version of node too :| [21:18:49] \o/ and it works! [21:19:45] nice [21:20:44] i've been using nvm to manage node versions and it's been pretty easy [21:20:47] https://github.com/nvm-sh/nvm [21:21:20] Ack! It looks like our stylelint is failing when it encounters perfectly valid CSS. [21:21:24] Looks like the style is out of date. [21:21:29] https://www.sitepoint.com/understanding-and-using-rem-units-in-css/ [21:21:33] "rem" units [21:24:44] Aha! It's been explicitly blacklisted. [21:28:27] Sometimes I hate javascript. Apparently this is bad: foo.hasOwnProperty("bar"); [21:28:38] And the right way to do this is Object.prototype.hasOwnProperty.call(foo, "bar"); [21:28:41] WHY [21:33:28] lol yeah the prototypal inheritance safety stuff drives me up the wall sometimes too :) [22:58:06] accraze, re that JS pattern. It's probably over my head, but I don't get the difference between the two except that the second call would let you circumvent any overriding logic for hasOwnProperty -- which does not seem like a good idea in general. [22:58:17] I assume that I would want whatever overrides to manifest. [22:58:28] But I really don't have a good sense for JS best practices :\ [23:04:16] * halfak watches wikilabels tests with great interest. [23:14:56] c'mon travis. Why do you always do this to me at the end of the day? [23:15:04] yep halfak you've got the general idea [23:15:35] * halfak is stuck on "job received" while he's trying to gear up to head out. [23:16:07] a js object could technically be null, so its safer to call the object.prototype method [23:16:47] also yeah i noticed the travis jobs have been stalled all day :| [23:21:51] Oh interesting re. Null. [23:22:21] null.hasOwnProperty("bob") --> Uncaught TypeError [23:22:33] Object.prototype.hasOwnProperty(null, "bob") --> false [23:22:41] Huzzah! Thanks accraze [23:34:51] OK I'm giving up on travis. See y [23:34:55] 'all tomorrow [23:34:55] o/