[12:08:17] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10kostajh) @Chtnnh cool! So, I think {T240558} is not so relevant here. As far as... [12:51:51] 10ORES, 10Scoring-platform-team, 10Commons, 10Community-Tech: Create a ML model to score new files in commons for copyvio issues - https://phabricator.wikimedia.org/T230561 (10Aklapper) [14:53:34] hello halfak! [14:53:46] any update on the articlequality numbers for ptwiki [14:54:07] if you are free we can collaborate on the feature_list for ptwiki now [14:55:27] I'm working on a new run now. I had some bugs in the last run for extracting labels. Once that is done, we'll know what kind of label counts we can expect for training. In the meantime, yes let's look at the feature list. [14:55:43] I think the enwiki.py list will be a good starting point for getting our features together. [14:56:04] We'll want to implement count of infoboxes and citation_needed templates based on the notes that GoEThe gave us in the phab task. [14:56:10] chtnnh, ^ [14:56:36] yes thats right [14:56:47] Side note, I just got saddled with a bunch of work for the upcoming "tuning session" for the technology department so I'm going to be doing a bunch of bureaucratic work over the next week. [14:57:21] I don't think that will slow us down chtnnh. But it will mean that I'm slowing down on some other work I had planned around Jade outreach. [14:57:30] oh of course, I understand. I will try working on this on my own dont worry [14:57:35] I was brewing a user testing session with dev users. That might need to way. [14:57:40] you can work on Jade if thats necessary [14:57:41] ^ re. Jade. [14:57:54] I want to see it come out sooner :D [14:58:08] heh. It's cool. let's work on feature lists! I'll just be slightly more absent and in meetings than usual. [14:58:11] Yes! [14:58:26] okay let me just open up my copy of enwiki [14:58:33] I'm really stoked that we're close to a Jade deployment. It's going to disrupt a lot of things in a good way. [14:59:07] :D it should [14:59:30] the first time you told me about it, i thought that IS clever [15:02:22] right so we need to include infobox and citations needed in the feature-list for sure [15:02:24] 10Jade, 10Scoring-platform-team: Add a confirmation dialog to Jade - https://phabricator.wikimedia.org/T247462 (10kevinbazira) a:03kevinbazira @Halfak I have ended up using the MW bubble notification to give users feedback/confirmation that their action was successful. [15:12:42] halfak what are who_templates in the feature_lists? [15:13:00] We can probably skip that. I think it's english Wikipedia specific. [15:13:22] aha, okay [15:13:42] It's like {{citation needed}} but you would use it in a place where someone put a pronoun in the article (e.g., "he said it was bad") but it's unclear who is being referred to. [15:13:43] 10[1] 10https://meta.wikimedia.org/wiki/Template:citation_needed [15:14:00] So you'd do something like "he{{who}} said it was bad" [15:14:01] 10[2] 04https://meta.wikimedia.org/wiki/Template:who [15:14:59] so are we sure that ptwiki uses the same templates for references? [15:15:11] aha i get it [15:22:59] :) right. let's work from GoEThe's notes and we can run some tests against real articles in ptwiki to make sure our assumptions are working as expected. [15:41:22] halfak o/ [15:41:49] I finally figured out how to use the native MW toast element in Jade after page reload: https://media.giphy.com/media/VdKg6LrbZW16S0l90c/source.gif [15:43:57] Nice! [15:44:31] 10Jade, 10Scoring-platform-team (Current), 10Patch-For-Review: Add a confirmation dialog to Jade - https://phabricator.wikimedia.org/T247462 (10kevinbazira) [15:44:31] And it looks exactly like the preferences one! [15:44:37] kevinbazira, amazing work [15:44:38] I love it. [15:45:56] kudos kevin [15:46:28] Thanks to you halfak for showing it to me. It helped us not roll our own :) [15:46:45] \o/ [15:47:08] akf for a bit. [16:40:00] 10Jade, 10Scoring-platform-team (Current), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Clean up naming conflicts around writing secondary schema data for Jade - https://phabricator.wikimedia.org/T235003 (10ACraze) [16:46:52] back! [16:46:54] And in a meeting [16:50:45] let me know when youre back after lunch :D [16:53:16] It's OK I'm around while doing lunch today, Too many meetings to actually take lunch. [17:05:33] ouch [17:24:30] Async time! Prepare for the flood! [17:24:32] kevinbazira: [17:24:32] Y: [17:24:32] Reviewed Andy's patchsets [17:24:32] - 585037 (Rename ProposalPageWikitextRenderer -> EntityPageWikitextRenderer) [17:24:32] - 585048 (Rename ProposalSummarizer -> EntitySummarizer) [17:24:33] I have been digging into mw-notification-area toast that Aaron shared with me comparing it with the Jade toast element I had created. [17:24:36] https://github.com/wikimedia/mediawiki-debian/blob/025bd8113a281ec6052ce81dccbf3c6038f45f5e/resources/src/mediawiki/mediawiki.notification.js [17:24:39] I'm yet to understand how extensions can utilize mw-notification-area toast before we roll our own Jade toast element. [17:24:42] T: [17:24:44] Reviewed Andy's patchsets [17:24:46] - 585315 (Rename ProposalValidator -> EntityValidator) [17:24:48] - 585346 (Rename ProposalTarget -> EntityTarget) [17:24:50] Added MW bubble notification for jade-updateproposal ( 👉 Demo: https://media.giphy.com/media/VdKg6LrbZW16S0l90c/source.gif ) [17:24:53] I finally found the native MW toast element ( Thanks to Aaron who showed me where it appears in MW preferences ). MW calls it a bubble notification. Here is how to use it in an extension: https://www.mediawiki.org/wiki/Bubble_notifications#API [17:24:59] accraze: [17:25:01] Y: Continued work on fixing the naming conflicts related to Jade 2ndary integrations, got 2 classes down, only one more to go [17:25:04] T: Rename ProposalEntityType -> EntityType and then will start working on re-enabling the hook tests (i.e. updating test fixtures to use our new jsonschema) [17:25:07] halfak: [17:25:09] Y: Helped chtnnh on some of his proposed work related to ptwiki. I also sync'd up with Guillaume L. He had some good ideas for how we might use search infrastructure for tokenization but he didn't think he'd be able to spare a co-mentor for haksoat. So I think we'll be on our own. Lots of good work we can still do with tokenization of wikitext on our side. I met with Kevin and talked to him about notifications and advised him on some [17:25:14] similar notifications in MW. I also met with Nate to discuss his work on measuring ORES bias. We're trying to get some more data but it seems pretty clear to us that ORES *does not* make patrollers *more biased* against anons and newcomers despite internal biases in the predictions. [17:25:18] T: I'm basically in meetings all day. It's mostly tuning (quarterly review) and metrics-related. I got assigned a big chunk of our department's narrative around machine learning work so I'll be doing a lot of work today and in the next couple of weeks to discuss work across the department in a slide deck. It's all due next Tuesday. [17:46:08] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10Chtnnh) @kostajh Thank you for the pointers. I will treat them as a step-by-step... [18:03:30] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10PageCuration: Add ORES topic prediction to the NewPagesFeed - https://phabricator.wikimedia.org/T218132 (10Chtnnh) a:03Chtnnh I do have some questions though @kostajh Does this task require me to implement the model from scratch and integrate it into th... [18:05:00] 10ORES, 10Scoring-platform-team, 10Growth-Team, 10PageCuration: Add ORES topic prediction to the NewPagesFeed - https://phabricator.wikimedia.org/T218132 (10Chtnnh) @Halfak The second link seems to be broken, could you help me find that resource please? @kostajh thank you for the green light, I am on it.... [18:52:14] chtnnh, still around? [18:54:17] ofcourse senpai [18:54:41] working on the text complexity report as of now [19:01:05] Cool. I was curious how ptwiki features were going [19:01:54] I have taken the enwiki file and customized it for ptwiki [19:02:07] that is, I have removed idioms, text complexity and who template [19:02:27] halfak^ anything else you would like to see in it? [19:02:28] Nice. PR up yet? [19:02:34] Na. Let's start with that [19:02:35] let me get that for you now [19:10:57] https://github.com/wikimedia/articlequality/pull/109 [19:11:06] Here it is halfak^ [19:11:15] I think there are some issues with the commits please have a look [19:32:05] Looks like you're on the same branch you were before. You need to start a new branch. [19:32:09] Back in 30 to help. [19:42:12] i did switch to a new branch [20:00:06] Looks like it pulled all of the other changes over. Here's the simplest solution I can think of. (1) copy your version of ptwiki.py to ptwiki.py.bak [20:00:25] (2) switch to the master branch. Pull down changes from the wikimedia repo [20:00:43] (3) create a new branch "git checkout -b ptwiki_features" [20:01:07] (4) mv your work on ptwiki.py.bak to "ptwiki.py" [20:01:11] commit and try again. [20:03:53] let me try that and let you know [20:11:10] still the same issue senpai [20:11:26] i had pulled the changes when I did it the last time as well [20:11:51] github says my fork is 4 commits ahead of wikimedia/articlequality [20:11:57] halfak^ [20:15:05] It sounds like your master is messed up. [20:15:17] indeed :( [20:15:47] Hmm. We need to get your master branch in line with wikimedia/articlequality [20:16:59] Try "git checkout master" and "git fetch upstream" [20:17:42] If it says you don't have an "upstream", try "git remote add upstream https://github.com/wikimedia/articlequality" [20:17:48] And try again. [20:19:06] chtnnh, ^ [20:21:47] i do have the upstream [20:22:29] all this while i have been git pulling i think i should have git fetched [20:24:34] it returned a 504 [20:28:46] What returned a 504? [20:29:48] the git fetch [20:29:58] this is starting to confuse me [20:30:00] let me tell you [20:30:18] i git pull every time before i push to get changes from upstream [20:30:28] and it said alaready up to date [20:30:30] so i pushed [20:30:36] halfak^ [20:32:34] Hmm. It's surprising that it returned a 504. [20:32:45] Can you paste the command and output? [20:32:57] git fetch upstream [20:33:37] fatal: unable to access 'https://github.com/wikimedia/articlequality/': The requested URL returned error: 504 [20:34:02] Aha. It has a slash on the end. [20:34:11] Not sure if that matters. But I don't like it. [20:34:26] Try editing your .git/config file in your local directory [20:34:42] hmm let me try and change that [20:35:36] I just ran a test and it seemed to work for me with the slash. [20:36:05] yep it worked now [20:36:10] i removed the slash [20:36:11] oh good. [20:36:35] OK now do "git reset upstream/master --hard" [20:36:47] That will clean up your master branch and remove the commits you don't want in it. [20:37:06] shouldnt it be git reset origin/master [20:37:43] nope. Your origin is wack [20:37:51] ;P [20:38:09] XD okay [20:39:42] its running [20:40:21] done [20:40:47] now i think i should checkout from this master [20:40:59] and add ptwiki and then push the changes to my fork [20:41:43] Wait. Before you do anything you need to fix your wack master on your remote. [20:41:48] *origin rather [20:41:51] thought so [20:42:03] So you want to do "git push origin/master --force" [20:42:07] aha [20:42:17] That should bring your origin up to match upstream. [20:42:27] Then you origin and local master should be good :) [20:42:56] These changes are distructive. I double-checked that I had a copy of your text complexity work before I advised you to do all this just in case we lost it. [20:45:09] woah [20:45:12] did not know that [20:51:21] i switched to a new branch from this fixed master [20:51:26] and added the ptwiki.py [20:54:31] and now github wont work for me [20:54:35] halfak^ [20:57:21] what does "won't work" mean? [20:57:42] Also, I don't get pinged for halfak^ because it doesn't match "\bhalfak\b" for some reason. [20:57:52] You probably want to ping me with "halfak ^" [20:57:58] (note the space) [20:58:03] okay senpai [20:58:06] haha [20:58:35] wont work meaning the site itself is giving me a 504 when i try to access my profile on firefoxx [20:58:52] Eek. I wonder if there is some sort of connection issue? [20:58:59] The site not loading is weird. [20:59:34] exactly [21:02:49] I just got a 504 too [21:02:52] lol [21:03:10] so that worked out amazingly XD [21:03:18] looks like this work is destined for tomorrow [21:03:27] Indeed. Good progress anyway. [21:03:40] thank you :D [21:04:01] im excited for the meeting tomorrow!! [21:05:25] Me too. :) [21:05:29] Hey clemons! Just noticed you were online. How are you? [21:06:00] I've been talking to accraze about the work you were looking at with KubeFlow and he's interested in looking at it too. [21:09:02] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10Halfak) I'm worried that adding topic predicitions to ores_classifications might... [21:15:11] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10Chtnnh) @Halfak is there a way to loop in someone who would know about ElasticSe... [21:36:16] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10MediaWiki-Recent-changes: Expose ORES topics in recent changes filters - https://phabricator.wikimedia.org/T245906 (10Halfak) @Gehel or someone on his team might be able to help with some insights.... [21:52:51] 10Jade, 10Scoring-platform-team, 10Huggle: Write Huggle labels to Jade - https://phabricator.wikimedia.org/T238877 (10Halfak) [21:54:26] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Growth-Team, 10MediaWiki-Recent-changes, 10Regression: Indicators for problematic changes (r) are missing from RC - https://phabricator.wikimedia.org/T248557 (10Etonkovidova) Thanks @matej_suchanek Confirmed - !!r!! is not present on Recent changes... [21:57:05] 10Jade, 10Scoring-platform-team (Current), 10Patch-For-Review: Add a confirmation dialog to Jade - https://phabricator.wikimedia.org/T247462 (10ACraze) Great work on this so far @kevinbazira, this approach works well with jade-updateproposal, just tested it on beta. I think it should work for all the other a... [22:00:01] I just pinged a group of tool devs who I hope will do some dev-user-testing with me. :) And with that I'm going to call it a day. [22:00:06] Take care folks. [22:00:29] o/ [22:22:24] 10Scoring-platform-team, 10Discovery-Search, 10Elasticsearch, 10revscoring, 10artificial-intelligence: Improve the performance and quality of tokenization in revscoring - https://phabricator.wikimedia.org/T248480 (10HAKSOAT) @Halfak Any update on this? The profiling script.