[13:14:06] 10Jade, 10Scoring-platform-team: Deleting an endorsement returns an error: jade-bad-content - https://phabricator.wikimedia.org/T247973 (10Halfak) I wonder if this is also a problem for moving another person's endorsement. That should be prevented and an error should make it clear why it is not possible to mo... [13:23:14] 10Jade, 10Scoring-platform-team: Deleting an endorsement returns an error: jade-bad-content - https://phabricator.wikimedia.org/T247973 (10kevinbazira) a:03kevinbazira I have pushed a patchset for this issue. Turns out User A was able to delete an endorsement created by User A but was not able to delete an e... [13:55:04] 10Jade, 10Scoring-platform-team: Deleting an endorsement returns an error: jade-bad-content - https://phabricator.wikimedia.org/T247973 (10Halfak) Aha! The move endorsement relies on matching your logged-in (or not) user status with an endorsement in order to move it. So the only way to move someone else's e... [14:42:13] 10Jade, 10Scoring-platform-team (Current), 10Patch-For-Review: Deleting an endorsement returns an error: jade-bad-content - https://phabricator.wikimedia.org/T247973 (10kevinbazira) [16:42:29] 10Scoring-platform-team, 10Gerrit, 10Release-Engineering-Team-TODO, 10Release-Engineering-Team (Development services): gerrit: scoring/ores/editquality takes a long time to git gc - https://phabricator.wikimedia.org/T237807 (10thcipriani) p:05Medium→03Low [16:53:04] Async time! First, accraze: [16:53:12] Y: Worked on cleaning up the Link Summary hooks for Jade (aka onPageContentSaveComplete) and did some experimentation with different approaches to storing label data, although nothing concrete yet. [16:53:12] T: More of the same. I've been fixing tests related to the hooks and it looks like our test coverage is increasing for Jade now, will also continue working storing label data. Also will be try out Kevin's new docs for setting up MW Vagrant if there's time. [16:53:20] And kevinbazira: [16:53:21] Y: [16:53:21] Documented an easier way to set-up MW-Vagrant here: https://etherpad.wikimedia.org/p/easier-way-to-set-up-mw-vagrant [16:53:21] Looking at the issue about deleting an endorsement that returns an error: jade-bad-content [16:53:21] https://phabricator.wikimedia.org/T247973 [16:53:22] T: [16:53:24] Fixed endorsement delete bug [16:53:26] User A was able to delete an endorsement created by User A but was not able to delete an endorsement created by User B. [16:53:29] This patch fixes this issue. Now User A is able to delete an endorsement created by User B. [16:53:37] haksoat: [16:53:38] Y: [16:53:38] I read up Trey Jones articles on normalization, tokenization and stemming. Studied and experimented with the tokenization module for revscoring. [16:53:40] T: [16:53:42] I continued from where I stopped with the tokenization module and also checked the deltas package where the tokenizer lives. I have also had an onboarding meeting with Aaron. I intend to check out the possibility of creating a custom tokenizer for Elasticsearch as I wasn't able to do that yesterday. [16:53:47] and me: [16:53:48] Y: Almost entirely meetings. But I do have ptwiki articlequality stuff up for review. I also have a small change for revscoring and a new labeling campaign for ptwiki up for review. So I managed to do something between meetings :) [16:53:52] T: I have a lot more meetings today. I just finished a dry run of the tuning session. Earlier I helped haksoat get set up with SSH access and get our calendar. Later today, I am working to unblock chtnnh who needs some deleted text to experiment with model building. Once I finish with that, I'm going to do a bit more work for capex and then do some backlog cleanup. If I make it that far, I'll start spec'ing out the work for trying to [16:53:57] compress our topic models or at least trying to figure out why they are so big. [19:01:53] 10Scoring-platform-team, 10Wikilabels, 10articlequality-modeling, 10artificial-intelligence: Deploy article quality labeling campaign for Portuguese Wikipedia - https://phabricator.wikimedia.org/T138726 (10He7d3r) [19:01:55] 10Scoring-platform-team (Current), 10Wikilabels, 10articlequality-modeling, 10artificial-intelligence: Build article quality model for ptwikipedia - https://phabricator.wikimedia.org/T246663 (10He7d3r) [19:04:56] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: revscoring fetch_text login should be optional - https://phabricator.wikimedia.org/T250311 (10Halfak) [19:06:49] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: revscoring fetch_text login should be optional - https://phabricator.wikimedia.org/T250311 (10Halfak) https://github.com/wikimedia/revscoring/pull/484 [19:06:54] 10Scoring-platform-team (Current), 10revscoring, 10artificial-intelligence: revscoring fetch_text login should be optional - https://phabricator.wikimedia.org/T250311 (10Halfak) a:03Halfak [19:19:27] 10Scoring-platform-team, 10Wikilabels, 10editquality-modeling, 10artificial-intelligence: Build draft quality model for ptwikipedia - https://phabricator.wikimedia.org/T246667 (10Halfak) @Chtnnh, grab the text dataset from /home/halfak/projects/draftquality/datasets/ptwiki.draft_quality.balanced_3k.with_te... [19:20:32] 10Scoring-platform-team (Current), 10Wikilabels, 10editquality-modeling, 10artificial-intelligence: Build draft quality model for ptwikipedia - https://phabricator.wikimedia.org/T246667 (10Halfak) [19:55:09] 10Jade, 10Scoring-platform-team (Current), 10Patch-For-Review: Deleting an endorsement returns an error: jade-bad-content - https://phabricator.wikimedia.org/T247973 (10ACraze) Patchset looks good @kevinbazira, +2'd and merged [20:08:29] Helder, have a minute to review https://github.com/wikimedia/wikilabels/pull/262 ? [20:16:12] wikimedia/wikilabels#543 (escape_diff_html - 6db152e : halfak): The build was fixed. https://travis-ci.org/wikimedia/wikilabels/builds/675467472 [20:16:21] yer dang right. [20:17:28] XD [20:54:48] halfak, done [20:55:15] merged? [20:56:02] Aha LGTM. Thanks! [21:02:57] yep, just a review (I don't have write access) [21:20:53] Helder, I got that change out to Wikilabels. Thanks for the spot and the quick review! [21:21:18] Is it live? [21:21:21] Yes [21:21:30] Great! :-) [21:22:32] Your note about this bring an XSS vector kicked me into gear :D [21:23:55] haha [21:26:37] Alright, I need to run. Have a good one, folks!