[06:22:19] <grrrit-wm>	 (PS1) Rfaulk: mod. build_request_obj to accept url and request object template separately. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78206
[06:22:20] <grrrit-wm>	 (PS1) Rfaulk: mod. build_request_obj only takes url as input. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78207
[06:22:21] <grrrit-wm>	 (PS1) Rfaulk: fix. request object construction in process_metrics. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78208
[06:22:22] <grrrit-wm>	 (PS1) Rfaulk: fix. build_request_obj takes one arg. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78209
[06:22:23] <grrrit-wm>	 (PS1) Rfaulk: fix. change parse_raw_request to define args as dict (iterable). [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78210
[06:22:24] <grrrit-wm>	 (PS1) Rfaulk: fix. Initialize parsed request args unconditionally. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78211
[06:22:47] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] mod. build_request_obj to accept url and request object template separately. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78206 (owner: Rfaulk)
[06:23:04] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] mod. build_request_obj only takes url as input. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78207 (owner: Rfaulk)
[06:23:21] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] fix. request object construction in process_metrics. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78208 (owner: Rfaulk)
[06:23:40] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] fix. build_request_obj takes one arg. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78209 (owner: Rfaulk)
[06:24:00] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] fix. change parse_raw_request to define args as dict (iterable). [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78210 (owner: Rfaulk)
[06:24:13] <grrrit-wm>	 (CR) Rfaulk: [C: 2 V: 2] fix. Initialize parsed request args unconditionally. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/78211 (owner: Rfaulk)
[06:29:31] <grrrit-wm>	 (CR) JGonera: [C: -1] "(1 comment)" [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/77278 (owner: Jdlrobson)
[06:46:23] <grrrit-wm>	 (PS2) Jdlrobson: Show graph of first time edits [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/77278
[15:49:11] <average>	 hey qchris
[15:49:19] <qchris>	 Hey average
[15:59:01] <ottomata>	 hey qchris, saw your email, let's talk after standup?  i'm into something atm
[15:59:13] <qchris>	 ottomata: Sure.
[16:36:51] <qchris>	 How serious do we take clean code?
[16:37:05] <qchris>	 (Like bikeshedding about code formatting)
[16:37:25] <qchris>	 (Mixing tabs/spaces in lines)
[16:37:30] <qchris>	 (overlong lines, ...)
[16:39:13] <ottomata>	 pretty seriously!
[16:39:20] <ottomata>	 for what?
[16:39:34] <ottomata>	 overlong lines, i dunno, tabs/spaces should be consistent
[16:40:19] <tnegrin>	 I think it's pretty important for readability but I only care about things being consistent
[16:40:52] <qchris>	 Ok. Thanks.
[16:43:20] <tnegrin>	 the foundation probably has something we should follow
[16:50:10] <qchris>	 tnegrin: Yes, they are spacing nazis :-)
[16:50:20] <qchris>	 tnegrin: Well ... I am also one of them.
[16:50:35] <qchris>	 tnegrin: But the foundations coding conventions do not cover Java.
[16:51:06] <tnegrin>	 do you have a page/$EDITOR config we can use as a base?
[16:51:36] <tnegrin>	 you probably know the search guy -- maybe you guys can do the java conventions
[16:52:20] <qchris>	 Ok, I'll try pinging manybubbles afterwards.
[16:53:15] <tnegrin>	 again -- I have no opinion other than there is a convention and we don't spend time discussing it :)
[17:02:07] <qchris>	 scrum ... anyone?
[17:04:41] <ottomata>	 gotta ping names!
[17:04:43] <ottomata>	 we forgetful!
[17:06:30] <tnegrin>	 I thought it was cancelled this week?
[17:06:37] <tnegrin>	 it's off my calendar
[17:19:46] <grrrit-wm>	 (CR) Stefan.petrea: "(4 comments)" [analytics/kraken] - https://gerrit.wikimedia.org/r/75349 (owner: Stefan.petrea)
[19:28:32] <ottomata>	 ooook qchirs
[19:28:34] <ottomata>	 you still around?
[19:28:36] <ottomata>	 qchris_away:
[19:28:39] <ottomata>	 oh i guess not
[19:28:40] <ottomata>	 away :)
[20:54:09] <qchris>	 ottomata: you pinged me?
[20:55:31] <ottomata>	 ja, got a bit of java code that is haunting me
[20:55:34] <ottomata>	 brain bounce might get it
[20:56:10] <qchris>	 I am booting the Google machine.
[20:56:24] <ottomata>	 my internet has been really flaky today, but lets' try
[20:56:47] <ottomata>	 ah now its working
[20:56:52] <ottomata>	 i'm in batcave
[20:56:53] <qchris>	 If you prefer IRC, I am happy about everything that's not google ;-)
[20:56:58] <qchris>	 Ah ok.
[21:53:16] <grrrit-wm>	 (CR) Stefan.petrea: "(6 comments)" [analytics/kraken] - https://gerrit.wikimedia.org/r/75349 (owner: Stefan.petrea)
[21:53:34] <grrrit-wm>	 (PS8) Stefan.petrea: Updating Kraken to cope with libdclass 2.2.2 [analytics/kraken] - https://gerrit.wikimedia.org/r/75349
[21:54:01] <average>	 qchris: covered everything imho
[21:54:31] <average>	 except for some left-over commented code from upstream which we don't use (but we might uncomment it and use it in the future)
[21:54:33] <qchris>	 average: I was just reviewing PS7 :-)
[21:54:53] <average>	 qchris: oh cool. few changes between PS7 and PS8
[21:55:08] <qchris>	 average: I'd much rather remove the commented out code. I'll bitrot anyway.
[21:55:23] <qchris>	 average: By removing it, Our code will get simpler and easier to read.
[21:55:57] <qchris>	 s/I'll/it'll/    � but ok. I am bitrotting as well :-)
[21:56:32] <qchris>	 average: I'll review the new patch set tomorrow then.
[21:57:00] <qchris>	 average: Thanks for uploading PS8 :-)
[21:57:25] <average>	 ok
[22:11:45] <grrrit-wm>	 (PS1) Erik Zachte: Activate use of api for determining countable namespaces [analytics/wikistats] - https://gerrit.wikimedia.org/r/78320
[22:12:50] <grrrit-wm>	 (CR) Erik Zachte: [C: 2 V: 2] Activate use of api for determining countable namespaces [analytics/wikistats] - https://gerrit.wikimedia.org/r/78320 (owner: Erik Zachte)