[06:29:38] (PS1) Rfaulk: mod. switch view logic to catch queued or running jobs before checking cache. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/79312 [06:30:12] (CR) Rfaulk: [C: 2 V: 2] mod. switch view logic to catch queued or running jobs before checking cache. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/79312 (owner: Rfaulk) [10:52:12] milimetric: Good morning! [10:52:26] milimetric: I got confused with timzones ... was it EST or EDT? [10:52:46] milimetric: Do we have the grooming session in ~10 minutes? [10:53:03] qchris: hi [10:53:16] average: Hi [10:53:33] qchris: thanks for the patchsets [10:53:45] for the new ticket, I am testing the old dtree file [10:53:55] I am getting some test failures in kraken-pig [10:54:12] average: Really? It passes for me with the old dtree files. [10:54:17] Which tests fail for you? [10:55:54] qchris: please see e-mail just sent [10:56:03] * qchris checks email [10:56:24] look at the bottom of the out.txt because it's quite big [10:56:26] I ran with -X [10:58:33] qchris: what openddr.dtree file are you using ? [10:58:41] qchris: what package did you get it from ? [10:58:46] Version 1.13. [10:58:51] drdee sent this file to me. [10:59:10] When I started in our team, he said that we should use this file [11:00:29] I'll send you the file. [11:02:35] ok [11:02:50] qchris: so I guess I should put that file inside the libdclass-data package right ? [11:03:07] and also document how we can produce dtree files [11:03:13] that's what #1017 says right ? [11:03:32] average: I was under the impression that we used the dtree file in version 1.13 already. At least that's what drdee told me. [11:03:47] average: If we do not, let's discuss with drdee what we are actually using. [11:04:02] that can be answered with a diff [11:04:24] average: #1017? [11:04:30] average: Oh you mean #1070. Yes. [11:04:41] #1070 yes , sorry [11:06:02] qchris: 1.13 or 1.1.3 ? [11:06:18] I thought 1.13. Let me check again. [11:06:44] It says 1.13 for me. [11:07:00] user@user-K56CM:/tmp/test1$ ls [11:07:00] 2.2.2-1 libdclass-data_2.2.2-1_all.deb openddr.dtree.v.1.13 [11:07:00] user@user-K56CM:/tmp/test1$ diff -q 2.2.2-1/usr/share/libdclass/openddr.dtree openddr.dtree.v.1.13 [11:07:03] Files 2.2.2-1/usr/share/libdclass/openddr.dtree and openddr.dtree.v.1.13 differ [11:07:06] qchris: ^^ [11:07:31] openddr.dtree.v.1.13 is the file you sent me on the e-mail minutes ago [11:07:42] The deb holds the 1.19 version. [11:07:57] (At least it did for me when I tried the other day) [11:08:10] Yes, they differ. [11:08:22] Acutally, they differ a lot as hinted in #1070 :-( [11:08:41] if I include this v.1.13 in the libdclass-data would this take us forward in solving this ? [11:09:02] Yes. But we'll have towait for an answer from tomasz [11:09:48] Sorry. I got confused. [11:10:14] I am not sure if that takes us forward, as I do not know how we currently install the dtree file. [11:10:31] by deb packages [11:10:39] We could also simply mask the new dtree file, if the old dtree file is already provided by some other package. [11:10:43] the libdclass-data deb package provides the dtree files [11:11:43] From my point of view, and by what we discussed with drdee yesterday, we should keep the old dtree file for now. I have no preference on how we realize that. [11:11:51] We could either keep the old debs. [11:11:58] Create new debs with the old files [11:12:03] or whatever. [11:12:21] I suppose the one who does the installing has to speak up what's easiest for him. [11:14:10] well basically I foresee this going like this : [11:14:19] 1) I can submit a new gerrit patchset to add v.1.13 [11:14:23] 2) Faidon reviews and approves [11:14:39] 3) Faidon uploads new packages to apt.wikimedia.org [11:14:56] 4) Andrew can install the new libdclass-data on the cluster nodes [11:15:16] and then we have the dtree v1.13 available [11:15:24] Is the new (1.19) version already installed on the cluster nodes? [11:15:35] If not, we could just keep what we have. [11:15:51] I'm not sure if all cluster nodes have 1.19 already. I believe Andrew is in the process of installing it to all nodes [11:15:56] He already installed it for some nodes [11:16:15] I guess it's best to discuss with him directly. [11:16:29] ok [11:16:41] average: Do the tests pass with the dtree file that I sent you? [11:19:08] running mvn test now [11:19:36] qchris: https://gist.github.com/wsdookadr/2125b55e6919d76f0dbe [11:19:41] this is the output of "mvn test" [11:19:45] it's failing on kraken-pig [11:19:54] I got your latest patchset btw [11:20:16] I also replaced openddr.dtree with the one you gave me [11:20:36] Can you show me the output of those two tests (testDesktopPageviewCount, testMobilePageviewCount) as well? [11:20:46] So we can see where the tests fail? [11:21:54] qchris: I'm having some trouble running those [11:21:57] I'm in the hangout [11:22:09] pls join [11:22:11] Ok. Let me start the google machine. [11:22:59] ok [11:24:58] (CR) QChris: [V: -1] "For Ştefan:" [analytics/kraken] - https://gerrit.wikimedia.org/r/75349 (owner: Stefan.petrea) [11:26:01] average: I am in the hangout. [11:41:24] (CR) QChris: "Removing block. Tests now pass for Ştefan. It was just some missing files that were necessary to run those tests." [analytics/kraken] - https://gerrit.wikimedia.org/r/75349 (owner: Stefan.petrea) [14:19:46] heay [14:19:51] i mean hiya [14:31:46] drdee: hi [14:31:53] hey average! [14:32:01] great work with qchris on dclass! [14:42:29] thanks, qchris helped a lot [16:50:05] Anyone around whom I could discuss the wp0 log decrease before scrum? [16:56:17] ask yurik [16:56:32] ? [16:57:01] Thanks, drdee. [16:57:11] qchris, are you talking about zero.log? [16:57:29] yurik: about mobile caches in general [16:57:39] * average is joining hangout [16:58:09] yurik: We're about to have a meeting right now, may I come back with the problem to you after the meeting? [16:58:24] qchris, sure, just ping me here [18:08:40] (CR) Diederik: [C: 2 V: 2] "Looking good! I saw some really minor issues but we clean that up next time (whitespace, years in license header) blablabla." [analytics/kraken] - https://gerrit.wikimedia.org/r/75349 (owner: Stefan.petrea) [18:11:36] qchris, average: it seems that on jenkins it cannot find the dclassjni files [18:11:37] https://integration.wikimedia.org/ci/view/Analytics/job/Kraken/11/org.wikimedia.analytics.kraken$kraken-dclass/testReport/junit/org.wikimedia.analytics.dclassjni/DclassWrapperTest/testDclassWrapper/ [18:11:51] java.lang.UnsatisfiedLinkError: no dclassjni in java.library.path [18:15:20] jenkins probably doesn't have the new dclass instaled [18:15:22] *installed [18:16:31] puppet production branch needs to be forked and package added to the jenkins machine [18:20:26] puppet$ grep "dclass" modules/contint/manifests/packages.pp 'libdclass0', 'libdclass0-dev', 'libdclass-jni', 'libdclass-java', 'libdclass-data', [18:21:01] http://goo.gl/BbHkcC [18:21:04] this is what I wanted to write [18:21:09] basically it seems to be already in puppet [18:21:46] ottomata: if new packages pop up on apt.wikimedia.org , are they automatically upgraded on machines that depend on them ? [18:22:19] ottomata: for example, right now, jenkins appears to be missing dclass packages [18:36:36] average: i asked ottomata to install dclass on the jenkins machine and he did that [18:36:47] so that's why i am surprised that it's not working [18:48:28] I'd login the jenkins machine and do troubleshooting, but I don't have access(maybe hashar can have a look). For qchris and myself the tests ran locally and no problems with the library were found. It may be that jenkins has old versions of dclass installed. [18:50:16] nah, ottomata installed it this week [19:28:49] i gotta run and get some lunch [19:28:53] be back soon [19:30:19] k [19:47:06] average, on your way with wikimetrics? [19:56:05] average: is card https://mingle.corp.wikimedia.org/projects/analytics/cards/824 clear? [20:47:38] (PS1) Milimetric: re-organizing the return value of report nodes [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79429 [20:48:12] (CR) Milimetric: [C: 2 V: 2] re-organizing the return value of report nodes [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79429 (owner: Milimetric) [21:07:51] milimetric: Thanks for the hint about trying to make numbers match although they did not. [21:08:22] milimetric: After some playing around, I round really filter out groups, as proportions did not make sense. [21:08:43] milimetric: And in the end found a (at least for me) convincing explanation. [21:08:53] milimetric: Thanks a lot! [21:27:46] drdee: Sorry. I missed the pings about Kraken in Jenkins. [21:27:59] drdee: It seems Jenkins is still using the github repo. [21:28:42] drdee: Github has an old version of loading the library (expects fixed path, ...). [21:29:01] drdee: I'll see if I can break Jenkin's kraken :-) [21:40:53] duuhhhhh [21:41:15] qchris: i can fix that as well [21:42:02] drdee: Ok. I just got distracted about the logging problems again. [21:42:15] ok, i will take care of jenkins [21:42:18] drdee: I thought there was a slight chance to get it fixed before the weekend [21:42:38] drdee: But it turns out people who could do it are away :-/ [21:42:47] :( [21:44:21] However, I am not sure if switching to gerrit is enough. I am not sure if the shared object's directory is in the ld path by default. [21:44:37] But I guess we'll find out soonish :-) [21:47:55] we will indeed :) [22:13:30] sorry, been busy looking after that silly runaway chicken :) have a good weekend everyone [22:13:38] email me if you need me