[06:53:55] (PS1) Stefan.petrea: Adding dtree [analytics/dclass] (wikimedia) - https://gerrit.wikimedia.org/r/79453 [09:10:32] (PS1) Stefan.petrea: Adding support page [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 [09:19:07] drdee: hi [10:10:07] hi [10:22:58] average, please have a look at https://mingle.corp.wikimedia.org/projects/analytics/cards/824 [10:36:31] (CR) Diederik: [C: -1] "(1 comment)" [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 (owner: Stefan.petrea) [10:49:26] (PS2) Stefan.petrea: Adding support page [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 [10:50:05] (CR) Stefan.petrea: "(1 comment)" [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 (owner: Stefan.petrea) [10:50:27] drdee: done [10:51:07] great! i will +1 it but milimetric has to do the real approval [10:51:11] thanks for doing so quickly! [10:51:15] np [10:51:33] we jus wanted to give some easy tasks so you can get familiar with the codebase [10:51:43] more interesting tasks will come soon! [10:51:50] looking forward :) [10:52:14] (CR) Diederik: [C: 1 V: 2] "Looking good Stefan! TY!" [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 (owner: Stefan.petrea) [10:52:42] you can have a look at https://mingle.corp.wikimedia.org/projects/analytics/cards/1069 [10:52:51] that's an Oauth bug [10:53:37] (CR) Faidon: [C: -1] "Single-line "Adding dtree" commit message says nothing to me. Where's that dtree from? Did you make it or did you extract it from somewher" [analytics/dclass] (wikimedia) - https://gerrit.wikimedia.org/r/79453 (owner: Stefan.petrea) [10:54:41] average: refresh https://mingle.corp.wikimedia.org/projects/analytics/cards/1069 [10:54:47] it's easier to rad [10:55:13] F5-ing now [10:57:09] k [11:05:08] average: makes sense? [11:10:40] drdee: yes [11:11:14] drdee: I have a question about the v1.13 dtree file [11:11:28] drdee: so, qchris e-mailed me that file [11:11:39] but now Faidon is asking me where the file is coming from [11:11:52] where is it coming from? [11:12:02] the problem is I made a oneliner to checksum all opendtree.dtree files from all revisions in the upstream dClass repo [11:12:12] and none of them matches with qchris's dtree file [11:12:13] git rev-list --all | perl -ne 'BEGIN { $goal_checksum=(`md5sum /tmp/test1/openddr.dtree.v.1.13`=~/^(.+?)\s/)[0]; }; chomp; `git checkout $_ 2>/dev/null`; $p=`find -name "openddr.dtree"`; $checksum=(`md5sum $p` =~ /^(.+?)\s/)[0]; $matches = ($checksum eq $goal_checksum) ? "YES":"NO"; print "$_ => $matches\n"; ' [11:12:42] mmmmm [11:12:48] and it's not from https://github.com/OpenDDRdotORG/OpenDDR-Resources ? [11:12:52] this basically goes through all revisions of the upstream dClass repo, and then it checks to see whether any of them have the same MD5 with the dtree that qchris sent to me [11:12:58] drdee: looking at that url now [11:12:59] right [11:38:36] (PS3) Stefan.petrea: Adding support page [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/79457 [11:55:29] average, what changed? [11:57:01] drdee: in this patchset, just added some comments to a method ^^ [11:57:06] ok [11:57:23] how does the oauth bug look? [11:57:29] is the report clear? [11:59:37] drdee: about the dtree, I have to checkout that repo you wrote about above, checkout to commit with v1.13 , run openddr_client somehow on the xmls and produce the dtree file and then hash it. Then I have to document all that and send an e-mail to Faidon to prove the origin of the dtree file is authentic [11:59:43] drdee: about the bug, I was able to reproduce it [12:00:01] bug report looks ok, I will try to do some debugging to see where it comes from [12:00:05] average: or mail qchris and ask him where he got the file :) [12:00:08] that's easier