[06:46:20] (PS1) Rfaulk: mv - aggregator constants to aggregator module. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80530 [06:46:21] (PS1) Rfaulk: mod - change refs to aggregator constants in metrics. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80531 [06:46:38] (CR) Rfaulk: [C: 2 V: 2] mv - aggregator constants to aggregator module. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80530 (owner: Rfaulk) [06:46:53] (CR) Rfaulk: [C: 2 V: 2] mod - change refs to aggregator constants in metrics. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80531 (owner: Rfaulk) [08:01:43] (PS1) Rfaulk: fix - refs to aggregator constants. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80535 [08:02:02] (CR) Rfaulk: [C: 2 V: 2] fix - refs to aggregator constants. [analytics/user-metrics] - https://gerrit.wikimedia.org/r/80535 (owner: Rfaulk) [11:59:56] morning everyone, I'll be gone for a couple hours from 9:00 EST to 11:00 EST [12:00:10] just working at my local co-op's farm [12:01:14] Sounds great. Have fun :-) [13:00:36] (PS1) JGonera: Story 1071: Add edit errors on daily edit graphs [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/80553 [13:38:20] BAM [13:40:47] bam bam bam [13:46:40] yo ottomata [13:46:42] yo qchris [13:48:48] yoyo [13:52:18] no sleep till brooklyn [13:53:18] Foot on the pedal - never ever false metal [13:53:19] Engine running hotter than a boiling kettle [13:53:20] My job's ain't a job - it's a damn good time [14:17:24] yo average [14:39:25] hey drdee [14:39:26] hey milimetric_ [14:39:41] do I use ipython to compose the sqlalchemy query ? is it easier ? [14:41:28] ipython is an interactive interpreter of python [14:41:36] so you can see what your code is doing [14:41:47] but it has it's own learning curve [14:41:53] i guess it depends on preference [14:51:02] ok so what I did was [14:51:07] I fired up an ipython [14:51:11] and I wrote two things [14:51:15] one to get a db session [14:51:18] and the other one a simple query [14:51:31] from wikimetrics.configurables import db [14:51:39] db_session = db.get_session() [14:51:46] now I should have a db_session [14:52:15] now I import the Revision model [14:52:16] from wikimetrics.models import Page [14:52:21] from wikimetrics.models import Revision [14:52:44] and now a simple query [14:52:45] db_session.query(Page.page_id).all() [14:52:48] and I get an error [14:52:59] OperationalError: (OperationalError) no such table: page u'SELECT page.page_id AS page_page_id \nFROM page' () [14:54:41] my aim is to get this working, so I can construct my query in ipython and then put it back in the new metric [14:55:51] stay on target average :) the metric is more important than ipython particularly as nobody has experience with ipython IIRC [14:56:20] ok [16:14:05] (PS1) Milimetric: up to 84 percent coverage now [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80572 [16:14:14] (CR) Milimetric: [C: 2 V: 2] up to 84 percent coverage now [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80572 (owner: Milimetric) [16:17:11] WOOT WOOT [16:52:10] woot they've got a webbpage! [16:52:10] http://samza.incubator.apache.org/ [16:55:38] awesome [17:01:19] ottomata scrum [17:27:48] ottomata can you join the hangout [17:44:06] (CR) Jdlrobson: [C: 2] Story 1071: Add edit errors on daily edit graphs [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/80553 (owner: JGonera) [17:50:09] milimetric: quick q [18:04:46] (CR) JGonera: [C: 2] Story 1071: Add edit errors on daily edit graphs [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/80553 (owner: JGonera) [18:04:51] (CR) JGonera: [V: 2] Story 1071: Add edit errors on daily edit graphs [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/80553 (owner: JGonera) [19:55:18] ottomata: hey, I tried to go into wikimetrics.pmtpa.wmflabs [19:55:20] ottomata: I wasn't able to [19:55:36] ottomata: can I get some help on that pls [19:55:38] sure [19:55:39] hm [19:55:44] how far did you get? [19:55:52] are you having trouble logging into other labs instances? [19:56:22] https://gist.github.com/wsdookadr/fddf667f06d3bf2332cd [19:57:31] ottomata: ^^ [19:57:42] I can access stat1002.eqiad.wmnet [19:57:43] stat1 [19:57:53] this is your problem [19:57:54] exec ssh -e none spetrea@analytics1001.wikimedia.org [19:57:59] you can't use analytics1001 as labs proxy [19:58:28] https://wikitech.wikimedia.org/wiki/Help:Access#Using_ProxyCommand_ssh_option [20:01:01] fixed [20:01:03] just got in it [20:01:14] ottomata: thanks for pointing that out, I used it to fix my .ssh/config [20:03:27] cool! [20:03:28] yup! [20:03:32] glad i could help [20:03:37] hey average can you push what you have so far for 704 [20:15:30] (PS1) Stefan.petrea: Added metric for card 704 [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80659 [20:15:34] drdee: ^^ [20:15:54] milimetric: ^^ [20:16:45] not ready for review yet [20:17:50] woo! [20:18:08] cool average, thanks for the patchset [20:18:21] thanks average! [20:18:40] np [20:19:23] I'm guessing rev_parent_id has to == 0 and not == None [20:19:25] not sure though [20:19:41] also, remember to run flake8, most of it looks like it'll pass tho [20:19:51] milimetric: I was on #wikimedia-dev and asked for the Mediawiki schema [20:20:05] milimetric: turns out rev_parent_id is INTEGER and can be NULL [20:20:17] milimetric: when it is NULL, Sqlalchemy makes it None in Python [20:20:46] and that happens for the first revision (I have to test that theory on real data though, that's one of the reasons why I'm logged into wikimetrics machine on labs) [20:21:00] yep, true [20:21:05] but i think in this case it's actually set to 0 where it's the first revision (page creation revision) [20:30:21] milimetric: and you're right [20:31:11] cool, it wasn't me, it was ryan whose query code we can usually take as gospel [20:31:25] because it's actually being used without many complaints [20:31:30] but it's always good to double check [21:36:01] (PS1) Milimetric: now 88 percent [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80674 [21:36:19] (CR) Milimetric: [C: 2 V: 2] now 88 percent [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80674 (owner: Milimetric) [21:38:34] hey ottomata, see the airbnb email? [21:38:45] drdee, if you and ottomata are good for it, let's book it! [21:39:07] it's a great place, so I vote Yes [21:39:15] yeah, cool! [21:39:19] ok checking that now [21:41:11] drdee, milimetric: what are your dates? [21:41:23] 8-14 [21:41:35] you? [21:41:39] 10-19 [21:41:41] ah [21:41:47] this might get complicated [21:41:52] dunno [21:41:55] you'll end up footing the bill for 5 days [21:42:12] hotel? [21:42:13] :) [21:42:19] hmm, yeah, maybe I should just book that for the all staff week [21:42:21] I'm sad because that place is awesome [21:42:28] and move to hotel for ops week afterwards? [21:42:33] yeah, sure! [21:42:34] that'd be great [21:42:39] drdee! [21:42:40] dates? [21:42:49] I think he's also 8-14 [21:42:53] oh no [21:42:55] he's 9-14 [21:43:14] basically same though [21:43:18] yea [21:43:34] checkin 8, checkout 14 [21:43:42] and we'll figure budgets out with Ken/Toby [21:43:58] awww it sbeen booked! [21:45:24] :) [21:45:40] well if you find anything else that looks awesome for 3 people, you can totally book it [21:45:48] without checking with me, i'm sure it'll be good [21:46:00] (Indonesian Restaurant style) [21:46:08] haha, awesome [21:46:09] hah [21:46:18] well, we'll see, that one was the one that was close and good for 3 [21:46:24] there are others, but nothign as good [21:46:32] and if not, by Monday or so we'll just tell Doreen let's go with the hotels [21:46:32] maybe we should accept this as a sign and just do hotel? [21:46:48] you can reply to doreen on all our behalf, I'm happy either way [21:46:51] hotel - close to everyone [21:47:00] airbnb - potentially fancy :) [21:47:23] portrero has some cool places, we stayed in a nice one last trip out [21:47:35] o yeah i'm only looking at stuff close to office [21:47:42] i'm ok with being farther out, but i have a bike [22:55:18] (PS2) Stefan.petrea: Added metric for card 704 [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/80659 [22:55:22] milimetric: wrote one test, it passes [22:57:17] it's basically ready, but needs more testing [22:57:21] I think I got the query right [22:57:46] didn't yet include the edge case where page is deleted and re-created yet [23:07:02] awesome average, you can submit the patch that way and I'll merge it [23:07:15] then you can improve the test coverage, hopefully to 100% later [23:07:28] but yeah, gj [23:07:58] k, i'm out for the weeekend, later everyone [23:08:23] ok, have a nice weekend