[13:50:22] (PS1) Milimetric: Implement security for public reports [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/118068 [13:50:26] (PS17) Stefan.petrea: [WIP] kraken-hive UDFs [analytics/kraken] - https://gerrit.wikimedia.org/r/96738 (owner: QChris) [17:59:30] (PS12) Terrrydactyl: Add TextAreaField for paste_username, reads input [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 [17:59:36] milimetric: ^ [17:59:44] (CR) jenkins-bot: [V: -1] Add TextAreaField for paste_username, reads input [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 (owner: Terrrydactyl) [17:59:47] sweet, checking [17:59:52] looks like jenkins doesn't love you though [18:00:06] ugh, always forget to run flake8 [18:00:10] not in habit yet. :( [18:01:19] i'll fix it in the next patch, haven't written all the patches i want [18:01:29] er patches > tests [18:02:49] terrrydactyl: this is nice: test_parse_textarea_usernames [18:02:50] ! [18:03:04] thanks! [18:05:56] (CR) Milimetric: Add TextAreaField for paste_username, reads input (3 comments) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 (owner: Terrrydactyl) [18:24:12] hi nuria [18:24:18] meet terrrydactyl if you haven't before [18:24:21] terrrydactyl: nuria :) [18:24:22] hi! [18:24:26] hello [18:24:33] so, terrrydactyl is having problems with her vagrant setup [18:24:37] and this one's weird [18:24:45] i tried looking at it but I think we need you [18:24:55] (and it's our problem of course 'cause we all need it working) [18:24:58] sure, i was updating my setup to latest master [18:25:01] cool [18:25:06] so, the symptom is this [18:25:09] when she does: [18:25:15] sudo stop wikimetrics-queue [18:25:20] cd /vagrant/wikimetrics [18:25:22] scripts/test [18:25:24] everything runs fine [18:25:28] but when she does [18:25:43] scripts/test tests/test_controllers/test_forms/test_cohort_upload.py [18:25:54] it gives her the wikimetrics@localhost can't access 'wiki' error [18:25:54] from inside vagrant right? [18:25:56] ye [18:25:58] yes [18:26:14] well, let me try to repro [18:26:18] which makes no sense, it seems like for the partial test it's using a different setup function somehow [18:26:26] git fetch ssh://nuria@gerrit.wikimedia.org:29418/analytics/wikimetrics refs/changes/60/117260/12 && git checkout FETCH_HEAD [18:26:43] that gets the patchset that terrrydactyl is on right now [18:26:48] well, it used to give me that error, but then i flubbed around and managed to change the error message to something like "can't create table..." [18:27:04] i think i tried granting access to the user, which probably wasn't something i should have done [18:27:09] yeah, but you shouldn't give access there, puppet should set up all the access necessary [18:27:11] can you try to run that same test on "master" branch [18:27:17] and see what you get? [18:27:23] w/o your patch [18:27:28] thanks for looking into this! [18:28:57] you can DM me at your convenience terrrydactyl, do let me know what you get with master of wikimetrics and master of wikimetrics puppet module (if that makes sense) [18:29:21] hmm, how do i get back to the master copy? [18:29:41] i'm pretty sure my local master isn't the same as the current wikimetrics master [18:29:58] the easiest is from outside vagrant [18:30:04] cd mediawiki-vagrant [18:30:06] cd wikimetrics [18:30:10] git checkout master [18:30:10] git pull [18:30:24] (making sure to git stash as needed to keep local changes from vanishing) [18:31:11] exactly, git operations happen outside vagrant [18:31:28] nuria: it still pops up. [18:31:29] http://pastebin.com/buZus3pr [18:31:33] here's what it looks like [18:32:00] it's trying to create a table in wiki db [18:32:05] this was an error that i had before i changed my .yaml file to have the _adding [18:32:05] which shouldn't [18:32:14] tables alredy exists [18:32:36] the error used to be wikimetrics@localhost doesn't have access to wiki database or something like that [18:32:42] milimetric received that error [18:33:04] that sounds like teh config you are using in vagrant is not teh right one [18:33:32] hmm, where do i check that? [18:33:39] the yaml files used in vagrant are different than the ones used outside it, give me a sec [18:33:44] sure! [18:37:29] test works fine on my setup [18:37:47] let's try to see what is going on with yours [18:38:18] do you have a gmail address in which we could do a hangout? (so as to share screen) [18:38:52] terrrydactyl, sorry, do you have a gmail address in which we could do a hangout? (so as to share screen) [18:39:08] we can just go into the bat cave if you want [18:39:27] let me do another test [18:40:02] sure, let's do that [20:20:24] (PS13) Terrrydactyl: Add TextAreaField for paste_username, reads input [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 [20:20:46] looking [20:23:02] terrrydactyl: nice! [20:23:03] wikimetrics.controllers.forms.cohort_upload 52 0 100% [20:23:09] great! [20:23:13] wikimetrics.controllers.cohorts 125 0 100% [20:23:16] very cool [20:23:33] i added to cohort_upload since it seemed like all those types of tests were happening there [20:23:34] ok, lemme do one final run through and give you any last comments, then we can merge this puppy [20:23:39] yay! [20:23:42] sadly I don't think we'll be able to deploy it anytime soon [20:23:44] :( [20:23:48] because of the labs migration [20:23:58] (they're moving to a new datacenter and everything's not 100% yet) [20:24:03] ah [20:24:13] i'm writing code in the most inconvenient times, haha [20:24:34] oh! do you know what needs to be done with the next priority? or should i set up a hangout with jaime to discuss it? [20:24:45] this one was pretty straight forward [20:25:51] (PS14) Milimetric: Add TextAreaField for paste_username, reads input [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 (owner: Terrrydactyl) [20:26:03] (CR) Milimetric: [C: 2] Add TextAreaField for paste_username, reads input [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/117260 (owner: Terrrydactyl) [20:26:31] https://gerrit.wikimedia.org/r/#/c/117260/ merged [20:26:44] congratulations terrrydactyl, first patch landed :) [20:26:51] yay! [20:26:52] well, first as an official employee [20:26:56] hahaha [20:26:58] you've got like two others :) [20:27:01] :) [20:27:06] what were the comments? [20:27:08] none [20:27:10] i didn't see any [20:27:11] perfect [20:27:15] oh, great! [20:27:25] it said it had comments but i didn't see any so i was confused [20:27:36] really? silly gerrit [20:27:46] i just had to rebase it on master before merging [20:28:00] because i had merged csalvia's change yesterday [20:28:15] ah okay [20:29:19] should i chat with jaime about the next task or would you be able to walk me through it? [20:29:35] oh I don't know what she wants you to do [20:29:41] you should definitely chat with her first [20:29:54] ah, okay, i'll email her and set something up then [20:29:54] :) [20:30:11] cool [20:32:34] (PS13) Milimetric: [WIP] Run recurring reports using the scheduler [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 [20:32:36] (PS8) Milimetric: Add scheduler mode to wikimetrics [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/111623 [20:32:38] (PS7) Milimetric: Allow reports to be rerun [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/111914 [21:31:08] http://multimedia-metrics.wmflabs.org/dashboards/mmv# - I updated these TSVs just now, but the new 03-11 data isn't showing up at all...it's weird [21:31:57] Does limn take time to update the TSV it has? [21:32:13] Oh...there it is [21:32:18] yes [21:32:23] it's a known problem [21:32:42] when it's an external URL, limn doesn't cache-bust the Browser cache of that TSV [21:32:43] Noted [21:32:55] because it's afraid, I think, of messing up the URL [21:33:19] it shouldn't be too hard though, and enough people have trouble with that [21:33:25] including the mobile folks [21:33:36] so - workaround - refresh cache manually [21:57:48] terrrydactyl, i have fixed your issue. it had to do with nose and tests two directories deep [22:07:58] (PS1) Nuria: Correcting test_config.yaml. Moving test, nose does not like tests nested two directories deep. [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/118208 [22:08:01] (CR) jenkins-bot: [V: -1] Correcting test_config.yaml. Moving test, nose does not like tests nested two directories deep. [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/118208 (owner: Nuria) [23:19:37] (PS14) Milimetric: [WIP] Run recurring reports using the scheduler [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 [23:20:10] nite everyone