[07:36:23] <grrrit-wm>	 (CR) QChris: [C: -1] "Mostly nits." (13 comments) [analytics/kraken] - https://gerrit.wikimedia.org/r/121531 (owner: Ottomata)
[13:59:35] <ottomata>	 yoyoo
[13:59:40] <ottomata>	 we in hangout or appear.in?
[13:59:45] <ottomata>	 oh appear!
[13:59:47] <qchris>	 yes :-)
[14:59:59] <grrrit-wm>	 (PS40) Nuria: [WIP] Run recurring reports using the scheduler [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 (owner: Milimetric)
[15:23:53] <quiddity>	 re: my question from yesterday, I asked/summarized everything here, just FYI: https://en.wikipedia.org/wiki/WP:VPT#Animated_article_history_revisions
[16:01:11] <grrrit-wm>	 (PS41) Nuria: [WIP] Run recurring reports using the scheduler [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 (owner: Milimetric)
[16:14:05] <grrrit-wm>	 (PS2) Ottomata: Adding camus wrapper script and camus properties file [analytics/kraken] - https://gerrit.wikimedia.org/r/121531
[16:14:17] <grrrit-wm>	 (CR) Ottomata: Adding camus wrapper script and camus properties file (7 comments) [analytics/kraken] - https://gerrit.wikimedia.org/r/121531 (owner: Ottomata)
[16:28:26] <grrrit-wm>	 (PS1) Ottomata: Adding README, Kraken submodule, and setting up for git-fat [analytics/kraken/deploy] - https://gerrit.wikimedia.org/r/122427
[16:29:59] <grrrit-wm>	 (PS2) Ottomata: Adding README, Kraken submodule, and setting up for git-fat [analytics/kraken/deploy] - https://gerrit.wikimedia.org/r/122427
[16:31:51] <grrrit-wm>	 (PS1) Ottomata: Removing test lib/ directory [analytics/kraken] - https://gerrit.wikimedia.org/r/122428
[19:03:08] <awjr>	 qchris_away: thanks for sending the mobile stats - can you provide headers for the c/tsv's?
[19:16:36] <grrrit-wm>	 (CR) Csalvia: [WIP] Run recurring reports using the scheduler (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 (owner: Milimetric)
[19:58:07] <grrrit-wm>	 (CR) Ottomata: [C: 2 V: 2] Removing test lib/ directory [analytics/kraken] - https://gerrit.wikimedia.org/r/122428 (owner: Ottomata)
[20:00:23] <qchris>	 awjr_away: I guess tnegrin stripped them from my email, when forwarding to you :-/ Should I just email them to you or some list?
[20:00:45] <qchris>	 Mhmm... away ... I'll just send them to you.
[20:03:47] <ottomata>	 qchris: i can't remember, what was the reason we renamed the libs/avro-repo-bundle thing that is committed to the camus repo?
[20:03:57] <ottomata>	 we renamed it to -wmf-1
[20:04:14] <qchris>	 mhmm.
[20:04:22] <qchris>	 We used -wmf-1 for our builds.
[20:04:36] <qchris>	 Not sure about libs/avro-repo-bundle ... did we build it?
[20:04:46] <qchris>	 No. Did we?
[20:04:52] <ottomata>	 no
[20:05:02] <ottomata>	 this is just a .jar file that linkedin manually committed to git repo
[20:05:33] <qchris>	 Let me look at the history ...
[20:05:56] <ottomata>	 0c024d7d7039114bc25b575d8a7f592416fd1cfc
[20:06:12] <qchris>	 Ah!
[20:06:21] <qchris>	 Because it was a SNAPSHOT jar
[20:06:42] <qchris>	 That might change any given day, and we would not know how to properly refer to the right version.
[20:06:59] <qchris>	 Hence we "-wmf-1"-ed it, so we know which of the snapshots is the right one.
[20:07:09] <qchris>	 (And we knew that one cannot change)
[20:07:37] <qchris>	 We did not want to depend on ever changing jars.
[20:07:45] <qchris>	 Makes sense?
[20:08:28] <ottomata>	 hm, oh to keep it from changing?  I guess, but since it is not generated, it will only change if we merge from upstream manually
[20:09:31] <qchris>	 But how would you disambiguate 0.1.0-SNAPSHOT from before the manual upgrade to 0.1.0-SNAPSHOT after the upgrade, if you do not have something like "-wmf-1", "-wmf-2"?
[20:10:08] <ottomata>	 hm, i guess so…
[20:10:12] <ottomata>	 ok, i will leave it
[20:10:16] <ottomata>	 speaking of versions
[20:10:31] <ottomata>	 I've got the whole camus version at this right now:
[20:10:31] <ottomata>	 0.1.0-wmf-0.1.0-SNAPSHOT
[20:10:37] <qchris>	 Hahaha.
[20:10:41] <ottomata>	 i want to make a release and then add the release artifact to the new kraken/deploy repo
[20:10:48] <ottomata>	 should I just remove the -SNAPSHOT?
[20:10:53] <ottomata>	 and build?
[20:11:01] <ottomata>	 or would you prefer something different?
[20:11:13] <qchris>	 No it's fine.
[20:11:25] <qchris>	 But "0.1.0-wmf-0.1.0" looks doubled.
[20:11:30] <ottomata>	 yeah, i dunno
[20:11:42] <ottomata>	 i figured we might as well use a normal looking versioning scheme for our own versino numbers?
[20:11:47] <ottomata>	 in case we make source changes that are not upstrea?
[20:11:48] <ottomata>	 m
[20:11:49] <ottomata>	 ?
[20:11:50] <ottomata>	 dunno
[20:12:10] <qchris>	 I'd prefer "0.1.0-wmf-1" "0.1.0-wmf-2", but
[20:12:17] <ottomata>	 hmm, yeah maybe its ok
[20:12:18] <ottomata>	 like that
[20:12:18] <qchris>	 I am fine with "0.1.0-wmf-0.1.0".
[20:12:22] <ottomata>	 i dunno
[20:12:25] <ottomata>	 it is ugly :p
[20:12:31] <qchris>	 It just sounds overcomplicated.
[20:12:35] <ottomata>	 if our versions are only going to be small changes that always get upstreamed
[20:12:40] <ottomata>	 then that's really easy
[20:12:44] <ottomata>	 kinda like Debian release numbers
[20:12:47] <qchris>	 will there ever be a "0.1.0-wmf-.0.2.3"?
[20:12:49] <ottomata>	 but if we have to make source changes..dunno
[20:12:52] <ottomata>	 doubtful
[20:12:53] <ottomata>	 yeah
[20:12:56] <ottomata>	 i doubt we will make that many
[20:13:00] <ottomata>	 and not upstream them if any
[20:13:10] <qchris>	 Then I'd just keep it simple and go with "0.1.0-wmf-1"
[20:13:17] <ottomata>	 ok
[20:13:18] <ottomata>	 wmf1
[20:13:19] <ottomata>	 wmf-1
[20:13:24] <ottomata>	 ~wmf1
[20:13:27] <ottomata>	 ~wmf-1
[20:13:34] <ottomata>	 -wmf1
[20:13:36] <ottomata>	 mhm
[20:13:37] <ottomata>	 hehe
[20:13:39] <qchris>	 Is tilde a valid character for jars?
[20:13:51] <ottomata>	 dunno, it is for deb versions :p
[20:13:51] <qchris>	 I've never seen that. Do not know.
[20:13:56] <ottomata>	 let's go with -wmf1?
[20:14:02] <qchris>	 For debs ... I have no clue.
[20:14:03] <ottomata>	 like you had it in the first place?
[20:14:05] <ottomata>	 haha
[20:14:15] <qchris>	 Totally :-P
[20:14:17] <ottomata>	 ok ok
[20:14:31] <qchris>	 But seriously, I have no clues about debs.
[20:14:32] <ottomata>	 I'm going to just set it at -wmf3 now, just to avoid any past confusion
[20:14:33] <ottomata>	 s'ok?
[20:14:40] <qchris>	 Sounds good.
[20:15:10] <ottomata>	 what's the proper process for making a release?
[20:15:16] <ottomata>	 just removing -SNAPSHOT locally and building?
[20:15:22] <ottomata>	 or tagging and building?
[20:16:03] <ottomata>	 hmmmmm: http://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html
[20:16:04] <ottomata>	 :)
[20:16:05] <qchris>	 Pffff. That's been a while that I did that without a script. ...
[20:16:25] <qchris>	 Let me read some docs :-(
[20:17:12] <ottomata>	 ooo, also
[20:17:19] <ottomata>	 i wonder what we should do about camus-example? :p
[20:17:31] <ottomata>	 that's the target .jar I've been using this whole time
[20:17:34] <ottomata>	 only because it comes with the shaded jar
[20:17:36] <ottomata>	 so it works
[20:18:02] <ottomata>	 but we aren't actually using any of the code from that target
[20:19:34] <qchris>	 About releasing ... I'd just change the pom's version for the time being and build the jars from there (we have no real scm integration and stuff, so mvn release ... would not work right away)
[20:19:58] <qchris>	 About the shaded jar ... you can use camus-example.
[20:20:17] <qchris>	 At some point we had a kraken-etl target for just that purpose.
[20:20:27] <qchris>	 If you want to, we get resurrect it.
[20:20:34] <ottomata>	 yeah, what about camus-parent?  we could just make that shaded maybe?
[20:20:56] <qchris>	 But since we're working in a separate camus branch anyways, you could also just add a subproject there that's building a shaded jar for you.
[20:21:14] <ottomata>	 is that better than just makign camus-parent pom shaded?
[20:21:22] <ottomata>	 i guess it would avoid more potential upstream conflicts
[20:21:34] <qchris>	 Shaded parent ... would thath work?
[20:21:40] <qchris>	 Do not think so.
[20:21:54] <qchris>	 Current setup camus setup tries to build that first.
[20:22:07] <ottomata>	 dunno how it works at all
[20:22:08] <ottomata>	 ok
[20:22:13] <ottomata>	 i just tried and it did not work :p
[20:22:22] <qchris>	 :-)
[20:22:31] <ottomata>	 HMMMMMMMMMMM
[20:22:39] <ottomata>	 yea, which is better?!  kraken-etl???
[20:22:43] <ottomata>	 or camus-wmf???
[20:22:54] <qchris>	 I'd either use camus-example.jar, resurrect kraken-etl, or create a separate subproject in camus.
[20:23:02] <ottomata>	 those are the options. :p
[20:23:07] <ottomata>	 do you have preferences?  I'm not sure
[20:23:10] <qchris>	 I like the separate subproject in camus best.
[20:23:13] <ottomata>	 using example.jar is the easiest
[20:23:19] <ottomata>	 yeah, i think I do too...
[20:23:26] <qchris>	 That would isolates best what we need.
[20:23:29] <ottomata>	 hm
[20:23:31] <ottomata>	 ok...
[20:23:31] <qchris>	 Cool.
[20:23:33] <ottomata>	 lemme try it
[20:23:47] <qchris>	 Just copy paste the dead kraken-etl pom file.
[20:23:50] <ottomata>	 ok
[20:23:50] <ottomata>	 cool
[20:23:53] <ottomata>	 camus-wmf?
[20:23:54] <ottomata>	 good name?
[20:23:58] <ottomata>	 for subproject?
[20:24:04] <qchris>	 No preferences.
[20:24:07] <qchris>	 Ja.
[20:26:17] <ottomata>	 org.wikimedia.analytics.camus-wmf
[20:26:17] <ottomata>	 hmmm
[20:26:19] <ottomata>	 ook
[20:26:19] <ottomata>	 hm
[20:26:23] <ottomata>	 maybe i just change the group id
[20:26:25] <ottomata>	 and call it camus?
[20:26:28] <ottomata>	 or maybe that is too confusing
[20:26:28] <ottomata>	 hmmm
[20:26:40] <qchris>	 Sounds a bit confusing to me.
[20:26:51] <qchris>	 The final name of the jar does not show the group.
[20:27:24] <ottomata>	 k
[20:27:42] <ottomata>	 org.wikimedia.analytics camus-wmf then
[20:27:43] <ottomata>	 ?
[20:27:46] <qchris>	 Which repo are you working on. the wmf branch of camus as it is in gerrit?
[20:27:57] <qchris>	 "org.wikimedia.analytics camus-wmf" sounds good. Yes.
[20:28:13] <ottomata>	 yes
[20:28:17] <ottomata>	 wmf branch of camus in gerrit
[20:28:22] <qchris>	 Thanks.
[20:28:40] <ottomata>	 oh man you had tons of tests in there too!
[20:28:44] <ottomata>	 i could resurrect those too!
[20:28:48] <ottomata>	 into camus-wmf subproject
[20:28:55] <qchris>	 If you want to.
[20:29:07] <ottomata>	 i want to try!  why not, right?  you did all those, we should use them if we can
[20:29:30] <qchris>	 We can resurrect them later if we want to as well.
[20:29:48] <qchris>	 Maybe behaviour changed in the meantime and they no longer pass?
[20:30:40] <ottomata>	 hmm, i actually only see a testcase for JsonStringMessageDecoder
[20:30:41] <ottomata>	 and I wrote that
[20:30:44] <ottomata>	 pretty sure it hasn't changed
[20:30:54] <ottomata>	 ok ok ok
[20:31:00] <ottomata>	 i will look into that later
[20:31:05] <qchris>	 IIRC that was the only testcase I did ... because the other code was third party.
[20:31:05] <ottomata>	 woudl be cool if we could save that work
[20:31:08] <ottomata>	 aye
[20:31:18] <ottomata>	 I wrote a second class since then too
[20:31:23] <ottomata>	 actually two other classes
[20:31:25] <ottomata>	 we are using one of them
[20:31:26] <qchris>	 You're a busy bee :-)
[20:31:29] <ottomata>	 the SequenceFile writer thing
[21:01:42] <grrrit-wm>	 (PS1) Ottomata: Updating archiva url for deployment [analytics/camus] (wmf) - https://gerrit.wikimedia.org/r/122562
[21:01:44] <grrrit-wm>	 (PS1) Ottomata: Adding camus-wmf subproject and setting wmf version to -wmf3 [analytics/camus] (wmf) - https://gerrit.wikimedia.org/r/122563
[21:02:07] <grrrit-wm>	 (CR) Ottomata: [C: 2 V: 2] Updating archiva url for deployment [analytics/camus] (wmf) - https://gerrit.wikimedia.org/r/122562 (owner: Ottomata)
[21:02:47] <grrrit-wm>	 (PS2) Ottomata: Adding camus-wmf subproject and setting wmf version to -wmf3 [analytics/camus] (wmf) - https://gerrit.wikimedia.org/r/122563
[21:44:44] <qchris>	 dr0ptp4kt: Do I understand it correctly that we do not want to count such requests as pageviews and we should fix that right away?
[21:45:02] <qchris>	 dr0ptp4kt: (Sorry. Was referring to the FFOS app)
[21:45:28] <dr0ptp4kt>	 qchris, those zeroconfig requests are not pageviews. that's what you're talking about, right?
[21:45:35] <qchris>	 Ja.
[21:45:36] <dr0ptp4kt>	 qchris, got a couple minutes for a videoconference?
[21:45:54] <qchris>	 Give me 10 minutes ...
[21:46:16] <dr0ptp4kt>	 qchris: cool, poke me on irc once you're ready to take a videoconference call
[21:56:14] <qchris>	 dr0ptp4kt: I am in our batcave at http://goo.gl/1pm5JI
[23:10:57] <grrrit-wm>	 (PS3) JGonera: Update the uploads schema definition [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/121525 (owner: Jdlrobson)
[23:11:39] <grrrit-wm>	 (CR) Milimetric: "One thing we missed was to write tests that set up the report table like the old report table was. Since show_in_ui was set to True on Ag" [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/112165 (owner: Milimetric)
[23:11:54] <grrrit-wm>	 (CR) JGonera: [C: 1] "I changed the number of columns in the union, might make it a bit faster and we don't need all of them." [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/121525 (owner: Jdlrobson)
[23:16:02] <grrrit-wm>	 (PS1) JGonera: Make --force a boolean flag [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/122604
[23:26:49] <grrrit-wm>	 (CR) Milimetric: [C: 2 V: 2] Make --force a boolean flag [analytics/limn-mobile-data] - https://gerrit.wikimedia.org/r/122604 (owner: JGonera)