[09:09:29] (PS1) QChris: Fix type of user_name in SQLAlchemy's model of MediaWiki's user table [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125961 [09:11:55] (CR) QChris: "Tests pass for me locally." [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125961 (owner: QChris) [09:23:22] chris, did you tested in staging? [09:23:44] i can test there cause the enwiki db [09:23:50] in vagrant [09:24:24] and the enwiki db in staging are not identical. [09:25:02] I believe this fixes an issue but there are a couple more in the parse_user function that would still make things blow up [09:26:28] I tested in my local vagrant. [09:26:40] But I would not want to change anything on staging, while [09:26:57] tnegrin and kevinator are testing mili metric's changes. [09:27:24] I may well be that there are further issues down the road. [09:27:29] I mean ... [09:27:46] the Wikimetrics models do not reflect MediaWikis' at all. [09:27:54] (At least when it comes to strings) [09:28:26] s/I may/It may/ [09:28:49] So actually ... I expect more problems to surface around character encoding over time. [09:43:35] (CR) Nuria: "We do not need a migration, that is correct." [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125961 (owner: QChris) [12:03:52] (CR) Nuria: "I think there is some more work needed." (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [12:59:27] (PS4) Csalvia: Fixed parse_username to handle Unicode [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 [13:07:26] (PS5) Csalvia: Fix parse_username to handle Unicode [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 [13:49:19] csalvia, nuria, qchris_away, looks like we need to get together to talk about the encoding bug [13:49:33] or have you guys all solved this already? [13:54:39] we can talk about it for 10 mins but qchris fix fixes uploading of cohorts [13:55:27] now the identification of valid users has a bug [13:55:45] so there are two different issues [13:55:52] (CR) Milimetric: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [14:55:18] (CR) Stefan.petrea: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [15:26:04] (CR) Stefan.petrea: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [15:38:01] (CR) QChris: [C: -1] Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [15:41:10] (CR) Stefan.petrea: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [16:51:10] (CR) Nuria: "I would like to make a "meta" point here:" (2 comments) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [16:52:30] (CR) Milimetric: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [16:58:21] (PS1) Milimetric: Fix bad initial recurrent report [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/126020 [19:58:33] (PS3) Terrrydactyl: Added delete wiki user functionality. [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/124878 [20:04:38] (PS6) Csalvia: Fix parse_username to handle Unicode [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 [20:05:45] (CR) Csalvia: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [20:07:13] (CR) Csalvia: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [20:08:31] (CR) Csalvia: Fix parse_username to handle Unicode (2 comments) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [20:10:53] (CR) Csalvia: Fix parse_username to handle Unicode (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125752 (owner: Csalvia) [20:57:57] (Abandoned) QChris: Fix type of user_name in SQLAlchemy's model of MediaWiki's user table [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/125961 (owner: QChris)