[00:00:06] awight: interesting I haven’t looked up the data in a while, be aware that there are multiple events for the same [00:00:21] which are likely due to people hitting the save button multiple time [00:00:23] s [00:00:25] yah lemme dedupe [07:18:47] (PS1) Gilles: Separate the opt-in/opt-out actions into their own tab/graph [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/140888 [07:24:44] (PS1) Gilles: Calculate opt-in/opt-out totals [analytics/multimedia] - https://gerrit.wikimedia.org/r/140889 [07:25:41] (PS2) Gilles: Separate the opt-in/opt-out actions into their own tab/graph [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/140888 [07:31:06] (PS1) Gilles: Add opt-out and opt-in totals to graph [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/140890 [07:52:49] (PS1) Gilles: Display opt-out totals for each wiki on a global graph [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/140892 [13:29:10] morning [13:55:55] (CR) Erik Zachte: [C: 2 V: 2] Make daily dammit compact script rsync files if monthly step fails [analytics/wikistats] - https://gerrit.wikimedia.org/r/138685 (owner: QChris) [14:01:22] mogge [15:48:35] k on ../bash/dammit_compact_daily.semaphore" ; exit 1 ; } >&2 [15:48:47] darn line break ... [15:48:53] nuria: ^ is the second part [15:49:36] sorry for sucking at copy/paste :-( [17:12:40] brb lunch [18:18:08] Henrik: is there a stats.grok.se api? [18:20:16] ah, I see, the json links are the way to go for that. [18:35:53] milimetric: Just wanted to double check with you ... [18:35:59] Currently /data/project/wikimetrics/backup does not exist. [18:36:02] yes [18:36:09] only /data/project/wikimetrics [18:36:09] Can I create it, and remove it afterwards [18:36:22] or does some part already use it temporary. [18:36:51] nothing uses it right now, you can create it and leave it there [18:36:56] or remove it, however you wish [18:37:00] Ok. Thanks. [18:37:21] That makes for easier testing of the class in labs. [21:31:03] (CR) Nuria: [C: 2] "While I do not love the fix it does work and fixes an issue we are likely going to run into with EEVs metrics in prod." [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/138031 (https://bugzilla.wikimedia.org/66439) (owner: Nuria) [21:31:12] (Merged) jenkins-bot: Fix Aggregation of empty metric results [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/138031 (https://bugzilla.wikimedia.org/66439) (owner: Nuria) [21:31:56] :) [21:55:52] qchris: how come you dropped the depends-on link from the backup role commit message? [21:56:04] (CR) Nuria: "Please see comment regarding design. I am happy to do changes myself, do let me know if you want me to do them." (1 comment) [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/140823 (https://bugzilla.wikimedia.org/66290) (owner: Milimetric) [21:56:30] milimetric: I made them explicit [21:56:48] i see [21:56:51] I just added a comment to the operations/puppet commit about it. [21:56:54] and jenkins freaked, i see [21:56:58] thanks [21:57:06] That's expected [21:57:17] "recheck" once the dependent one is merged. [21:57:22] and jenkins is fine again. [21:57:31] I tested both commits agains my own labs instance. [21:57:40] And it worked. [22:04:25] nuria: You asked about testing the backup in staging. [22:04:30] qchris: [22:04:30] $public_directory = '/var/lib/wikimetrics/public', [22:04:43] isn't the var_directory variable better there? [22:05:37] Which line? (The default value for the parameter of the wikimetrics class cannot use the value of another parameter :-/ ) [22:05:51] i'll make a comment [22:06:00] public_directory could just be what's appended to var_directory then [22:07:05] Ok. waiting for the comment then. [22:07:41] I thought about using 'undef' at some spots and building the variables from $var_directory when we see 'undef' [22:07:52] But that felt hacky. [22:08:27] mm, either way, it's just a nit, I +0-ed it as I don't really care/know enough [22:08:34] so yeah, this looks fine to test in staging [22:08:50] you guys give it a shot Monday morning and then feel free to improve as much as you want in another patch [22:10:13] ok, will test the patch locks & backup restore Monday [22:10:36] also did not know about trap, will remember that for the future [22:11:13] trap is awesome right? [22:11:18] i didn't know about it either [22:11:25] #adulteducation [22:11:35] I tested locking & stuff already. But yes, I'd be glad if someone else has a look as well. Thanks nuria. [22:42:17] qchris: you didn't agree with nuria's comment on line 193 here: https://gerrit.wikimedia.org/r/#/c/139558/6..7/manifests/role/wikimetrics.pp [22:42:18] ? [22:42:24] to remove the comment block [22:43:50] Thanks for the hint. [22:44:12] That comment happened while I worked on the patch. I'll chime in there. [22:48:11] I'll call it a day. Have fun! [23:07:05] DarTar: if you're interested, here are rough drafts of the new event streams we were discussing: https://meta.wikimedia.org/wiki/Schema:EditLifecycle https://meta.wikimedia.org/wiki/Schema:EditDebugging [23:07:40] nice :) [23:10:11] (PS1) Milimetric: Remove useless scripts [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/141076 [23:14:10] (PS1) Milimetric: [WIP] Add script to bulk insert cohorts or reports [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/141077 (https://bugzilla.wikimedia.org/65946) [23:17:46] DarTar: detecting the platform from the server seems really difficult, I don't see how to do it without repeating code or breaking encapsulation, yet.