[01:07:22] (PS1) Bmansurov: Add support for timezones while creating reports [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/175169 (https://bugzilla.wikimedia.org/72116) [01:08:27] (CR) Bmansurov: "It's a hacky solution. Maybe we I should do it some other way? Any suggestions?" [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/175169 (https://bugzilla.wikimedia.org/72116) (owner: Bmansurov) [01:15:38] (PS2) Bmansurov: Add support for timezones while creating reports [analytics/wikimetrics] - https://gerrit.wikimedia.org/r/175169 (https://bugzilla.wikimedia.org/72116) [06:05:56] YuviPanda|zzzz, ping [06:06:03] rtnpro: pong [06:06:06] good morning [06:06:13] YuviPanda|zzzz, Good morning :) [06:06:27] YuviPanda|zzzz, I thought we were sleeping :P [06:06:37] s/we/you/g [06:07:40] YuviPanda|zzzz, I had some query regarding this line: https://github.com/wikimedia/analytics-quarry-web/blob/master/quarry/web/app.py#L292 [06:07:53] YuviPanda|zzzz, AFAIK, "joins" are bad [06:08:59] YuviPanda|zzzz, when the tables grow, this is gonna have its toll [06:09:09] indeed [06:09:16] but they haven't grown yet [06:09:18] so it's ok :) [06:09:23] YuviPanda|zzzz, ok [06:09:24] don't want to denormalize yet [06:09:31] YuviPanda|zzzz, ok [06:09:42] and denormalizing is the way to fix it [06:09:57] YuviPanda|zzzz, yes [06:10:24] YuviPanda|zzzz, since, READs are way lot greater than WRITEs, we need to optimize it that way [06:10:48] true, but we can do that when we hit a few hundred thousand records, I think [06:11:06] YuviPanda|zzzz, yes, I agree [06:11:11] YuviPanda|zzzz, also, regarding the pagination for all queries page, I have used the following URL pattern [06:11:47] YuviPanda|zzzz, /query/runs/all?from=&direction= [06:12:02] I think just having 'next' is ok [06:12:03] ? [06:12:32] YuviPanda|zzzz, I do not follow [06:12:45] as in [06:12:59] ?from=query_id&limit= [06:13:01] YuviPanda|zzzz, 'next' in place of 'direction'? [06:13:32] as in, don't support 'previous' [06:13:33] YuviPanda|zzzz, 'next' is always on by default [06:13:37] ok [06:13:38] ok [06:13:42] why support previous? [06:14:16] YuviPanda|zzzz, that's what pagination is for, you need to be able to go backwards and forwards [06:14:49] YuviPanda|zzzz, it will just involve one more line [06:14:53] rtnpro: you go backwards by knowing the query_id of the page that was 'previous' [06:15:00] rtnpro: but hmm, if this is simpler, sure. [06:16:23] YuviPanda|zzzz, so, let's finalize on this URL pattern: query/runs/all?from=&limit=&prev [06:16:44] how about [06:16:47] just setting negative limit [06:16:50] to go prev? [06:17:16] YuviPanda|zzzz, hmm, makes sense [06:17:18] +1 [06:17:31] :) [06:19:58] YuviPanda|zzzz, I still don't have access for: https://www.mediawiki.org/wiki/Special:OAuthConsumerRegistration/propose :( [06:20:09] rtnpro: bah. [06:20:27] rtnpro: send me your email, I will send you some test credentials [06:20:54] YuviPanda, it's rtnpro AT gmail DOT com [06:22:44] rtnpro: sent [06:22:45] try those? [06:22:58] YuviPanda, thanks :) [06:23:17] rtnpro: tell me if it does work, tho [06:23:35] YuviPanda, ok [06:28:21] YuviPanda, it worked :) [06:28:40] yay [06:28:43] cool\