[01:30:06] (PS1) Gergő Tisza: Fix date format in pageview SQL query [analytics/multimedia] - https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) [01:30:56] (CR) Gergő Tisza: [C: 2] "Self-merge, trivial bug that prevents me from testing the limn half of the patch." [analytics/multimedia] - https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) (owner: Gergő Tisza) [01:31:02] (Merged) jenkins-bot: Fix date format in pageview SQL query [analytics/multimedia] - https://gerrit.wikimedia.org/r/185362 (https://phabricator.wikimedia.org/T78189) (owner: Gergő Tisza) [02:16:56] (PS1) Ewulczyn: first draft of host parsing udf. extracts the project and project qualifier from the uri_host. [analytics/refinery/source] - https://gerrit.wikimedia.org/r/185377 [02:20:49] (PS2) Ewulczyn: first draft of host parsing udf. extracts the project and project qualifier from the uri_host. [analytics/refinery/source] - https://gerrit.wikimedia.org/r/185377 [02:24:54] (PS1) Yurik: weblog2: monthly sums, enabled [analytics/zero-sms] - https://gerrit.wikimedia.org/r/185380 [02:25:10] (CR) Yurik: [C: 2 V: 2] weblog2: monthly sums, enabled [analytics/zero-sms] - https://gerrit.wikimedia.org/r/185380 (owner: Yurik) [03:17:40] Analytics-EventLogging: Can't save new schemas on MetaWiki - https://phabricator.wikimedia.org/T86989#981125 (ori) Open>Resolved a:ori Fixed by cherry-picking https://gerrit.wikimedia.org/r/#/c/184111/ to wmf14 [03:32:51] (CR) OliverKeyes: first draft of host parsing udf. extracts the project and project qualifier from the uri_host. (11 comments) [analytics/refinery/source] - https://gerrit.wikimedia.org/r/185377 (owner: Ewulczyn) [08:06:46] (CR) Gilles: [C: 2] Show page view / image view comparison [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: Gergő Tisza) [08:07:35] (CR) Gilles: [V: 2] Show page view / image view comparison [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: Gergő Tisza) [08:08:08] (CR) Gilles: "Deployed" [analytics/multimedia/config] - https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) (owner: Gergő Tisza) [09:03:54] Analytics-EventLogging: Can't update schemas on meta - https://phabricator.wikimedia.org/T86926#981315 (Gilles) Maybe related to your recent changesets, Timo? [09:06:19] Analytics-EventLogging: sendBeacon throws an exception in Firefox when event.gif is adblocked - https://phabricator.wikimedia.org/T86680#981317 (Gilles) a:MarkTraceur>ori [09:11:16] Analytics-EventLogging: sendBeacon throws an exception in Firefox when event.gif is adblocked - https://phabricator.wikimedia.org/T86680#981323 (Gilles) I can reproduce with the subscriptions listed by @oseveno and as @Rillke already confirmed, the exception is correctly trapped by wrapping the navigator.send... [11:30:19] Analytics-EventLogging: PHP Notice: Undefined index: REQUEST_TIME in extensions/EventLogging/includes/EventLogging.php on line 56 - https://phabricator.wikimedia.org/T70629#981545 (hashar) Seems EventLogging works fine under HHVM with a bunch of other extensions. Proposed https://gerrit.wikimedia.org/r/#/c/1... [13:10:35] Analytics-EventLogging: PHP Notice: Undefined index: REQUEST_TIME in extensions/EventLogging/includes/EventLogging.php on line 56 - https://phabricator.wikimedia.org/T70629#981702 (Nemo_bis) Your definition of "a bunch" differs of 1-2 orders of magnitude from mine. :) I still have open patches to fix the bug... [13:11:34] Analytics: Firewall changes on 2015-01-13 affect udp2log - https://phabricator.wikimedia.org/T86973#981704 (QChris) [13:13:21] Analytics: Firewall changes on 2015-01-13 affect udp2log - https://phabricator.wikimedia.org/T86973#980599 (QChris) (Removed Incident-20141129-Network project as that is not a general catch-all for network issies, but was only for the Incident report of network issues that occurred on 2014-11-19) [14:21:39] (PS1) QChris: Add script to dump status of webrequest partitions [analytics/refinery] - https://gerrit.wikimedia.org/r/185436 [14:21:41] (PS1) QChris: Add quiet mode to webrequest partition status dumping [analytics/refinery] - https://gerrit.wikimedia.org/r/185437 [14:36:38] Analytics-EventLogging: Recent EventLogging change breaking Echo, Popups on blocked event.gif calls / on Firefox with Adblock Plus - https://phabricator.wikimedia.org/T86918#981898 (Aklapper) This seems to be the same as T86680, hence merging. [14:36:46] Analytics-EventLogging: Recent EventLogging change breaking Echo, Popups on blocked event.gif calls / on Firefox with Adblock Plus - https://phabricator.wikimedia.org/T86918#981900 (Aklapper) [14:36:48] Analytics-EventLogging: sendBeacon throws an exception in Firefox when event.gif is adblocked - https://phabricator.wikimedia.org/T86680#973983 (Aklapper) [14:39:05] Analytics-EventLogging: sendBeacon throws an exception in Firefox when event.gif is adblocked - https://phabricator.wikimedia.org/T86680#981904 (Aklapper) p:High>Unbreak! This creates problems and confusion all over the VillagePumps etc.; raising priority. [14:42:47] (PS1) QChris: Add --hdfs-mount option to script to dump webrequest status [analytics/refinery] - https://gerrit.wikimedia.org/r/185440 [14:55:10] ottomata, do you have time to look at the altiscale data transfer options with me today? [14:55:41] sure, let's do it after I do the haddoop namenode migration this morning, i'm starting that in 45 minutes [14:55:51] i think it will take me 30 - 60 mintues to do, hopefully less [14:55:55] Sure. Sounds good. [14:55:57] i've scheduled 2 hours just in case [14:56:43] kk. [14:57:10] hmm... I have something writing to HDFS. It seems like it might have stalled. [15:22:37] Analytics-Engineering, Analytics-EventLogging: Community Engineers have a working EventLogging dev server in vagrant [8 pts] - https://phabricator.wikimedia.org/T86067#981952 (mforns) Open>Resolved [15:26:14] hmm, nuria, the first mobile daily job ran [15:26:24] but, i would have expected it to wait until then end of today [15:26:29] since I the start time was jan 16 [15:26:35] maybe we've got our offsets wring? [15:26:36] wrong? [15:26:40] jan 16 contains data for jan 15? [15:27:30] hmm, also, the filename is [15:27:33] 2015-1-16.gz [15:27:39] probably would be better to have those 0 padded [15:27:45] so they sort properly in displays [15:27:58] but, it seems to have worked! [15:27:59] Android 56560 [15:27:59] iOS 825 [15:28:05] nuria, also, these files are super small [15:28:15] do we need to gzip compress them? [15:28:18] could we just leave them uncompressed? [15:28:25] Analytics-EventLogging: Client Engineer passes null to EventLogging::logEvent for optional boolean fields [8 pts] - https://phabricator.wikimedia.org/T78325#981960 (kevinator) [15:28:46] Analytics-EventLogging: Client Engineer passes null to EventLogging::logEvent for optional boolean fields [8 pts] - https://phabricator.wikimedia.org/T78325#842558 (kevinator) We are canceling our commitment to complete this task in our sprint. I removed the sprint project. [15:30:17] ottomata: i think compressing as a default is an ok default [15:30:40] ottomata: as for the zero padding i will get a patch together. [15:31:58] k [15:31:58] cool [15:32:08] also, check that the date offset is right [15:32:23] the nominal time for this job was 2015-01-16 00:00 GMT [15:32:41] and it was started at 2015-01-16 02:16 GMT [15:32:45] the 16th isn't over yet [15:32:50] so that means that the data in that file is for the 15th [15:33:11] maybe you want dataset files 0, 23, instead of -23? [16:09:19] milimerric: will be back in 40 mins and look at pentaho then [16:09:25] cc kevinator [16:11:13] Analytics-EventLogging: Client Engineer passes null to EventLogging::logEvent for optional boolean fields [8 pts] - https://phabricator.wikimedia.org/T78325#981990 (kevinator) Open>declined We are not going implement this functionality... see my longer comment above. [16:12:57] Analytics-Engineering, Analytics-EventLogging: Community Engineers have a working EventLogging dev server in vagrant [8 pts] - https://phabricator.wikimedia.org/T86067#981993 (kevinator) Resolved>Open temporarily re-opening this task so its points show up on our burndown chart. [16:46:29] migration done! hadoop is back [16:47:24] ottomata: super fast!, ok, will start trying changes in abit [16:51:39] Analytics, operations: Upgrade Analytics Cluster to Trusty, and then to CDH 5.3 - https://phabricator.wikimedia.org/T1200#982081 (Ottomata) [16:52:57] Analytics, operations: Upgrade Analytics Cluster to Trusty, and then to CDH 5.3 - https://phabricator.wikimedia.org/T1200#20804 (Ottomata) analytics1001 and analytics1002 have been provisioned, and the Hadoop NameNode and YARN master services have been migrated off of analytics1010 and analytics1004 (ciscos).... [16:55:50] nuria: ananthrk, lemme know if you want me to chime in, maybe chat here? [16:56:32] yes. [16:56:51] ottomata: nuria, just to summarize our discussions so far - [16:57:20] the reason why we have the constructor is to pass the db path from tests even though the main code tries to read it from a property [16:57:41] this property would typically be set via hive-site or via the CLI [16:57:46] ananthrk, ottomata : what we wnat to avoid is having test specific code mixed with runtime code [16:57:55] ananthrk: as that is a source of potential bugs [16:58:14] would making the constructor protected minimize the confusion? [16:58:15] ananthrk, ottomata : also we want to avoid testing code "undoing" teh static initializer [16:58:51] ananthrk: actually you should be able to pass properties to the test with mvn, did you tried that? [16:59:18] that would be system or env level properties [16:59:31] but the ones that we read in our code are in the "hiveconf" namespace [16:59:40] ananthrk: regardless of whether you make the constructor private you woudl still be undoing the static initialization, which is not good practice. [16:59:52] ananthrk, i'm pretty sure hiveconf will use sys level properties too, at least in some way. [16:59:59] i'm fine if they are sys level propeties and not avaiable in hive [17:00:00] e.g. [17:00:08] -Dmaxmind.database.country=/path/to/db [17:00:35] hm, maybe it won't, not sure, even if it doesn't though, i'm ok if they are sys level [17:00:52] if they are sys level, then you could move the logic to choose the database into the Geocode class, rather than the hive class [17:01:11] agreed, the important thing is removing testing specific code and let configuration handle that [17:01:54] okay..in that case, we can even set it in tests using System.setProperty [17:02:17] the part I was not sure of was the way it would be set in the cluster [17:04:14] also - this cannot be in Geocode because the class it common to both Country and City UDF - and we want to use two different DBs for these two usecases [17:05:11] otherwise we have to split the underlying Geocode class into two as well - one for country and the other for city [17:06:48] hm, ananthrk, as is now, someone could call country() on the city db, right? [17:07:02] if they were just using the Geocdoe class [17:07:03] yes..they can [17:07:13] or even city() on the country db [17:07:19] if they instantiated Geocode witih the country db [17:07:44] city() on the country DB will not work [17:07:57] but country() on city DB will [17:08:00] right, but someone coudl maek that happen right now, right? [17:08:20] g = new Geocode(/path/to/country); g.getGeocodedData() [17:08:29] yes..by changing UDFs code [17:08:37] no, this class will be used by more than just hive [17:08:44] the UDF is just for the Hive interface [17:08:55] say someone just wrote a mapreduce job that needed Geocoding [17:08:57] they would use this class [17:09:54] so, probably [17:10:03] the class should know how to work with both databases [17:10:33] maybe have two DatabaseReaders? [17:10:44] thats what I am thinking now [17:11:21] in that case we will have two readers and initialize both of them with their respective system-level properties? [17:11:23] we've already got two settings [17:11:25] yes [17:11:28] that sounds good to me [17:12:42] so any user of this class is expected to set these two properties - or atleast have the respective DBs in the classpath..is that a reasonable assumption to make? [17:16:04] Analytics-EventLogging: sendBeacon throws an exception in Firefox when event.gif is adblocked - https://phabricator.wikimedia.org/T86680#982160 (greg) @gilles / @ori: Feel free to fix/deploy this ASAP given Andre's previous comment without checking in with me further. [17:17:28] ananthrk: they are expected to set them if they want to change the defaults [17:17:43] i think having the defaults at /usr/share/GeoIP/... is cool [17:17:51] since that should be present everywhere on our cluster [17:17:54] does that make sense? [17:17:56] okay...fine [17:18:17] cool [17:19:27] a quick question on setting this property from Hive CLI [17:19:47] ja? [17:19:49] will the users need to explicitly use system:maxmind.database.country= [17:22:10] I'm not sure, if that works, then that is fine. or, they may be able to just use -D on the CLI when they start hive [17:22:18] hive -Dmaxmind.database.country= [17:22:52] okay...thanks [17:23:12] yup :) [17:23:32] nuria: do you see any issues in setting the property in tests explicitly via System.setProperty? [17:25:08] ananthrk: in teh setup method , I think that will be preferable but i suspect that you might run into issues, it might be be sytem properties have been read alredy and test cannot change them, that is why the mvn route seemed more likely to work. But you can try it and see. [17:27:53] ananthrk: aren't JVM properties read by JVM upon startup? I think that is the case for tests too [17:28:35] ananthrk: but as i said you can try it and see, it is possible to set up properties just for tests, we have to find teh best way to do it in our env. [17:29:41] you are right...the ones initialized in setup are not available in the class [17:30:37] https://www.irccloud.com/pastebin/NnNqEka1 [17:31:25] So you can do the same on mvn i bet. [17:31:28] cc ananthrk [17:31:51] nuria: thanks...will check [17:33:37] ananthrk: k, please see: http://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html [17:35:01] yup...saw them [17:36:27] we currently do not explicitly add the surefire-plugin in our pom.xml [17:36:44] i trust it is okay to add them? [17:41:27] ananthrk: that is a question for ottomata the man, i would need to look a bit more about what that pluging does exactly but qchris and ottomata might have looked at options whn they setup mvn infrastructure. [17:42:02] okay..cc ottomata ? [17:43:08] ha you can add whatever you want [17:43:18] once we get this patchset ready, we'll add the jars to our archiva mirror [17:43:19] We're using it already. It's just not in the poms. [17:43:34] ok :) [17:44:50] Actually ... it should already be in archiva ... [17:46:16] There you go: http://archiva.wikimedia.org/#artifact/org.apache.maven.plugins/maven-surefire-plugin [17:48:37] thanks qchris [17:48:46] yw [17:53:09] qchris - is 2.18.1 a valid version for the surefire plugin? [17:54:11] Not sure what "valid" means in this context ... but 2.18.1 is in wmf's archiva. [17:54:26] ananthrk: ^ http://archiva.wikimedia.org/#artifact/org.apache.maven.plugins/maven-surefire-plugin/2.18.1 [17:55:13] i saw a checksum failure when i first added the plugin to pom [17:55:37] but i now think it was probably due to a broken download in my end [17:55:56] So it's working now? [17:56:16] hm...just moved to a different one now [17:56:28] https://www.irccloud.com/pastebin/Y2T9Tgp6 [17:57:08] ananthrk: that ^ error is for maven-plugin-tools-3.3 [17:57:14] not for the surefire plugin. [17:58:03] got the same msg for surefire earlier, but it got resolved [17:58:08] https://www.irccloud.com/pastebin/PphTlUXj [17:58:21] so may be it is the connection in my end?? [17:59:01] Are you downloading manually or through automatic means? [18:02:14] mvn is automatically downloading the dependencies [18:02:28] Mhmmm ... there is something weird going on then. [18:02:33] The error message you gave: [18:02:42] [WARNING] Checksum validation failed, expected