[00:05:26] 10Analytics, 10Analytics-Kanban, 10serviceops, 10Patch-For-Review: Create production and canary releases for existent eventgate helmfile services - https://phabricator.wikimedia.org/T245203 (10EBernhardson) Re-deployed our glent esbulk oozie job against refinery versioned `2020-02-19T16.58.16+00.00--scap_s... [00:06:05] i spoke too soon, oozie sent me a failure email :P Probably not related to eventgate though :) [02:02:49] 10Analytics, 10Analytics-Kanban, 10Patch-For-Review: Support CSV uploads in Superset - https://phabricator.wikimedia.org/T245679 (10Nuria) Sounds good, +1 [02:34:32] 10Analytics, 10Analytics-Kanban, 10serviceops, 10Patch-For-Review: Create production and canary releases for existent eventgate helmfile services - https://phabricator.wikimedia.org/T245203 (10Ottomata) Thank you! [05:05:32] 10Analytics, 10Product-Analytics: wmfdata cannot recover from a crashed Spark session - https://phabricator.wikimedia.org/T245713 (10nshahquinn-wmf) [05:50:10] morning! [07:08:46] 10Analytics, 10Analytics-Kanban: Move the Analytics infrastructure to Debian Buster - https://phabricator.wikimedia.org/T234629 (10elukey) [07:09:06] 10Analytics, 10Analytics-Kanban: Move the Analytics infrastructure to Debian Buster - https://phabricator.wikimedia.org/T234629 (10elukey) [07:36:46] good morning! [07:36:51] finally the pyhive repo seems moving [07:36:54] good news [07:40:50] 10Analytics, 10Analytics-Kanban, 10Patch-For-Review: Support CSV uploads in Superset - https://phabricator.wikimedia.org/T245679 (10elukey) Past me filed a similar code change in the past: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/479408/ Moritz suggested to modify Superset's systemd unit to ad... [10:03:59] 10Analytics, 10Analytics-Kanban, 10User-Elukey: Kerberize Superset to allow Presto queries - https://phabricator.wikimedia.org/T239903 (10elukey) Somebody from Dropbox is willing to revive the repository! He asked for some help, so I filed a pull request for https://github.com/dropbox/PyHive/issues/288 to un... [10:05:12] brb [10:25:13] 10Analytics, 10Product-Analytics (Kanban): Update wmfdata to use sensible Spark settings - https://phabricator.wikimedia.org/T245097 (10elukey) [10:25:32] 10Analytics, 10Product-Analytics (Kanban): Update wmfdata to use sensible Spark settings - https://phabricator.wikimedia.org/T245097 (10elukey) Explicitly adding the Analytics tag to get this task triaged. [10:59:26] 10Analytics, 10Fundraising-Backlog: Whitelist CentralNotice banner history events for sanitization and long-term storage - https://phabricator.wikimedia.org/T245285 (10mforns) I believe this is done! We deployed the white-listing of CentralNoticeBannerHistory yesterday. From now on data from event.CentralNoti... [10:59:43] 10Analytics, 10Analytics-Kanban, 10Fundraising-Backlog: Whitelist CentralNotice banner history events for sanitization and long-term storage - https://phabricator.wikimedia.org/T245285 (10mforns) [12:58:21] 10Analytics, 10Fundraising-Backlog, 10WMDE-Analytics-Engineering, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech: Find a better way for WMDE to get impression counts for their banners - https://phabricator.wikimedia.org/T243092 (10kai.nissen) So, for logging banner impressions we have * beacon/impression * Spe... [14:10:10] 10Analytics, 10Analytics-Kanban, 10Fundraising-Backlog: Whitelist CentralNotice banner history events for sanitization and long-term storage - https://phabricator.wikimedia.org/T245285 (10jkumalah) Thanks everyone! I just looked at the event_sanitized.CentralNoticeBannerHistory and it looks good. [14:35:08] 10Analytics, 10Analytics-Kanban, 10serviceops, 10Patch-For-Review: Create production and canary releases for existent eventgate helmfile services - https://phabricator.wikimedia.org/T245203 (10Ottomata) [14:36:53] 10Analytics, 10Analytics-Kanban, 10serviceops, 10Patch-For-Review: Create production and canary releases for existent eventgate helmfile services - https://phabricator.wikimedia.org/T245203 (10Ottomata) [14:56:37] 10Analytics, 10Analytics-Kanban, 10Patch-For-Review, 10User-Elukey: Repurpose db1108 as generic Analytics db replica - https://phabricator.wikimedia.org/T234826 (10elukey) I compared the `my.cnf` of dbstore1003 with the one on db1108, looking for peculiar things of the latter: ` datadir = /srv/sqldata... [14:57:11] let's rebuild the hadoop package, it will be fun! [14:57:13] <========-----> 66% EXECUTING [1h 56m 22s] [14:59:16] does this use multiple cores or entirely serial? [15:00:46] ...said no one ever [15:01:08] it is using docker, I am a little bit ignorant if it is able to use a multicore or note.. but my laptop is a dual core, so not much powerful [15:01:29] it is going through a ton of jars of course, generating them etc.. [15:01:45] upstream asked me to test the openssl patch [15:12:50] heya, sorry for the unexpected absence [15:12:52] back for good [15:13:06] o/ [15:16:07] 10Analytics, 10Better Use Of Data, 10Epic, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), and 3 others: Prototype client to log errors in vagrant - https://phabricator.wikimedia.org/T235189 (10Krinkle) [15:16:14] !log deploying AQS [15:16:16] Logged the message at https://www.mediawiki.org/wiki/Analytics/Server_Admin_Log [15:17:05] 10Analytics, 10Better Use Of Data, 10Epic, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), and 3 others: Prototype client to log errors in vagrant - https://phabricator.wikimedia.org/T235189 (10Krinkle) >>! In T235189#5900911, @gerritbot wrote: > Change 573338 **merged** by jenkins-bot: > [mediawiki/extension... [15:18:17] (03PS1) 10Fdans: Update aqs to 5e18813 [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573586 [15:18:42] (03CR) 10Fdans: [V: 03+2 C: 03+2] Update aqs to 5e18813 [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573586 (owner: 10Fdans) [15:19:18] 10Analytics, 10Better Use Of Data, 10Epic, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), and 3 others: Prototype client to log errors in vagrant - https://phabricator.wikimedia.org/T235189 (10Ottomata) AH! Sorry I didn't quite realize I wasn't supposed to merge. We can revert until the dependency is merge... [15:19:36] 10Analytics, 10Better Use Of Data, 10Epic, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), and 3 others: Prototype client to log errors in vagrant - https://phabricator.wikimedia.org/T235189 (10Ottomata) Although, it isn't quite a blocker, is it? The code isn't active unless it is enabled via config. [15:22:33] (03CR) 10Milimetric: "looks good, just one nitpick on param ordering" (032 comments) [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/572746 (owner: 10Joal) [15:25:21] 10Analytics, 10Inuka-Team, 10Product-Analytics: Set up pageview counting for KaiOS app - https://phabricator.wikimedia.org/T244547 (10hueitan) These key is dynamic based on the article language `webHost` - `en.wikipedia.org` `fr.wikipedia.org` `hi.wikipedia.org` `wiki` - `enwiki` `frwiki` `hiwiki` @Nuria... [15:26:53] (03CR) 10Milimetric: [C: 03+2] Use different logic for chart axis number formatting from dashboard [analytics/wikistats2] - 10https://gerrit.wikimedia.org/r/571991 (https://phabricator.wikimedia.org/T242790) (owner: 10Fdans) [15:27:36] (03PS1) 10Fdans: Fix per file mediarequests tests [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573597 [15:28:03] milimetric: hellooo can you quickly take a look at this? I'm deploying aqs [15:28:04] * fdans https://gerrit.wikimedia.org/r/#/c/analytics/aqs/deploy/+/573597/ [15:29:02] (03CR) 10Milimetric: [C: 03+2] "Sweet, at least now the dist output is sane. We'll see if the build time gets annoying as languages get added." [analytics/wikistats2] - 10https://gerrit.wikimedia.org/r/558702 (https://phabricator.wikimedia.org/T240617) (owner: 10Fdans) [15:29:57] fdans: is the idea that /test.jpg would never exist because it'd be /File:Test.jpg? [15:30:04] or /Test.jpg [15:30:08] (03Merged) 10jenkins-bot: Add vue-i18n integration, English strings [analytics/wikistats2] - 10https://gerrit.wikimedia.org/r/558702 (https://phabricator.wikimedia.org/T240617) (owner: 10Fdans) [15:30:27] milimetric: nah it's more like, in the current state of the api we only accept paths with a slash at the beginning [15:30:28] (03CR) 10Milimetric: [C: 03+2] Fix per file mediarequests tests [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573597 (owner: 10Fdans) [15:31:15] fdans: no I know, I mean, the idea that it wouldn't take the place of potentially real data [15:31:22] (03CR) 10Milimetric: [V: 03+2 C: 03+2] Fix per file mediarequests tests [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573597 (owner: 10Fdans) [15:33:08] milimetric: ugh, that didn't do it [15:45:12] (03PS1) 10Fdans: Fix per file mediarequests integration tests [analytics/aqs] - 10https://gerrit.wikimedia.org/r/573599 [15:46:13] milimetric: ^ (sorry) [15:46:59] (03CR) 10Milimetric: [C: 03+2] Fix per file mediarequests integration tests [analytics/aqs] - 10https://gerrit.wikimedia.org/r/573599 (owner: 10Fdans) [15:54:52] (03PS1) 10Fdans: Update aqs to 469f143 [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573603 [15:55:57] (03CR) 10Fdans: [V: 03+2 C: 03+2] Update aqs to 469f143 [analytics/aqs/deploy] - 10https://gerrit.wikimedia.org/r/573603 (owner: 10Fdans) [15:59:23] 10Analytics, 10Better Use Of Data, 10Epic, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), and 3 others: Prototype client to log errors in vagrant - https://phabricator.wikimedia.org/T235189 (10Ottomata) Ah ha, this is the dependency^ let's go! (Trying to get all this merged for next week's train) [16:03:19] PROBLEM - aqs endpoints health on aqs1004 is CRITICAL: /analytics.wikimedia.org/v1/mediarequests/per-file/{referer}/{agent}/{file_path}/{granularity}/{start}/{end} (Get per file requests) is CRITICAL: Test Get per file requests returned the unexpected status 404 (expecting: 200) https://wikitech.wikimedia.org/wiki/Services/Monitoring/aqs [16:05:26] RECOVERY - aqs endpoints health on aqs1004 is OK: All endpoints are healthy https://wikitech.wikimedia.org/wiki/Services/Monitoring/aqs [16:05:48] fdans: all good with aqs? [16:06:31] elukey: I'm struggling with the tests [16:07:51] heya teammm [16:08:36] ottomata, yt? wanna EL client for a bit? [16:12:29] hello! [16:12:35] sure i have a few mins before 1:1 with N [16:14:07] mforns: am in bc [16:23:06] oh ottomata sorry, coming [16:27:26] (03CR) 10Fdans: [C: 03+2] Fix GetGeoDataUDF and underlying function [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/553726 (https://phabricator.wikimedia.org/T238432) (owner: 10Joal) [16:29:58] (03CR) 10Fdans: [V: 03+2 C: 03+2] "super minor change, looks good, merging" [analytics/refinery] - 10https://gerrit.wikimedia.org/r/572840 (https://phabricator.wikimedia.org/T245496) (owner: 10Joal) [16:32:57] (03CR) 10Fdans: [V: 03+2 C: 03+2] "AFAICS all concerns have been addressed, merging" [analytics/refinery] - 10https://gerrit.wikimedia.org/r/569836 (https://phabricator.wikimedia.org/T209655) (owner: 10Joal) [16:33:37] a-team deploying refinery source yall [16:33:47] k [16:37:46] (03PS1) 10Fdans: Bump changelog.md to v0.0.113 [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/573621 [16:38:04] (03CR) 10Fdans: [V: 03+2 C: 03+2] Bump changelog.md to v0.0.113 [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/573621 (owner: 10Fdans) [16:39:51] !log deploying refinery source 0.0.114 [16:39:53] Logged the message at https://www.mediawiki.org/wiki/Analytics/Server_Admin_Log [16:46:03] OH mforns nuria is not working [16:46:04] back to BC [16:47:14] fdans: while catching up with email I saw that wikitext_history and wikitext_current jobs need to be restarted after Jo's patch, but didn't see that in the deployment train [16:47:35] I'll raise it during standup unless everyone's already talked about it [16:50:08] ottomata, omw [16:57:33] !log refinery source jars updated [16:57:34] Logged the message at https://www.mediawiki.org/wiki/Analytics/Server_Admin_Log [17:01:36] milimetric: today's train starts at L23 [17:02:01] Thanks a lot fdans for the merges :) [17:37:29] 10Analytics, 10Release-Engineering-Team-TODO, 10Continuous-Integration-Infrastructure (phase-out-jessie), 10Release-Engineering-Team (CI & Testing services): Migrate analytics/refinery/source release jobs to Docker - https://phabricator.wikimedia.org/T210271 (10Ottomata) a:03JAllemandou [17:41:38] 10Analytics, 10Analytics-SWAP, 10GLOW: Viewing Santali and Javanese characters on SWAP via Chrome only displays Tofu signs - https://phabricator.wikimedia.org/T242490 (10Ottomata) 05Open→03Declined @iflorez this sounds like an issue with your browser and or installed fonts. [17:46:45] 10Analytics, 10Pageviews-API: Pageviews missing for titles with emojis since April 23, 2019 - https://phabricator.wikimedia.org/T245468 (10Ottomata) p:05Triage→03High [17:46:58] 10Analytics, 10Pageviews-API: Pageviews missing for titles with emojis since April 23, 2019 - https://phabricator.wikimedia.org/T245468 (10Ottomata) p:05High→03Triage [17:48:12] 10Analytics, 10Analytics-Kanban, 10Pageviews-API: Pageviews missing for titles with emojis since April 23, 2019 - https://phabricator.wikimedia.org/T245468 (10Ottomata) a:03Nuria Nuria assigning this to you for now since you worked with Adam on this in the past (right?) feel free to re-assign or whatever! [17:48:14] 10Analytics, 10Product-Analytics: Publish data on editors per country for sister projects - https://phabricator.wikimedia.org/T245466 (10Milimetric) 05Open→03Declined We limited the release to Wikipedias because there was a compelling use case. Folks involved with grants and programs needed that data for... [18:17:04] mforns: [18:17:06] while i'm in meetings [18:17:13] to run eg in foreground so you ucan try to figurue out what is going on [18:17:20] cd /vagrant/srv/eventgate-wikimedia [18:17:26] nodejs node_modules/eventgate/server.js -c /vagrant/srv/eventgate-wikimedia/config.vagrant.yaml [18:17:29] aha [18:17:29] i think should work [18:17:38] trying [18:17:53] https://wikitech.wikimedia.org/wiki/Event_Platform/EventGate#Development_in_Mediawiki_Vagrant [18:17:56] maybe cd not needed [18:19:37] it works, but it does not spit logs, do I need a -verbose or sth/ [18:19:39] ? [18:31:18] milimetric: coming to CPT meeting? [18:46:04] * elukey off! [18:46:04] o/ [19:09:29] team, alerts are me restarting jobs [19:14:44] ottomata: aaah, sorry I spaced out giving Ada medicine [19:15:18] :( lemme know if there's anything you wanna brainbounce [19:18:16] joal, if you're still here, what's the parameter value for wikidata_raw_directory in json_entity? [19:18:33] the command in the etherpad doesn't include it [19:18:35] I forgot it ? [19:18:45] joal: https://etherpad.wikimedia.org/p/analytics-weekly-train [19:18:48] you can add it :)\ [19:18:53] It should be in the properties file :( [19:18:56] hm looking [19:19:56] fdans: BUG!! (sorry) [19:20:15] fdans: the value is said to be needed but actually not used - The one used is wikidata_raw_data_directory [19:20:20] Which is defined [19:20:27] fdans: you can define to anything [19:20:35] joal: sounds good [19:20:41] fdans: Will send a patch [19:21:23] joal: job is sent [19:21:29] \o/ !!! [19:21:33] Thanks a lot fdans :) [19:21:48] no problem, good night! [19:26:26] (03PS1) 10Joal: Fix wikidata-json_entity job [analytics/refinery] - 10https://gerrit.wikimedia.org/r/573663 [19:26:51] (03CR) 10Joal: [V: 03+2 C: 03+2] "Self merging bug correction - Fixed in prod" [analytics/refinery] - 10https://gerrit.wikimedia.org/r/573663 (owner: 10Joal) [19:32:47] (03PS2) 10Joal: Bump webrequest load hive jar to 0.0.115 [analytics/refinery] - 10https://gerrit.wikimedia.org/r/572846 (https://phabricator.wikimedia.org/T245453) [19:33:47] (03PS3) 10Joal: Bump webrequest load hive jar to 0.0.115 [analytics/refinery] - 10https://gerrit.wikimedia.org/r/572846 (https://phabricator.wikimedia.org/T245453) [19:35:10] (03PS7) 10Joal: Add wikidata item_page_link oozie job [analytics/refinery] - 10https://gerrit.wikimedia.org/r/572834 (https://phabricator.wikimedia.org/T244707) [19:36:07] (03PS2) 10Joal: Fix webrequest host normalization [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/572726 (https://phabricator.wikimedia.org/T245453) [19:36:10] mforns: how goes?! [19:36:13] i can help again now [19:36:32] ottomata, ok I'managed to print stuff but not sure what's hap[pening anyway... [19:36:43] mforns: push your patch so I can try too [19:36:47] (03PS6) 10Joal: Add wikidata item_page_link spark job [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/572746 [19:36:51] ok [19:37:00] one min I need to fix a git mess [19:37:12] Ok all stuff rebased after deploy - gone for tonight tema [19:37:22] I'm on top of previous patch, but should be standalone [19:37:30] bye joaaaal [19:37:46] I'll double check later tonight that jobs look ok :) [19:39:18] hm mforns need linke [19:39:25] laterds joal! [19:39:42] one sec ottomata [19:39:46] oh ok [19:54:17] almost done [20:01:27] ottomata, https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventLogging/+/573677/ [20:03:28] k [20:06:00] mforns: can you paste me the dev console snippet you are running to produce the event? [20:06:09] sure! [20:06:18] var cli = new mw.eventClient({'EventClientTest': {}}); [20:06:18] cli.produce('EventClientTest', {'$schema': 'TestSchema', 'field': 'value'}); [20:06:58] also how do you load it via RL? [20:07:01] we need to figure that out too [20:07:18] it's loaded already [20:07:20] oh it is loadec? [20:07:20] oh [20:07:24] we juust getajust saw warnings? [20:07:26] I found it [20:07:27] on .configure doesn't exist [20:07:34] ? [20:08:03] I don't see warnings? [20:08:27] bc? [20:08:44] hm i got it mforns [20:08:45] with [20:08:46] cli.produce('EventClientTest', {'$schema': 'test/event/1.0.0'}); [20:08:55] your $schema value was wrong, but that isn't the same [20:08:58] it actually worked for me [20:09:01] i got the event produced via eventgate [20:10:00] !!!! [20:10:22] with the text/plain blob? [20:10:49] i didn't change anything in your code [20:10:53] i just ran that in the console [20:11:12] hm i'm in brave [20:11:16] oh [20:11:17] what browser are you in? [20:11:19] chrome [20:11:25] hm brave is chromium [20:11:27] will try chrome directly [20:11:31] k [20:12:20] yup works for me [20:12:22] just fine [20:12:24] :C [20:12:31] good news your code works! [20:12:33] and you couldn't even test it! [20:12:34] :D [20:14:30] I guess you could try navigator.sendBeacon( moduleConfig.EventLoggingServiceUrl, eventData ); instead of the whole blob thing [20:14:33] ottomata, ^ [20:14:54] the prior code did not do the JSON.stringify! [20:15:13] so I guess it should work like that, given that the default content-type is text [20:15:18] mforns: ? [20:15:24] yes? [20:17:34] oh didn't understand what your last messages meant [20:17:35] also, hm [20:17:46] i'm not sure how we can get away without a global config object after all [20:17:54] we need to be able to configure streams from a RL hook [20:18:05] i guess the hook could do the instantiation of EventClient [20:18:25] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/573677/1/includes/EventLoggingHooks.php#155 [20:18:40] this RL PHP hook generates a JS snippet that is executed at page load tiem [20:18:43] time* [20:19:07] ottomata, I got it to work from firefox! but I don't know why it doesn't from chrome :[ [20:19:12] great! [20:19:42] ottomata, there's a RL hook in the change, I left it there as it was in previous patch [20:19:49] yes but [20:19:50] it calls [20:19:53] mw.eventClient.configure [20:19:55] I haven't yet tried to understand it though [20:20:03] heheh [20:20:18] ok, it should call the constructor instead no? [20:20:22] yeah this took me forever reading RL docs and code to understand how timo was telling me to do this [20:20:25] welll.... [20:20:27] should it? [20:20:30] no [20:20:31] because [20:20:41] multiple instrumentation codes might register the hook [20:20:47] yea right, maybe not [20:20:51] it will be called multiple times [20:21:00] so, just store the streamConfig somewhere public? [20:21:12] i think so, as a propertly of eventCLient I guess [20:21:17] btw....we should probably pick a better name [20:21:20] maybe eventProducer? [20:21:30] sure! [20:21:34] eventSender? [20:21:39] heheh [20:22:00] i guess, if EventClient had a singleton [20:22:05] or factory [20:22:11] if the final action method is called produce, then calling it EventSender is weird no? [20:22:13] this hook could just use it and add configuration by default [20:22:25] but the class would need a configure or addStreamConfig funciton [20:22:26] well, we have client.js [20:22:35] ya let's change that too, to producer.js [20:22:44] that can be the singleton [20:22:48] oh [20:22:50] lookingh [20:23:18] hm it'd have to do mw.eventProducer = new EventProducer, right? [20:23:24] not require the module as it? [20:23:46] mmmm [20:24:04] wait, but why do we need an instance of the client [20:24:05] ? [20:24:16] the hook just needs to be able to call configure() multiple times [20:24:16] I thought that would be created by the instrumentation no? [20:24:18] to add stream config [20:24:31] oh... [20:24:46] that is interesting [20:25:06] we didn't discuss that the day before yesterday... [20:25:22] yeah i forgot about that [20:25:22] so [20:25:33] each instrumentation...let's say extension for now [20:25:35] each extension [20:25:35] this goes against the constructor style [20:26:14] can register the streams it will use in its extension.js or in mediawiki-config [20:26:19] aha [20:26:31] each extension also registers the EL registerStreamConfigs hook [20:26:34] to be called [20:26:36] but can't each extension create a new instance of EventProducer? [20:27:01] with their own set of streamConfigs [20:27:19] each could, but that would be a lot more code on their part, the streamConfig needs to be delievered as part of ResourceLoader at page load time [20:27:34] and we wanted a way for users to do that without havinig to write their own RL hooks [20:27:45] understanding the RL hook part + JS code snippet generation isn't that easy [20:27:52] aha [20:27:54] so, the hook is in EL extension [20:27:58] and other extensions can choose to use it [20:28:10] and the hook loads ALL streams? [20:28:32] remember when we edited WikimediaEvents extensions.js? [20:28:37] aha [20:28:53] "callback": "EventLoggingHooks::registerStreamConfigs", [20:28:53] "callbackParam": ["test.event", "mediawiki.virtual_page_edit", "mediawiki.virtual_page_view", "mediawiki.job.ottoA"] [20:29:12] so maybe [20:29:12] EventLoggingHooks::registerStreamConfigs [20:29:23] insetad of just calling configure on a global object [20:29:24] MAYBE [20:29:26] it could return a client [20:29:32] ? I'm lost [20:29:38] heheh, bc? [20:29:46] would it be OK to bc? [20:30:26] mforns: in bc [20:30:41] omw [22:00:57] (03PS2) 10Ottomata: Refine - Warn when merging incompatible types; FAILFAST when reading JSON data with a schema [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/571365 (https://phabricator.wikimedia.org/T244771) [22:01:19] (03CR) 10Ottomata: "Joal, this is ready for review! :)" [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/571365 (https://phabricator.wikimedia.org/T244771) (owner: 10Ottomata) [22:03:35] (03PS3) 10Ottomata: Refine - Warn when merging incompatible types; FAILFAST when reading JSON data with a schema [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/571365 (https://phabricator.wikimedia.org/T244771) [22:06:30] (03PS4) 10Ottomata: Refine - Warn when merging incompatible types; FAILFAST when reading JSON data with a schema [analytics/refinery/source] - 10https://gerrit.wikimedia.org/r/571365 (https://phabricator.wikimedia.org/T244771)