[00:15:48] (03CR) 10Mattflaschen: "Same in Flow. It would have been helpful to grep through for wgResourceModules in hooks files, and notify teams." [core] - 10https://gerrit.wikimedia.org/r/218769 (owner: 10Krinkle) [02:36:06] (03CR) 10Nikerabbit: Make MessageCache handle lock timeouts better (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) (owner: 10Aaron Schulz) [03:41:04] (03PS3) 10Aaron Schulz: Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) [04:20:08] (03CR) 10PleaseStand: "Here's one diff affected by the bug that is fixed by this change: https://wikitech.wikimedia.org/w/index.php?title=Server_Admin_Log&diff=4" [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [05:16:07] (03CR) 10Nikerabbit: "The commit message does not tell me anything about the change." [core] - 10https://gerrit.wikimedia.org/r/284239 (owner: 10Florianschmidtwelzow) [05:20:14] (03CR) 10Nikerabbit: [C: 04-1] "Does not support digitGroupingPattern?" [core] - 10https://gerrit.wikimedia.org/r/281198 (https://phabricator.wikimedia.org/T123999) (owner: 10Catrope) [05:21:28] (03CR) 10Nikerabbit: Simplify autocomplete attribute in HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [05:23:00] (03CR) 10Krinkle: Follow up I2480149 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284239 (owner: 10Florianschmidtwelzow) [05:23:27] (03CR) 10Nikerabbit: [C: 032] Remove unused wfGetDB() in SiteStats::jobs [core] - 10https://gerrit.wikimedia.org/r/284214 (owner: 10Addshore) [05:31:50] (03Merged) 10jenkins-bot: Remove unused wfGetDB() in SiteStats::jobs [core] - 10https://gerrit.wikimedia.org/r/284214 (owner: 10Addshore) [05:36:09] (03CR) 10Fomafix: Simplify autocomplete attribute in HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [05:39:11] (03PS3) 10Gerrit Patch Uploader: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 [05:39:14] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [06:51:01] (03CR) 10Catrope: "Why is digitGroupingPattern relevant? The functions I'm overriding don't do anything with digitGroupingPattern as far as I can tell..." [core] - 10https://gerrit.wikimedia.org/r/281198 (https://phabricator.wikimedia.org/T123999) (owner: 10Catrope) [07:01:11] (03CR) 10Nikerabbit: "Ok I was confused about the scope of the patch." [core] - 10https://gerrit.wikimedia.org/r/281198 (https://phabricator.wikimedia.org/T123999) (owner: 10Catrope) [08:07:39] (03PS10) 10WMDE-leszek: [DNM]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) [08:08:57] (03CR) 10WMDE-leszek: [C: 04-1] "PS10 is a rebase. The actual work on this patch will follow in the next patch sets" [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) (owner: 10WMDE-leszek) [08:10:19] (03CR) 10jenkins-bot: [V: 04-1] [DNM]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) (owner: 10WMDE-leszek) [08:17:52] (03CR) 10Addshore: [C: 032] Add LinkTarget::hasFragment() helper function [core] - 10https://gerrit.wikimedia.org/r/284415 (owner: 10Legoktm) [08:18:42] (03CR) 10Addshore: [C: 031] Add LinkTarget::createFragmentTarget() function [core] - 10https://gerrit.wikimedia.org/r/284416 (owner: 10Legoktm) [08:29:51] (03Merged) 10jenkins-bot: Add LinkTarget::hasFragment() helper function [core] - 10https://gerrit.wikimedia.org/r/284415 (owner: 10Legoktm) [10:08:54] (03PS2) 10Condorcent: Add hideredirect, onlynew, onlypatrolled API param [core] - 10https://gerrit.wikimedia.org/r/284386 (https://phabricator.wikimedia.org/T132840) [10:09:25] (03CR) 10jenkins-bot: [V: 04-1] Add hideredirect, onlynew, onlypatrolled API param [core] - 10https://gerrit.wikimedia.org/r/284386 (https://phabricator.wikimedia.org/T132840) (owner: 10Condorcent) [10:17:22] (03CR) 10Gergő Tisza: [C: 032] SessionManager: Ignore Session object destruction during global shutdown [core] - 10https://gerrit.wikimedia.org/r/284480 (owner: 10Anomie) [10:25:46] (03Merged) 10jenkins-bot: SessionManager: Ignore Session object destruction during global shutdown [core] - 10https://gerrit.wikimedia.org/r/284480 (owner: 10Anomie) [10:32:57] (03CR) 10Gergő Tisza: "We discussed this at the Reading Infrastructure meeting and decided to merge this right after the release branch cut and issue a warning. " [core] - 10https://gerrit.wikimedia.org/r/273373 (https://phabricator.wikimedia.org/T127233) (owner: 10Anomie) [10:55:43] (03PS4) 10Aaron Schulz: Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) [10:57:09] (03PS5) 10Aaron Schulz: Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) [11:03:49] (03CR) 10Addshore: Add missing tests for some edge cases in WatchedItem::getNotificationTimestamp (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284436 (owner: 10WMDE-leszek) [11:12:39] (03CR) 10Addshore: Assert jobs called from WIS::resetNotificationTimestamp are correct (032 comments) [core] - 10https://gerrit.wikimedia.org/r/284461 (owner: 10WMDE-leszek) [12:50:40] (03PS1) 10Addshore: WIP watchlist_props table [core] - 10https://gerrit.wikimedia.org/r/284690 (https://bugzilla.wikimedia.org/129486) [12:56:06] (03CR) 10jenkins-bot: [V: 04-1] WIP watchlist_props table [core] - 10https://gerrit.wikimedia.org/r/284690 (https://bugzilla.wikimedia.org/129486) (owner: 10Addshore) [13:09:41] (03PS2) 10Nemo bis: WIP watchlist_props table [core] - 10https://gerrit.wikimedia.org/r/284690 (https://phabricator.wikimedia.org/T129486) (owner: 10Addshore) [13:14:50] (03CR) 10jenkins-bot: [V: 04-1] WIP watchlist_props table [core] - 10https://gerrit.wikimedia.org/r/284690 (https://phabricator.wikimedia.org/T129486) (owner: 10Addshore) [13:17:56] (03CR) 10Ori.livneh: [C: 032] Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) (owner: 10Aaron Schulz) [13:18:32] (03PS6) 10Ori.livneh: Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) (owner: 10Aaron Schulz) [13:18:40] (03CR) 10Ori.livneh: [V: 032] Make MessageCache handle lock timeouts better [core] - 10https://gerrit.wikimedia.org/r/284512 (https://phabricator.wikimedia.org/T133069) (owner: 10Aaron Schulz) [13:18:53] (03PS1) 10Ori.livneh: Make MessageCache handle lock timeouts better [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284696 (https://phabricator.wikimedia.org/T133069) [13:19:39] (03CR) 10Ori.livneh: [C: 032 V: 032] Make MessageCache handle lock timeouts better [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284696 (https://phabricator.wikimedia.org/T133069) (owner: 10Ori.livneh) [13:35:16] (03PS11) 10WMDE-leszek: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) [13:37:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) (owner: 10WMDE-leszek) [13:39:12] (03CR) 10WMDE-leszek: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw (038 comments) [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) (owner: 10WMDE-leszek) [13:43:20] (03CR) 10WMDE-leszek: "PS11 includes changes suggested in comments on PS9 plus several other rather minor improvements." [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T129482) (owner: 10WMDE-leszek) [13:45:43] (03PS12) 10WMDE-leszek: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) [13:46:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [13:48:37] (03CR) 10Daniel Kinzler: [C: 04-1] Add LinkTarget::createFragmentTarget() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284416 (owner: 10Legoktm) [13:50:13] (03CR) 10Daniel Kinzler: [C: 032] Have Linker::linkUrl() accept LinkTarget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284417 (owner: 10Legoktm) [13:54:28] (03CR) 10Daniel Kinzler: [C: 032] Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [13:56:11] (03CR) 10Daniel Kinzler: [C: 031] "The schema change I see in tables.sql is what we want. Haven't looked at the other code." [core] - 10https://gerrit.wikimedia.org/r/271502 (https://phabricator.wikimedia.org/T125991) (owner: 10Addshore) [13:56:57] (03PS2) 10WMDE-leszek: Add missing tests for some edge cases in WatchedItem::getNotificationTimestamp [core] - 10https://gerrit.wikimedia.org/r/284436 [13:57:15] (03CR) 10Addshore: Have Linker::linkUrl() accept LinkTarget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284417 (owner: 10Legoktm) [14:03:48] (03Merged) 10jenkins-bot: Add getStatsdDataFactory to MediawikiServices [core] - 10https://gerrit.wikimedia.org/r/282740 (owner: 10Addshore) [14:05:23] (03CR) 10WMDE-leszek: Add missing tests for some edge cases in WatchedItem::getNotificationTimestamp (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284436 (owner: 10WMDE-leszek) [14:24:20] (03PS3) 10WMDE-leszek: [WIP]Refactor database-related code in ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) [14:24:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Refactor database-related code in ApiQueryWatchlist [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) (owner: 10WMDE-leszek) [14:27:00] (03CR) 10WMDE-leszek: [WIP]Refactor database-related code in ApiQueryWatchlist (033 comments) [core] - 10https://gerrit.wikimedia.org/r/284169 (https://phabricator.wikimedia.org/T132565) (owner: 10WMDE-leszek) [14:33:50] (03PS13) 10WMDE-leszek: [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) [14:34:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Use WatchedItemStore::getWatchedItemsForUser in ApiQueryWatchlistRaw [core] - 10https://gerrit.wikimedia.org/r/278859 (https://phabricator.wikimedia.org/T132566) (owner: 10WMDE-leszek) [15:29:15] (03CR) 10Aaron Schulz: [C: 032] Catch JobQueue errors in SiteStats::jobs [core] - 10https://gerrit.wikimedia.org/r/284434 (https://phabricator.wikimedia.org/T133045) (owner: 10Addshore) [15:37:34] (03PS1) 10Bartosz Dziewoński: mediawiki.api.upload: Unbreak finishing stash uploads [core] - 10https://gerrit.wikimedia.org/r/284710 (https://phabricator.wikimedia.org/T133295) [15:39:05] (03CR) 10MarkTraceur: [C: 032] "D'oh" [core] - 10https://gerrit.wikimedia.org/r/284710 (https://phabricator.wikimedia.org/T133295) (owner: 10Bartosz Dziewoński) [15:39:11] (03Merged) 10jenkins-bot: Catch JobQueue errors in SiteStats::jobs [core] - 10https://gerrit.wikimedia.org/r/284434 (https://phabricator.wikimedia.org/T133045) (owner: 10Addshore) [15:49:21] (03Merged) 10jenkins-bot: mediawiki.api.upload: Unbreak finishing stash uploads [core] - 10https://gerrit.wikimedia.org/r/284710 (https://phabricator.wikimedia.org/T133295) (owner: 10Bartosz Dziewoński) [15:52:52] (03PS1) 10MarkTraceur: mediawiki.api.upload: Unbreak finishing stash uploads [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284715 (https://phabricator.wikimedia.org/T133295) [15:57:33] (03CR) 10MarkTraceur: [C: 032] mediawiki.api.upload: Unbreak finishing stash uploads [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284715 (https://phabricator.wikimedia.org/T133295) (owner: 10MarkTraceur) [16:05:51] (03Merged) 10jenkins-bot: mediawiki.api.upload: Unbreak finishing stash uploads [core] (wmf/1.27.0-wmf.21) - 10https://gerrit.wikimedia.org/r/284715 (https://phabricator.wikimedia.org/T133295) (owner: 10MarkTraceur) [16:34:20] (03PS2) 10Aaron Schulz: Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) [16:34:31] (03PS2) 10Aaron Schulz: Remove unused JobQueueRedis vars [core] - 10https://gerrit.wikimedia.org/r/284254 [16:39:01] (03CR) 10jenkins-bot: [V: 04-1] Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) (owner: 10Aaron Schulz) [17:19:51] (03CR) 10Legoktm: Have Linker::linkUrl() accept LinkTarget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284417 (owner: 10Legoktm) [17:20:51] (03CR) 10Legoktm: Add LinkTarget::createFragmentTarget() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284416 (owner: 10Legoktm) [17:37:53] (03PS1) 10Jforrester: OOjs UI: Correct display of MenuToolGroup checkmarks [core] - 10https://gerrit.wikimedia.org/r/284733 (https://phabricator.wikimedia.org/T133227) [17:40:44] (03CR) 10MaxSem: "Diffs on wikitech are produced with wikidiff2. Are you saying it's also affected?" [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [17:51:39] (03CR) 10Bartosz Dziewoński: [C: 032] OOjs UI: Correct display of MenuToolGroup checkmarks [core] - 10https://gerrit.wikimedia.org/r/284733 (https://phabricator.wikimedia.org/T133227) (owner: 10Jforrester) [18:03:09] (03Merged) 10jenkins-bot: OOjs UI: Correct display of MenuToolGroup checkmarks [core] - 10https://gerrit.wikimedia.org/r/284733 (https://phabricator.wikimedia.org/T133227) (owner: 10Jforrester) [18:24:04] (03CR) 10John Vandenberg: [C: 04-1] "jQuery is the version selected and managed in the MediaWiki source, and isnt software that is installed on the server, so it doesnt fit in" [core] - 10https://gerrit.wikimedia.org/r/275160 (https://phabricator.wikimedia.org/T34892) (owner: 10Harjotsingh) [18:50:23] (03PS1) 10Urbanecm: Set an alias for TrackingCategories page in Czech [core] - 10https://gerrit.wikimedia.org/r/284737 [19:12:21] (03CR) 10Krinkle: "Also attach T121646." [core] - 10https://gerrit.wikimedia.org/r/256115 (owner: 10Ori.livneh) [19:12:51] (03PS3) 10Aaron Schulz: Avoid lock error exceptions during upgradeRow() contention [core] - 10https://gerrit.wikimedia.org/r/284213 (https://phabricator.wikimedia.org/T132921) [19:14:09] (03CR) 10Krinkle: "Add release notes?" [core] - 10https://gerrit.wikimedia.org/r/281253 (https://phabricator.wikimedia.org/T123156) (owner: 10coren) [19:27:43] (03PS2) 10Aaron Schulz: Remove DELETE_SOURCE flag from FileRepo store()/storeBatch() [core] - 10https://gerrit.wikimedia.org/r/275059 [19:41:38] (03CR) 10Matěj Suchánek: Set an alias for TrackingCategories page in Czech (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284737 (owner: 10Urbanecm) [19:43:44] (03CR) 10PleaseStand: "> Diffs on wikitech are produced with wikidiff2. Are you saying it's also affected?" [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [19:46:39] (03CR) 10MaxSem: "Then wikitech must be misconfigured." [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [20:06:18] (03CR) 10Daniel Kinzler: Add LinkTarget::createFragmentTarget() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284416 (owner: 10Legoktm) [20:06:56] (03PS10) 10Smalyshev: [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [20:07:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:09:27] (03PS11) 10Smalyshev: [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [20:12:35] (03PS3) 10Legoktm: Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 [20:12:38] (03PS4) 10Legoktm: Namespace LinkTarget under MediaWiki\Linker [core] - 10https://gerrit.wikimedia.org/r/284420 [20:12:41] (03PS4) 10Legoktm: Have Linker::linkUrl() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/284417 [20:12:44] (03PS4) 10Legoktm: Add LinkTarget::createFragmentTarget() function [core] - 10https://gerrit.wikimedia.org/r/284416 [20:12:47] (03CR) 10Smalyshev: [WIP] Convert SearchEngine to service containers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:12:57] (03CR) 10Legoktm: Add LinkTarget::createFragmentTarget() function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284416 (owner: 10Legoktm) [20:14:21] (03PS1) 10Legoktm: [WIP] Add HtmlPageLinkRenderer (rewrite of Linker::link()) [core] - 10https://gerrit.wikimedia.org/r/284750 [20:15:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:16:51] (03PS12) 10Smalyshev: [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [20:19:42] (03PS13) 10Smalyshev: [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [20:24:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:28:00] (03PS14) 10Smalyshev: [WIP] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 [20:38:48] (03CR) 10Smalyshev: [WIP] Convert SearchEngine to service containers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:46:59] (03PS2) 10MaxSem: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) [21:13:08] (03CR) 10Krinkle: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:15:57] (03CR) 10Legoktm: [C: 032] Improve getErrorsByType() docs [core] - 10https://gerrit.wikimedia.org/r/283990 (owner: 10Aaron Schulz) [21:25:43] (03Merged) 10jenkins-bot: Improve getErrorsByType() docs [core] - 10https://gerrit.wikimedia.org/r/283990 (owner: 10Aaron Schulz) [21:26:19] (03PS3) 10MaxSem: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) [21:27:58] (03CR) 10MaxSem: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:28:05] (03CR) 10MaxSem: [C: 032] TableDiffFormatter: Don't repeatedly call array_shift() [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [21:37:44] (03Merged) 10jenkins-bot: TableDiffFormatter: Don't repeatedly call array_shift() [core] - 10https://gerrit.wikimedia.org/r/266959 (owner: 10PleaseStand) [21:44:29] (03CR) 10Jforrester: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:46:08] (03CR) 10MaxSem: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:51:07] (03CR) 10Jforrester: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:54:52] (03CR) 10MaxSem: Make wikidiff3 the only diff engine (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:57:43] (03PS1) 10Physikerwelt: Print context information for LegacyLogger [core] - 10https://gerrit.wikimedia.org/r/284819 [22:00:21] (03CR) 10Physikerwelt: "I'm not too sure, we want to do this by default, but it helped me to solve my problem." [core] - 10https://gerrit.wikimedia.org/r/284819 (owner: 10Physikerwelt) [22:01:15] (03CR) 10Physikerwelt: "I'm not too sure, if we want to do this by default. However, it helped me to solve my problem." [core] - 10https://gerrit.wikimedia.org/r/284819 (owner: 10Physikerwelt) [22:15:08] (03CR) 10Jforrester: [C: 031] "Product sign-off." [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [22:18:30] (03PS7) 10Krinkle: BagOStuff: Optionally log duplicate key lookups [core] - 10https://gerrit.wikimedia.org/r/274333 (https://phabricator.wikimedia.org/T128125) (owner: 10BryanDavis) [22:42:51] (03PS15) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:42:54] (03PS75) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [22:42:57] (03PS33) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:44:39] (03CR) 10Gergő Tisza: "PS75: fix Special:ChangePassword for $wgDisableAuthManager = true, hide new special pages when $wgDisableAuthManager = true" [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [22:45:52] (03CR) 10jenkins-bot: [V: 04-1] AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [22:46:19] (03CR) 10jenkins-bot: [V: 04-1] Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [22:46:33] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [22:47:27] (03PS8) 10VolkerE: Align to CSS coding guidelines and fix CSSLint errors & warnings [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) [22:48:35] (03CR) 10VolkerE: "PS 8 was manual rebase locally after Gerrit didn't like it before." [core] - 10https://gerrit.wikimedia.org/r/256619 (https://phabricator.wikimedia.org/T120154) (owner: 10VolkerE) [22:58:31] (03PS8) 10Krinkle: BagOStuff: Optionally log duplicate key lookups [core] - 10https://gerrit.wikimedia.org/r/274333 (https://phabricator.wikimedia.org/T128125) (owner: 10BryanDavis) [22:58:48] (03CR) 10Krinkle: BagOStuff: Optionally log duplicate key lookups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/274333 (https://phabricator.wikimedia.org/T128125) (owner: 10BryanDavis) [23:14:27] (03CR) 10BryanDavis: [C: 031] "Generally looking good to me. A note inline about one small optimization that could be made. Timo should also at least take co-author cred" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/274333 (https://phabricator.wikimedia.org/T128125) (owner: 10BryanDavis)