[02:49:07] (03CR) 10Aaron Schulz: [C: 032] Convert array() => [] in some comments [core] - 10https://gerrit.wikimedia.org/r/284979 (owner: 10Aaron Schulz) [02:56:56] (03Merged) 10jenkins-bot: Convert array() => [] in some comments [core] - 10https://gerrit.wikimedia.org/r/284979 (owner: 10Aaron Schulz) [03:05:08] (03CR) 10Legoktm: [C: 032] Add @since docs to SpecialPage::getTitleFor [core] - 10https://gerrit.wikimedia.org/r/285172 (owner: 10Addshore) [03:06:20] (03CR) 10Legoktm: [C: 032] Update hard refresh instructions for Opera [core] - 10https://gerrit.wikimedia.org/r/284998 (owner: 10Amire80) [03:06:36] (03CR) 10Legoktm: [C: 032] cleanUp all invalid utf8 in sql for debug toolbar [core] - 10https://gerrit.wikimedia.org/r/284938 (owner: 10Umherirrender) [03:14:08] (03Merged) 10jenkins-bot: Add @since docs to SpecialPage::getTitleFor [core] - 10https://gerrit.wikimedia.org/r/285172 (owner: 10Addshore) [03:14:12] (03Merged) 10jenkins-bot: Update hard refresh instructions for Opera [core] - 10https://gerrit.wikimedia.org/r/284998 (owner: 10Amire80) [03:22:42] (03Merged) 10jenkins-bot: cleanUp all invalid utf8 in sql for debug toolbar [core] - 10https://gerrit.wikimedia.org/r/284938 (owner: 10Umherirrender) [06:40:23] (03PS1) 10Tim Starling: In ParserCache, respect $useOutdated [core] - 10https://gerrit.wikimedia.org/r/285337 [06:41:45] (03CR) 10Tim Starling: [C: 04-1] "Untested" [core] - 10https://gerrit.wikimedia.org/r/285337 (owner: 10Tim Starling) [08:18:47] (03CR) 10jenkins-bot: [V: 04-1] In ParserCache, respect $useOutdated [core] - 10https://gerrit.wikimedia.org/r/285337 (owner: 10Tim Starling) [09:41:39] (03PS2) 10Tim Starling: In ParserCache, respect $useOutdated [core] - 10https://gerrit.wikimedia.org/r/285337 (https://phabricator.wikimedia.org/T133659) [12:48:53] (03PS4) 10Addshore: Add getSkinFactory to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284165 [12:49:19] (03PS1) 10Addshore: Add missing include in MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285385 [13:15:41] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/285389 [13:16:04] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) [13:19:43] (03CR) 10Addshore: [C: 04-1] "Also now needs another manual rebase!" [core] - 10https://gerrit.wikimedia.org/r/283462 (owner: 10Daniel Kinzler) [13:22:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [13:23:25] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) [13:25:14] (03CR) 10Hashar: "check zend" [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [13:40:59] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [13:41:36] (03CR) 10Hashar: "wrong branch" [core] - 10https://gerrit.wikimedia.org/r/285389 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [13:43:07] (03CR) 10Anomie: "At a glance, this doesn't look like it will regress T48014. Code paths that ask for outdated revisions should be smart enough to check if " [core] - 10https://gerrit.wikimedia.org/r/285337 (https://phabricator.wikimedia.org/T133659) (owner: 10Tim Starling) [13:43:10] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285396 (https://phabricator.wikimedia.org/T131556) [13:43:24] (03CR) 10Hashar: "check zend" [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285396 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [13:49:48] (03CR) 10Esanders: "Code seems fine. Obviously this is a key piece of architecture that will be hard to make non-breaking changes to later so CCing a few more" [core] - 10https://gerrit.wikimedia.org/r/260950 (https://phabricator.wikimedia.org/T114007) (owner: 10Jdlrobson) [13:59:46] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285396 (https://phabricator.wikimedia.org/T131556) (owner: 10Hashar) [14:05:56] (03CR) 10WMDE-Fisch: [C: 031] Remove un-needed cast for array key in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/279332 (owner: 10Addshore) [14:27:31] (03CR) 10Anomie: [C: 032] Handle null data return in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/285013 (https://phabricator.wikimedia.org/T133163) (owner: 10Gergő Tisza) [14:37:21] (03Merged) 10jenkins-bot: Handle null data return in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/285013 (https://phabricator.wikimedia.org/T133163) (owner: 10Gergő Tisza) [14:50:55] (03CR) 10WMDE-leszek: [C: 031] Remove un-needed cast for array key in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/279332 (owner: 10Addshore) [14:52:30] (03PS84) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [14:53:47] (03CR) 10Gergő Tisza: "PS 84: add blacklists to disallow some authentication types for Special:Change/RemoveCredentials" [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [14:54:01] (03PS43) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [14:56:39] (03PS1) 10Matthias Mullie: Fall back to API error msg when msg params are needed [core] - 10https://gerrit.wikimedia.org/r/285401 (https://phabricator.wikimedia.org/T115946) [15:03:34] (03CR) 10jenkins-bot: [V: 04-1] Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [15:04:43] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:08:48] (03PS1) 10Hashar: $wgVersion = '1.27.0-wmf.22' [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285407 [15:11:30] (03CR) 10Anomie: Use AuthManager on special pages (035 comments) [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [15:13:00] (03CR) 10Chad: [C: 032 V: 032] $wgVersion = '1.27.0-wmf.22' [core] (wmf/1.27.0-wmf.22) - 10https://gerrit.wikimedia.org/r/285407 (owner: 10Hashar) [15:13:29] (03CR) 10Anomie: "You appear to have accidentally reverted PS37." [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:17:09] (03PS44) 10Anomie: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) [15:18:09] (03PS22) 10Anomie: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 [15:23:12] (03PS28) 10Anomie: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [15:28:09] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:29:27] (03CR) 10jenkins-bot: [V: 04-1] Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [15:41:28] (03PS45) 10Anomie: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) [15:48:23] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - 10https://gerrit.wikimedia.org/r/285415 [15:48:37] (03CR) 10jenkins-bot: [V: 04-1] API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [15:48:46] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_25) - 10https://gerrit.wikimedia.org/r/285415 (owner: 10Ejegg) [16:17:12] (03PS85) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [16:19:33] (03CR) 10Gergő Tisza: "Fixed per comments." [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [16:19:57] (03PS46) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:24:58] (03CR) 10Gergő Tisza: "Sorry. I tried to be clever with git stash & checkout and ended up doing something different than I wanted to. I tried to clean it up but " [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:50:04] (03PS86) 10Gergő Tisza: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) [16:50:36] (03CR) 10Gergő Tisza: "PS 86: ignore user input on RemoveCredentials" [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [16:50:55] (03PS47) 10Gergő Tisza: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) (owner: 10Anomie) [16:51:15] (03PS23) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [16:51:28] (03PS1) 10Alex Monk: Allow specifying OutputPage object in Skin::subPageSubtitle parameters [core] - 10https://gerrit.wikimedia.org/r/285428 (https://phabricator.wikimedia.org/T97700) [16:56:39] (03PS24) 10Gergő Tisza: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [16:57:40] (03CR) 10Gergő Tisza: "PS 24: mention $wg[Change|Remove]CredentialsBlacklist" [core] - 10https://gerrit.wikimedia.org/r/282202 (owner: 10Anomie) [16:57:51] (03PS29) 10Gergő Tisza: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 [17:06:51] (03Abandoned) 10Brian Wolff: Make old parserTests.php work again. [core] - 10https://gerrit.wikimedia.org/r/277187 (owner: 10Brian Wolff) [17:07:34] (03PS2) 10Brian Wolff: Add -f as an alias of --force to cli args of updateCollation.php [core] - 10https://gerrit.wikimedia.org/r/272617 [17:13:53] (03CR) 10Bartosz Dziewoński: [C: 032] Add -f as an alias of --force to cli args of updateCollation.php [core] - 10https://gerrit.wikimedia.org/r/272617 (owner: 10Brian Wolff) [17:23:50] (03Merged) 10jenkins-bot: Add -f as an alias of --force to cli args of updateCollation.php [core] - 10https://gerrit.wikimedia.org/r/272617 (owner: 10Brian Wolff) [17:26:25] (03CR) 10Jforrester: [C: 031] Allow specifying OutputPage object in Skin::subPageSubtitle parameters [core] - 10https://gerrit.wikimedia.org/r/285428 (https://phabricator.wikimedia.org/T97700) (owner: 10Alex Monk) [17:37:46] (03CR) 10Smalyshev: Convert SearchEngine to service containers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [17:51:55] (03PS3) 10Brian Wolff: Require strip marker names to not have & ' " < or > in them [core] - 10https://gerrit.wikimedia.org/r/267224 [17:53:16] (03PS3) 10Brian Wolff: Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 [17:58:19] (03CR) 10jenkins-bot: [V: 04-1] Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 (owner: 10Brian Wolff) [18:05:48] (03CR) 10Daniel Kinzler: [C: 032] Make WatchedItemStore use MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/283463 (owner: 10Addshore) [18:07:50] (03CR) 10Daniel Kinzler: [C: 032] Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [18:10:12] (03PS4) 10Brian Wolff: Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 [18:18:52] (03CR) 10jenkins-bot: [V: 04-1] Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 (owner: 10Brian Wolff) [18:19:06] (03Merged) 10jenkins-bot: Convert SearchEngine to service containers [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [18:21:24] (03PS5) 10Brian Wolff: Allow a comma separated list of namespaces for Special:Random [core] - 10https://gerrit.wikimedia.org/r/140931 [18:24:40] (03CR) 10Daniel Kinzler: [C: 04-1] "The direction looks very good!" (037 comments) [core] - 10https://gerrit.wikimedia.org/r/284750 (owner: 10Legoktm) [18:26:43] (03CR) 10Daniel Kinzler: [C: 032] Remove un-needed cast for array key in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/279332 (owner: 10Addshore) [18:29:18] (03CR) 10Daniel Kinzler: [C: 032] Add missing include in MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285385 (owner: 10Addshore) [18:33:44] (03CR) 10Daniel Kinzler: [C: 032] Add getSkinFactory to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284165 (owner: 10Addshore) [18:36:51] (03Merged) 10jenkins-bot: Remove un-needed cast for array key in WatchedItemStore [core] - 10https://gerrit.wikimedia.org/r/279332 (owner: 10Addshore) [18:40:12] (03Merged) 10jenkins-bot: Add missing include in MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285385 (owner: 10Addshore) [18:40:15] (03CR) 10jenkins-bot: [V: 04-1] Add getSkinFactory to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/284165 (owner: 10Addshore) [18:43:31] (03PS134) 10Anomie: Add AuthManager [core] - 10https://gerrit.wikimedia.org/r/195297 (https://phabricator.wikimedia.org/T91699) [18:43:34] (03PS1) 10Anomie: SessionManager: Add provision for encrypting session data [core] - 10https://gerrit.wikimedia.org/r/285438 [18:44:11] (03PS87) 10Anomie: Use AuthManager on special pages [core] - 10https://gerrit.wikimedia.org/r/240052 (https://phabricator.wikimedia.org/T110277) (owner: 10Gergő Tisza) [18:44:33] (03PS48) 10Anomie: API changes for AuthManager [core] - 10https://gerrit.wikimedia.org/r/265201 (https://phabricator.wikimedia.org/T110276) [18:47:23] (03PS25) 10Anomie: AuthManager release notes [core] - 10https://gerrit.wikimedia.org/r/282202 [18:47:28] (03CR) 10Daniel Kinzler: [C: 031] "The code looks trivially fine, and the intention is definitely what we want. But are we sure this doesn't have any averse side effects?" [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [18:48:08] (03PS30) 10Anomie: Remove $wgDisableAuthManager [core] - 10https://gerrit.wikimedia.org/r/280945 (owner: 10Gergő Tisza) [18:48:50] (03CR) 10Alex Monk: [C: 032] i18n: Provide new "publish" strings for extra translator time [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [18:53:39] (03CR) 10Catrope: [C: 032] "Let's find out. The wmf22 cut just happened, so this patch will live on beta labs for a full week before getting deployed to the cluster." [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [19:00:24] (03PS4) 10MaxSem: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) [19:00:27] (03PS1) 10MaxSem: Refactoring [core] - 10https://gerrit.wikimedia.org/r/285443 [19:02:30] (03Merged) 10jenkins-bot: i18n: Provide new "publish" strings for extra translator time [core] - 10https://gerrit.wikimedia.org/r/285238 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [19:05:34] (03PS5) 10Legoktm: Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 [19:05:37] (03PS3) 10Legoktm: [WIP] Add HtmlPageLinkRenderer (rewrite of Linker::link()) [core] - 10https://gerrit.wikimedia.org/r/284750 [19:05:40] (03CR) 10Legoktm: Have Linker::normaliseSpecialPage() accept LinkTarget objects (031 comment) [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [19:08:02] (03CR) 10Addshore: [C: 032] Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [19:09:41] (03Merged) 10jenkins-bot: OutputPage: Use PageViewLanguage instead of PageLanguage for mw.config [core] - 10https://gerrit.wikimedia.org/r/88478 (owner: 10Tpt) [19:10:25] (03CR) 10Addshore: [C: 032] registration: Improve schema validation for some properties [core] - 10https://gerrit.wikimedia.org/r/285306 (owner: 10Legoktm) [19:19:29] (03CR) 10jenkins-bot: [V: 04-1] Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [19:19:58] (03CR) 10Addshore: [C: 032] Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [19:25:01] (03CR) 10Legoktm: [C: 032] Introduce InterwikiTest [core] - 10https://gerrit.wikimedia.org/r/285018 (https://phabricator.wikimedia.org/T113034) (owner: 10Daniel Kinzler) [19:29:11] (03Merged) 10jenkins-bot: registration: Improve schema validation for some properties [core] - 10https://gerrit.wikimedia.org/r/285306 (owner: 10Legoktm) [19:30:42] (03Merged) 10jenkins-bot: Have Linker::normaliseSpecialPage() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/284422 (owner: 10Legoktm) [19:47:27] (03PS1) 10Aaron Schulz: Make refreshLinksJob explicitly check the cache rev ID [core] - 10https://gerrit.wikimedia.org/r/285449 [19:57:46] (03CR) 10Gergő Tisza: SessionManager: Add provision for encrypting session data (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285438 (owner: 10Anomie) [20:07:13] (03CR) 10EBernhardson: "causing blank Special:Search page in beta cluster" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [20:08:48] (03PS1) 10EBernhardson: Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 [20:12:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think this is reasonable. I'd change two things though:" [core] - 10https://gerrit.wikimedia.org/r/251797 (https://phabricator.wikimedia.org/T118097) (owner: 10Florianschmidtwelzow) [20:12:42] (03PS2) 10EBernhardson: Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 [20:13:12] (03CR) 10Smalyshev: [C: 032] Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 (owner: 10EBernhardson) [20:13:36] (03PS2) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 [20:13:39] (03PS5) 10MaxSem: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) [20:17:53] (03CR) 10jenkins-bot: [V: 04-1] Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 (owner: 10EBernhardson) [20:23:58] (03PS3) 10EBernhardson: Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 [20:32:33] (03CR) 10Smalyshev: [C: 032] Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 (owner: 10EBernhardson) [20:39:09] (03CR) 10Legoktm: [C: 032] Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [20:44:50] (03Merged) 10jenkins-bot: Fix fatal on Special:Search [core] - 10https://gerrit.wikimedia.org/r/285456 (owner: 10EBernhardson) [20:47:01] (03Merged) 10jenkins-bot: Make wikidiff3 the only diff engine [core] - 10https://gerrit.wikimedia.org/r/284003 (https://phabricator.wikimedia.org/T128896) (owner: 10MaxSem) [21:04:13] (03PS2) 10Aaron Schulz: Make refreshLinksJob explicitly check the cache rev ID [core] - 10https://gerrit.wikimedia.org/r/285449 (https://phabricator.wikimedia.org/T133659) [21:07:55] (03PS1) 10Aaron Schulz: Do not let DataUpdate exceptions block other deferred updates [core] - 10https://gerrit.wikimedia.org/r/285518 [21:16:43] (03CR) 10Legoktm: Convert SearchEngine to service containers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [21:38:21] (03PS1) 10Legoktm: LinkCache: Make clearBadLink() only clear that link [core] - 10https://gerrit.wikimedia.org/r/285525 [21:42:54] (03PS2) 10Legoktm: LinkCache: Make clearBadLink() only clear that link [core] - 10https://gerrit.wikimedia.org/r/285525 [21:47:27] (03CR) 10Aaron Schulz: [C: 032] LinkCache: Make clearBadLink() only clear that link [core] - 10https://gerrit.wikimedia.org/r/285525 (owner: 10Legoktm) [21:49:36] (03PS1) 10Jforrester: Update OOjs UI to v0.17.0 [core] - 10https://gerrit.wikimedia.org/r/285528 [21:52:13] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.17.0 [core] - 10https://gerrit.wikimedia.org/r/285528 (owner: 10Jforrester) [21:52:18] (03PS2) 10Legoktm: [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 [21:54:43] (03CR) 10Legoktm: [WIP] Add TitleParser and TitleFormatter to MediaWikiServices (031 comment) [core] - 10https://gerrit.wikimedia.org/r/285141 (owner: 10Legoktm) [21:55:02] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.17.0 [core] - 10https://gerrit.wikimedia.org/r/285528 (owner: 10Jforrester) [21:58:17] (03Merged) 10jenkins-bot: LinkCache: Make clearBadLink() only clear that link [core] - 10https://gerrit.wikimedia.org/r/285525 (owner: 10Legoktm) [21:58:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add TitleParser and TitleFormatter to MediaWikiServices [core] - 10https://gerrit.wikimedia.org/r/285141 (owner: 10Legoktm) [22:03:04] (03Merged) 10jenkins-bot: Update OOjs UI to v0.17.0 [core] - 10https://gerrit.wikimedia.org/r/285528 (owner: 10Jforrester) [22:04:46] (03CR) 10Addshore: [C: 032] "re +2 to re poke the jobs" [core] - 10https://gerrit.wikimedia.org/r/285018 (https://phabricator.wikimedia.org/T113034) (owner: 10Daniel Kinzler) [22:09:59] (03PS1) 10Aaron Schulz: Optimize consistencyCheck() in FileBackendMultiwrite [core] - 10https://gerrit.wikimedia.org/r/285532 [22:12:58] (03Merged) 10jenkins-bot: Introduce InterwikiTest [core] - 10https://gerrit.wikimedia.org/r/285018 (https://phabricator.wikimedia.org/T113034) (owner: 10Daniel Kinzler) [22:19:37] (03CR) 10Smalyshev: Convert SearchEngine to service containers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [22:32:05] (03PS3) 10Mattflaschen: Fix i18n message parameter for 'keep me logged in' days. [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [22:33:01] (03PS1) 10Smalyshev: Move wgContLang from config to injectable [core] - 10https://gerrit.wikimedia.org/r/285539 [22:35:23] (03CR) 10Smalyshev: "What do you think about this approach? It still has wgContLang as global but at least it's not everywhere but just in couple of points and" [core] - 10https://gerrit.wikimedia.org/r/285539 (owner: 10Smalyshev) [22:36:06] (03CR) 10Smalyshev: Convert SearchEngine to service containers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/282217 (owner: 10Smalyshev) [22:36:10] (03CR) 10jenkins-bot: [V: 04-1] Fix i18n message parameter for 'keep me logged in' days. [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [22:40:38] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - 10https://gerrit.wikimedia.org/r/285541 [22:40:51] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_25) - 10https://gerrit.wikimedia.org/r/285541 (owner: 10Ejegg) [22:43:45] (03CR) 10Mattflaschen: Fix i18n message parameter for 'keep me logged in' days. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza) [22:54:33] (03PS1) 10Smalyshev: [WIP] Infrastructure for augmenting search results [core] - 10https://gerrit.wikimedia.org/r/285544 (https://phabricator.wikimedia.org/T117493) [23:00:06] (03PS3) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 [23:00:09] (03PS1) 10MaxSem: Remove unused constant [core] - 10https://gerrit.wikimedia.org/r/285547 [23:00:12] (03PS1) 10MaxSem: Merge Wikidiff3 into DiffEngine [core] - 10https://gerrit.wikimedia.org/r/285548 [23:00:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Infrastructure for augmenting search results [core] - 10https://gerrit.wikimedia.org/r/285544 (https://phabricator.wikimedia.org/T117493) (owner: 10Smalyshev) [23:10:23] (03PS4) 10MaxSem: Refactor diffs [core] - 10https://gerrit.wikimedia.org/r/285443 [23:12:21] (03CR) 10Mattflaschen: [C: 04-1] "Per Anomie on patch set 2. The $ prefix is not allowed on setMwGlobals, and it probably shouldn't support wgCookieExpiration being null." [core] - 10https://gerrit.wikimedia.org/r/283698 (https://phabricator.wikimedia.org/T109031) (owner: 10Gergő Tisza)