[19:58:11] <Luke081515>	 ok, who is ready? ;)
[19:59:00] <Luke081515>	 Maybe a few other reviewers and change submitter join today, I annouced it at 3 channels, paladox at two others
[19:59:17] <paladox>	 Ok
[20:00:21] <grrrit-wm>	 (03CR) 10Ori.livneh: "recheck" [core] - 10https://gerrit.wikimedia.org/r/289369 (owner: 10Ori.livneh)
[20:01:27] <grrrit-wm>	 (03CR) 10Luke081515: "recheck" [core] - 10https://gerrit.wikimedia.org/r/252455 (owner: 10Alexia)
[20:01:43] <grrrit-wm>	 (03CR) 10Hashar: "PS1 is the Gerrit automatic revert" [core] - 10https://gerrit.wikimedia.org/r/291025 (https://phabricator.wikimedia.org/T136188) (owner: 10Hashar)
[20:02:27] <bawolff>	 Well how about https://gerrit.wikimedia.org/r/#/c/288922/ [Charinsert] and https://gerrit.wikimedia.org/r/#/c/288878/ [gwtoolset] ?
[20:02:47] <Luke081515>	 I think we should ping some reviewers first ;) pinging:
[20:03:06] <Luke081515>	 twentyafterfour, jdlrobson, phuedx as +2 reviewers ;)
[20:03:25] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Revert "build: Bump grunt-karma and related tools to 1.0.x" [core] - 10https://gerrit.wikimedia.org/r/291025 (https://phabricator.wikimedia.org/T136188) (owner: 10Hashar)
[20:03:44] * bawolff notes that over half the people currently idling in this channel are +2 reviewers
[20:04:00] <bawolff>	 Anyways, both those patches are kind of hard, but for different reasons
[20:04:33] * Luke081515 is willing to give some more people voice, if they want ;)
[20:04:34] <bawolff>	 the charinsert one because it broke things last time (Don't worry, I'm taking full responsibility for anything that breaks) and the gwtoolset one is hard because nobody wants to set up gwtoolset
[20:04:39] <grrrit-wm>	 (03CR) 10Paladox: ":)" [core] - 10https://gerrit.wikimedia.org/r/291025 (https://phabricator.wikimedia.org/T136188) (owner: 10Hashar)
[20:04:51] <Luke081515>	 hm
[20:04:54] <bawolff>	 So if nobody wants to review those two, I won't be offended :)
[20:05:23] <Luke081515>	 but we should have at least some reviewers, who are available today, we got some proposed patches
[20:05:56] <bawolff>	 And https://gerrit.wikimedia.org/r/#/c/143835/ [globalusage] is doubley hard, because really nobody wants to set up global usage
[20:06:02] <grrrit-wm>	 (03PS1) 10Hashar: Revert "build: Bump grunt-karma and related tools to 1.0.x" [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291034 (https://phabricator.wikimedia.org/T136188) 
[20:06:12] <bawolff>	 Luke081515: If anyone else has a patch, I can maybe look at it
[20:06:12] <Luke081515>	 and we have https://phabricator.wikimedia.org/E196#2142 as proosed too
[20:06:20] <bawolff>	 for now, I'm going to have to go in about 15 minutes
[20:06:23] <Luke081515>	 bawolff: ^ have fun :)
[20:06:52] <bawolff>	 oh look, my patch was nominated without me even knowing :D
[20:08:06] <grrrit-wm>	 (03CR) 10VolkerE: [C: 031] Use HTMLForm style sheets on mobile [core] - 10https://gerrit.wikimedia.org/r/290941 (https://phabricator.wikimedia.org/T135779) (owner: 10Gergő Tisza)
[20:08:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "build: Bump grunt-karma and related tools to 1.0.x" [core] - 10https://gerrit.wikimedia.org/r/291025 (https://phabricator.wikimedia.org/T136188) (owner: 10Hashar)
[20:08:29] * twentyafterfour has been dealing with train deployment blockers
[20:08:51] <Luke081515>	 ah, ok :)
[20:08:56] <twentyafterfour>	 ping me if you need me I'll be tied up for a few more minutes
[20:10:54] <bawolff>	 Most of those on the phab comment already have -1's
[20:11:03] <Luke081515>	 :-/
[20:11:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bail out in ApiStashEdit for bots for sanity [core] - 10https://gerrit.wikimedia.org/r/291016 (owner: 10Aaron Schulz)
[20:11:25] <Luke081515>	 https://gerrit.wikimedia.org/r/#/c/272708/ for example not ;)
[20:11:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "build: Bump grunt-karma and related tools to 1.0.x" [core] - 10https://gerrit.wikimedia.org/r/291025 (https://phabricator.wikimedia.org/T136188) (owner: 10Hashar)
[20:12:22] <Luke081515>	 and https://gerrit.wikimedia.org/r/#/c/210675/ is open too for review
[20:12:24] <bawolff>	 I'm pretty sure isarra would have me killed if I ever approved something that had the words "use grey text" in the description ;)
[20:12:52] <bawolff>	 but more generally, I don't really feel comfortable merging design-y/super front-end changes, I'm more a backend php person
[20:13:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Whenever possible, reuse User objects in unit tests [core] - 10https://gerrit.wikimedia.org/r/289369 (owner: 10Ori.livneh)
[20:14:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Abstract out the authentication error handling and call try catch handler. [core] - 10https://gerrit.wikimedia.org/r/252455 (owner: 10Alexia)
[20:14:55] <bawolff>	 That one is kind of a big change (534 lines touched). more then I can review in the next ten minutes :)
[20:15:20] <Luke081515>	 hm, maybe others want to review some front changes? ;)
[20:16:23] <bawolff>	 Hopefully :)
[20:16:40] <grrrit-wm>	 (03PS1) 10EBernhardson: Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 
[20:18:39] <grrrit-wm>	 (03CR) 10DCausse: [C: 031] Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 (owner: 10EBernhardson)
[20:21:37] <grrrit-wm>	 (03CR) 10Alexia: "Everything passes now except for HHVM, but the error is related to an Elastica change." [core] - 10https://gerrit.wikimedia.org/r/252455 (owner: 10Alexia)
[20:21:55] <grrrit-wm>	 (03PS2) 1020after4: Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 (https://phabricator.wikimedia.org/T136356) (owner: 10EBernhardson)
[20:22:39] <grrrit-wm>	 (03PS3) 1020after4: Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 (https://phabricator.wikimedia.org/T136356) (owner: 10EBernhardson)
[20:22:58] <grrrit-wm>	 (03CR) 1020after4: [C: 032] Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 (https://phabricator.wikimedia.org/T136356) (owner: 10EBernhardson)
[20:31:41] <grrrit-wm>	 (03PS1) 10Legoktm: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] - 10https://gerrit.wikimedia.org/r/291040 (https://phabricator.wikimedia.org/T136352) 
[20:32:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Temporary hack to fix interwiki search with bad titles returned by search engine [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291037 (https://phabricator.wikimedia.org/T136356) (owner: 10EBernhardson)
[20:33:06] <grrrit-wm>	 (03PS2) 10Legoktm: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] - 10https://gerrit.wikimedia.org/r/291040 (https://phabricator.wikimedia.org/T136352) 
[20:34:27] <grrrit-wm>	 (03PS3) 10Legoktm: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] - 10https://gerrit.wikimedia.org/r/291040 (https://phabricator.wikimedia.org/T136352) 
[20:42:25] <grrrit-wm>	 (03CR) 10Ori.livneh: "recheck" [core] - 10https://gerrit.wikimedia.org/r/289369 (owner: 10Ori.livneh)
[20:42:34] <grrrit-wm>	 (03PS23) 10Ori.livneh: Whenever possible, reuse User objects in unit tests [core] - 10https://gerrit.wikimedia.org/r/289369 
[20:43:01] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] "(carrying over anomie's +2 to the rebase)" [core] - 10https://gerrit.wikimedia.org/r/289369 (owner: 10Ori.livneh)
[20:44:00] <grrrit-wm>	 (03CR) 10Ori.livneh: [V: 032] Whenever possible, reuse User objects in unit tests [core] - 10https://gerrit.wikimedia.org/r/289369 (owner: 10Ori.livneh)
[20:48:49] <grrrit-wm>	 (03CR) 10MaxSem: [C: 032] TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] - 10https://gerrit.wikimedia.org/r/291040 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[20:50:13] <grrrit-wm>	 (03PS1) 10Legoktm: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291099 (https://phabricator.wikimedia.org/T136352) 
[20:50:50] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291099 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[20:51:45] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] LinkRenderer: Re-implement noclasses as makePreloadedLink function [core] - 10https://gerrit.wikimedia.org/r/290879 (owner: 10Legoktm)
[20:57:41] <grrrit-wm>	 (03PS1) 10Ori.livneh: Bail out in ApiStashEdit for bots for sanity [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291102 
[20:57:49] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Bail out in ApiStashEdit for bots for sanity [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291102 (owner: 10Ori.livneh)
[20:58:10] <grrrit-wm>	 (03PS1) 10Ori.livneh: Bail out in ApiStashEdit for bots for sanity [core] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/291103 
[21:01:36] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Bail out in ApiStashEdit for bots for sanity [core] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/291103 (owner: 10Ori.livneh)
[21:01:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] - 10https://gerrit.wikimedia.org/r/291040 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[21:01:55] <grrrit-wm>	 (03CR) 10Florianschmidtwelzow: [C: 031] "Unfortunately, I don't understand enough of AuthManager's logic used inside when managing requests, yet. However, as far as I can see, it " [core] - 10https://gerrit.wikimedia.org/r/291003 (owner: 10Anomie)
[21:02:42] <grrrit-wm>	 (03PS2) 10Ori.livneh: Send edit stash metrics for cache attempts [core] - 10https://gerrit.wikimedia.org/r/291021 (owner: 10Aaron Schulz)
[21:02:51] <grrrit-wm>	 (03CR) 10Ori.livneh: [C: 032] Send edit stash metrics for cache attempts [core] - 10https://gerrit.wikimedia.org/r/291021 (owner: 10Aaron Schulz)
[21:03:27] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 04-1] Parser: Replace Linker::link() with LinkRenderer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/288572 (owner: 10Legoktm)
[21:05:58] <grrrit-wm>	 (03PS24) 10Legoktm: Parser: Replace Linker::link() with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/288572 
[21:06:41] <grrrit-wm>	 (03PS7) 10Legoktm: Parser: Use LinkRenderer for building ISBN magic links [core] - 10https://gerrit.wikimedia.org/r/290393 
[21:06:44] <grrrit-wm>	 (03PS7) 10Legoktm: Remove unused MediaWikiPageLinkRenderer class and interface [core] - 10https://gerrit.wikimedia.org/r/290392 
[21:06:47] <grrrit-wm>	 (03PS8) 10Legoktm: LinkBatch: Use TitleValue instead of Title [core] - 10https://gerrit.wikimedia.org/r/290166 
[21:06:50] <grrrit-wm>	 (03PS22) 10Legoktm: Have Linker::getLinkColour() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/288577 
[21:06:53] <grrrit-wm>	 (03PS10) 10Legoktm: LinkCache: Don't try looking up NS_SPECIAL [core] - 10https://gerrit.wikimedia.org/r/289808 
[21:06:56] <grrrit-wm>	 (03PS23) 10Legoktm: ChangesList: Use LinkRenderer instead of Linker::link() [core] - 10https://gerrit.wikimedia.org/r/288579 
[21:06:59] <grrrit-wm>	 (03PS6) 10Legoktm: SpecialLinkSearch: Use LinkRenderer instead of MediaWikiPageLinkRenderer [core] - 10https://gerrit.wikimedia.org/r/290391 
[21:07:02] <grrrit-wm>	 (03PS13) 10Legoktm: Add tests for Linker::getLinkColour() [core] - 10https://gerrit.wikimedia.org/r/289782 
[21:07:05] <grrrit-wm>	 (03PS6) 10Legoktm: SpecialCategories: Use LinkRenderer instead of MediaWikiPageLinkRenderer [core] - 10https://gerrit.wikimedia.org/r/290390 
[21:07:08] <grrrit-wm>	 (03CR) 10Legoktm: Parser: Replace Linker::link() with LinkRenderer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/288572 (owner: 10Legoktm)
[21:09:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Parser: Use LinkRenderer for building ISBN magic links [core] - 10https://gerrit.wikimedia.org/r/290393 (owner: 10Legoktm)
[21:09:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove unused MediaWikiPageLinkRenderer class and interface [core] - 10https://gerrit.wikimedia.org/r/290392 (owner: 10Legoktm)
[21:09:38] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] LinkBatch: Use TitleValue instead of Title [core] - 10https://gerrit.wikimedia.org/r/290166 (owner: 10Legoktm)
[21:09:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Have Linker::getLinkColour() accept LinkTarget objects [core] - 10https://gerrit.wikimedia.org/r/288577 (owner: 10Legoktm)
[21:10:11] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] Parser: Replace Linker::link() with LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/288572 (owner: 10Legoktm)
[21:10:15] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] LinkCache: Don't try looking up NS_SPECIAL [core] - 10https://gerrit.wikimedia.org/r/289808 (owner: 10Legoktm)
[21:10:18] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ChangesList: Use LinkRenderer instead of Linker::link() [core] - 10https://gerrit.wikimedia.org/r/288579 (owner: 10Legoktm)
[21:10:32] <grrrit-wm>	 (03PS1) 10Paladox: Revert "Revert "build: Bump grunt-karma and related tools to 1.0.x"" [core] - 10https://gerrit.wikimedia.org/r/291104 
[21:10:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SpecialLinkSearch: Use LinkRenderer instead of MediaWikiPageLinkRenderer [core] - 10https://gerrit.wikimedia.org/r/290391 (owner: 10Legoktm)
[21:10:46] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add tests for Linker::getLinkColour() [core] - 10https://gerrit.wikimedia.org/r/289782 (owner: 10Legoktm)
[21:10:49] <grrrit-wm>	 (03PS2) 10Paladox: Revert "Revert "build: Bump grunt-karma and related tools to 1.0.x"" [core] - 10https://gerrit.wikimedia.org/r/291104 
[21:11:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] SpecialCategories: Use LinkRenderer instead of MediaWikiPageLinkRenderer [core] - 10https://gerrit.wikimedia.org/r/290390 (owner: 10Legoktm)
[21:12:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291099 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[21:12:34] <grrrit-wm>	 (03CR) 10Legoktm: TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291099 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[21:12:39] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] TitleParser: In formatTitle(), don't throw exceptions on bad namespaces [core] (wmf/1.28.0-wmf.3) - 10https://gerrit.wikimedia.org/r/291099 (https://phabricator.wikimedia.org/T136352) (owner: 10Legoktm)
[21:13:11] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Let's get things working first before declaring that this is not the cause." [core] - 10https://gerrit.wikimedia.org/r/291104 (owner: 10Paladox)
[23:01:25] <jdlrobson>	 Luke081515: hey so phuedx is a reviewer but only in European hours. Do we have a European hours friendly code review window?
[23:05:35] <Luke081515>	 I think I should create a task at phab that we find one 
[23:12:19] <Luke081515>	 https://phabricator.wikimedia.org/T136370
[23:14:40] <jdlrobson>	 Luke081515: awesome
[23:35:40] <Danny_B>	 it would be practical to mark at events in phab after they finish, which tasks / patches were actually discussed and solved, since it may vary from the proposed list quite significantly
[23:39:01] <Luke081515>	 Danny_B: Today no patches I thing. We had not enough reviewers, that's why I filed T136370
[23:39:01] <stashbot>	 T136370: Setup a codereview hour for non american people - https://phabricator.wikimedia.org/T136370
[23:42:14] <Danny_B>	 https://phabricator.wikimedia.org/T11424#2332448 seems to be reviewed
[23:43:02] <Luke081515>	 yep, but not of a reviewer that took part of the hour