[20:03:05] <twentyafterfour>	 Any patches for review today?
[20:03:51] <bawolff>	 I'd like someone to look at https://gerrit.wikimedia.org/r/#/c/303135
[20:04:13] <twentyafterfour>	 bawolff: looking
[20:04:49] <paladox>	 Could someone also review https://gerrit.wikimedia.org/r/#/c/193434/ please?
[20:09:26] <bawolff>	 paladox: I don't understand how the LocalSettingsGenerator.php part of that patch works. Where does the value for wgLogoSVG come from when put into the new LocalSettings.php
[20:10:27] <paladox>	 bawolff oh your right that is unneded since we only do wgLogo through mw-config
[20:10:32] <paladox>	 I will remove that part now
[20:10:47] <bawolff>	 Luke081515: Can I be voiced?
[20:10:56] <Luke081515>	 give me a moment
[20:11:00] <bawolff>	 not that it matters
[20:11:10] <bawolff>	 but the topic says people with +2 are voiced
[20:11:10] <Luke081515>	 done
[20:11:12] <bawolff>	 woo
[20:11:15] <Luke081515>	 :)
[20:11:29] * bawolff points out that the majority of people in this channel have +2 in core
[20:11:57] <grrrit-wm>	 (03PS56) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[20:12:07] <grrrit-wm>	 (03PS57) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[20:12:24] <paladox>	 bawolff ^^
[20:12:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] MultiHTTPClient: Support sending JSON POST requests. [core] - 10https://gerrit.wikimedia.org/r/308014 (https://phabricator.wikimedia.org/T94890) (owner: 10Ppchelko)
[20:12:52] <Luke081515>	 bawolff, just tell me the names ;)
[20:13:11] <bawolff>	 I'll pm you since I don't want to ping everyone in existence
[20:15:00] <Luke081515>	 ok :)
[20:19:20] <paladox>	 bawolff does that https://gerrit.wikimedia.org/r/193434/ look better?
[20:19:45] <bawolff>	 paladox: The @since annotation in DefaultSettings.php needs to be updated to 1.28
[20:19:50] <bawolff>	 And I haven't actually tested this yet
[20:19:54] <paladox>	 Ok
[20:20:02] <paladox>	 bawolff ive tested it and works both ways
[20:20:10] <paladox>	 using just wgLogo, so no breakage
[20:20:21] <paladox>	 and using wgLogo and wgLogoSVG together :)
[20:20:59] * bawolff hasn't actually really looked at the REsourceLoaderSkinModule part yet
[20:21:11] <grrrit-wm>	 (03PS58) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[20:21:23] <paladox>	 Oh
[20:21:49] <paladox>	 Would you be able to test it please. Ive tested it but to make sure it works it needs two
[20:22:04] <paladox>	 bawolff ^^
[20:22:16] <bawolff>	 In a moment
[20:22:20] <twentyafterfour>	 bawolff: can you explain what the system|  thing does in your patch?
[20:22:29] <paladox>	 Ok thanks
[20:22:31] <paladox>	 :)
[20:23:20] <bawolff>	 twentyafterfour: That's what Preference::getTimezoneOptions() seems to use to mean - "Use system default timezone"
[20:23:44] <twentyafterfour>	 ok, that makes sense
[20:23:56] <twentyafterfour>	 in that case, +2
[20:24:03] <grrrit-wm>	 (03CR) 10Legoktm: [WIP] API: Add action=x-amples to autogenerate a swagger spec (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/307913 (https://phabricator.wikimedia.org/T136839) (owner: 10Legoktm)
[20:24:11] <grrrit-wm>	 (03PS2) 10Legoktm: API: Add action=x-amples to autogenerate a swagger spec [core] - 10https://gerrit.wikimedia.org/r/307913 (https://phabricator.wikimedia.org/T136839) 
[20:24:32] <grrrit-wm>	 (03CR) 1020after4: [C: 032] "Seems sensible although I haven't experienced the bug myself." [core] - 10https://gerrit.wikimedia.org/r/303135 (owner: 10Brian Wolff)
[20:26:00] <twentyafterfour>	 I think we may need to promote codereview a little better. Surely there are more people who would like patches reviewed but are not aware of the channel or the recurring "office hours"
[20:26:09] <grrrit-wm>	 (03PS2) 10Ppchelko: MultiHTTPClient: Support sending JSON POST requests. [core] - 10https://gerrit.wikimedia.org/r/308014 (https://phabricator.wikimedia.org/T94890) 
[20:26:54] <bawolff>	 paladox: So looking at this patch. What if the user set an HD logo - and set an svg logo. Does that mean normal dpi users would get the svg, but high dpi would get the HD png?
[20:27:04] <paladox>	 I think so
[20:27:19] <paladox>	 But not sure
[20:27:25] <bawolff>	 Because to me, I think people who set an svg logo, would want the svg to show up on high-dpi displays too
[20:27:34] <paladox>	 Oh
[20:27:45] <paladox>	 I guess we could create a new option to
[20:27:54] <paladox>	 something like a copy of wgLogo but for svg
[20:30:23] <bawolff>	 Personally, I think it should ignore $wgLogoHD if $wgLogoSVG is specified
[20:30:47] <bawolff>	 Or perhaps instead of new variable, there could be a different key in $wgLogoHD for svgs
[20:31:37] <paladox>	 bawolff thats a good idea
[20:31:50] <grrrit-wm>	 (03CR) 10Legoktm: "x-default-params didn't work as I expected, so I submitted another patch to add x-default-query functionality: <https://gerrit.wikimedia.o" [core] - 10https://gerrit.wikimedia.org/r/307913 (https://phabricator.wikimedia.org/T136839) (owner: 10Legoktm)
[20:32:06] <paladox>	 I guess we could add a check in to say if wgLogoSVG is set then it will not use the png ones
[20:32:13] <paladox>	 bawolff would ^^ that sound good?
[20:32:23] <bawolff>	 That sounds good to me
[20:32:26] <paladox>	 Ok
[20:32:41] <paladox>	 bawolff i wont be able to test this one due to me not knowing the difference.
[20:33:02] <bawolff>	 Test it as good as you are able to
[20:33:18] <paladox>	 Ok
[20:33:45] <paladox>	 I will be able to test as in that it wont affect it or cause it to show a non svg or make it a breaking change
[20:33:46] <paladox>	 :)
[20:33:49] <paladox>	 thanks for spotting it though
[20:33:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Register a default value for the timecorrection preference [core] - 10https://gerrit.wikimedia.org/r/303135 (owner: 10Brian Wolff)
[20:39:26] <grrrit-wm>	 (03CR) 10Daniel Kinzler: API: Output structured content representation if requested (031 comment) [core] - 10https://gerrit.wikimedia.org/r/307017 (https://phabricator.wikimedia.org/T143967) (owner: 10Legoktm)
[20:41:19] <grrrit-wm>	 (03PS3) 10Ppchelko: MultiHTTPClient: Support sending JSON POST requests. [core] - 10https://gerrit.wikimedia.org/r/308014 (https://phabricator.wikimedia.org/T94890) 
[20:46:01] <grrrit-wm>	 (03Restored) 10Aaron Schulz: Make RedisBagOStuff respect SYNC_WRITE [core] - 10https://gerrit.wikimedia.org/r/306312 (owner: 10Aaron Schulz)
[20:47:23] <grrrit-wm>	 (03PS10) 10Aaron Schulz: objectcache: allow for callbacks to mask SYNC_WRITE latency [core] - 10https://gerrit.wikimedia.org/r/307329 
[20:47:26] <grrrit-wm>	 (03PS1) 10Aaron Schulz: Make RedisBagOStuff respect SYNC_WRITE [core] - 10https://gerrit.wikimedia.org/r/308022 
[20:48:18] <grrrit-wm>	 (03Abandoned) 10Aaron Schulz: Make RedisBagOStuff respect SYNC_WRITE [core] - 10https://gerrit.wikimedia.org/r/306312 (owner: 10Aaron Schulz)
[20:51:33] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 04-1] "I like the idea. But this does not affect API only; the same warnings bubble up in Special:Upload. You'll need to add the localisation mes" [core] - 10https://gerrit.wikimedia.org/r/306336 (https://phabricator.wikimedia.org/T141822) (owner: 10Matthias Mullie)
[20:57:10] <grrrit-wm>	 (03CR) 10Legoktm: "Also we need to figure out whether we want this entire module to be specific to x-amples, or have a generic action=swagger-spec which is m" [core] - 10https://gerrit.wikimedia.org/r/307913 (https://phabricator.wikimedia.org/T136839) (owner: 10Legoktm)
[20:57:38] <grrrit-wm>	 (03PS2) 10Aaron Schulz: Make RedisBagOStuff respect SYNC_WRITE [core] - 10https://gerrit.wikimedia.org/r/308022 
[21:05:14] <paladox>	 bawolff im working on it now :)
[21:05:23] <bawolff>	 ok
[21:06:06] <paladox>	 bawolff how do you set it for these devices
[21:06:13] <paladox>	 what i mean is there a svg option
[21:06:21] <paladox>	 for example
[21:06:22] <paladox>	 -webkit-min-device-pixel-ratio: 1.5
[21:06:33] <paladox>	 do i just duplicate what is done in HD?
[21:06:51] <bawolff>	 Well I believe that anything that supports device-pixel-ratio also supports svg
[21:07:12] <bawolff>	 But what I was suggesting earlier was to simply not set the HD logos if an svg logo is specified
[21:07:23] <paladox>	 Ah ok
[21:08:09] <paladox>	 bawolff would  $logoHD && $logoSVG == false  that work?
[21:09:21] <bawolff>	 $logoHD && !$logoSVG
[21:09:26] <paladox>	 Oh
[21:09:27] <paladox>	 thanks
[21:09:28] <paladox>	 :)
[21:10:35] <grrrit-wm>	 (03PS59) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[21:10:44] <paladox>	 bawolff ok done ^^ does that look better :)
[21:12:33] <paladox>	 ?
[21:12:40] <bawolff>	 better. You still have a random if ( isset( $logoHD['1.5x'] ) ) { on line 53
[21:13:08] <paladox>	 bawolff oh, but i thought that is needed if we have svg set to off?
[21:13:33] <paladox>	 unless we need to do && !$logoSVG there too
[21:13:34] <paladox>	 ?
[21:13:43] <bawolff>	 The one on line 63 is needed. The one on line 53 is not
[21:13:52] <paladox>	 Oh woops
[21:13:53] <paladox>	 sorry
[21:13:59] <paladox>	 forgot to remove that one
[21:14:36] <grrrit-wm>	 (03PS60) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[21:14:43] <paladox>	 bawolff ^^ ok done :)
[21:15:00] <bawolff>	 ok, I'll look in a moment
[21:16:00] <paladox>	 Ok
[21:16:01] <paladox>	 thanks
[21:16:06] <paladox>	 and thankyou for your reviews
[21:16:07] <paladox>	 :)
[21:17:01] <grrrit-wm>	 (03PS5) 10Aaron Schulz: Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 
[21:17:25] <grrrit-wm>	 (03PS6) 10Aaron Schulz: Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 
[21:18:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: 10Paladox)
[21:18:40] <grrrit-wm>	 (03PS61) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[21:19:15] <grrrit-wm>	 (03PS62) 10Paladox: Add support for svg with png fallback for logo [core] - 10https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) 
[21:25:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 (owner: 10Aaron Schulz)
[21:25:56] <grrrit-wm>	 (03PS7) 10Aaron Schulz: Enable DBO_TRX for DeferredUpdates::execute() in CLI mode [core] - 10https://gerrit.wikimedia.org/r/308007 
[22:14:42] <paladox>	 bawolff did you manage to test?
[22:14:50] <bawolff>	 looking at it right now
[22:17:21] <paladox>	 Ok
[22:17:22] <paladox>	 thanks
[22:17:23] <paladox>	 :)
[22:21:27] <bawolff>	 paladox: +2 :)
[22:22:07] <paladox>	 bawolff yay
[22:22:16] <paladox>	 would you be able to +2 it please?
[22:22:19] <paladox>	 bawolff ^^
[22:22:50] <bawolff>	 I did. Its just waiting for jenkins to run
[22:23:07] <bawolff>	 	grrrit-wm	(CR) Brian Wolff: [C: 2] Add support for svg with png fallback for logo [core] - https://gerrit.wikimedia.org/r/193434 (https://phabricator.wikimedia.org/T86229) (owner: Paladox)
[22:23:15] <paladox>	 Oh lol
[22:23:16] <paladox>	 thanks
[22:23:28] <paladox>	 Oh id didnt see that
[22:23:33] <paladox>	 id = i
[22:24:42] <paladox>	 Yay thankyou
[22:25:30] <paladox>	 bawolff oh a -1 by legoktm