[07:30:19] can anyone please review this issue https://gerrit.wikimedia.org/r/#/c/344976/ ? [09:33:06] rammanoj__, as not everybody knows every codebase, please provide content instead of just a link. thanks :) [09:33:35] so "mediawiki/skins/Vector". [09:33:47] Last version updated a few hours ago. [09:33:59] Which sends Gerrit notifications anyway. [15:23:32] Last change was a update of the commit message, taking into account the last "real" change it's been waiting about 1,5 days. There are currently four reviewers on this, of which one is jenkins, one said he has no opinion on this change and one being me who has already given all input I can provide. The last one has been added automatically and might or might not even read notifications about this. So reaching out for more people to review [15:23:32] this (especially in -codereview) sounds sensible to me. Especially if you're a newcomer waiting for any feedback on your very first contribution. ;-) [15:42:53] Interesting, as it does not sound sensible to me after 36h :) [16:13:54] I'm also quite new here (started a couple of weeks ago) and it also took me a while to accept that it's completely normal in the mediawiki universe to wait for days to get some code review, even if the patch is just about adding a single line which fixes some minor style issue and is absolutely un-controversial. It can be quite de-motivating when you're sending your very first contribution in and nobody responds to it (and may lead to not [16:13:54] continuing contribution). I'm not saying we should have everything reviewed within 36h. But we shouldn't reject somebody who's new to mw development when they - in a friendly tone - try to raise awareness of their contribution, even if they do so after 36h. [18:21:33] eddiegp: totally reasonable, unfortunately the code review culture in Mediawiki-land is in need of some improvements [18:24:32] eddiegp: It might help to look at the git blame for the files you've edited and then add a few people as reviewers to your patch [18:38:09] twentyafterfour: I've already noticed that people are aware of problems about code review and searching for it in phab gives you a ton of discussion and ideas how to improve it. It's absolutely normal that improvements need time. I merely wanted to explain why I oppose andre__ s "does not sound sensible to me after 36h" ;-) [18:39:12] git blame is a good hint too, thanks. I've mostly looked at mw.org's "Maintainers" page to find someone to add to my patches as reviewers :) [22:05:25] eddiegp, yeah, I'm sorry it takes so long. It's been topic of discussions (as mentioned already) and I do appreciate that you stick around :) [22:06:29] eddiegp, I've sent (kind of weekly) emails to wikitech-l@ for a while, listing patches awaiting review by complete newcomers, but the data source I used to get the list of new contributors currently around anymore... :-/ [22:06:43] in any case, thanks for the patience!