[17:43:42] (03CR) 10jenkins-bot: EditPage: Fix 'id' attributes on buttons in non-OOUI mode [core] - 10https://gerrit.wikimedia.org/r/357852 (https://phabricator.wikimedia.org/T167390) (owner: 10Bartosz Dziewoński) [17:45:48] (03PS3) 10Anomie: WIP: API: Split description messages into summary + additional text [core] - 10https://gerrit.wikimedia.org/r/355825 (https://phabricator.wikimedia.org/T166411) [17:46:01] (03CR) 10jerkins-bot: [V: 04-1] WIP: API: Split description messages into summary + additional text [core] - 10https://gerrit.wikimedia.org/r/355825 (https://phabricator.wikimedia.org/T166411) (owner: 10Anomie) [18:12:53] (03CR) 10Chad: [C: 032] Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/357561 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [18:12:56] (03CR) 10Chad: [C: 032] Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_29) - 10https://gerrit.wikimedia.org/r/357560 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [18:19:03] (03CR) 10MaxSem: [C: 032] EditPage: Fix 'id' attributes on buttons in non-OOUI mode [core] (wmf/1.30.0-wmf.4) - 10https://gerrit.wikimedia.org/r/357855 (https://phabricator.wikimedia.org/T167390) (owner: 10Bartosz Dziewoński) [18:24:18] (03Merged) 10jenkins-bot: Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/357561 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [18:25:22] (03Merged) 10jenkins-bot: Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_29) - 10https://gerrit.wikimedia.org/r/357560 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [18:31:47] (03Merged) 10jenkins-bot: EditPage: Fix 'id' attributes on buttons in non-OOUI mode [core] (wmf/1.30.0-wmf.4) - 10https://gerrit.wikimedia.org/r/357855 (https://phabricator.wikimedia.org/T167390) (owner: 10Bartosz Dziewoński) [18:37:22] (03CR) 10jenkins-bot: Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_28) - 10https://gerrit.wikimedia.org/r/357561 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [18:41:34] (03CR) 10Arlolra: "Bump" [core] - 10https://gerrit.wikimedia.org/r/350830 (https://phabricator.wikimedia.org/T100453) (owner: 10Arlolra) [18:46:23] (03CR) 10jenkins-bot: Use AutoCommitUpdate instead of Database->onTransactionIdle [core] (REL1_29) - 10https://gerrit.wikimedia.org/r/357560 (https://phabricator.wikimedia.org/T154425) (owner: 10Seb35) [19:16:36] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Saying "2 times" and writing it with a cross-shaped character is a very American thing, I'm afraid. I assume this will not translate well " [core] - 10https://gerrit.wikimedia.org/r/357343 (owner: 10Matěj Suchánek) [19:24:00] (03CR) 10Umherirrender: Add hook for cleaning up data that depends on purged recentchanges rows (032 comments) [core] - 10https://gerrit.wikimedia.org/r/351146 (https://phabricator.wikimedia.org/T159753) (owner: 10Gergő Tisza) [19:42:52] (03CR) 10Gergő Tisza: Add hook for cleaning up data that depends on purged recentchanges rows (032 comments) [core] - 10https://gerrit.wikimedia.org/r/351146 (https://phabricator.wikimedia.org/T159753) (owner: 10Gergő Tisza) [19:46:48] (03CR) 10Gergő Tisza: Add hook for cleaning up data that depends on purged recentchanges rows (031 comment) [core] - 10https://gerrit.wikimedia.org/r/351146 (https://phabricator.wikimedia.org/T159753) (owner: 10Gergő Tisza) [20:02:21] Hi, I fixed this patch of mine: https://gerrit.wikimedia.org/r/#/q/Ib36063b69d6846fc197800bba44287493b0632c0 [20:02:27] Could you please take a look again? [20:03:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/357885 (owner: 10L10n-bot) [20:04:18] (03PS5) 10Gergő Tisza: Add hook for cleaning up data that depends on purged recentchanges rows [core] - 10https://gerrit.wikimedia.org/r/351146 (https://phabricator.wikimedia.org/T159753) [20:10:51] (03PS1) 10Anomie: WIP: Add `comment` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/357892 (https://phabricator.wikimedia.org/T166732) [20:11:02] I submitted a patch for two tickets here : https://phabricator.wikimedia.org/D670 [20:12:37] I'm not sure I did everything properly. I did `arc diff`, next time I will try to have two separate patches for each ticket [20:15:34] Thank you for your consideration for this minor JS bug fix and minor improvement [20:16:19] louperivois hi, is that for mw core? [20:17:03] one for MediaWiki-Categories and the other in MediaWiki-HTMLForm [20:17:04] we doint currently accept differential diffs for mediawiki core. We will support that at a later date. But for now all contributions to mw core are done through gerrit. [20:17:17] see https://gerrit.wikimedia.org/r/#/dashboard/self [20:17:35] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core [20:18:47] louperivois: see https://www.mediawiki.org/wiki/Gerrit/Tutorial [20:18:55] ok I could see something got wrong. [20:19:15] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add `comment` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/357892 (https://phabricator.wikimedia.org/T166732) (owner: 10Anomie) [20:21:36] louperivois: also, please make separate commits for the two tasks, and put the task number in the commit message (like in https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ) [20:22:16] thank you for the links [20:28:07] (03CR) 10MaxSem: "We don't have tests around this area, but I'm wondering if it's worth adding at least tests for this case?" [core] - 10https://gerrit.wikimedia.org/r/357016 (https://phabricator.wikimedia.org/T14458) (owner: 10Dbarratt) [20:30:18] (03PS1) 10Gilles: Remove X-Content-Dimensions header [core] - 10https://gerrit.wikimedia.org/r/357895 (https://phabricator.wikimedia.org/T150741) [20:30:37] paladox: hi, could you take a look to patch https://gerrit.wikimedia.org/r/#/q/Ib36063b69d6846fc197800bba44287493b0632c0 [20:31:15] yep, but i have no +2 [20:31:36] paladox: what do you mean with +2? [20:31:37] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [20:31:59] mertyildiran the change needs a +2 to be able to be merged [20:32:42] paladox: oh OK. I'm a new contributor so I'm not familiar with the terms sorry about that. [20:32:59] ok, nothing to be sorry about. :) [20:33:22] anyways looks ok, saw no code errors. [20:33:34] i've added a few reivewers that have +2 but not sure who will review [20:34:10] paladox: yeah I fixed everything mentioned in the comments by TTO and Aklapper [20:34:22] TTO has +2 rights [20:34:46] (03CR) 10Paladox: [C: 031] Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [20:36:22] paladox: so it needs Code-Review +2 and jenkins-bot +2 to be able to be merged, right? [20:36:30] yep [20:36:56] when someone does +2, jenkins will put the change through the gate and submit pipeline [20:37:15] if it passes then it will merge the change. If it fails then the change will not be merged. [20:37:30] (03PS1) 10Louperivois: FIX T166483 : Allow CategoryPageView to set $mCategoryViewerClass [core] - 10https://gerrit.wikimedia.org/r/357899 [20:37:59] ok here it is [20:38:12] paladox: if two person give +1 in total +2 then is it the same thing with +2? [20:38:31] (03CR) 10Paladox: FIX T166483 : Allow CategoryPageView to set $mCategoryViewerClass (032 comments) [core] - 10https://gerrit.wikimedia.org/r/357899 (owner: 10Louperivois) [20:38:44] mertyildiran nope [20:38:51] It needs an actual +2 [20:39:09] two +1 means it looks good to the users but needs someone else to approve [20:39:10] paladox: oh I understand [20:39:52] paladox: who does have +2 rights? [20:40:02] TTO and who? [20:40:06] most of wmf eployees. And some volunteeers [20:40:21] Is there a list that I can look? [20:40:41] Not that im aware of [20:40:49] so I can ping them via IRC if there is a need. [20:41:01] Yes but only if needed otherwise. [20:42:22] (03CR) 10Paladox: [C: 04-1] FIX T166483 : Allow CategoryPageView to set $mCategoryViewerClass [core] - 10https://gerrit.wikimedia.org/r/357899 (owner: 10Louperivois) [20:42:55] paladox: users with @wikimedia.org emails have +2 rights I think. [20:43:07] yes most of them should [20:43:18] but not all wmf employees review mw changes [20:43:36] paladox: I understand [20:43:42] paladox : not sure about what you wrote means [20:44:04] louperivois we do Bug: on top of the change id [20:44:26] ok it is just related to comment label. ill do. [20:44:33] your commit msg should look like [20:44:34] Allow CategoryPageView to set $mCategoryViewerClass [20:44:39] Bug: T166483 [20:44:39] Change-Id: I9937148dd8114e7167d6a581e64bfed5fdcc568e [20:44:39] T166483: allow CategoryPageView to set $mCategoryViewerClass - https://phabricator.wikimedia.org/T166483 [20:44:45] louperivois ^^ [20:45:46] paladox: there is no task about my patch in the Phabricator (I think...) Should I open a task about it? [20:46:01] Is it necessary to have a Phabricator task? [20:46:01] mertyildiran: its not a requirement [20:46:02] mertyildiran you doint have to if you doint want too [20:46:13] oh OK [20:48:23] mertyildiran: i do know that are bugwrangler (an wmf employee who helps keep stuff sorted and other things for us developers, see mediawiki.org/wiki/Bugwrangler) has asked developers with +2 rights to check your patch out so it will be done at some point however, it could still take some time. [20:50:02] Zppix: oh OK thank you. [20:52:35] (03PS1) 10Louperivois: Bug: T166621 : HTMLSelectOrOtherField - no toggle with default option - https://phabricator.wikimedia.org/T166621 [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) [20:53:02] eheh here is the other [20:53:50] Louperivois that looks wrong, it should look like https://phabricator.wikimedia.org/P5559 [20:54:10] mertyildiran: also i saw your other question just earlier, i dont know if you were answered but the reason main tests arent done when you upload a new change is because your not apart of a whitelist that we use for Continous Intergration (fancy term for testing our code) for users whom been around awhile or we trust with having the privilege of running tests that arent run normally for normal tests (such as also [20:54:10] running gate and submit ontop of the normal tests, etc etc) [20:54:45] agh sorry again [20:55:05] releng requires you have 5+ changes merged before your eligible to be added to the whitelist [20:55:33] so now is that a blocker for the merging of the patches? [20:56:03] Zppix: yeah someone explained. I get it. There is a CPU cost so untrusted people can abuse the test trigger. [20:56:06] louperivois the layout of the commit msg? Yes. [20:56:35] mertyildiran nah, nodepool is meant to replace static instances which would allow us to remove the whitelist [20:56:43] but we are going the way of docker now :) [20:58:09] paladox: I don't fully understand but anyway no problem :) [20:58:25] louperivois oh wait, that's a new change you uploaded. [20:58:30] So the commit msg will be [20:58:57] https://phabricator.wikimedia.org/P5560 [20:59:01] louperivois ^^ [21:10:08] I managed to edit the commit files [21:14:31] (03PS2) 10Louperivois: HTMLSelectOrOtherField - no toggle with default option [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) [21:14:44] (03PS2) 10Louperivois: Allow CategoryPageView to set $mCategoryViewerClass [core] - 10https://gerrit.wikimedia.org/r/357899 (https://phabricator.wikimedia.org/T166483) [21:15:00] (03CR) 10Paladox: [C: 031] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) (owner: 10Louperivois) [21:15:12] (03PS2) 10Anomie: WIP: Add `comment` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/357892 (https://phabricator.wikimedia.org/T166732) [21:15:53] (03CR) 10Paladox: [C: 031] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/357899 (https://phabricator.wikimedia.org/T166483) (owner: 10Louperivois) [21:23:49] (03CR) 10jerkins-bot: [V: 04-1] HTMLSelectOrOtherField - no toggle with default option [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) (owner: 10Louperivois) [21:24:22] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add `comment` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/357892 (https://phabricator.wikimedia.org/T166732) (owner: 10Anomie) [21:24:31] (03CR) 10Paladox: [C: 04-1] HTMLSelectOrOtherField - no toggle with default option (031 comment) [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) (owner: 10Louperivois) [21:29:44] (03CR) 10Gergő Tisza: [C: 031] "Nitpick, feel free to ignore: skipTo is not a very intuitive name. Something like pageOffset would be more conventional IMO." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [21:29:52] (03CR) 10Gergő Tisza: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [21:30:44] (03PS3) 10Louperivois: HTMLSelectOrOtherField - no toggle with default option [core] - 10https://gerrit.wikimedia.org/r/357910 (https://phabricator.wikimedia.org/T166621) [21:46:37] (03PS8) 10Mertyildiran: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 [21:50:38] (03CR) 10Zppix: "recheck" [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [21:55:22] (03PS9) 10Mertyildiran: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 [21:56:59] (03CR) 10Mertyildiran: "I fixed the code upon Gergő Tisza's comments." [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [21:57:33] Zppix: Could you please call "recheck" again? [21:58:25] (03CR) 10Gergő Tisza: Add skipping to nth page option/ability for dump importing process (031 comment) [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [21:59:02] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [22:01:20] (03PS10) 10Mertyildiran: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 [22:02:49] (03CR) 10Mertyildiran: "omg I'm so sorry Gergő Tisza. I think it's correct now." [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [22:05:38] paladox: could you please run "recheck" one more time, hope it's last time :) [22:05:51] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [22:05:55] ok [22:05:57] *I hope it will be the last time :) [22:06:16] :) [22:10:44] (03CR) 10Aaron Schulz: Make refreshFileHeaders start parameter inclusive (031 comment) [core] - 10https://gerrit.wikimedia.org/r/357827 (owner: 10Gilles) [22:29:23] twentyafterfour: wanna put https://gerrit.wikimedia.org/r/#/c/336963/ out of its misery? :) [22:32:45] tgr: put it out of it's misery? [22:33:03] I was just re-reviewing it again, it seems like it should merge? [22:39:12] twentyafterfour: yeah I meant merge [22:39:43] I keep updating it every two weeks because of release note conflicts [22:40:23] and it blocks a bunch of ORES fixes [22:41:35] release note conflicts are a pain [22:41:37] I'll merge it [22:42:59] thx [22:43:37] (03CR) 1020after4: [C: 032] "The code looks sane to me, and it's been thoroughly reviewed by multiple competent reviewers. Time to JFDI." [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [22:56:35] (03CR) 10jerkins-bot: [V: 04-1] ChangesList: Expose basic properties of lines as data attributes [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [22:59:09] (03CR) 1020after4: [C: 031] "It seems like the review feedback has been addressed." [core] - 10https://gerrit.wikimedia.org/r/351146 (https://phabricator.wikimedia.org/T159753) (owner: 10Gergő Tisza) [23:00:23] tgr: looks like a test failed: [23:00:26] WfArrayFilterTest::testWfArrayFilter [23:00:38] https://integration.wikimedia.org/ci/job/mediawiki-phpunit-php55-trusty/5048/console [23:05:41] (03CR) 1020after4: "Test failure: EnhancedChangesListTest does not find any data attributes within the generated html." [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [23:06:23] (03CR) 1020after4: ChangesList: Expose basic properties of lines as data attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [23:07:18] (03CR) 1020after4: ChangesList: Expose basic properties of lines as data attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [23:07:35] test fails but only with php5.5 [23:11:54] twentyafterfour: could you also take a look to mine: https://gerrit.wikimedia.org/r/355738/ [23:12:08] mertyildiran: looking [23:12:21] twentyafterfour: great thank you so much! [23:16:22] (03CR) 1020after4: [C: 032] Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [23:18:20] (03CR) 1020after4: [C: 032] "This should prove to be a very helpful feature when something goes wrong. Thank you for contributing!" [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [23:19:40] oh, duh [23:19:58] (03PS15) 10Gergő Tisza: ChangesList: Expose basic properties of lines as data attributes [core] - 10https://gerrit.wikimedia.org/r/336963 [23:20:24] twentyafterfour: can I re-trigger that test somehow? [23:21:36] just comment "recheck" on gerrit [23:21:50] that should re-run the test, or it can be reran via jenkins [23:23:26] recheck does not trigger gate tests [23:25:54] oh, well... [23:26:05] I can rerun one via jenkins, hang on [23:28:03] blah. well I guess I can't rerun it [23:28:09] let's just try to merge again I guess? [23:29:38] (03CR) 1020after4: [C: 032] ChangesList: Expose basic properties of lines as data attributes [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [23:29:41] (03Merged) 10jenkins-bot: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [23:39:30] (03Merged) 10jenkins-bot: ChangesList: Expose basic properties of lines as data attributes [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza) [23:43:14] (03CR) 10jenkins-bot: Add skipping to nth page option/ability for dump importing process [core] - 10https://gerrit.wikimedia.org/r/355738 (owner: 10Mertyildiran) [23:48:26] tgr: congras, it merged ... [23:48:39] I mean .. congrats [23:49:07] mertyildiran: yours did too [23:49:33] twentyafterfour: yeah, thank you so much :) [23:52:17] mertyildiran: you're welcome. Thank you for your efforts! [23:54:14] (03CR) 10jenkins-bot: ChangesList: Expose basic properties of lines as data attributes [core] - 10https://gerrit.wikimedia.org/r/336963 (owner: 10Gergő Tisza)