[00:00:01] 6Collaboration-Team-Backlog, 10Echo: Don't show a bell if there is only one Echo icon in personal toolbar - https://phabricator.wikimedia.org/T112108#1668948 (10Catrope) 5Open>3declined a:3Catrope [00:09:19] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1669010 (10Catrope) 5Open>3declined a:3Catrope We should re-think which notification types are in which section, and the details of what exactly determines the distinc... [00:09:51] 6Collaboration-Team-Backlog, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1669013 (10Catrope) p:5Triage>3Normal [00:10:21] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Link creation dialog appears offscreen when editing flow board description. - https://phabricator.wikimedia.org/T111949#1669014 (10Catrope) [00:10:44] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Link creation dialog appears offscreen when editing flow board description. - https://phabricator.wikimedia.org/T111949#1620650 (10Catrope) This sounds like a bug in #VisualEditor or #OOUI [00:10:49] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Link creation dialog appears offscreen when editing flow board description. - https://phabricator.wikimedia.org/T111949#1669019 (10Catrope) p:5Triage>3Normal [00:11:00] 6Collaboration-Team-Backlog, 10Echo: Echo: Granular icons in the Notifications Badge - https://phabricator.wikimedia.org/T58476#1669020 (10Quiddity) [00:11:25] 6Collaboration-Team-Backlog, 10Flow: Mention suggestions drop down - the width size is not calculated correctly - https://phabricator.wikimedia.org/T111864#1669022 (10Catrope) p:5Triage>3Normal This might be an OOUI bug, but it could also be a bug in our code. [00:12:10] 6Collaboration-Team-Backlog, 10Echo: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1669026 (10Catrope) I think this happens because the initial version of the badge (before lazy-loading happens) is different from the OOUI version of the badge (after we've l... [00:12:45] 6Collaboration-Team-Backlog, 10Echo: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1669028 (10Catrope) p:5Triage>3Normal [00:12:59] 3Collaboration-Team-Current, 10Echo: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1668833 (10Catrope) [00:13:52] 6Collaboration-Team-Backlog, 10Flow: Switching Flow's editor-mode from VE to wikitext whilst a link inspector is open, makes the edit area fully collapse - https://phabricator.wikimedia.org/T113382#1669030 (10Catrope) p:5Triage>3Unbreak! [00:14:03] 3Collaboration-Team-Current, 10Flow: Switching Flow's editor-mode from VE to wikitext whilst a link inspector is open, makes the edit area fully collapse - https://phabricator.wikimedia.org/T113382#1663544 (10Catrope) [00:15:49] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Visiting Special:Notifications should not mark all Flow messages as read - https://phabricator.wikimedia.org/T97057#1669039 (10Catrope) [00:15:50] 6Collaboration-Team-Backlog, 10Echo: Echo: Visiting Special:Notifications should not change any notification's "read" status - https://phabricator.wikimedia.org/T111750#1669038 (10Catrope) [00:15:52] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1669041 (10DannyH) p:5Triage>3Normal [00:16:00] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an overview about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1669042 (10DannyH) p:5Triage>3Normal [00:16:13] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1669043 (10DannyH) p:5Triage>3Normal [00:16:42] 6Collaboration-Team-Backlog, 10Flow: Board description: cannot wrap text around images - https://phabricator.wikimedia.org/T111744#1669048 (10Catrope) p:5Triage>3Low [00:17:13] 6Collaboration-Team-Backlog, 10Thanks, 7JavaScript: Non-breaking spaces break page layout when confirming thanks in diff view - https://phabricator.wikimedia.org/T111735#1669056 (10Catrope) p:5Triage>3Normal [00:19:50] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Flow's elapsed Timestamp message at Lvwp, changes to an incorrect translation after loading is complete - https://phabricator.wikimedia.org/T110934#1669072 (10Catrope) [00:19:52] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1669073 (10Catrope) [00:20:06] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1611323 (10Catrope) See also {T102728} [00:20:15] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1669080 (10Catrope) p:5Triage>3Normal [00:20:56] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1669082 (10Catrope) [00:21:24] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Error after enabling flow on a page - https://phabricator.wikimedia.org/T111429#1669084 (10Catrope) p:5Triage>3Low [00:22:20] 6Collaboration-Team-Backlog, 10Flow: Installation of Flow on fr.wikt - https://phabricator.wikimedia.org/T73330#1669093 (10Catrope) p:5Triage>3Normal [00:22:42] 6Collaboration-Team-Backlog, 10Flow: Enable Flow on Wiktionnaire:Questions_sur_les_mots/Flow on frwiktionary - https://phabricator.wikimedia.org/T73330#1669095 (10Catrope) a:3DannyH [00:26:55] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1669112 (10He7d3r) Based on the timestamp, I believe I was trying to insert this link: https://pt.wikipedia.org/w/index.php?title=T%C3%B3pico:Sp1tjiviqo5e9uji&act... [00:30:57] RoanKattouw, he cut me off mid-story!! [00:31:19] rabblerabble! [00:31:51] haha [00:31:59] I was basically done anyway [00:41:02] (03CR) 10Catrope: [C: 04-1] EditTopicSummary widget (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:44:21] (03PS19) 10Catrope: EditTopicSummary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:44:30] (03CR) 10Catrope: [C: 032] EditTopicSummary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:44:41] (03PS3) 10Catrope: Show the wikitext editor first on the undo pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240019 (https://phabricator.wikimedia.org/T112338) (owner: 10Sbisson) [00:44:46] (03CR) 10Catrope: [C: 032] Show the wikitext editor first on the undo pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240019 (https://phabricator.wikimedia.org/T112338) (owner: 10Sbisson) [00:47:49] (03CR) 10Catrope: [C: 032] Prevent the badge icon from flashing red when updating notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) (owner: 10Mooeypoo) [00:48:19] (03Merged) 10jenkins-bot: EditTopicSummary widget [extensions/Flow] - 10https://gerrit.wikimedia.org/r/236870 (https://phabricator.wikimedia.org/T111102) (owner: 10Sbisson) [00:48:23] (03Merged) 10jenkins-bot: Show the wikitext editor first on the undo pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240019 (https://phabricator.wikimedia.org/T112338) (owner: 10Sbisson) [00:49:58] (03Merged) 10jenkins-bot: Prevent the badge icon from flashing red when updating notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240294 (https://phabricator.wikimedia.org/T112823) (owner: 10Mooeypoo) [00:51:21] (03PS18) 10Catrope: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [01:00:34] (03CR) 10Catrope: [C: 04-1] Add categories to the sidebar (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [01:14:43] (03PS1) 10Catrope: Make middle-clicking badge work [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240629 (https://phabricator.wikimedia.org/T113555) [01:14:51] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Middle/ctrl-clicking on Echo badge does not always work - https://phabricator.wikimedia.org/T113555#1669241 (10Catrope) a:3Catrope [01:14:56] (03CR) 10jenkins-bot: [V: 04-1] Make middle-clicking badge work [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240629 (https://phabricator.wikimedia.org/T113555) (owner: 10Catrope) [01:29:45] (03PS1) 10Catrope: Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) [01:35:18] (03CR) 10Catrope: [C: 032] Remove 'initiallyUnseen' class when the popup closes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240295 (owner: 10Mooeypoo) [01:37:40] (03Merged) 10jenkins-bot: Remove 'initiallyUnseen' class when the popup closes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240295 (owner: 10Mooeypoo) [03:09:21] 6Collaboration-Team-Backlog, 10Echo: Clicking on an item in the Echo menu doesn't mark them as read anymore - https://phabricator.wikimedia.org/T112477#1669498 (10Huji) >>! In T112477#1668755, @Catrope wrote: >>>! In T112477#1635889, @Huji wrote: >> It does take me to the page, but that does not result in the... [05:44:11] RoanKattouw_away: um, can you publish the comments on the Echo patch? :) [08:18:11] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per questions asked by Moriel." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/240175 (https://phabricator.wikimedia.org/T45481) (owner: 10Haritha28) [08:25:15] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) misisng - https://phabricator.wikimedia.org/T113574#1669857 (10Josve05a) 3NEW [09:11:49] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing - https://phabricator.wikimedia.org/T113574#1669944 (10zhuyifei1999) [09:12:06] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing or shown inconsistently with custom CSS - https://phabricator.wikimedia.org/T113574#1669947 (10Aklapper) [09:21:54] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1669964 (10Trizek-WMF) [09:21:56] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1669966 (10Trizek-WMF) [09:21:58] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an overview about Flow, with most important things to know about - https://phabricator.wikimedia.org/T111528#1669962 (10Trizek-WMF) 5Open>3Resolved [[https://www.mediawiki.org/wiki/Flow/Quick_tour|Created]], and marked for translation. [09:26:58] 6Collaboration-Team-Backlog, 10Echo, 6Commons: Notifications icon(s) missing or shown inconsistently with custom CSS - https://phabricator.wikimedia.org/T113574#1669973 (10Josve05a) [09:36:21] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1669997 (10Trizek-WMF) [09:37:35] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about Topics: Edit a topic/a message, Summarize a topic, Resolve a topic - https://phabricator.wikimedia.org/T113578#1670000 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:38:09] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about permalinks - https://phabricator.wikimedia.org/T113580#1670014 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:38:44] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow history system - https://phabricator.wikimedia.org/T113581#1670021 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:39:23] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow's administration - https://phabricator.wikimedia.org/T113582#1670028 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:40:13] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1670035 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:40:36] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about permalinks - https://phabricator.wikimedia.org/T113580#1670042 (10Trizek-WMF) [09:40:43] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Topics: Edit a topic/a message, Summarize a topic, Resolve a topic - https://phabricator.wikimedia.org/T113578#1670044 (10Trizek-WMF) [09:41:28] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow's administration - https://phabricator.wikimedia.org/T113582#1670049 (10Trizek-WMF) >>! In T111367#1604435, @Mattflaschen wrote: > See https://www.mediawiki.org/wiki/Extension:Flow#Moderation for part of this. [10:04:01] 6Collaboration-Team-Backlog, 10Flow: Resolving a topic that has an existing summary, forces to save the summary (there's no cancel button) - https://phabricator.wikimedia.org/T113585#1670096 (10Ciencia_Al_Poder) 3NEW [10:06:06] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 7Design: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#1670115 (10Pginer-WMF) 3NEW [10:07:12] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 7Design: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#1670123 (10Pginer-WMF) [10:24:00] 6Collaboration-Team-Backlog, 10Flow: "Update summary" is enabled before entering text after Mark as resolved - https://phabricator.wikimedia.org/T103928#1670160 (10Ciencia_Al_Poder) [10:24:31] 6Collaboration-Team-Backlog, 10Flow: "Update summary" is enabled before entering text after Mark as resolved - https://phabricator.wikimedia.org/T103928#1402857 (10Ciencia_Al_Poder) This also happens when editing a topic title [10:25:50] 6Collaboration-Team-Backlog, 10Flow: "Update summary" is enabled before entering text after Mark as resolved - https://phabricator.wikimedia.org/T103928#1670169 (10Ciencia_Al_Poder) [11:02:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Switching Flow's editor-mode from VE to wikitext whilst a link inspector is open, makes the edit area fully collapse - https://phabricator.wikimedia.org/T113382#1670268 (10SBisson) a:3Catrope [11:03:32] 3Collaboration-Team-Current, 10Flow, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1670277 (10SBisson) The discussed solution is to "Add text to move log item during opt-in process to explain better" [11:04:10] 3Collaboration-Team-Current, 10Flow, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1670279 (10SBisson) [11:04:12] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add text to move log item during opt-in process to explain better - https://phabricator.wikimedia.org/T113500#1670278 (10SBisson) [11:04:35] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Add text to move log item during opt-in process to explain better - https://phabricator.wikimedia.org/T113500#1670287 (10SBisson) [11:51:51] (03CR) 10Sbisson: [C: 032] Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [11:55:33] (03CR) 10jenkins-bot: [V: 04-1] Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [11:59:19] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [12:11:47] 6Collaboration-Team-Backlog, 10Echo: Thanks notification should have link to page in popup, like it does in Special:Notifications - https://phabricator.wikimedia.org/T112283#1670420 (10IKhitron) I see. So, I just never payed attention to this part. Thank you. [12:45:52] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1670538 (10SBisson) Edit post now uses the new editor and that should be fixed. [12:46:04] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1670539 (10SBisson) [12:54:13] 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Tweak LQT->Flow import code to support a mode where LQT is enabled by default - https://phabricator.wikimedia.org/T107634#1670563 (10SBisson) Is this the same as {T107634} ? [12:58:08] 6Collaboration-Team-Backlog, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1670576 (10SBisson) This should be fixed now. [12:58:21] 3Collaboration-Team-Current, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1670577 (10SBisson) [14:09:49] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7Testme: Line height is too low, text appears cramped in Special:Notifications - https://phabricator.wikimedia.org/T73358#1670706 (10matej_suchanek) [14:43:16] 3Collaboration-Team-Current, 10Flow: Opt-in: Copy templates above the first heading when enabling Flow on an existing wikitext page - https://phabricator.wikimedia.org/T113426#1670855 (10SBisson) a:3SBisson [15:37:04] Google Summer of Code showcase is in #wikimedia-office if anyone is interested. [15:38:44] I co-mentored happy5214 on Pywikibot-Flow. [15:53:27] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 2 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1671049 (10matthiasmullie) a:3matthiasmullie [15:58:32] (03PS1) 10Sbisson: Optin: Copy templates before first heading from talk page to Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) [15:59:35] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1671099 (10Pginer-WMF) > Defining the "norm" is going to be hard. Yes. I agree that it is unrealistic to aim for a metric that perfectly reflect users intents (n... [15:59:59] 6Collaboration-Team-Backlog, 10Echo, 10Flow: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1671102 (10Pginer-WMF) [16:00:01] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1671101 (10Pginer-WMF) [16:10:02] (03PS1) 10Matthias Mullie: Add reasons when moving pages during optin process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) [16:10:33] 6Collaboration-Team-Backlog, 10Echo: Re-merge the split Echo icons if I disable Flow mentions - https://phabricator.wikimedia.org/T112107#1671124 (10Nemo_bis) My workaround is ```li#pt-notifications-message, li#pt-notifications-alert { display: none; }``` in my global.css. [16:11:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1671125 (10matthiasmullie) Patch is up. I'm bad with copy, so feel free to improve these move reasons:... [16:12:53] pginer, I hope I didn't spam too much in that ticket with my humongous example, but I hope it helps? [16:13:25] (03PS4) 10Matthias Mullie: Get rid of $wgFlowMigrateReferenceWiki [extensions/Flow] - 10https://gerrit.wikimedia.org/r/232465 (https://phabricator.wikimedia.org/T108104) [16:14:17] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:18:25] (03PS2) 10Matthias Mullie: Add reasons when moving pages during optin process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) [16:18:33] (03CR) 10Matthias Mullie: Add reasons when moving pages during optin process (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:24:19] (03CR) 10Matthias Mullie: Add reasons when moving pages during optin process (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:24:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:40:29] mooeypoo, it’s definitely helpful, and it relates to one of the key questions we need to figure out. I’ll add more details in the ticket. [16:44:55] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1671266 (10DannyH) Here are some screenshots from Wikia's cross-wiki notifications: {F2631489} {F2631491} {F2631494} [16:51:43] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1671314 (10Etonkovidova) Checked in betalabs - the link to User tall:[user name]/Archive 1 is alway... [16:52:44] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1671319 (10Etonkovidova) Checked in betalabs. And T113525: [betalabs] enwiki - ref_src_wiki colu... [16:53:08] (03CR) 10Sbisson: [C: 032] Add reasons when moving pages during optin process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:54:36] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [16:55:37] (03Merged) 10jenkins-bot: Add reasons when moving pages during optin process [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240734 (https://phabricator.wikimedia.org/T111220) (owner: 10Matthias Mullie) [16:58:12] (03PS2) 10Sbisson: Optin: Copy templates before first heading from talk page to Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) [16:58:54] (03CR) 10Sbisson: Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [16:58:59] (03CR) 10Sbisson: [C: 032] Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [17:01:04] (03CR) 10jenkins-bot: [V: 04-1] Optin: Copy templates before first heading from talk page to Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) (owner: 10Sbisson) [17:02:23] 6Collaboration-Team-Backlog, 10Echo: Measure the number of different wikis from which users have unread notifications - https://phabricator.wikimedia.org/T113626#1671377 (10Pginer-WMF) 3NEW [17:04:53] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1671411 (10Pginer-WMF) [17:11:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): Link to archived wikitext page isn't added when opting in for 2nd time - https://phabricator.wikimedia.org/T112784#1671457 (10DannyH) 5Open>3Resolved [17:11:47] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1671458 (10DannyH) [17:11:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Fix toggling Flow to false in BetaFeatures (opt-out) - https://phabricator.wikimedia.org/T111830#1671459 (10DannyH) 5Open>3Resolved [17:11:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1671460 (10DannyH) [17:12:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), 7WorkType-NewFunctionality: Opt-in: Guided tour on user talk for first visit to new Flow board - https://phabricator.wikimedia.org/T108266#1671463 (10DannyH) [17:12:04] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23), and 2 others: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1671461 (10DannyH) 5Open>3Resolved Hooray, well done! [17:13:17] (03CR) 10jenkins-bot: [V: 04-1] Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [17:13:54] quiddity: https://phabricator.wikimedia.org/T112940#1668619 [17:18:05] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: Don't show "Mark all as read" for Alerts - https://phabricator.wikimedia.org/T113629#1671510 (10DannyH) 3NEW [17:18:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Marking a Flow topic as unresolved creates "cur" links that give Fatal exceptions - https://phabricator.wikimedia.org/T113261#1671525 (10DannyH) 5Open>3Resolved [17:18:33] 3Collaboration-Team-Current, 10Echo, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification - https://phabricator.wikimedia.org/T55564#1671528 (10DannyH) 5Open>3Resolved [17:18:36] 3Collaboration-Team-Current, 10Echo: When marking an unread notification "read" it should be pushed downwards, under the read notifications - https://phabricator.wikimedia.org/T113630#1671531 (10Mooeypoo) 3NEW [17:18:40] 3Collaboration-Team-Current, 10MediaWiki-extensions-GettingStarted, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24): GettingStarted issue with less.php - https://phabricator.wikimedia.org/T113313#1671538 (10DannyH) 5Open>3Resolved [17:18:45] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 3 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1671541 (10DannyH) 5Open>3Resolved a:3DannyH [17:26:49] 3Collaboration-Team-Current, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1671614 (10Quiddity) > So...what is set in your preferences for timezone? Defaults, I think: {F26315... [17:28:32] 3Collaboration-Team-Current, 10Echo, 10Flow: One account getting "Exception encountered, of type "Exception" " on certain pages from Echo and Flow at mediawiki.org - https://phabricator.wikimedia.org/T112940#1671624 (10Quiddity) [17:30:10] lol [17:30:25] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Echo notifications: when updating Alerts display red momentarily before switching to gray - https://phabricator.wikimedia.org/T112823#1671642 (10Etonkovidova) Checked in betalabs. [17:30:27] legoktm, matt_flaschen ping standup [17:30:55] legoktm, and yeah.. idk! [17:34:39] (03CR) 10Catrope: [C: 032] "Per Stephane" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [17:36:02] (03PS2) 10Catrope: Make middle-clicking badge work [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240629 (https://phabricator.wikimedia.org/T113555) [17:36:33] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) (owner: 10Sbisson) [17:38:06] (03CR) 10Catrope: [C: 04-1] [WIP] Clean up and refactor formatting system (0317 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/232632 (https://phabricator.wikimedia.org/T107823) (owner: 10Legoktm) [17:39:25] legoktm: Comments published, sorry [17:39:31] ty [17:48:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1671748 (10Mattflaschen) a:5Mattflaschen>3Catrope [17:48:59] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 7WorkType-NewFunctionality: Convert LQT->Flow on se.wikimedia.org - https://phabricator.wikimedia.org/T106302#1671753 (10Catrope) a:3Mattflaschen [17:49:30] 3Collaboration-Team-Current, 10Echo: When marking an unread notification "read" it should be pushed downwards, under the read notifications - https://phabricator.wikimedia.org/T113630#1671762 (10DannyH) 5Open>3declined a:3DannyH [17:51:33] matt_flaschen fyi, we may also convert pt.wikibooks -- they're currently discussing. That's the only remaining big one -- I think 5k LQT pages. [17:52:55] (03CR) 10jenkins-bot: [V: 04-1] Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [17:55:41] 3Collaboration-Team-Current, 10Echo, 7WorkType-NewFunctionality: Don't show "Mark all as read" for Alerts - https://phabricator.wikimedia.org/T113629#1671815 (10Mooeypoo) a:3Mooeypoo [18:12:47] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Have 'flow-suppress' work on MediaWiki-Vagrant out of the box - https://phabricator.wikimedia.org/T113641#1671975 (10Mattflaschen) 3NEW [18:16:33] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [18:17:51] (03PS1) 10Catrope: Add better debug info for FlowFixLinks.php failure [extensions/Flow] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240776 [18:17:54] (03CR) 10Mooeypoo: Add categories to the sidebar (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [18:19:04] mooeypoo: "The link caption should be Category:Foo to be consistent with the current MW behavior" [18:19:09] mooeypoo: WTF? Where do you see that? [18:19:47] meh, I saw it before. Am I wrong? [18:20:13] (03CR) 10Catrope: Add categories to the sidebar (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) (owner: 10Mooeypoo) [18:20:41] mooeypoo: I don't know, but I remember it differently. IIRC it was "Categories: Foo | Bar | Baz" [18:20:50] But, anyway, show me, and we'll see who's right :) [18:21:05] RoanKattouw, no, you're right, I just double checked. I'm not sure where I saw it [18:21:23] (03CR) 10jenkins-bot: [V: 04-1] Add better debug info for FlowFixLinks.php failure [extensions/Flow] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240776 (owner: 10Catrope) [18:28:48] stephanebisson, your patch looks great, but my browser tests for optin are failing locally because of the issue of going to the talk page "too fast" -- just when it's not moved yet :\ [18:28:59] (03Merged) 10jenkins-bot: Work around JS error when switching editors while an inspector is open [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240631 (https://phabricator.wikimedia.org/T113382) (owner: 10Catrope) [18:30:01] mooeypoo: damn [18:30:23] mooeypoo: next time I have a race condition to troubleshoot, can I borrow your laptop? [18:30:40] stephanebisson, I'll give it to you very quickly [18:30:53] There's another failure I'm intercepting, hang on [18:33:19] stephanebisson, http://pastebin.com/i6d09TVb [18:33:53] :\ [18:34:30] mooeypoo: indeed [18:34:37] stephanebisson, since it seems these errors only REALLY consistently happen on my local installation -- do you want me to consider them less urgent, and merge as is? it seems these tests will consistently fail for me [18:34:43] but they don't for 99% of everyone else [18:34:48] I just can't validate, though [18:35:25] dannyh said that in his tests on test.wikipedia.org he encountered this "bug" once out of 15+ attempts. [18:36:12] it was the first one, if that helps, and then all the rest were fine. I did a few more yesterday and they were all fine too. [18:36:37] It seems like it happens but most of production is fast enough to not make it an issue [18:36:39] mooeypoo: I think we could merge as is, but I also think that we should fix the test so it works for you as well [18:36:50] stephanebisson, ok but the fix can be a followup [18:37:08] stephanebisson, right now I'm trying to figure out why qunit fails on that patch... seems to be something unrelated? getWikitext from VE ? [18:37:12] mostly to promote 'good behaviour' (i.e.. running the tests) [18:37:19] stephanebisson, indeed [18:37:47] qunit has been failing >50% of the time for me since yesterday [18:38:08] (03CR) 10Mooeypoo: [C: 032] "LGTM and works great" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) (owner: 10Sbisson) [18:38:15] doesn't seem to be related to the patches themselves [18:38:16] RoanKattouw says +2 and see what happens. [18:38:41] no, it can't be, it's qunit and you didn't touch anything that relates to any js tests, I don't think. Not in VE for sure [18:39:30] Yeah there have been lots of qunit failures due to Chrome timing out [18:39:47] Oh, is this the problem of the recent upgrade? [18:40:05] Maybe? [18:40:14] No I think that was fixed [18:40:17] That was the localStorage error [18:40:41] (03CR) 10Sbisson: "Big orange notices on recentchanges currently prevent local testing of this patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/182400 (owner: 10Spage) [18:44:14] stephanebisson, just curious, what do the orange notices say? [18:44:46] matt_flaschen: Undefined offset: 0, Undefined offset: -1 [18:45:02] Hmm [18:45:17] I thought it was what you were working on... [18:45:24] (03Abandoned) 10Mattflaschen: QA: "should be in RecentChanges" in more scenarios [extensions/Flow] - 10https://gerrit.wikimedia.org/r/182400 (owner: 10Spage) [18:45:48] stephanebisson, https://phabricator.wikimedia.org/T111494 ? No connection that I know of. [18:51:07] matt_flaschen: I don't see anything out of place on recentchanges in beta or mw.org but that doesn't mean much... I will investigate those notices [18:51:55] (03CR) 10Catrope: [C: 032 V: 032] Add better debug info for FlowFixLinks.php failure [extensions/Flow] (wmf/1.26wmf24) - 10https://gerrit.wikimedia.org/r/240776 (owner: 10Catrope) [18:52:20] stephanebisson, it could be something doing: if ( $arr[$ind] ) {} . Should still definitely be fixed. Don't know if it's new, though. [18:53:16] matt_flaschen: I saw it just a few days ago. It breaks recentchanges tests, which I run every day [18:55:34] stephanebisson, could be https://phabricator.wikimedia.org/T9148 . (It was done a while ago, reverted, then it's started being merged again, e.g. https://gerrit.wikimedia.org/r/#/c/239061/2 ). [18:56:03] Doesn't look like it would cause it, but maybe I'm missing something, and there might be a related patch that's not in that last comment (https://phabricator.wikimedia.org/T9148#1648605) [18:58:55] (03PS1) 10Mattflaschen: Grant 'flow-suppress' to the 'suppress' group as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240785 (https://phabricator.wikimedia.org/T113641) [18:59:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1672140 (10Catrope) I deployed Matthias's debugging patch (https://gerrit.wikimedia.org/r/#/c/240439/) and t... [18:59:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1672141 (10Catrope) a:5Catrope>3matthiasmullie [19:00:17] mlitn: I reran FlowFixLinks.php with your debugging patch and I got this: https://phabricator.wikimedia.org/T110326#1672140 [19:00:37] I tried doing var_dump($wgMemc->get('flowdb:flow_ref:wiki:by-source:v3:Parser\'s_"broken"_ _(page)_&_grill:testwiki:1:4.7')); but that doesn't return anything [19:01:23] 3Collaboration-Team-Current, 10Flow: Notification: the counter for Messages that come from updates on User talk page in wikitext is not updated correctly. - https://phabricator.wikimedia.org/T113645#1672143 (10Etonkovidova) 3NEW a:3Mooeypoo [19:01:41] (03CR) 10Catrope: [C: 032] Grant 'flow-suppress' to the 'suppress' group as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240785 (https://phabricator.wikimedia.org/T113641) (owner: 10Mattflaschen) [19:03:55] 6Collaboration-Team-Backlog, 10Flow: Flow overlay not going away - https://phabricator.wikimedia.org/T111624#1672164 (10Rical) For me the bug is the same when I logout, update the cache and restart Firefox. [19:08:26] (03Merged) 10jenkins-bot: Optin: Copy templates before first heading from talk page to Flow board [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240729 (https://phabricator.wikimedia.org/T113426) (owner: 10Sbisson) [19:08:54] (03Merged) 10jenkins-bot: Grant 'flow-suppress' to the 'suppress' group as well [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240785 (https://phabricator.wikimedia.org/T113641) (owner: 10Mattflaschen) [19:16:42] RoanKattouw_away: I assume https://gerrit.wikimedia.org/r/#/c/235458/ has been deployed already? [19:19:26] yeah, it is [19:23:46] matt_flaschen: it turns out my mediawiki repo was not up to date, even though I run `vagrant git-update` every day [19:23:52] matt_flaschen: notices: gone [19:24:34] Nice [19:26:14] It is supposed to update MW core. The most common reason it doesn't update repos (either core, extension, or whatever) for me is that another branch is checked out. [19:30:55] yeah, I'll double-check next time [19:35:02] RoanKattouw_away: that key looks suspicious with the space in there [19:35:12] looks like that space is a + in the title [19:35:20] var_dump($wgMemc->get('flowdb:flow_ref:wiki:by-source:v3:Parser\'s_"broken”_+_(page)_&_grill:testwiki:1:4.7')); [19:35:24] this yields a result [19:36:03] Flow or some BagOStuff does some inconsistent encoding, it seems [19:36:17] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Null edits should not be saved in posts, topic titles, descriptions, summaries - https://phabricator.wikimedia.org/T60975#1672254 (10SBisson) a:3SBisson [19:36:23] I can look at it more tomorrow ;) [19:36:25] RoanKattouw_away, mooeypoo: https://grafana.wikimedia.org/#/dashboard/db/echoflyout if you set the view time to day, there's a pretty significant jump in the overlay timing graph after the wmf24 deploy [19:44:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-09-22_(1.26wmf24), 7WorkType-NewFunctionality: Run maintenance/FlowFixLinks.php - https://phabricator.wikimedia.org/T110326#1672284 (10matthiasmullie) that key looks suspicious with the space in there looks like that space is a + in... [19:53:07] * mooeypoo mutters about calling it a popup [19:53:51] legoktm, RoanKattouw_away this isn't surprising, though. We're loading OOUI, which we didn't before. The timing counts from click (before ooui is loaded) to full rendering of the notifications after getting it from the API [19:54:16] legoktm, do you want to add an intemediate timing check, after we load ooui but before we get the results rendered? [19:54:37] actually, we'll need two timers for that, since the API request is sent alongside the ooui load [19:55:12] legoktm, also, what's the difference between the unseen flyout and echo overlay timing? [20:02:01] Yeah I think that's probably due to lazy-loading [20:02:18] It's just pushing the cost of loading OOUI into the popup opening stage [20:05:16] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1672339 (10He7d3r) Actually, this just happened again on MW.org. I wrote a comment using the wikitext editor in a flow page, then I previewed my edit, and then I... [20:09:51] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1672358 (10Catrope) >>! In T112879#1672339, @He7d3r wrote: > Actually, this just happened again on MW.org. I wrote a comment¹ using the wikitext editor in a flow... [20:21:14] (03PS19) 10Mooeypoo: Add categories to the sidebar [extensions/Flow] - 10https://gerrit.wikimedia.org/r/230017 (https://phabricator.wikimedia.org/T92874) [20:27:37] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1672451 (10Mattflaschen) [20:31:51] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1672479 (10He7d3r) 1. Open https://www.mediawiki.org/w/index.php?title=Talk:Flow_QA&action=new-topic 2. Type a title "test" 3. Type "`a[]`" (using VisualEditor) 4... [20:33:09] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Flow opt in process takes long enough to process for the user to actually notice - https://phabricator.wikimedia.org/T111220#1672484 (10Etonkovidova) Checked in betalabs( including the case when Beta 'Flow on user talk' is enabl... [20:36:37] "memcached: recommended or required?" - "The docs currently say both. If memcached is not an option, would Flow be out of the question?" https://www.mediawiki.org/wiki/Topic:Sph8at0chmdngan2 [20:37:22] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1672519 (10Etonkovidova) Checked in betalabs - as a general regression testing. [20:37:30] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1672520 (10Catrope) Thanks, I can reproduce that now, but only in Firefox. Will investigate. [20:43:15] 3Collaboration-Team-Current, 10Flow: Summarize: switching to wikitext mode displays old style icon - https://phabricator.wikimedia.org/T111984#1672545 (10Etonkovidova) Checked in betalabs. [20:47:52] matt_flaschen, re: pywikibot - Do various bot owners who use pywikibot, need to individually add code blocks to each of their bots? Or, will the functionality (detailed at https://www.mediawiki.org/wiki/Manual:Pywikibot/Flow) all automagically work if they're using uptodate pywikibot code? [20:47:52] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1672567 (10Mattflaschen) [20:48:52] (I'm trying to figure out what to say in the docs, and in various onwiki discussions. :) [20:51:09] quiddity, yes, they have to individually add it. [20:51:16] ok, thanks :) [20:52:00] quiddity, on the plus side, there is already some Flow functionality exposed in Pywikibot that on-wiki discussions don't even have, such as infinite topic list (without worrying about finding the archive page) and resolving/unresolving topics (good for an auto-resolve bot). [20:52:37] I also replied re memcached. [20:53:35] ty. :) I've updated https://www.mediawiki.org/w/index.php?title=Flow/Architecture/API&diff=1899123&oldid=1852702 [20:53:48] udpate* >.< [20:55:23] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Schema-change, 7WorkType-Maintenance: Separate reference tables by wiki - https://phabricator.wikimedia.org/T107204#1672589 (10Mattflaschen) [20:55:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-Maintenance: Set wgFlowMigrateReferenceWiki to false in production - https://phabricator.wikimedia.org/T113245#1672588 (10Mattflaschen) [20:55:28] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1672587 (10Mattflaschen) 5Resolved>3Open [20:55:30] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1593860 (10Mattflaschen) a:5DannyH>3None [20:55:34] 6Collaboration-Team-Backlog, 10Flow: Enable Flow on Wiktionnaire:Questions_sur_les_mots/Flow on frwiktionary - https://phabricator.wikimedia.org/T73330#1672592 (10DannyH) 5Open>3Resolved Done at last -- please contact me on Mediawiki.org if I can help with anything else. https://www.mediawiki.org/wiki/Us... [20:55:49] mooeypoo: the "unseen flyout" one is people who are served a page with unseen notifications vs people who click on the flyout when they have unseen notifications, to see whether preloading is worth it [21:01:02] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1672606 (10Mattflaschen) From production slaves: Got credentials using: ``` $factory = Flow\Co... [21:01:32] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Do backfill and final schema change for "Segregate Reference objects by source wiki." - https://phabricator.wikimedia.org/T111084#1672608 (10Mattflaschen) [21:04:50] 6Collaboration-Team-Backlog: [enwiki-betalabs] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1672624 (10Etonkovidova) 3NEW [21:24:13] mooeypoo: the line `myWidget.popup.toggle( true );` is what shows the popup on initial click right? [21:24:25] legoktm, yep [21:24:51] the notifications may be resolved *before* though... as.... we just saw in beta, of all places [21:25:03] I'm seeing the notifications resolve before locally too [21:25:08] (03PS1) 10Mooeypoo: Update seen time only if the popup is actually open [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240899 (https://phabricator.wikimedia.org/T113645) [21:25:13] RoanKattouw, ^^ [21:25:19] Object { key: "MediaWiki.echo.overlay.api", value: "1448ms" } [21:25:19] Object { key: "MediaWiki.echo.overlay", value: "1829ms" } [21:25:19] Object { key: "MediaWiki.echo.overlay.ooui", value: "1853ms" } [21:25:48] .api is how long it takes the API request to resolve, .overlay is time to see notifications, .ooui is time to flyout opening [21:26:00] yeah it makes sense, especially on first click [21:26:10] the api request and load-ooui request are sent in parallel [21:26:18] the api may be resolved before the ooui load [21:26:40] also, we should really normalize our naming of all these things. [21:26:50] >.> [21:26:52] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7JavaScript: "TypeError: cur is null" in jQuery - https://phabricator.wikimedia.org/T112879#1672727 (10Catrope) This appears to be a bug in jQuery. There's a paste event whose `.target` is a text node, and the corresponding jQuery event has a `.target` o... [21:27:01] 6Collaboration-Team-Backlog, 10Echo: Measure the notification types that are most abundantly received at 5 sample wikis - https://phabricator.wikimedia.org/T113664#1672728 (10Quiddity) 3NEW [21:27:02] flyout, overlay, popup... [21:27:11] so our current stats could easily be wrong [21:27:19] flyout doesn't exist anymore, overlay is a different concept altogether in ooui (that we're going to use soon) and popup is what it actually is [21:27:23] mooeypoo: when I use hhvm instead of zend -which I use for php debugging- I can reproduce the optin race condition [21:27:37] legoktm, not necessarily wrong, just misleading. We need to understand what each stats means [21:27:39] (03PS1) 10Sbisson: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [21:27:50] mooeypoo: ^ just for you [21:27:52] stephanebisson, I don't *think* I have hhvm? [21:28:27] mooeypoo: I think that's what you have by default in mw-vagrant [21:28:29] ooh there's refresh_until [21:28:33] stephanebisson, does it have a timeout? [21:28:43] mooeypoo: *now* there's refresh_until [21:28:47] mooeypoo: right...it's just not actually measuring what I want it to measure. [21:29:02] stephanebisson, yes, happy birthday, refresh_until! [21:29:05] ;) [21:29:06] using built-in PageObject.default_page_wait [21:29:34] stephanebisson, ah, I just saw it in the code [21:29:35] awesome [21:29:37] I'm going to test [21:29:47] legoktm, what do you want to measure? [21:30:03] time from click -> user seeing notifications [21:30:23] legoktm,that would be time to ooui popup.toggle( true ) [21:30:33] legoktm, oh ,wait, no no [21:30:34] you're right [21:30:37] hm [21:30:45] you might ahve a popup that is still in the process of loading. [21:30:48] mooeypoo: there is still a theoretical race condition where the board is there but the description hasn't been edited yet but I'm willing to cross that bridge when we get there [21:30:58] * mooeypoo nods [21:31:02] stephanebisson, testing now [21:31:03] (03CR) 10jenkins-bot: [V: 04-1] Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [21:33:30] (03PS1) 10Legoktm: Add intermediate metrics for API and ext.echo.ui loading response times [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240903 [21:33:39] mooeypoo: ^ next in line :P [21:33:56] stephanebisson, eh, some pass, some still fail [21:34:04] hang on, pastebinning [21:34:42] stephanebisson, http://pastebin.com/fTtXUK10 [21:36:10] mooeypoo: review: command not found [21:36:26] not clear if you really downloaded the patch [21:36:27] stephanebisson: review is her alias for git review -d [21:36:58] it still complains that 'review' is not found [21:37:37] Oh in her pastebin! [21:37:39] I see [21:37:50] That's because I am using it inside vagrant [21:37:50] Her review alias doesn't exist inside of vagrant [21:37:54] vagrant@mediawiki-vagrant:/vagrant/mediawiki/extensions/Flow/tests/browser$ review 230017 [21:37:55] No command 'review' found, but there are 18 similar ones [21:37:57] review: command not found [21:38:02] sorry hang on hang on [21:38:07] I *pasted* too much [21:38:08] but wait, also something wrong in the patch [21:38:14] that mistake with review XXX was earlier. [21:38:24] I forgot I was inside vagrant. I downloaded the patch outside of vagrant then [21:38:27] and ran the tests [21:38:36] let me re-paste the results, I didn't notice I was pasting everything [21:39:23] stephanebisson, update that pastebin http://pastebin.com/fTtXUK10 [21:39:28] refresh* [21:39:52] legoktm, I'm not sure your patch does it either... I think the safer way is to put the 'when everything is visible' inside the badge widget [21:40:29] legoktm, i was dealing with the same phenomenon (api resolving quicker than ooui load) in this patch, and I think the logger should probably go there: https://gerrit.wikimedia.org/r/#/c/240899/1/modules/ooui/mw.echo.ui.NotificationBadgeWidget.js [21:40:56] wait no.. crap, tht's only triggered once the popup is loaded. [21:40:57] meh [21:41:16] mooeypoo: I didn't try to fix it, I just added two new intermediate stages and added a FIXME comment [21:41:35] stephanebisson, if you want, you can disable the Zend role (so you're normally testing in a more-like-production mode), then use http://php5.local.wmftest.net:8080 when you want to use XDebug. [21:41:40] legoktm, yeah no i know, i'm just trying to figure out if that place is actually representing what we want [21:43:08] legoktm, okay, I think that's right in the sense that we will get timing for ooui load, api request, and popup showing [21:43:36] but we will have to then analyze the durations of those to actually see when the user had the "final state" of all notifications displayed, which I think should probably be in the widget itself. [21:43:38] (03PS2) 10Sbisson: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [21:43:42] mooeypoo: ^ [21:43:50] I am merging but we probably need to figure it out more broadly [21:44:59] 3Collaboration-Team-Current, 10Flow: 'View a restore deleted pages' displays broken layout for deleted Flow pages - https://phabricator.wikimedia.org/T113668#1672791 (10Etonkovidova) 3NEW [21:45:01] mooeypoo: the final state should be max(.overlay, .ooui) right? [21:45:13] 3Collaboration-Team-Current, 10Flow: 'View and restore deleted pages' displays broken layout for deleted Flow pages - https://phabricator.wikimedia.org/T113668#1672798 (10Etonkovidova) [21:45:38] matt_flaschen: I did not know that, thanks! [21:45:43] legoktm, max( overlay, ooui, api) [21:45:57] No problem. [21:46:09] legoktm, oh, no, you're right, in your new fix [21:46:15] something's up with me today [21:46:17] .api will always come before .overlay [21:46:19] (03PS3) 10Catrope: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [21:46:19] ok :) [21:46:30] (03CR) 10Catrope: [C: 032] Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [21:52:31] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 2 others: Can no longer view deleted board in Special:Undelete - https://phabricator.wikimedia.org/T110696#1672810 (10Etonkovidova) 1) Clicking 'Show changes' on http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Undelete&... [21:55:55] stephanebisson, we're making progress. It's failing on archive name [21:56:15] mooeypoo: where exactly [21:56:23] http://pastebin.com/2h8TcQRs [21:56:38] expecting "Flow Archive 1" and getting "Archive 1" [21:56:57] and another failure for "this is the content..." [21:58:25] let me deal with :31 first [21:58:58] :38 is weird: User does not have the "Create Flow boards in any location" permission (invalid-page) [22:02:03] Do I need to add something to settings, maybe? [22:03:53] you shouldn't have to [22:08:25] (03PS4) 10Sbisson: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [22:08:45] (03CR) 10Catrope: [C: 032] Update seen time only if the popup is actually open [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240899 (https://phabricator.wikimedia.org/T113645) (owner: 10Mooeypoo) [22:08:53] mooeypoo: ^ that's for :31 [22:09:07] bundle exec cucumber features/opt_in.feature:31 [22:10:09] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Editing posts: Keep input focus when switching from VE to wikitext editing - https://phabricator.wikimedia.org/T110093#1672908 (10Etonkovidova) Checked in betalabs. - When switching between editing modes the behavior of cursor placement is con... [22:10:20] stephanebisson, passes! [22:10:34] mooeypoo: multiple times please ;) [22:12:32] mooeypoo: https://gerrit.wikimedia.org/r/240629 [22:12:37] stephanebisson, passes x 3 [22:13:22] good [22:14:35] (03Merged) 10jenkins-bot: Update seen time only if the popup is actually open [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240899 (https://phabricator.wikimedia.org/T113645) (owner: 10Mooeypoo) [22:16:15] (03PS5) 10Sbisson: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [22:16:20] mooeypoo: ^ for :38 [22:17:35] (03PS6) 10Sbisson: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [22:17:54] stephanebisson, fails :\ http://pastebin.com/EJFfKVAu [22:18:29] but that seems to be the timeout [22:18:34] maybe if I make it longer [22:18:45] I actually saw the correct page refresh, but it may have been too late [22:20:59] 10s should be plenty [22:21:08] but you can export PAGE_WAIT_TIMEOUT=30 just to see [22:24:10] hm [22:24:31] passed once, failed second time on [22:24:32] Then my talk page is my old Flow board # features/step_definitions/opt_in_steps.rb:85 [22:24:33] expected "Template:Template before first heading" to match "User talk:New user 79344479948377508558003730888325233389/Archive 1" (RSpec::Expectations::ExpectationNotMetError) [22:24:33] ./features/step_definitions/opt_in_steps.rb:90:in `block (2 levels) in ' [22:24:33] ./features/step_definitions/opt_in_steps.rb:87:in `/^my talk page is my old Flow board$/' [22:24:36] features/opt_in.feature:41:in `Then my talk page is my old Flow board' [22:24:40] running a third time [22:24:48] stephanebisson: Your shell username on labs is sbisson, right? [22:24:58] RoanKattouw: yes [22:25:37] mooeypoo: of course: if it can happen, it will happen on yourlaptop [22:26:08] passed a third time [22:26:13] stephanebisson, yes. It's the Moo phenomanon. [22:26:17] Moonomenon. [22:27:56] stephanebisson, so far, it passes 3/4 times [22:28:18] hold on, not good enough [22:28:51] She's running more [22:29:07] (but doesn't want to touch her computer while it runs, so she's having me tell you :) ) [22:29:25] oops. 3/5 passes [22:29:29] it just failed again [22:29:50] Then my talk page is my old Flow board # features/step_definitions/opt_in_steps.rb:85 [22:29:50] expected "Template:Template before first heading" to match "User talk:New user 63241246734263052155444683247325982737/Archive 1" (RSpec::Expectations::ExpectationNotMetError) [22:29:50] ./features/step_definitions/opt_in_steps.rb:90:in `block (2 levels) in ' [22:29:53] ./features/step_definitions/opt_in_steps.rb:87:in `/^my talk page is my old Flow board$/' [22:29:56] features/opt_in.feature:41:in `Then my talk page is my old Flow board' [22:30:00] same as before. [22:33:01] (03PS7) 10Sbisson: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [22:33:11] mooeypoo: ^ here [22:33:16] 5/7 passes [22:33:21] okay, checking again [22:35:44] (03CR) 10jenkins-bot: [V: 04-1] Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 (owner: 10Sbisson) [22:36:23] stephanebisson, 3/3 passes! [22:36:35] mooeypoo: the whole thing now? [22:36:41] no just 38 [22:36:45] let me try the whole thing [22:37:26] (03PS8) 10Sbisson: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [22:54:51] stephanebisson, okay, it failed on :38 again, but I am going to retry with the latest patchset [22:55:24] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant, 5Patch-For-Review: Have 'flow-suppress' work on MediaWiki-Vagrant out of the box - https://phabricator.wikimedia.org/T113641#1673077 (10Catrope) a:3Mattflaschen [22:55:30] latest is functionally the same as the one before. what's the error? [22:56:11] same error as before [22:58:00] matt_flaschen: Could you respond to https://phabricator.wikimedia.org/T109676#1646040 ? [22:58:33] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1673080 (10Catrope) @jcrespo When shall we schedule this for? [22:58:56] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert pt.wikibooks from LQT to Flow - https://phabricator.wikimedia.org/T113682#1673081 (10DannyH) 3NEW [22:59:16] stephanebisson, it passed now. Running again. [22:59:26] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1673091 (10DannyH) [23:03:18] stephanebisson, passed x 2 [23:03:43] (03CR) 10Mooeypoo: [C: 032] Add intermediate metrics for API and ext.echo.ui loading response times [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240903 (owner: 10Legoktm) [23:05:33] (03PS9) 10Sbisson: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [23:05:55] (03PS10) 10Sbisson: Browser tests: Refresh flow page until optin process is finished [extensions/Flow] - 10https://gerrit.wikimedia.org/r/240901 [23:06:03] (03Merged) 10jenkins-bot: Add intermediate metrics for API and ext.echo.ui loading response times [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240903 (owner: 10Legoktm) [23:06:25] (03CR) 10Mooeypoo: [C: 032] Make middle-clicking badge work [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240629 (https://phabricator.wikimedia.org/T113555) (owner: 10Catrope) [23:06:40] mooeypoo: let me know if you see any other error. I have to go make dinner now but I'll look at it later or tomorrow morning. [23:06:55] we'll get there [23:07:11] stephanebisson, oki doki [23:14:42] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1673133 (10Mattflaschen) >>! In T109676#1646040, @matthiasmullie wrote: >>>! In T109676#1585731, @Mattfla... [23:16:10] (03Merged) 10jenkins-bot: Make middle-clicking badge work [extensions/Echo] - 10https://gerrit.wikimedia.org/r/240629 (https://phabricator.wikimedia.org/T113555) (owner: 10Catrope) [23:17:46] matt_flaschen: Out of curiosity, why do we not use auto_increment IDs? [23:24:12] RoanKattouw: was initially asked (by terry) to build something that can shard [23:24:43] Also, it allows generating a UUID application-side, writing it to both memcached and DB, then committing them. No need to read the row index from DB. [23:25:19] Another nice aspect is that they're globally unique (mostly...), so if you just see a UUID, it refers to a specific object, whereas 123 could be page ID 123 or revision ID 123. [23:25:35] mostly :( i'm sorry [23:26:21] Yeah, we probably wouldn't have done it like this from scratch. There are also ways to generate number-y looking values that seem sequential, but actually aren't (see Twitter). [23:26:31] Knowing what we know now I mean. [23:30:26] rewrite! [23:54:45] 6Collaboration-Team-Backlog, 10Beta-Cluster, 10MediaWiki-Recent-changes: [enwiki-betalabs] Special: Recent changes page is not displayed correctly - https://phabricator.wikimedia.org/T113660#1673256 (10Mattflaschen) It looks some content has invalid interwiki links, so they're being converted to regular red...