[00:00:34] (03CR) 10jenkins-bot: [V: 04-1] Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) (owner: 10Mattflaschen) [00:00:37] (03CR) 10jenkins-bot: [V: 04-1] BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) (owner: 10Mattflaschen) [00:13:19] 03Collab-Team-2016-Q4, 10Flow, 13Patch-For-Review: FlowReplies is not firing in production - https://phabricator.wikimedia.org/T96620#2226058 (10Mattflaschen) (Side note, part of this is a regression from {926a83a07d6bf29965fd56008cb0df68c959e4ea}). [00:14:12] (03PS2) 10Mattflaschen: WIP: Make FlowReplies slightly work [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282841 (https://phabricator.wikimedia.org/T96620) [01:02:06] (03CR) 10Mattflaschen: [C: 04-1] "Thanks for the patch. See inline." (0310 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/279957 (https://phabricator.wikimedia.org/T131055) (owner: 10Paladox) [01:25:23] (03PS6) 10Mattflaschen: BREAKING CHANGE: Change $wgEchoDefaultNotificationTypes to be logical [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284124 (https://phabricator.wikimedia.org/T132820) [01:25:56] (03PS4) 10Mattflaschen: Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) [01:30:35] (03CR) 10jenkins-bot: [V: 04-1] Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) (owner: 10Mattflaschen) [01:32:07] (03PS5) 10Mattflaschen: Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) [01:35:57] (03CR) 10jenkins-bot: [V: 04-1] Unlisted special page for displaying notification configuration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284125 (https://phabricator.wikimedia.org/T132127) (owner: 10Mattflaschen) [02:21:00] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, haven't tested yet." (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282738 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [03:45:41] 10Flow, 10Wikimedia-Site-requests: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2226256 (10Kenrick95) [04:43:30] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2226298 (10Pginer-WMF) >>! In T125654#2225781, @jmatazzoni wrote: > - When a topic is resolved and summarized... [05:35:10] 03Collab-Team-2016-Q4, 10Flow, 10Wikimedia-Site-requests: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2226346 (10Catrope) [05:37:40] (03PS1) 10Catrope: Add namespace translation for Indonesian (id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284632 (https://phabricator.wikimedia.org/T133254) [06:20:38] (03CR) 10Catrope: [C: 032] Topmost: Minor follow-up to add fallback for missing topmost post ID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284524 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [06:20:56] (03CR) 10jenkins-bot: [V: 04-1] Topmost: Minor follow-up to add fallback for missing topmost post ID [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284524 (https://phabricator.wikimedia.org/T126264) (owner: 10Mattflaschen) [06:58:04] 06Collaboration-Team-Interested, 10Notifications: Links in echo notifications do not follow the mobile view, even though browsing in m.domain.tld - https://phabricator.wikimedia.org/T131678#2226438 (10Catrope) [06:58:07] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Redirects, 06Operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#2226439 (10Catrope) [09:59:38] (03CR) 10MarcoAurelio: [C: 031] Add namespace translation for Indonesian (id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284632 (https://phabricator.wikimedia.org/T133254) (owner: 10Catrope) [10:11:13] 03Collab-Team-2016-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2226620 (10MarcoAurelio) p:05Triage>03Normal * Archive policy is defined at https://id.wikipedia.org/wiki/MediaWiki:Flow-conversion-archive-p... [10:22:24] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 10Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2226636 (10MarcoAurelio) Creating t... [11:22:13] (03PS1) 10Matthias Mullie: Remove param index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284674 [11:22:16] (03PS1) 10Matthias Mullie: List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 [11:22:19] (03PS1) 10Matthias Mullie: Change (opt-out) noforn to (opt-in) crosswikisummary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284676 [11:22:22] (03PS1) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [11:23:53] (03PS2) 10Matthias Mullie: Remove param index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284674 [11:24:15] (03PS2) 10Matthias Mullie: List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 [11:28:38] (03CR) 10jenkins-bot: [V: 04-1] List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 (owner: 10Matthias Mullie) [11:28:44] (03PS3) 10Matthias Mullie: List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 [11:28:58] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [11:30:14] (03CR) 10jenkins-bot: [V: 04-1] Change (opt-out) noforn to (opt-in) crosswikisummary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284676 (owner: 10Matthias Mullie) [11:31:39] (03CR) 10jenkins-bot: [V: 04-1] Remove param index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284674 (owner: 10Matthias Mullie) [11:32:53] (03CR) 10jenkins-bot: [V: 04-1] List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 (owner: 10Matthias Mullie) [11:34:10] (03PS3) 10Matthias Mullie: Remove param index [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284674 [11:40:54] (03PS4) 10Matthias Mullie: List is no longer an associative array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284675 [11:42:33] (03PS2) 10Matthias Mullie: Change (opt-out) noforn to (opt-in) crosswikisummary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284676 [11:42:52] (03PS2) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [11:48:20] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [11:52:58] (03CR) 10jenkins-bot: [V: 04-1] Change (opt-out) noforn to (opt-in) crosswikisummary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284676 (owner: 10Matthias Mullie) [12:07:18] (03PS1) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) [12:08:51] (03PS3) 10Matthias Mullie: Change (opt-out) noforn to (opt-in) crosswikisummary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284676 [12:11:40] (03CR) 10jenkins-bot: [V: 04-1] Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [12:15:45] (03PS3) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [12:22:09] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [12:32:52] (03PS4) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [12:35:55] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [12:43:19] (03PS5) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [12:46:35] 03Collab-Team-2016-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2226994 (10Trizek-WMF) a:03Trizek-WMF I'll create these boards when namespace translation will be shipped. [12:48:57] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [12:59:15] 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-requests, 10Community-Liaisons (Apr-Jun-2016): Enable beta function for Flow on user pages at nowiki, plus page about Flow and test page (and related configuration) - https://phabricator.wikimedia.org/T132693#2227033 (10Trizek-WMF) @MarcoAureli... [13:03:39] (03PS6) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [13:07:23] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:09:25] (03PS7) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [13:13:59] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:16:07] (03PS8) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [13:22:08] (03CR) 10jenkins-bot: [V: 04-1] Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:22:30] (03PS9) 10Matthias Mullie: Server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284677 (https://phabricator.wikimedia.org/T130636) [13:22:40] (03PS2) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) [13:27:42] (03CR) 10jenkins-bot: [V: 04-1] Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:32:11] (03CR) 10Matthias Mullie: [WIP] server-side crosswiki requests (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282738 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:33:15] (03Abandoned) 10Matthias Mullie: [WIP] server-side crosswiki requests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/282738 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:35:37] (03PS3) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) [13:42:15] (03CR) 10jenkins-bot: [V: 04-1] Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [13:44:08] (03PS4) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) [13:47:33] (03CR) 10jenkins-bot: [V: 04-1] Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) (owner: 10Matthias Mullie) [14:28:04] Morning/late afternoon, all. [14:39:45] 03Collab-Team-2016-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2226256 (10Mattflaschen) > The exact name of a "sandbox" page, where the community would like to test out Flow: Wikipedia:Warung Kopi (Bantuan) (... [14:41:06] (03CR) 10Mattflaschen: [C: 032] Add namespace translation for Indonesian (id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284632 (https://phabricator.wikimedia.org/T133254) (owner: 10Catrope) [14:47:45] (03Merged) 10jenkins-bot: Add namespace translation for Indonesian (id) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/284632 (https://phabricator.wikimedia.org/T133254) (owner: 10Catrope) [15:01:36] (03PS5) 10Matthias Mullie: Let frontend always query local for foreign sources, instead of those foreign APIs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/284682 (https://phabricator.wikimedia.org/T130636) [15:08:19] 03Collab-Team-2016-Q4, 10Flow, 10Wikimedia-Site-requests, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Enable Flow in id.wikipedia for testing - https://phabricator.wikimedia.org/T133254#2227422 (10Kenrick95) @Mattflaschen If that is the case, then I guess `Wikipedia:Bak pasir Flow` will... [15:16:03] (03PS10) 10Sbisson: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [15:20:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [16:20:20] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Notify owners when an OAuthapp changes state - https://phabricator.wikimedia.org/T62528#2227677 (10matej_suchanek) [16:20:23] 06Collaboration-Team-Interested, 10Notifications, 10MediaWiki-extensions-OAuth, 13Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#2227678 (10matej_suchanek) [16:20:25] 06Collaboration-Team-Interested, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2227676 (10matej_suchanek) [16:30:07] (03PS11) 10Sbisson: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [16:34:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [16:40:34] (03PS12) 10Sbisson: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [16:41:23] legoktm: ^ as you may have noticed I'm working on the email formatters. I hope you don't mind [16:45:10] (03CR) 10Mattflaschen: "It should show the JS problems and refuse to commit." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [16:58:55] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2227832 (10jmatazzoni) @Pginer-WMF, re. your hypothetical above, I believe the excerpts in the messages sent wo... [17:06:29] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2227852 (10SBisson) >>! In T125654#2227832, @jmatazzoni wrote: > @Pginer-WMF, re. your hypothetical above, I be... [17:07:14] stephanebisson_: not at all [17:12:52] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#2227874 (10Catrope) [17:12:54] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#1898814 (10Catrope) [17:12:56] 03Collab-Team-2016-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2227877 (10Catrope) [17:12:58] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#1898814 (10Catrope) [17:13:33] 03Collab-Team-2016-Q4, 10Notifications: E-mail notification subject does not say which wiki (e.g. which language Wikipedia) it came from - https://phabricator.wikimedia.org/T122229#1898814 (10Catrope) We could use the human-readable wiki name messages that we created for cross-wiki notifications. [17:13:57] stephanebisson_: The task I was thinking of is ---^^ [17:14:26] got it [17:28:24] matt_flaschen: re commithooks: can't get it to work like in your example [17:29:54] matt_flaschen: I see that ".git/hooks/pre-commit" is updated, you added jsduck in there [17:40:06] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2227966 (10jmatazzoni) > Pau's scenario is actually correct and it explains the problem perfectly. Ahhhh. I se... [18:04:08] 03Collab-Team-2016-Q4: Transclusions in section titles on wikitext pages not displayed as plain text in Notifications - https://phabricator.wikimedia.org/T133319#2228071 (10Etonkovidova) [18:09:32] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): API fallback (broken) title shown for mention notification - https://phabricator.wikimedia.org/T132872#2212800 (10Etonkovidova) Checked in betalabs - for templates in section titles on wikitext based pages.... [18:49:17] 06Collaboration-Team-Interested, 10Notifications, 07Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2228274 (10jmatazzoni) [18:49:19] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2228273 (10jmatazzoni) 05Open>03Resolved [19:17:47] 10Collab-Notifications-Page, 03Collab-Team-2016-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Notifications - the whole page is bold - https://phabricator.wikimedia.org/T131073#2228348 (10Quiddity) [19:21:27] aha! I have sourced my phab-spam to user-error. My custom Herald rule, for "when non-teammembers file tasks, email me", didn't have the extra condition set for "Is newly created = true", hence it was ignoring my email-preference-settings, and sending me updates about *every action* in a task. [19:21:58] Now I can reduce the backlog, without feeling quite to sisyphean. [19:40:15] (03PS4) 10Aaron Schulz: Make notifications use getMainStashInstance() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250304 [20:02:27] stephanebisson, sorry, I was prepping for a meeting when you asked about the hooks. Is now a good time to discuss that? [20:02:47] matt_flaschen: yep [20:04:41] stephanebisson, okay, I have a theory that maybe your .git directory is not at the root of the extension (this could happen with submodules). Could you check that? [20:05:24] matt_flaschen: I'm at "/Users/sbisson/dev/vagrant/mediawiki/extensions/Flow" [20:05:36] and there's a .git here [20:07:14] stephanebisson, it's a directory? Just checking since there will be a git file if it's a submodule clone. [20:07:34] yes, .git is a dir [20:07:55] stephanebisson, what do you get for: [20:07:57] ls -l .git/hooks/pre-commit [20:08:50] lrwxr-xr-x 1 sbisson staff 71 21 Apr 13:19 .git/hooks/pre-commit -> /Users/sbisson/dev/vagrant/mediawiki/extensions/Flow/scripts/pre-commit [20:09:34] stephanebisson, do you want to do a screen share? [20:10:08] matt_flaschen: hangout? [20:10:20] Sure, let me get ready. [20:23:13] stephanebisson, can you change a JS file, add it, then do: [20:23:28] git diff --name-only --cached | grep -E "\.js" [20:23:51] yep, it lists the changed file [20:23:54] Great [20:26:52] (03PS3) 10Mattflaschen: Pre-commit hook fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 [20:26:58] Fixed [20:28:16] stephanebisson, it runs the actual commands inside Vagrant, but not that part, currently. [20:29:05] matt_flaschen: success! [20:29:43] Cool. :) [20:31:44] (03CR) 10Sbisson: [C: 032] Pre-commit hook fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [20:33:05] 03Collab-Team-2016-Q4, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Write email formatter that uses presentation models - https://phabricator.wikimedia.org/T121067#2228567 (10SBisson) a:05Legoktm>03SBisson [20:35:39] Getting lunch [20:42:58] (03Merged) 10jenkins-bot: Pre-commit hook fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/282400 (owner: 10Mattflaschen) [20:57:52] 06Collaboration-Team-Interested: [betalabs] Non-relevant highlighting for multiple edits of the same post thread - https://phabricator.wikimedia.org/T133340#2228720 (10Etonkovidova) [21:04:54] 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2228761 (10Krinkle) [21:14:18] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2009559 (10Etonkovidova) Checked in betalabs - a notification message f... [21:20:37] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2228955 (10Etonkovidova) [21:53:10] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2229111 (10Etonkovidova) >The problem is: Resolve and Summarize are independent actions that don't happen simultaneously even though the UI presents >them one after the ot... [22:09:57] 06Collaboration-Team-Interested, 10Flow: [betalabs] Non-relevant highlighting for multiple edits of the same post thread - https://phabricator.wikimedia.org/T133340#2229250 (10Mattflaschen) [22:10:45] 03Collab-Team-2016-Q4, 10Flow, 10MediaWiki-Patrolling: Flow "mark as patrolled" links don't work (claims "Session failure") - https://phabricator.wikimedia.org/T133341#2229257 (10Mattflaschen) [22:15:43] 03Collab-Team-2016-Q4, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [betalabs] Bundled flowusertalk-new-topic notifications refer to a user talk page with a full title. - https://phabricator.wikimedia.org/T133100#2229306 (10Etonkovidova) Checked the fix in betalabs - the issue is corrected.... [22:26:49] 06Collaboration-Team-Interested, 10Flow, 06Mobile-Apps, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Product-Backlog: Flow broken in mobile apps - https://phabricator.wikimedia.org/T73754#2229340 (10JMinor) >>>! In T73754#2200669, @JMinor wrote: >> This is in our tracking column so we can monito... [22:41:19] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2229376 (10jmatazzoni) Jonathan would like to close the French survey. Can som... [22:41:38] matt_flaschen: Hah, I now find myself having a use case for that special page of yours [22:41:53] "What is the default setting for Flow notifications on officewiki?" [22:42:05] Gee if only we had software that could tell me :P [22:42:14] RoanKattouw: egrep is your friend. [22:42:25] mwscript, too [22:42:31] *mwscript eval.php [22:43:06] ["echo-subscriptions-web-flow-discussion"]=> [22:43:06] bool(true) [22:43:06] ["echo-subscriptions-email-flow-discussion"]=> [22:43:06] bool(false) [22:47:49] 03Collab-Team-2016-Q4, 10Notifications, 07Mobile, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Abbreviated timestamps not shown in notifications on mobile - https://phabricator.wikimedia.org/T133134#2221493 (10Etonkovidova) Before the fix {F3906130} {F3906132} {F3906134} After the fi... [23:00:24] 03Collab-Team-2016-Q4, 10Notifications, 13Patch-For-Review, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): Invite French users to take the Notification Survey (using the Notifications panel) - https://phabricator.wikimedia.org/T131893#2229447 (10Mattflaschen) >>! In T131893#2229376, @jmatazzoni wrote: > Jonathan... [23:04:47] I'm going to head out in a few minutes. I will be on a little bit later, though. [23:06:48] 03Collab-Team-2016-Q4: [mobile] Clicking on 'Mark as resolved' forces the dotdotdot menu to move down - https://phabricator.wikimedia.org/T133365#2229457 (10Etonkovidova) [23:16:45] 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Clicking a marked-as-unread notification should mark it as read - https://phabricator.wikimedia.org/T129898#2229476 (10Catrope) This works OK, but 1) Matt is right that there's no guarantee the AJAX request will finish, and 2) the notification... [23:17:04] matt_flaschen: For when you get back: do you think ---^^ is a good idea? [23:19:32] RoanKattouw, I think it's fine. I don't mind the adding it to the URL much (yeah, people will bookmark it, etc., but that's not actually a problem). And the only alternatives I know are: [23:19:53] 1. Not being able to re-mark notifications as read. [23:20:07] (after unread) [23:20:24] Re #1: by clicking them that is, you can still use the "X" (to be replaced with a blue bubble thingy soonish) [23:22:39] Yeah, true. [23:23:08] 2. Having to repopulate the echo_target_page (a pain, and even then not everything has that, so for things without it people would have to click blue bubble when we stop auto-marking alerts). [23:24:03] 3. sendBeacon (not too bad, but browser support is not 100% (http://caniuse.com/#search=sendBeacon) so that brings us back to blue bubble [23:24:19] So I don't have anything else. If I think of something, I'll post there. [23:24:51] 4. sendBeacon + mocking it with localStorage. Eh. [23:31:14] Alright, I'll be back on later. [23:34:40] Re #2 that also has the side affect of visiting the page (other than from a notification) will mark it as read again [23:35:08] We sort-of-decided that that was undesirable behavior (i.e. if you mark something as unread explicitly, it should not then get marked as read implicitly) [23:41:30] matt_flaschen: fwiw we do #4 in search for tracking clicks on the SERP. Just added it recently though so waiting on analysis to come back on how it compares to the events we collect when they land (triggered via a wprov query param) [23:43:34] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Combine "Resolved" and "Summarized" notifications when both actions happen on Flow - https://phabricator.wikimedia.org/T131722#2229535 (10Catrope) p:05Triage>03Normal [23:43:53] 03Collab-Team-2016-Q4, 10Flow, 10Notifications: Combine "Resolved" and "Summarized" notifications when both actions happen on Flow - https://phabricator.wikimedia.org/T131722#2176196 (10Catrope) It was done this way initially because that was easiest, but we should figure out if we can make this nicer. [23:44:13] 03Collab-Team-2016-Q4, 10Flow, 10Notifications, 03Collab-Archive-2015-2016, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#1993603 (10Catrope) {T131722} is related. [23:44:30] 03Collab-Team-2016-Q4: [betalabs] flow-topic-resolved notifications should have a summary excerpt - https://phabricator.wikimedia.org/T133088#2219478 (10Catrope) {T131722} is related. [23:48:10] 10Notifications, 10Collaboration-Community-Engagement, 10Community-Liaisons (Apr-Jun-2016), 07Documentation: Rethink how the different types of notifications are displayed on Help:Notifications - https://phabricator.wikimedia.org/T131604#2172364 (10Catrope) {T132127} is related. We should also consider re-... [23:58:12] 03Collab-Team-2016-Q4, 10Notifications: Update categorization of notification types - https://phabricator.wikimedia.org/T133367#2229569 (10Catrope) [23:59:12] 03Collab-Team-2016-Q4, 10Notifications: Update categorization of notification types - https://phabricator.wikimedia.org/T133367#2229584 (10Catrope) D'oh, Joe did in fact already file this task. I searched for it, didn't find it, then found it as a blocker of another task seconds after filing this one. [23:59:34] 03Collab-Team-2016-Q4, 10Notifications: Update categorization of notification types - https://phabricator.wikimedia.org/T133367#2229585 (10Catrope) [23:59:36] 03Collab-Team-2016-Q4, 10Notifications: Sort out Notification categories to make them more logical - https://phabricator.wikimedia.org/T133220#2229586 (10Catrope)