[00:03:14] RoanKattouw, there used to be a way to access parsoid directly to an html page... do you remember/know what it is now? [00:14:48] mooeypoo, to get the real error message, try: [00:15:11] grep parsoid logs/mediawiki-Flow.log [00:15:18] in your root vagrant directory. [00:17:39] [06/15/16 16:58:25] moriel:~/code/vagrant (master)$ grep parsoid logs/mediawiki-Flow.log [00:17:39] grep: logs/mediawiki-Flow.log: No such file or directory [00:20:52] mooeypoo: [00:20:55] ls -l logs/*Flow* [00:21:10] It might be compressed, but I thought it shouldn't be if it's a recent error. [00:21:25] i am just looking at this dir, it looks like there's a mediawiki-Flow.log.1.gz ... all the way to 7 [00:21:39] mooeypoo, is there anything from today? [00:21:47] That's also the result i'm getting from the ls -l cmd [00:21:48] no [00:22:22] matt_flaschen, could it be that it's going by UTC, and so "today" just ended? [00:22:37] mooeypoo, yeah, is there anything from tomorrow? :) [00:22:48] hee [00:22:56] nothing is outside the gzip [00:23:23] mooeypoo, and none of the gzip are 14 or 15? [00:23:41] no [00:23:44] 1-7 [00:24:03] and I juts tried to save a topic, got the same error, so you'd think there'll be a new log message... :\ [00:24:51] mooeypoo, yeah, let me take a look at the logging. [00:27:19] I suck at linux commands, but I think this should find any log files with Flow in them: find . -type f -name "*Flow*.log" ? [00:27:38] (that comes back with no response) am I missing some flag for recursive search in folders ? [00:29:12] mooeypoo, oh, are you using 127.0.0.1 or http://dev.wiki.local.wmftest.net:8080 ? [00:29:34] dev.wiki.local.wmftest.net:8080 [00:29:39] mooeypoo, you need a * after the log. [00:29:39] Okay, good. [00:30:45] find . -type f -name "*Flow*.log*" --> gives me the same .gz files from before, 1-7 [00:30:49] Yeah [00:31:07] mooeypoo, hmm, all I had to do was stop parsoid and post a topic, and it created a mediawiki-Flow.log file with the error ("Couldn't connect to server"). [00:31:13] So I don't know what's wrong with your logging. [00:31:18] let me try that.. [00:31:30] I mean... it might be some fluke with the type of error or something [00:31:46] sudo service parsoid stop [00:31:52] yup [00:31:53] and negative [00:32:01] i got "could not connect" this time (different error) but no log [00:32:15] Is there some sort of config variable to enable logging? [00:33:05] matt_flaschen, not sure if that helps, but I do have a mediawiki-wiki-debug.log file that's being updated [00:33:59] mooeypoo, I already wrote the Vagrant code to set up these logs, it should be enabled through $wgDebugLogGroups['Flow'] = '/vagrant/logs/mediawiki-Flow.log'; [00:34:30] mooeypoo, can you run: [00:34:32] sudo -u vagrant touch /vagrant/logs/Foo_bar.txt [00:34:36] inside vagrant ssh. [00:34:48] Just to make sure it can create files. [00:35:13] I just grepped my entire vagrant folder for this -- it's there in two files, vagrant/puppet/modules/role/templates/flow/conf.php.erb and vagrant/settings.d/puppet-managed/20-Flow.php [00:35:18] * mooeypoo nods [00:35:49] matt_flaschen, that worked [00:35:58] That's so weird. [00:36:05] :\ [00:36:19] mooeypoo, are you using NFS? [00:36:43] .... yes...? [00:36:46] I think so? [00:36:48] df -Th|grep vagrant [00:37:07] in ssh ? [00:37:19] vagrant@mediawiki-vagrant:/vagrant/logs$ df -Th|grep vagrant [00:37:19] 10.11.12.1:/home/moriel/code/vagrant nfs 227G 69G 147G 32% /vagrant [00:37:53] Yeah, although mine is nfs4, and yours is just nfs, which is kinda weird. [00:38:08] matt_flaschen, can I upgrade that? [00:38:12] .. should I? [00:38:27] No, probably not. [00:38:41] hm. [00:38:56] Oh, I found the curl command to call parsoid directly. [00:39:46] it used to be a very convenient html page [00:40:02] Not working, though. Let me find the current command. [00:40:18] ...wait, matt_flaschen, could it be related to the error I had with local dev wiki having an issue with headers? [00:40:24] header sent as "Origin" or something like that [00:40:51] it displayed for requesting local token [00:40:58] Never mind, now it's working. [00:41:13] mooeypoo, no, because that's proxied. JS doesn't talk directly to Parsoid. It goes through PHP on the local server. [00:41:21] * mooeypoo nods [00:41:51] mooeypoo, try: [00:41:53] curl -H 'Accept: text/html; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/HTML/1.2.1"' 'http://localhost:8000/dev.wiki.local.wmftest.net/v3/transform/wikitext/to/html/Topic%3AT3wmn6vy1k6smkk2' -d 'wikitext=Testing&body_only=true&pagebundle=false' [00:42:13] I'm on a Vagrant branch, so I guess I should update, so mine can be broken too. [00:42:15] ;) [00:42:31]

Testing

[00:42:39] Good [00:42:48] from both in and out of the ssh [00:44:05] matt_flaschen, could it be localsettings.js config? [00:45:00] mooeypoo, yeah, but that is part of the Parsoid role, so it should Just Work. [00:45:05] vagrant setup suggests something about parsoidConfig.setMwApi( ... ) for domains... could it be we need to add the multiple domains in there? [00:45:10] yeah [00:45:18] mooeypoo, but it doesn't even work on dev, right? [00:45:42] nope [00:45:58] but it might be a difference between dev.wiki.local.wmftest.net and localhost ? [00:46:20] * mooeypoo is wildly guessing at this point [00:47:14] mooeypoo, localhost is the actual host the HTTP request connects to, but after that is the dev.wiki which is working for both of us on the command line. [00:47:30] yeah [00:47:35] I have no idea what's going on :\ [00:47:38] mooeypoo, working on some debug code, so we can check for differences between our two setups. In the mean time, could you do: [00:47:57] grep -ri parsoid settings.d [00:48:40] http://pastebin.com/J5yWg4Wq [00:49:29] matt_flaschen, notice that 99-LocalSettings.php (first result) is commented out [00:50:29] mooeypoo, yeah, but: [00:50:31] settings.d/wikis/wiki/settings.d/99-LocalSettings.php [00:50:33] is active. [00:50:37] yup [00:50:40] Sorry, I should have asked you to grep this before. [00:50:50] You should remove that or comment it out. [00:50:57] but that line is commented out [00:51:06] Not the last one. [00:51:10] That is a custom config, not part of vagrant. [00:51:35] settings.d/99-LocalSettings.php is commented out. [00:51:40] wtf [00:51:43] I'm not seeing it [00:51:43] But not settings.d/wikis/wiki/settings.d/99-LocalSettings.php [00:51:52] ohh [00:52:17] what the hell is this file there [00:52:24] can I just remove it? It seems to be a duplicate [00:52:42] the settings.d/99-LocalSettings.php will override it anyways, right? [00:53:34] mooeypoo, no, the per-wiki will override. But yeah, just remove it unless you need something else in there. [00:54:15] matt_flaschen, ok, we have progress... there's a NEW error message now when I try to add a flow topic [00:54:20] [e0ba01b3b885e2c8da0abfa2] Exception Caught: wfDiff(): popen() failed [00:54:32] mooeypoo, that probably just means you're out of memory. [00:54:44] free -m [00:54:47] inside vagrant ssh [00:55:29] total used free shared buffers cached [00:55:29] Mem: 2001 1879 122 43 17 216 [00:55:43] -/+ buffers/cache: 1645 356 [00:55:47] and Swap is 0s [00:56:04] Yeah, that's pretty tight. [00:56:09] meh [00:56:17] I give it 3 GB right now: [00:56:19] vagrant@mediawiki-vagrant:~$ free -m [00:56:21] total used free shared buffers cached [00:56:22] Mem: 2937 2204 733 106 43 846 [00:56:24] -/+ buffers/cache: 1313 1623 [00:56:25] Swap: 0 0 0 [00:56:28] mooeypoo, for now you can just vagrant reload, and it will probably work. [00:56:42] Unless you want to give it more memory right away (which also requires a reload). [00:56:49] * mooeypoo awaits reload [00:58:51] ok, vagrant hath reloaded [00:58:57] * mooeypoo attempts to Flow [00:59:30] \o/ [00:59:32] IT FLOWS [01:01:10] matt_flaschen, w00t, it works now!! thanks :) [01:02:07] ok, now I can test stephane's fix, which I shall do tomorrow. Time to head out of the office. [01:02:09] matt_flaschen, thanks again! [01:02:29] mooeypoo, you're welcome. Still don't know why your logging is broken. That's a mystery for another day. [01:02:36] * mooeypoo nods [01:02:42] yeah and I need to increase memory in vagrant [01:02:45] i'll do that another day too [01:03:36] matt_flaschen, also, it just occured to me that according the Jamesification of Flow names, Flow topic is Flopic. [01:03:45] Have a good evening ;) [01:03:58] mooeypoo, you too. [01:04:37] Still not feeling the Fl-, but oh well. ;) [02:04:07] Have a good night, all. [07:09:20] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2384612 (10jcrespo) Go for it. You may want to have some kind of check/flowdb list usage maybe, thinking in production? I think... [07:10:03] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 07Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2384613 (10Nemo_bis) >>! In T119511#2379060, @ArielGlenn wrote: > Uh, this is done, insofar as... [09:54:55] 10Flow, 10Notifications: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2384854 (10Trizek-WMF) [10:15:36] 10Flow: Flow: show an other page than the URL - https://phabricator.wikimedia.org/T137894#2384887 (10Framawiki) Ok, I see, thank you. [10:26:34] RoanKattouw, can you confirm https://phabricator.wikimedia.org/T132525#2379029? [10:57:14] 10Collab-Notifications-Page, 06Collaboration-Team-Interested, 07Tracking: Keep pagination consistent when switching status filters on the Notification Page - https://phabricator.wikimedia.org/T137863#2384928 (10Pginer-WMF) >>! In T137863#2382932, @Mooeypoo wrote: >>>! In T137863#2382162, @Catrope wrote: > Be... [12:00:22] (03CR) 10Sbisson: [C: 032] ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [12:09:50] (03Merged) 10jenkins-bot: ApiEchoNotificatons: Add nottitles parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293142 (https://phabricator.wikimedia.org/T137139) (owner: 10Catrope) [12:20:49] (03CR) 10Sbisson: [C: 04-1] "Typo (hasOwnProperties)" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [13:28:26] 10Notifications, 06TCB-Team, 07German-Community-Wishlist, 03TCB-Team-Sprint-2016-06-16: Send notification for easy-to-find failed mentions - https://phabricator.wikimedia.org/T136326#2385165 (10Lea_WMDE) [14:10:04] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2369994 (10SBisson) I thought I fixed it with https://gerrit.wikimedia.org/r/#/c/283869 on April 17th. [14:12:13] (03PS1) 10Sbisson: Notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 [14:41:33] (03CR) 10Catrope: [C: 032] "That was embarrassing and totally my fault." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (owner: 10Sbisson) [14:41:59] Trizek: Yes, we are definitely deploying that next week [14:42:18] Cool! I'm adding it to Tech News [14:42:20] RoanKattouw: ^ well, I think I merged it so it's also my fault [14:43:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2385436 (10Catrope) >>! In T137501#2385274, @SBisson wrote: > I thought I fixed it with https://gerrit.wikimedia.org/r/#/c/283869 on April 17th. That's poss... [14:44:17] Fair enough :) [14:44:28] I guess it's sort of obviously wrong in retrospect, EchoHooks::somethingTopic [14:48:06] (03PS2) 10Catrope: Follow-up 3253600cef: Actually notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (https://phabricator.wikimedia.org/T137501) (owner: 10Sbisson) [14:48:15] (03CR) 10Catrope: [C: 032] Follow-up 3253600cef: Actually notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (https://phabricator.wikimedia.org/T137501) (owner: 10Sbisson) [14:50:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2385453 (10Catrope) >>! In T137501#2385441, @gerritbot wrote: > Change 294715 had a related patch set uploaded (by Catrope): > Follow-... [14:51:14] (03PS3) 10Catrope: Follow-up 89880f89d: Actually notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (https://phabricator.wikimedia.org/T136060) (owner: 10Sbisson) [14:51:36] (03CR) 10Catrope: [C: 032] Follow-up 89880f89d: Actually notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (https://phabricator.wikimedia.org/T136060) (owner: 10Sbisson) [14:51:50] yeah, that's the one [14:51:59] Yeah, sorry, I had multiple tabs open and got confused [14:52:03] and I didn't merge it, it was lego [14:53:06] Trizek: FYI, our "fix" for https://phabricator.wikimedia.org/T136060 broke resolved/reopened notifications completely (sent them to neither board watchers nor topic watchers). Starting next week they'll be sent again, to topic watchers this time [14:53:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2385464 (10SBisson) a:03SBisson [14:55:24] ok, thanks RoanKattouw [14:58:04] (03Merged) 10jenkins-bot: Follow-up 89880f89d: Actually notify topic watchers of topic-resolved/topic-reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/294715 (https://phabricator.wikimedia.org/T136060) (owner: 10Sbisson) [14:58:37] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5): Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2385473 (10SBisson) [14:59:27] ^ added the task to our board so it goes through QA [15:15:24] 10Flow, 10Notifications: No orange-bar-of-doom when a message is posted on a user talk page using Flow - https://phabricator.wikimedia.org/T137954#2385547 (10Trizek-WMF) Is it linked to {T58845}? [15:17:39] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: flow-topic-resolved should use board as event title, not topic - https://phabricator.wikimedia.org/T137501#2385552 (10Catrope) You're right, this is now fixed. We may want to write a script that fixes old entries though, because pre-April no... [15:19:25] RoanKattouw, when https://phabricator.wikimedia.org/T123018 will be released? [15:19:46] Trizek: I'm about to write an email asking for input on that actually [15:19:48] Just to know, is there a clue on Gerrit to see if the release is scheduled? [15:20:03] The patch isn't merged yet, so that's not currently knowable by software [15:20:38] Trizek: If the patch is merged, the task will be tagged with WMF-deploy-2016-06-21 or similar [15:21:08] (Which means it'll be deployed the week of June 21) [15:22:04] That's not the case on that task. That's why I4m asking. :) [15:22:20] Yeah, it's not merged yet, we have yet to decide when to merge it and deploy it [15:22:28] okay [15:22:38] There's an issue with the bundling changes that makes me want to deploy bundling and the re-sort together [15:22:43] I'm about to start writing an email about that [15:22:58] But real quick, what are your thoughts about when we can/should deploy the re-sort? [15:23:24] I think we should announce it early - two weeks before the deployment. [15:23:47] OK, I expected something like that [15:24:00] We can have a "we are going to change that in the coming weeks" on next week's TN issue. [15:26:24] Yes, if we decide the timing works [15:26:31] I'll try to get that email written before the standup [15:27:34] Thanks [15:31:09] while also preventing a 2yo from destroying the house so his parents can put together the wedding cake stand [15:44:33] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks, 07User-notice: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2385615 (10Trizek-WMF) [16:05:05] (03PS1) 10Sbisson: Maintenance script generates edit-thank notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294731 (https://phabricator.wikimedia.org/T120152) [16:13:28] (03PS1) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [16:21:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [16:28:06] (03PS2) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [16:29:41] (03PS19) 10Mooeypoo: Add a cross-wiki sidebar to the Special:Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) [16:29:50] Finnish Chapter's members are asking to set-up a Flow page on their wiki. It is a WMF maintained wiki, but not SULed. Ideas? [16:31:22] That would be fine [16:31:34] We have Flow on some chapter wikis already as part of the LQT conversion [16:31:38] (03CR) 10Mooeypoo: "I have seen the Origin issue too, only for devwiki ("local" wiki for vagrant) and thought it was an issue of vagrant setup, too, since the" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [16:31:46] I thought fiwikimedia was one of them actually [16:33:08] Trizek: In fact: https://fi.wikimedia.org/wiki/Kahvihuone [16:33:19] That's the only Flow page on that wiki (aside from a test page), but it seems to be used still [16:33:41] Or... no, all the comments are from 3-4 years ago, it's just that someone resolved all the topics 30 days ago [16:33:43] They want Flow on an other page RoanKattouw [16:33:47] OK [16:34:11] Oh, wait, you bring up the non-SUL part because that means you don't have the right to create Flow boards through a global group? [16:34:30] https://fi.wikipedia.org/wiki/Aihe:T5z3pck4fz8hq1ag [16:35:13] I don't have the possibility to log-in on fr.wikimedia.org, and if it was possible, I'm not sure I can enable Flow on a page there. [16:35:29] And they can't enable Flow on a page either. [16:35:55] Ha, I have an account there apparently [16:36:00] Not sure why, maybe because of the LQT conversion [16:36:04] Roan Kattouw (WMF) (talk | contribs | block) (Created on 20 February 2016 at 00:00) [16:36:36] And I have Flow create rights [16:36:46] No idea why or how I got them, but I won't complain :) [16:37:29] :D [16:37:47] I let you create that page. [16:38:36] Done [16:38:42] And replied on the fiwiki thread [16:39:38] What the... I have lots of rights but I'm not in any grops? [16:39:54] And no user rights log entry either [16:39:54] What sorcery is this [16:40:16] Oh, it is an SUL wiki [16:41:03] Why am I not able to log in then? [16:41:03] I don't know why you weren't able to log in, but for me it shows as being connected to SUL and my global account (with rights) works there [16:41:25] Very strange [16:41:37] I wonder if this might be an AuthManager regression or sometihng [16:41:48] I don't think my volunteer account exists on that wiki, so lemme try that one [16:43:21] WFM [16:47:13] (03PS2) 10Catrope: Maintenance script generates edit-thank notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294731 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [16:50:07] (03CR) 10Catrope: [C: 032] Maintenance script generates edit-thank notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294731 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [16:55:45] (03CR) 10jenkins-bot: [V: 04-1] Maintenance script generates edit-thank notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294731 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [16:58:08] (03Merged) 10jenkins-bot: Maintenance script generates edit-thank notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/294731 (https://phabricator.wikimedia.org/T120152) (owner: 10Sbisson) [17:14:36] matt_flaschen: noticed the chat too late [17:14:53] I’m definitely going to take a look at it tomorrow [17:15:11] maybe later this evening, but won’t promise :) [17:15:25] stephanebisson, I'm testing your patch, and it looks good to me (no issues with secondary links) did you fix that or am I missing something? [17:15:47] feel free to ask someone else if you’d like to have it reviewed faster! [17:16:25] mooeypoo: sort of... I'm making them all non-prioritized. They show ok in the menu but are not aligned when they are next to 'expand'. [17:16:43] hmmm [17:16:53] Ok, I'll try to override the non-prioritized so I can test that too [17:17:13] so far so good in terms of behavior, I'm going over the new code next (but I think it looks good overall with our conversation) [17:17:40] look for 'delete link.prioritized;' in mw.echo.dm.BundleNotificationItem [17:32:37] quiddity: Checking: the tech news schedule is: get stuff in by Thu, you/Johan work on it on Fri, published on Mon, is that right? [17:33:14] Oh I found the documentation [17:34:23] RoanKattouw, deadline is: get stuff in by thursday morning ideally, or by friday morning (European time) at absolute latest, as those are the two times that Johan (or his backups, benoit and I) sends out the translation requests. Then it is sent on Mon. [17:34:30] OK [17:35:03] Then we have probably missed the boat on announcing a deployment date for the notification re-sort / bundling changes given that we haven't yet decided that date [17:35:28] I'm writing an email to the team about that now (same email I mentioned in my standup update) [17:36:11] I guess maybe we could decide today and get it out, but that feels a bit rushed, especially since we don't have a good write-up to explain what the changes actually are [17:36:34] RoanKattouw, there are 3 items about notifs right now. (Feel free to check/tweak those!) I suggested to benoît that we could mention the upcoming sorting change at the same time, but that's not absolutely necessary. (https://meta.wikimedia.org/wiki/Tech/News/2016/25) [17:37:06] quiddity: "Notifications can be sorted by title" is false [17:37:15] You (or someone) may have misinterpreted that task [17:37:33] It's just a backend task, it won't be exposed to the user until the sidebar is merged [17:37:42] benoit added all 3. I'll remove that one. [17:37:58] * RoanKattouw checks that the sidebar didn't get merged while he wasn't paying attention [17:38:29] hehe [17:38:43] stephanebisson: What's the status of the expandable bundles front-end change? Working and in review? [17:42:47] (03CR) 10Catrope: "That 403 error means that something is trying to use ForeignApiRequest to query the local wiki. That doesn't work, you have to use truly l" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [17:44:11] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1528272 (10Mattflaschen-WMF) [17:44:13] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 07Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2386030 (10Mattflaschen-WMF) 05Open>03Resolved >>! In T119511#2384613, @Nemo_bis wrote: > h... [17:47:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Edit-Review-Improvements, 06Editing-Analysis: Measure New-User Retention - https://phabricator.wikimedia.org/T137824#2386038 (10Capt_Swing) Agree with @Halfak. If the 'treatment' in this case is that the editor received some sort of message from an experienced Wikipedian who... [17:49:15] stephanebisson, question regarding behavior -- if I have a bundle of 2 messages, marking either of them as read does not dismantle the bundle. Marking both as read doesn't dismantle the bundle either, it just marks it all as read ... but if the bundle is read and I refresh or reopen the popup, now there's no longer a bundle; both messages appear individually marked as read. Is this the desired behavior? [17:57:44] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Dumps-Generation, 03Collab-Archive-2015-2016, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#2386109 (10Mattflaschen-WMF) This looks good, except for two things: * There are only current dumps. We need full too (--full). * Smal... [17:59:28] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-06-07_(1.28.0-wmf.5), 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Mark a Topic as resolved shouldn't send a notifications to people who follow the Board but not the Topic itself - https://phabricator.wikimedia.org/T136060#2321729 (10... [17:59:33] * mooeypoo sighs and waves the matt_flaschen help-me-help-me flag [17:59:56] matt_flaschen, I am again getting vagrant errors "[6f2e635996f10aee809a5387] Exception Caught: wfDiff(): popen() failed" [18:00:02] which seems to be memory allocation again [18:00:07] how do I increase vagrant's memory? [18:01:13] 03Collab-Team-2016-Apr-Jun-Q4, 06Design-Research, 10Edit-Review-Improvements: Scheduling Huggle user interviews - https://phabricator.wikimedia.org/T135792#2386137 (10Capt_Swing) [18:02:06] mooeypoo: [18:02:07] vagrant config vagrant_ram 3000 [18:02:12] You can get the list at: [18:02:17] vagrant config --list [18:02:37] You will have to reload, but I think it might do that automatically. [18:03:18] matt_flaschen, is this in the ssh or out? [18:03:51] oh, I think I got it [18:03:53] * mooeypoo reloads [18:06:17] Out [18:09:01] matt_flaschen, ok, works for now. How do I check if the memory allocation actually changed rathre than it works because I freed whatever small memory it had during reload? [18:10:22] mooeypoo: free -m [18:12:28] hm, total 3441 [18:12:35] is that in mb ? [18:12:45] if so, looks like it works [18:16:38] (03CR) 10Mooeypoo: "Got it. I know why that happens, then (the sidebar calls remote APIs for everything, but shouldn't if it's the local wiki) I'll work on fi" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/292600 (https://phabricator.wikimedia.org/T129366) (owner: 10Mooeypoo) [18:17:51] heh, oops [18:21:07] stephanebisson, another question -- I added 3 topics to some board my admin user is watching. 2 topics were by the same user, another was by an anonymous user. I get a bundle saying "3 new topics on ..." and when i open, I see 3 items with only the topic title... shouldn't it include the user who posted them? [18:21:29] I could've sworn I saw this with the username before [18:21:34] but I can't see that now [18:34:38] stephanebisson, http://i.imgur.com/RUat3Pt.png [19:00:15] Getting lunch [19:02:07] mooeypoo: username is included in flow-reply [19:02:16] RoanKattouw: yes, working and in-review [19:02:55] stephanebisson, I think it makes more sense to also include it in new topics [19:02:58] see the image, it's weird [19:03:26] mooeypoo: bundles do not change when you mark them (or their constituent as read), that was agreed upon in vancouver and can be added as a second step if needed [19:03:49] mooeypoo: agreed, could you post that suggestion on the task? [19:03:54] * mooeypoo nods [19:05:38] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1692910 (10Mooeypoo) Right now, a bundle about new topics in a board only shows the topic names: {F4172515} I think we should display the... [19:26:51] if I have a message that's just "$1", is it still relevant to have a message for that? If not, is there a shortcut to create a Message object for that? [19:27:32] I don't think that you need a message for "$1" [19:27:40] There's no translations for it... [19:28:24] You also don't need a message object for it. If you want to inject something directly into the text, just make sure you wrap it with .text() and if it's html, then use parseHTML [19:29:36] mooeypoo: I need to return a Message instance (in presentation model) but I don't know how to create it with the string "$1" and not a message key. [19:29:48] Oh [19:30:18] hm, I'm not sure [19:31:14] I vaguely remember Roan telling me how to do it in some patch review [19:31:52] Or maybe it was in a dream because, you know, it's one of my dreams to be able to do that. [19:35:26] matt_flaschen: do you know how to create a Message object with the string "$1" instead of a message key? [19:37:12] (03CR) 10Mooeypoo: [C: 031] "Looks good to me; minor comments, none of them a blocker." (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [19:37:25] stephanebisson, ^^ I'm good with this commit. +1'ed so we can wait for the merge timing [19:37:53] stephanebisson, my only objection is to the language used in the topic bundle, but that's not really this specific commit, and I added that to the task [19:37:55] mooeypoo: fantastic, I'll go over your comments in a bit, thanks! [19:37:56] I don't know offhand how to do that [19:38:34] Maybe I did once but in that case I forgot. Look through Message.php I guess? [19:38:48] * RoanKattouw is on very spotty 2G so may drop off again, sorry [19:39:38] got it: $msg = new RawMessage( '$1' ); [19:39:49] stephanebisson, also, when are we adding more bundles? I initially didn't see bundles at all until I pulled the Flow commit... are we not planning to bundle "regular" talk page messages? [19:40:19] or rather "unbundle" [19:40:21] mooeypoo: from Echo we are only making page-link bundles expandable [19:40:32] mooeypoo: flow: new-topic, topic-reply [19:40:42] mooeypoo: thanks: edit-thanks, flow-thanks [19:40:50] stephanebisson, well, it kinda doesn't make sense that Flow topics are bundled but talk page message aren't, especially in cases where you have them in user's talk page [19:41:14] mooeypoo: edit-user-talk would be great, it's probably the next one [19:41:20] * mooeypoo nods [19:41:32] It was just confusing to not see it expandable when the flow talk page is [19:41:50] Also, i forgot to test one thing... we're not showing expandable bundle inside cross-wiki, are we? [19:42:01] hopefully not [19:42:07] * mooeypoo double-checks [19:42:33] Could be amusing to have nested bundles inside nested bundles inside nested bundles. [19:42:40] Amusing in the "please let's not do that" sort of way [19:43:27] stephanebisson, we are not, but I'm getting the blank "you have 2 notifs from other wikis" message inside cross-wiki now [19:43:31] let me test if this is in master [19:43:58] blank? [19:45:33] ok, I'm only getting it in your commit [19:45:45] Yes, it's not expandable, is what I mean, but I do see it [19:45:50] inside the xwiki bundle [19:45:58] hang on, I'm reloading once again to see the difference [19:46:41] (03PS3) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [19:46:57] stephanebisson, ok, a couple of things, not sure if they're intended: [19:47:24] 1. With your patch, when I look at xwiki, I see the list **completely** unbundled. No more "2 messages from X", but rather each one of those as an individual message. [19:47:27] ^^ intended? [19:47:48] mooeypoo: they are unread? [19:47:56] They are all unread, yes [19:48:03] they should be bundled [19:48:10] They're not [19:48:18] inside the xwiki bundle, they're individual [19:48:22] let me take a screenshot [19:48:29] I believe you [19:49:07] http://i.imgur.com/6mjEvMH.png [19:49:36] bundling is controlled by a new api param [19:49:58] if you look at 'devwiki' there are 2 unread messages from TestingStuff... when I view the popup in devwiki, they're expandable bundle [19:50:19] ok, second thing I wanted to show you in this screenshot -- look at the last item in the xwiki list [19:50:26] it also appears in each one of the groups [19:50:34] we should add crosswikisummary: 0 or something [19:50:54] Somehow, your commit sends a request for the xwiki item - and then it adds it in without skipping it [19:51:13] so we get the xwiki notification as if it's a normal single notification [19:51:59] yep [19:51:59] this one might be a bad rebase [19:52:25] (03CR) 10Mooeypoo: [C: 04-1] "Found two bugs in xwiki bundle:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [20:03:12] (03PS18) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [20:03:24] ^ fixes both bugs [20:03:43] (03CR) 10jenkins-bot: [V: 04-1] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [20:09:44] (03PS49) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:09:47] (03PS19) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [20:14:53] (03CR) 10jenkins-bot: [V: 04-1] Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [20:15:15] (03CR) 10jenkins-bot: [V: 04-1] Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [20:15:44] (03PS20) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [20:17:31] (03PS50) 10Sbisson: Dynamic bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:25:41] (03PS21) 10Sbisson: Expandable bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) [20:25:56] (03CR) 10Sbisson: Expandable bundle (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293504 (https://phabricator.wikimedia.org/T114356) (owner: 10Sbisson) [20:41:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 07WorkType-Maintenance: Migrate Flow content to new separate logical External Store in production - https://phabricator.wikimedia.org/T106363#2386779 (10Mattflaschen-WMF) [20:42:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Flow, 10Beta-Cluster-Infrastructure, 10DBA: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2386806 (10Mattflaschen-WMF) >>! In T119567#2384612, @jcrespo wrote: > Go for it. You may want to have some kind of check/flowdb... [20:50:36] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks, 13Patch-For-Review, and 2 others: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2386900 (10SBisson) The current header text for flow-thank is actually: Fama thanked you for your comment in "How the Moai Moved" on "Page... [20:56:30] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2386921 (10jmatazzoni) Moriel observes that: > Right now, a bundle about new topics in a board only shows the topic names: That is the co... [20:59:21] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2386953 (10Mooeypoo) I think it's also a matter of consistency. "Ludmilla replied to [TOPIC]" has the same issues of length as "Ludmil... [21:01:59] (03PS4) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [21:02:52] (03PS5) 10Sbisson: [WIP] Make thanks notifications expandable bundles [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/294733 (https://phabricator.wikimedia.org/T120152) [21:07:23] 10Collab-Notifications-Page, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-06-21_(1.28.0-wmf.7): Add ability to filter notifications by title - https://phabricator.wikimedia.org/T137139#2358580 (10Etonkovidova) @Catrope - just double-checking with you that all notifi... [21:09:12] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2387023 (10jmatazzoni) Moriel wrote: > I think it's also a matter of consistency. "Ludmilla replied to [TOPIC]" has the same issues of le... [21:11:31] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 13Patch-For-Review: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#2387028 (10SBisson) >>! In T114356#2386953, @Mooeypoo wrote: > I think it's also a matter of consistency. > > "Ludmilla replied to [TOPIC... [21:20:23] mooeypoo, stephanebisson: Not a bad rebase really, because we did in fact have that bug and I only fixed it yesterday [21:20:51] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks, 13Patch-For-Review, and 2 others: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2387057 (10jmatazzoni) Stephane writes: > The current header text for flow-thank is actually: > Fama thanked you for your comment in "How th... [21:21:21] RoanKattouw, wait, we did? [21:21:24] in master? [21:21:27] Yeah.... L/ [21:21:29] * :/ [21:21:31] Kunal found it [21:21:33] when was it introduced? [21:21:34] wow [21:21:41] I think 2 weeks ago [21:21:43] Maybe last week [21:21:45] yikes [21:21:46] :o [21:21:52] When I refactored ApiCrossWikiBase [21:22:06] it was in the back end or front end? [21:22:17] in the way we request the list or the way the server built it? [21:22:18] 03Collab-Team-2016-Apr-Jun-Q4, 10Notifications, 10Thanks, 13Patch-For-Review, and 2 others: Bundle "Thanks" notifications - https://phabricator.wikimedia.org/T120152#2387062 (10SBisson) >>! In T120152#2387057, @jmatazzoni wrote: > I think we should leave the bundled message as specified and fix the standar... [21:22:27] I'm just wondering if it transfered to other patches, like phillip [21:22:44] phillip? [21:22:54] as in, if it's something I should adjust now since the bundles patch will be merged probably after phillip [21:23:02] legoktm, Phillip is the new Special:Notifications sidebar [21:23:17]