[00:16:01] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Adjust Notification Preferences page language to match re-categorization - https://phabricator.wikimedia.org/T149365#2766994 (10jmatazzoni) OK, we've reinstated User Rights, so I dropped the note above to eliminate it. (I updated [[ ht... [00:16:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Adjust Notification Preferences page language to match re-categorization - https://phabricator.wikimedia.org/T149365#2766996 (10jmatazzoni) [00:25:10] 06Collaboration-Team-Triage, 10MediaWiki-General-or-Unknown, 10VisualEditor, 05MW-1.28-release, and 3 others: [Regression wmf.23] MW's title suggestion widget displays a suggestion for "foo" and "Foo" for non-existing pages on input of "foo" (OK), and for "... - https://phabricator.wikimedia.org/T149130#2767007 [00:49:56] 06Collaboration-Team-Triage, 10Notifications: Paginate notifications by event ID, not timestamp - https://phabricator.wikimedia.org/T143964#2767068 (10jmatazzoni) [00:55:53] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2767070 (10jmatazzoni) [00:56:43] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 06Editing-Analysis: Add notification popup views vs Special:Notifications views to Echo dashboard - https://phabricator.wikimedia.org/T121940#2767072 (10jmatazzoni) [00:57:43] 06Collaboration-Team-Triage, 10Flow, 07Technical-Debt: Flow should not manually forward metadata from ParserOutput - https://phabricator.wikimedia.org/T140665#2767074 (10jmatazzoni) [00:58:54] 06Collaboration-Team-Triage: Delete old instances that are no longer used - https://phabricator.wikimedia.org/T129389#2767077 (10jmatazzoni) [00:59:54] 06Collaboration-Team-Triage, 10Notifications: RTL version for feedback.svg icon - https://phabricator.wikimedia.org/T146218#2767081 (10jmatazzoni) [01:00:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10ORES: Recent changes page: ORES scored entries are not highlighted when 'Enhanced recent changes' option is used - https://phabricator.wikimedia.org/T146291#2767083 (10jmatazzoni) [01:01:38] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#2767086 (10jmatazzoni) [01:03:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 10Beta-Cluster-Infrastructure, 07Technical-Debt: Use dedicated $wgFlowCluster and $wgFlowDefaultWikiDb on Beta Cluster - https://phabricator.wikimedia.org/T147523#2767088 (10jmatazzoni) @Catrope, you asked me to remind you to talk to @SBiss... [01:08:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 15User-Urbanecm: New notifs sometimes doesn't appear correctly - progress bar appears but nothing happens - https://phabricator.wikimedia.org/T148066#2767091 (10jmatazzoni) [01:09:49] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreachy (Round-13), and 2 others: Create a reminder for reading articles - https://phabricator.wikimedia.org/T148123#2767093 (10jmatazzoni) [10:47:10] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767865 (10Pginer-WMF) >>! In T132084#2766340, @KMuthu wrote: > @Pginer-WMF, it will be... [10:53:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767872 (10Samwalton9) > I think we may be providing too many actions with similar desti... [11:04:08] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767881 (10Pginer-WMF) >>! In T132084#2767872, @Samwalton9 wrote: >> I think we may be p... [11:09:04] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767896 (10Samwalton9) >>! In T132084#2767881, @Pginer-WMF wrote: >>>! In T132084#276787... [11:22:21] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767921 (10Pginer-WMF) >>! In T132084#2767896, @Samwalton9 wrote: >>>! In T132084#276788... [11:25:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767925 (10Samwalton9) >>! In T132084#2767921, @Pginer-WMF wrote: >>>! In T132084#276789... [11:32:30] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767932 (10Pginer-WMF) >>! In T132084#2767925, @Samwalton9 wrote: > Oh, in which case th... [11:33:15] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2767933 (10Samwalton9) That looks good! [11:39:20] (03CR) 10Jcrespo: [C: 031] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [11:41:02] (03CR) 10Marostegui: [C: 031] Add primary keys to the remaining Flow tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [11:41:54] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, 07Schema-change: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2767952 (10jcrespo) Thank you, this is actually important because even if internally, InnoDB treats those as PKs, from the SQL point of vi... [12:38:13] (03CR) 10Sbisson: [C: 04-1] "This message is used in EchoHtmlEmailFormatter.php:135" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/314686 (https://phabricator.wikimedia.org/T145439) (owner: 10Mounicamergify) [12:41:59] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: Flow fatal: Default format of 'topic-title-html' or 'topic-title-wikitext' can only be used to format topic titles. - https://phabricator.wikimedia.org/T149827#2768086 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [12:45:02] (03CR) 10Sbisson: [C: 031] "You can probably merge this at the same time as the other attribution patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/316035 (owner: 10Catrope) [12:59:11] 06Collaboration-Team-Triage, 10Flow: Many unnecessary flow bots - https://phabricator.wikimedia.org/T121420#2768127 (10Mattflaschen-WMF) p:05Triage>03Low It used to be intentionally translated, so the username would use a name in the wiki's language. Wikis with more than two (e.g. https://fr.wikipedia.org... [13:07:37] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2768149 (10Mattflaschen-WMF) This is done. I will file a follow-up for the broader issue. [13:08:05] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2768151 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [13:12:48] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 13Patch-For-Review: Turn off Flow Beta Feature on wikis with Flow on user talk by default - https://phabricator.wikimedia.org/T147241#2686503 (10Mattflaschen-WMF) Follow up is {T149897}. [13:16:17] 06Collaboration-Team-Triage, 10Flow: Decide on any changes to how preferences should work for Flow user talk - https://phabricator.wikimedia.org/T149897#2768205 (10Paladox) [13:20:04] (03CR) 10Mattflaschen: [C: 04-1] "Pre-existing issue, but flow_subscription is totally unused. Rather than update it further, we should drop it." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [13:26:58] (03CR) 10Mattflaschen: "Reviewed the rest and it looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [13:27:40] (03CR) 10Sbisson: [C: 032] Clean up icons using svgo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319341 (owner: 10Catrope) [13:36:34] (03Merged) 10jenkins-bot: Clean up icons using svgo [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319341 (owner: 10Catrope) [13:43:28] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: Flow fatal: Default format of 'topic-title-html' or 'topic-title-wikitext' can only be used to format topic titles. - https://phabricator.wikimedia.org/T149827#2768318 (10Mattflaschen-WMF) [14:06:58] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Flow, 07Wikimedia-log-errors: Flow fatal: Default format of 'topic-title-html' or 'topic-title-wikitext' can only be used to format topic titles. - https://phabricator.wikimedia.org/T149827#2768361 (10Mattflaschen-WMF) From IRC: ``` [Thursday, Nov... [14:07:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per Stephane." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/314686 (https://phabricator.wikimedia.org/T145439) (owner: 10Mounicamergify) [14:09:52] Started working on the topic title patch. [14:10:07] Have to go to the airport now, will join meetings or post on Hangout as the timing allows. [14:10:37] matt_flaschen: Alright, safe travel [14:16:01] (03CR) 10Siebrand: "I think Roan's reasoning makes sense. I'd prefer to leave this message unchanged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/317860 (https://phabricator.wikimedia.org/T149061) (owner: 10Mooeypoo) [15:27:52] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2768562 (10jmatazzoni) Responding (belatedly) to @Samwalton9 's suggestion for wording o... [15:45:15] (03CR) 10Catrope: "Fair enough, will fix" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [15:56:27] (03PS2) 10Catrope: Add primary keys to the remaining Flow tables [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) [16:01:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#2768659 (10Pginer-WMF) [16:01:41] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, 07Schema-change: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2768660 (10Catrope) Matt pointed out that the `flow_subscription` table is unused and should just be dropped entirely (I checked and it's... [16:03:10] (03CR) 10Marostegui: [C: 031] "Looks good!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319358 (https://phabricator.wikimedia.org/T149819) (owner: 10Catrope) [16:03:29] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#2768689 (10Pginer-WMF) [16:11:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements-RC-Page: Build user interface for the Highlight Tools and implement highlighting in the Edit Results List - https://phabricator.wikimedia.org/T149467#2768699 (10Pginer-WMF) [16:50:09] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2768833 (10Trizek-WMF) [17:29:11] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2768977 (10Halfak) > On the other hand, precision of 55% is too low for a "very likely" setting. 55% is... [17:49:56] 06Collaboration-Team-Triage, 10Flow: Flow needs accesskey to submit - https://phabricator.wikimedia.org/T149929#2769130 (10jhsoby) [18:28:24] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Adjust Notification Preferences page language to match re-categorization - https://phabricator.wikimedia.org/T149365#2769274 (10Catrope) I agree with the general de-branding sentiment (your point #1). Flow isn't really de-branded at th... [18:28:25] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Schema-change: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#2769308 (10Catrope) [18:28:25] (03PS1) 10Catrope: Delete unused flow_subscription table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/319642 (https://phabricator.wikimedia.org/T149936) [18:28:26] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, 07Schema-change: Add primary keys to remaining Flow tables - https://phabricator.wikimedia.org/T149819#2769339 (10Catrope) >>! In T149819#2768660, @Catrope wrote: > Matt pointed out that the `flow_subscription` table is unused and should jus... [18:28:26] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, 07Schema-change: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#2769308 (10Catrope) SQL: https://gerrit.wikimedia.org/r/#/c/319642/1/db_patches/patch-drop-flow_subscription.sql [18:30:40] (03PS7) 10Sbisson: convertToText: include full attribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314299 [18:31:19] (03PS8) 10Sbisson: convertToText: include full attribution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/314299 [18:47:35] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Adjust Notification Preferences page language to match re-categorization - https://phabricator.wikimedia.org/T149365#2769449 (10Trizek-WMF) Use Flow as a brand is really useful: you don't need to find a way to translate "Flow". (In Fre... [19:17:06] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2769549 (10Samwalton9) @jmatazzoni That'... [19:41:02] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2769614 (10KMuthu) @Pginer-WMF , Thank y... [19:46:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2769629 (10Samwalton9) @KMuthu The link... [19:49:41] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2769634 (10KMuthu) >>! In T132084#276962... [20:24:06] (03PS3) 10Kmuthu: [WIP] Create notification for The Wikipedia Library users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/318140 (https://phabricator.wikimedia.org/T132084) [20:27:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Create notification for The Wikipedia Library users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/318140 (https://phabricator.wikimedia.org/T132084) (owner: 10Kmuthu) [20:30:42] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements: Fine-tune and finalize ORES score ranges for the Quality and Intent filters - https://phabricator.wikimedia.org/T149761#2769736 (10jmatazzoni) @Halfak > 55% is 22 more likely than random. Yes, 22 times more likely should... [21:24:50] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Accessibility: Special:Notifications has bad accessibility of pagination - https://phabricator.wikimedia.org/T149953#2770011 (10TheDJ) [21:26:14] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Accessibility: Special:Notifications has bad accessibility of settings button - https://phabricator.wikimedia.org/T149954#2770043 (10TheDJ) [21:27:34] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Accessibility: Special:Notifications has bad accessibility of settings button - https://phabricator.wikimedia.org/T149954#2770064 (10TheDJ) [21:47:19] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Notifications page linewrap issue for long content in excerpt - https://phabricator.wikimedia.org/T147802#2770204 (10Etonkovidova) Checked on testwiki 1.29.0-wmf (and on betalabs) - Chrome, FF, Safari - no problem with prop... [23:27:19] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications: Adjust Notification Preferences page language to match re-categorization - https://phabricator.wikimedia.org/T149365#2770542 (10jmatazzoni) > "Flow discussion" works for me. what about "Discussion (Flow)"? If that doesn't work, we ca... [23:51:21] (03PS1) 10Kmuthu: Add shadow to the notifications top toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/319764 (https://phabricator.wikimedia.org/T140964) [23:56:50] (03CR) 10jenkins-bot: [V: 04-1] Add shadow to the notifications top toolbar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/319764 (https://phabricator.wikimedia.org/T140964) (owner: 10Kmuthu)