[00:24:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3433826 (10jmatazzoni) [00:37:47] matt_flaschen: Thanks for reviewing my pager patch. I replied to your comments and uploaded a new PS that fixes some of the trivial things (but not the less trivial things yet), and also expands the commit message with stuff I had lying around in my COMMIT-MSG file locally but hadn't actually submitted [00:39:04] RoanKattouw, cool, I'll re-review when the deeper change is updated, unless there's something I should specifically look at now. [00:40:22] RoanKattouw, while you're here (and CCing jmatazzoni_), thoughts on priority of T158025 and if we should have a engineer meeting about it? [00:40:23] T158025: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025 [00:41:14] Hmm, not terribly high prio IMO especially given that it would take a bunch of effort [00:41:24] And we have a bunch of stuff on our plates already [00:42:07] We could also see if Adam Wight is interested in taking that on, now that the ORES team (called the Scoring Platform team) has, in him, an engineer with MW experience on board [00:42:32] And /technically/ I suppose this would be in their area [00:43:06] RoanKattouw, yeah, I agree. We (either GC, SP, or combo) definitely could do it, but there's cross-team coordination and fairly significant schema changes no matter how we slice it. [00:43:23] And it doesn't seem that high priority to me. I just wrongly thought it was easy at one point. [00:43:51] Yeah now that we know it's not, it's probably a good thing to consider sacrificing [00:44:19] (going off line for a bit but will probably be back on in the next 30 mins or so) [00:45:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3433885 (10Mattflaschen-WMF) [00:45:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3023878 (10Mattflaschen-WMF) [00:46:39] RoanKattouw, are you around? I have a question relatd to unit tests with 'single_option' group [00:47:10] RoanKattouw, so, the definition of this group is that it must have a value; it either has the default value from the group (sent by the definition) or, if it doesn't have that, it selects the first item [00:47:15] it should never have an empty value [00:47:24] (unless empty is a value on its own, I guess) [00:47:50] anyways -- model.getFiltersFromParameters( {} ) --> this is supposed to be relatively distinct from model state [00:48:01] so up until now it returned all params with empty/falsey values [00:48:23] does it make sense, though, to do that to all params **except** single_option -- so, they are outputted with whatever was set as their "base" (default or first item) ? [00:48:35] on one hand, if I don't do that it seems inconsistent to me [00:48:54] on the other, it means that sending a blank object does rely on some model state (albeit original base one) [00:49:05] then again, we rely on some model state here in terms of *what* parameters it knows about anyways [00:49:09] RoanKattouw, does that sound sane? [00:49:36] (I just noticed the time, read/answer tomorrow, whoops) [00:55:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3433894 (10jmatazzoni) [01:07:09] mooeypoo: Sorry I'm here now [01:07:18] You don't need to be.... it's late! [01:07:38] (Anyways, I decided "yes" is my answer; the group will always have a single valid value-- unless you say otherwise?) [01:07:42] Thought I would be back sooner. For future reference: from the office to Market & Van Ness, it's way faster to take the subway, I should have done that instead of biking [01:07:59] Really?! [01:08:04] That sounds wrong [01:08:39] At least at 6pm [01:08:54] There are sooo many traffic lights on Market [01:09:03] And buses to get stuck behind [01:09:11] I guess I should have taken Howard, that would have been faster [01:11:01] Oh yeah, traffic [01:11:11] It's not like there are dedicated bike lanes anywhere >.< [01:11:19] mooeypoo: I think what you said sounds good to me, everything should be set to its default if you pass in {}, and it so happens that the default is usually empty string or false except for these things [01:11:28] There are on Market but only west of 8th [01:11:34] On Howard there's one all the way [01:11:39] RoanKattouw, wait, not everything is set to default -- we had this initially as a discussion. All other filters are set to FALSE [01:11:45] Oh right [01:11:48] Yes [01:11:57] ... I can change that ,but it changes the way things work, especially since we're using this to set up "base filter state" [01:11:59] But the point is, false is at least a valid value for those things [01:12:06] Right, so s/default/base value [01:12:07] So this will be the only ones that do get "default" (or first item) [01:12:14] exactly [01:12:20] Base values will just have to not be empty/false for single_value things [01:12:36] yeah it just might be a tad confusing because these use default if they have it, but first-item if not, as opposed to the others who use *falsey values* always in that case [01:12:43] * mooeypoo nods [01:12:55] Which actually solves a bunch of other things that I encountered btw [01:13:08] like not reading properly from the URL because overriding with "base" >.< [01:13:11] meh [01:13:16] Also it needs to match what happens if you don't specify the parameter and have urlversion=2 [01:13:25] Which for limit, days etc is the default [01:13:31] Right, which is the default, exactly [01:13:45] I just wanted to make sure I don't build this because I only think of limit/days [01:13:55] "what happens if I drop this param in urlversion=2" is pretty much the definition of "base value", I feel like [01:14:12] Well, not quite, because other filters do get a value from wiki-default [01:14:15] so not exactly [01:14:24] it's more like "what do we minimize the URL to" maybe? [01:14:40] Not in urlversion=2 do they? [01:14:44] empty-params are minimized; default-values for single_options can be minimized [01:14:48] no [01:14:54] oh oh yes [01:14:58] Right, so as I said: -- [01:14:59] yeah [01:15:03] "in urlvesion=2" I misread [01:15:34] yeah same idea, we minimize to base values which is the same as "if I drop this param in urlversion=2" [01:15:41] Yes [01:15:54] So, with that definition of "base value", it's clear that the base value for limit has to be 50, otherwise things break [01:17:21] yup [01:17:23] also [01:17:26] \o/ unit tests pass [01:17:45] I added another single_option group to the tests [01:17:49] so one has a default value and one doesn't [01:17:57] it tests that they always have a base value -- the default, or the first item [01:18:40] Also it's the only group that pre-selects an item, because of that [01:18:55] the rest wait for the status -- either from the URL or from a query or from defaults [01:23:27] RoanKattouw, there might be something you'll be a bit meh about in this commit -- the UI buttons are waiting to be initialized after an event [01:23:32] because they have to wait for the model to be ready [01:23:48] so onModelInitialize -> that's when I actually set up the UI with the popup + buttons, etc. [01:23:56] I couldn't find a way around it. [01:24:19] There is a precedent for that, though, with dialogs [01:24:26] getSetupProcess or whatever it's called [01:25:08] Why is it delayed? What do you not know at the start? [01:25:27] The items :\ [01:25:30] As you know I don't like onModelInitialize stuff but you write that kind of code faster than I can spot it so there's still a bunch of those [01:25:39] It needs to get the item definition from the constructor in initializeFilters [01:25:47] OK sure [01:26:00] But why is that not able to be set up synchronously at the start? It's just URL parsing right? [01:26:16] Yeah the onModelInitialize exists because of those things -- the model is built, and the UI is built, but the information is then processed and delivered to the model - including what filters we have and their defaults, etc. [01:26:25] Because the options THEMSELVES are filter items [01:26:32] [ 5, 10, 20, 500 ] [01:26:46] So why can't the UI be built later? [01:26:49] ^ those are defined in the filters. You can change and say [ 10, 14, 56, 90 ] in the definition [01:26:58] oh, well, it's attached to FilterWrapperWidget [01:27:01] What is async in processing and delivering the information to the modl? [01:27:02] which is created on init [01:27:16] We attach that on init, and then we fill it up [01:27:27] Cause if nothing is async, you could change the order of operatoins in the init function, right? [01:27:32] in the case of most things, we just fill up **menu items** in onModelInitialize so that's not horrible [01:27:42] but in the case of the value picker, it's OO.ui.ButtonOptionWidgets [01:27:50] hm [01:27:52] I guess so [01:28:59] I need to look into that, good point [01:29:10] It's just the way we've done it so far -- the ui is built, then waits for the data to pass [01:29:21] this also means, theoretically, that we can empty the model and reinitialize the filters [01:29:26] Yeah and I've been complaining about that since its inception :P [01:29:26] but we'll never do that mid-session anyways [01:29:36] haha [01:29:44] Indeed [01:30:11] Instead of onModelInitialize widgets would examine the model state in their constructors and initialize themselves there [01:30:24] Yeah, I guess we can do that. [01:30:37] Not urgent obviously but that's my pet peeve with all this code [01:30:45] It always felt like having the UI and model be separate (and so the ui just listens to when the model is done) made it more generic [01:30:48] but you're right [01:31:07] I mean, it doesn't matter either way, except for things like this where i need to wait for the model to be ready to set up the buttons [01:31:07] If I talk about it often enough, eventually there will be a little Roan on your other shoulder [01:31:15] (The first shoulder already having a little Stephane of course) [01:31:17] That's the goal [01:31:26] There already is, it tends to argue with a tiny Timo [01:31:38] and the a little James_F shushes them [01:31:47] hahaha [01:32:35] I remember there was an issue when I tried to build the UI from the model and not wait for the event, but when I think of it it sounds ridiculous, so it may have just been a silly thing and not a real problem [01:32:48] RoanKattouw, anyways, this is a big enough change that we might want it in its own commit [01:32:51] above or below [01:32:58] Oh yes definitely [01:33:01] ok grunt is driving me crazy [01:33:08] 78:21 error 'defaultItem' is assigned a value but never used no-unused-vars [01:33:19] I take it off, I get [01:33:20] 163:4 error 'defaultItem' is not defined no-undef [01:33:22] the hell, grunt! [01:33:44] Does line 1643 write but not read the variable? [01:33:47] *163 [01:34:17] .... [01:34:19] ......... [01:34:22] yes it does [01:34:25] haha [01:34:53] Seems I don't even need that [01:34:57] that was confusing [01:35:23] I misread the error to say it was undefined, and then complained it was defined and not used [01:35:27] rather than assigned and not used [01:36:58] (PS15) Mooeypoo: [wip] RCFilters: Add range group filters - limit and days [core] - https://gerrit.wikimedia.org/r/361186 (https://phabricator.wikimedia.org/T162784) [01:37:02] \o/ [01:37:23] now... it should pass qunit tests AND grunt. I'll be testing it properly and further tomorrow [01:37:31] also, RoanKattouw did you see I added the logging thing? [01:37:57] https://gerrit.wikimedia.org/r/#/c/364922/ && https://gerrit.wikimedia.org/r/#/c/364923/ [01:38:00] RoanKattouw, ^ [01:38:13] I am having trouble testing the log, but I put in console.logs and it seemed to be working [01:38:42] Yeah I saw but haven't reviewed yet [01:40:02] * mooeypoo nods [01:40:11] just wanted to make sure you saw, since I couldn't find the proper task to attach this to [01:40:12] mooeypoo: So is limit/days still WIP? [01:40:23] RoanKattouw, the only reason is because I found a bug with reading from the url [01:40:28] and I'm not 100% sure I fixed it [01:40:42] other than that, it should be ready, I just need to test it properly again [01:40:50] Re not attached to a task: don't worry, I have a Gerrit dashboard, it's hard for me to not stumble upon your commits [01:40:58] oh yeah [01:41:01] I forgot you use that [01:41:22] Anyways, I just need to double-check the limit/days commit again.. i'll do that when I get back from the gym [01:41:37] Should be okay (knock on wood) now that the base is properly set [01:42:27] meh, it doesn't work >.< goddamnit [01:43:28] ok i'm running to do some training, I'll debug when I get back. this is annoying. [03:09:51] RoanKattouw, limit/days is out of WIP [03:09:55] found the issue! [03:09:57] fixed it [03:09:58] \o/ [03:13:24] Yay [03:13:27] Will review [04:54:19] 10Collaboration-Team-Sprint-P-2015-02-11/q3, 10Collaboration-Team-Triage, 10Thanks, 10Continuous-Integration-Infrastructure, and 2 others: Thanks is broken again (Mobile Thanks needs qunit tests) - https://phabricator.wikimedia.org/T86687#3434100 (10Krinkle) [05:06:16] 10Collaboration-Team-Triage, 10Flow: QA: qunit test should have caught ext.flow.new error - https://phabricator.wikimedia.org/T73070#3434147 (10Krinkle) 05Open>03Resolved a:03Krinkle This has since been solved by a core structure test that asserts a non-error state on all loaded modules. [05:06:24] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Core-Tests: QA: qunit test should have caught ext.flow.new error - https://phabricator.wikimedia.org/T73070#3434150 (10Krinkle) [05:07:39] 10Collaboration-Team-Triage, 10Notifications, 10Technical-Debt: Get rid of wgEchoConfig hack for qunit tests - https://phabricator.wikimedia.org/T118488#3434152 (10Krinkle) [05:07:49] 10Collaboration-Team-Triage, 10Notifications, 10Technical-Debt: Get rid of wgEchoConfig hack for qunit tests - https://phabricator.wikimedia.org/T118488#1801613 (10Krinkle) (For the record, still there anno 2017) [07:02:28] (03CR) 10Mattflaschen: [C: 04-1] "Just followup on the date/timestamp thing." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [07:04:54] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10Outreach-Programs-Projects, and 5 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3434250 (10Mattflaschen-WMF) [07:06:08] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10WorkType-NewFunctionality: Icon for - https://phabricator.wikimedia.org/T170517#3434251 (10Mattflaschen-WMF) [07:06:15] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10WorkType-NewFunctionality: Icon for Article Reminder - https://phabricator.wikimedia.org/T170517#3434251 (10Mattflaschen-WMF) a:05Eee888>03None [09:02:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3434519 (10Eee888) [09:26:28] 10Collaboration-Team-Triage, 10Flow: Flow boards should use paginated scrolling - https://phabricator.wikimedia.org/T132817#2211250 (10Trizek-WMF) >>! In T132817#3431379, @Elitre wrote: > Right now, because I need to find specific words/strings on a board, I either need a way to load an entire board at once, o... [09:30:23] 10Collaboration-Team-Triage, 10Flow, 10Epic: Reconsider how to navigate on a Flow board - https://phabricator.wikimedia.org/T170530#3434598 (10Trizek-WMF) [09:33:38] 10Collaboration-Team-Triage, 10Flow: Flow boards should use paginated scrolling - https://phabricator.wikimedia.org/T132817#3434617 (10Trizek-WMF) [09:33:40] 10Collaboration-Team-Triage, 10Flow, 10Tracking: Search in Flow boards (tracking) - https://phabricator.wikimedia.org/T104631#3434618 (10Trizek-WMF) [09:33:43] 10Collaboration-Team-Triage, 10Flow, 10Notice, 10Roadmap, and 2 others: Basic search on Flow board (tracking) - https://phabricator.wikimedia.org/T76823#3434619 (10Trizek-WMF) [09:33:47] 10Collaboration-Team-Triage, 10Flow, 10Epic: Reconsider how to navigate on a Flow board - https://phabricator.wikimedia.org/T170530#3434616 (10Trizek-WMF) [09:59:59] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3434699 (10Trizek-WMF) [10:30:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3434782 (10Trizek-WMF) > Notify me about this article when I asked. I know the global task has been named Article... [10:42:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3434790 (10Eee888) [10:43:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3362850 (10Eee888) Thanks @Trizek-WMF , I'll fix the "article"->"page" and the tipo of course :) If you'll look at... [11:11:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3434828 (10Trizek-WMF) >>! In T168385#3434790, @Eee888 wrote: > If you'll look at the attachment I've just added, I... [11:17:35] (03PS55) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [11:17:45] (03CR) 10Foxy brown: New Article Reminder API (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [11:18:00] (03PS56) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [11:18:15] (03PS28) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [11:18:24] (03PS20) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [11:24:57] (03CR) 10Foxy brown: "Checked and verified the API examples" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [13:15:29] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Patrolled changes are shown as unpatrolled in RC Filters results - https://phabricator.wikimedia.org/T162020#3435196 (10Trizek-WMF) 05stalled>03declined The user doesn't have the problem anymore. [14:22:01] 10MediaWiki-Watchlist, 10Wikidata: Wikidata wbremoveclaims/wbcreateclaims errors in Wikipedia watchlists - https://phabricator.wikimedia.org/T170573#3435532 (10Mike_Peel) [14:23:24] 10MediaWiki-Watchlist, 10Wikidata: Wikidata wbremoveclaims/wbcreateclaims errors in Wikipedia watchlists - https://phabricator.wikimedia.org/T170573#3435547 (10Mike_Peel) The 'diff' and 'hist' links aren't working correctly either - they point towards the page on enwp, which doesn't show any changes, rather th... [14:35:39] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3435679 (10Trizek-WMF) I've checked on Meta and I haven't seen anything ther... [15:45:34] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Link to combined change on watchlist wrong for Wikidata edits - https://phabricator.wikimedia.org/T170122#3436064 (10matej_suchanek) Unfortunately, I'm afraid this needs to be fixed in core. The code is not much flexible. [16:03:54] 10Collaboration-Team-Triage, 10Notifications: Option to disable notifications about 1st, 10th, etc. edit - https://phabricator.wikimedia.org/T169924#3436135 (10MF-Warburg) How is this blocked on global preferences? I'd say the first step would be having a preference for this at all, then it could at least be s... [16:34:25] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3436299 (10TBolliger) Roan and I agreed to pull it from Wednesday's release. [16:35:40] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3436307 (10Catrope) Sorry for not communicating that earlier. Some annoying... [16:38:39] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Sometimes pop-up filter list in Recent Changes won't dismiss - https://phabricator.wikimedia.org/T170600#3436347 (10kaldari) [16:38:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team: Define a process for adding ORES filters to new wikis when ORES is enabled on those wikis - https://phabricator.wikimedia.org/T164331#3436361 (10Catrope) @awight: A couple weeks a... [16:39:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team: Add a new config setting to enable ORES UI features - https://phabricator.wikimedia.org/T170500#3436364 (10Catrope) Dupe of {T167908} ? At least its patch does exactly what this t... [16:40:03] (03CR) 10Mattflaschen: [C: 04-1] New Article Reminder API (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [16:59:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team: Add a new config setting to enable ORES UI features - https://phabricator.wikimedia.org/T170500#3436451 (10awight) [16:59:46] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3436454 (10awight) [17:06:32] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3436494 (10awight) Yes, that's perfect! My curren... [17:07:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team: Add a new config setting to enable ORES UI features - https://phabricator.wikimedia.org/T170500#3436501 (10awight) [17:07:13] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3436502 (10awight) [17:07:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team: Define a process for adding ORES filters to new wikis when ORES is enabled on those wikis - https://phabricator.wikimedia.org/T164331#3436500 (10awight) [17:25:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as a conflict - https://phabricator.wikimedia.org/T162630#3436622 (10Catr... [17:36:00] 10Collaboration-Team-Triage, 10Notifications, 10Reading-Web-Backlog, 10Mobile, and 3 others: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#3436708 (10Jdlrobson) [17:36:29] 10Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922715 (10Jdlrobson) [17:36:46] 10Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#2922715 (10Jdlrobson) [17:40:38] 10Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Mobile mentions should link to mobile view and not desktop view - https://phabricator.wikimedia.org/T154750#3436742 (10Jdlrobson) [17:40:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice-collaboration: Announce to communities the change for RecentChangesText... - https://phabricator.wikimedia.org/T167945#3436749 [17:47:27] 10Collaboration-Team-Triage, 10Notifications, 10MinervaNeue, 10Reading-Web-Backlog: SkinMinerva shouldn't know about Echo service - https://phabricator.wikimedia.org/T165190#3436820 (10Jdlrobson) [17:48:08] (03PS21) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [17:50:11] (03PS57) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [17:50:24] (03CR) 10Foxy brown: New Article Reminder API (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [17:50:45] (03PS29) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [17:50:53] (03PS22) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [18:12:54] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [19:18:49] going to lunch, bbiab [19:34:15] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3437413 (10Catrope) >>! In T167908#3436494, @awigh... [19:46:17] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3437430 (10awight) @Catrope Cool. I think I can p... [20:40:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/365116 (owner: 10L10n-bot) [20:40:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365119 (owner: 10L10n-bot) [21:29:10] 10MediaWiki-Watchlist, 10Africa-Wikimedia-Developers, 10Easy: Remove "viewmywatchlist" user right from anonymous users - https://phabricator.wikimedia.org/T71301#724275 (10Eugene233) Great discussion made so far @He7d3r. Is this still open for a fix? This is so i can do that ASAP. Thanks [22:42:28] 10Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks, 10Community-Wishlist-Survey-2015: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#3437974 (10happy5214) [23:31:28] omg [23:31:33] My own code comment just quacked at me [23:31:45] RoanKattouw, ^ [23:32:26] I was explaining why this was a super bad idea and why if we need to generalize, really, we should do this in another way, like for example--- and then I realized wait, I... I should do it that way instead. [23:32:43] (Though its still crappy) [23:47:21] OMG MY CODE WORKED [23:47:36] I am way too surprised for comfort here