[01:05:40] 10DBA, 10Community-Tech-Sprint, 10Patch-For-Review: Issue with maintenance script: SELECTing revisions with high rev_id is painfully slow - https://phabricator.wikimedia.org/T175962#3612603 (10IKhitron) I see. Thank you. [18:21:17] 10DBA, 10Community-Tech-Sprint, 10Patch-For-Review: Issue with maintenance script: SELECTing revisions with high rev_id is painfully slow - https://phabricator.wikimedia.org/T175962#3613269 (10MusikAnimal) @MaxSem Could we kill the currently running script? It's now taking [[ https://tendril.wikimedia.org/re... [18:43:35] 10DBA, 10Community-Tech-Sprint, 10Patch-For-Review: Issue with maintenance script: SELECTing revisions with high rev_id is painfully slow - https://phabricator.wikimedia.org/T175962#3609201 (10Reedy) >>! In T175962#3613269, @MusikAnimal wrote: > I don't know how the deployment script you used works, but hope... [18:55:06] 10DBA, 10Community-Tech-Sprint, 10Patch-For-Review: Issue with maintenance script: SELECTing revisions with high rev_id is painfully slow - https://phabricator.wikimedia.org/T175962#3613309 (10MusikAnimal) >>! In T175962#3613284, @Reedy wrote: > Not really... But as you've subclassed `LoggedUpdateMaintenance... [22:17:58] 10DBA, 10MediaWiki-Core-Tests, 10MediaWiki-Maintenance-scripts: rev_comment needs a default value in unit tests - https://phabricator.wikimedia.org/T176041#3613456 (10Huji) p:05Low>03High I was wrong above. And I think I have uncovered a bigger issue. I installed MediaWiki again, and run `mysqldump` imm... [22:45:44] 10DBA, 10MediaWiki-Core-Tests, 10MediaWiki-Maintenance-scripts: rev_comment needs a default value in unit tests - https://phabricator.wikimedia.org/T176041#3611940 (10Reedy) ``` Modifying rc_comment field of table recentchanges ...done. ``` That's the offending updater chnge It's being run... on every run.... [22:47:14] 10DBA, 10MediaWiki-Core-Tests, 10MediaWiki-Maintenance-scripts: rev_comment needs a default value in unit tests - https://phabricator.wikimedia.org/T176041#3613495 (10Reedy) Though, why is modifyField letting it run? It should be checking for the updatelog row... ```lang=php /** * Modify an existing fiel... [23:17:31] 10DBA, 10MediaWiki-Core-Tests, 10MediaWiki-Maintenance-scripts, 10Patch-For-Review: rev_comment needs a default value in unit tests - https://phabricator.wikimedia.org/T176041#3613502 (10Reedy) Kinda hacky... But if one field has been affected on a dev wiki by this bug, all of them would be; granted, it sh...