[06:20:31] 10Blocked-on-schema-change, 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Schema-change: Remove unused bundling DB fields - https://phabricator.wikimedia.org/T143763 (10Marostegui) p:05Triage→03Normal x1 runs row based replication, which means this may break replication if ex... [06:20:48] 10Blocked-on-schema-change, 10Growth-Team, 10Notifications, 10Patch-For-Review, 10Schema-change: Add index on event_page_id - https://phabricator.wikimedia.org/T143961 (10Marostegui) p:05Triage→03Normal [06:47:36] 10DBA, 10Patch-For-Review: Document clearly the mariadb backup and recovery setup - https://phabricator.wikimedia.org/T205626 (10Marostegui) I have done a first full reading and just fixed minor things: https://wikitech.wikimedia.org/w/index.php?title=MariaDB/Backups&action=history Thanks for putting all this... [06:54:04] 10DBA, 10MediaWiki-Database, 10WikimediaEditorTasks, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Choose DB/Cluster for WikimediaEditorTasks tables - https://phabricator.wikimedia.org/T218302 (10Marostegui) extension1 (x1) looks good to me as a location for those. Can you also post... [07:35:04] I have prepared the patches for the possible failover if the network maintenance goes bad [07:40:30] thanks [07:46:19] latest changes: https://gerrit.wikimedia.org/r/496714 [07:46:52] I realized that we were going to keep snapshots for 18 days every day [07:51:55] what do you mean [07:52:17] no retention config was passed to the backup_mariadb script [07:52:27] (it was not an option, in fact) [07:52:41] so the default was 18 days (what we use for dumps) [07:53:11] meaning we would have 18 + 1 * 2TB of enwiki backups (more later if more sections were setup) [07:53:21] oh.... [07:53:29] I added https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/494899/23..25/modules/profile/templates/mariadb/daily-snapshots-codfw.cnf.erb [07:53:37] and the code to support that, of course [07:54:02] Ah nice! [07:54:07] 1 meaning? [07:54:11] 1 day [07:54:13] 1 day per snapshot? [07:54:14] that [07:55:04] would that support 0.5 days? meaning 12h? [07:55:44] not at the moment [07:55:53] but you would get the same effect setting 0 [07:56:28] we can setup seconds instead [07:57:00] I don't want that patch to become too big, though, I would do that on a separate patch [07:57:09] sure sure, just asking . [07:57:24] note purging only has efect on backup creation [07:58:09] you would need an hourly cron calling WMFBackup('section' dict()).purgue_backups() [07:58:32] I have also changed a bit the logic [07:58:47] in the past purge_backups purged all backups of the same type [07:58:55] now it only purges those of the same section [07:59:57] (and type) [08:03:45] Ah cool, makes a lot more sense indeed [13:05:03] 10Blocked-on-schema-change, 10MediaWiki-extensions-UrlShortener: Add usc_deleted to urlshortcodes - https://phabricator.wikimedia.org/T218397 (10Ladsgroup) [13:55:37] 10Blocked-on-schema-change, 10MediaWiki-extensions-UrlShortener: Add usc_deleted to urlshortcodes - https://phabricator.wikimedia.org/T218397 (10Marostegui) a:03Marostegui Should be easy and a good test for T217453#5011169 I will try to tackle this next week [13:55:46] 10Blocked-on-schema-change, 10MediaWiki-extensions-UrlShortener: Add usc_deleted to urlshortcodes - https://phabricator.wikimedia.org/T218397 (10Marostegui) p:05Triage→03Normal [14:18:22] 10Blocked-on-schema-change, 10MediaWiki-extensions-UrlShortener: Add usc_deleted to urlshortcodes - https://phabricator.wikimedia.org/T218397 (10Reedy) [19:59:04] 10DBA, 10MediaWiki-Database, 10WikimediaEditorTasks, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Choose DB/Cluster for WikimediaEditorTasks tables - https://phabricator.wikimedia.org/T218302 (10Mholloway) @Marostegui Sure: === wikimedia_editor_tasks_entity_description_exists This... [21:39:26] 10DBA, 10Core Platform Team, 10MediaWiki-General-or-Unknown, 10Schema-change, 10Technical-Debt (Deprecation): Remove use of legacy page.page_restrictions field - https://phabricator.wikimedia.org/T218446 (10Krinkle) [21:39:36] 10DBA, 10Core Platform Team, 10MediaWiki-General-or-Unknown, 10Performance-Team (Radar), and 2 others: Remove use of legacy page.page_restrictions field - https://phabricator.wikimedia.org/T218446 (10Krinkle) [21:41:22] 10DBA, 10Core Platform Team, 10MediaWiki-General-or-Unknown, 10Performance-Team (Radar), and 2 others: Remove use of legacy page.page_restrictions field - https://phabricator.wikimedia.org/T218446 (10Krinkle) Marking as perf recommendation for the additional queries required currently. To reduce the overh... [22:46:46] 10DBA, 10Quibble: Optimize MySQL settings for MediaWiki CI / Quibble - https://phabricator.wikimedia.org/T218196 (10Krinkle)