[02:57:05] As of yesterday, mediawiki core has tables defined in abstract schema and the sql DDL is generated instead of handwriting them [02:57:05] https://github.com/wikimedia/mediawiki/blob/master/maintenance/tables.json [02:57:05] https://github.com/wikimedia/mediawiki/blob/master/maintenance/tables-generated.sql [02:57:05] Welcome to the new world order 😎 [04:14:42] Amir1: nice, is tables.sql still at where it used to be? [04:15:02] yup but it's shrinking [04:15:17] so it doesn't have everything anymore [04:15:35] you need to run tables-generated.sql on top of it [04:16:14] so if I wanted to check a table definition I should go to that new file? [04:16:27] like that: https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintenance/blob/master/addWiki.php#L251 [04:16:40] "so if I wanted to check a table definition I should go to that new file?" <- It can be in one of them [04:17:12] now mostly it's in the old file but slowly you might have to check the new file instead [04:17:32] we migrated 2 tables out of 55 so far [04:17:44] marostegui: does it make sense? [04:18:33] yeah it does, I just wanted to make sure I knew which is the canonical file now [04:18:39] as I pretty much use it everyday [04:19:24] sorry for inconvenience. I hope it makes things better and easier for you [04:19:33] (once it's fully done) [04:20:26] do you have an rough idea on when that will be? [04:21:44] it really depends on how fast we can migrate tables and how fast we can review it. Some are pretty tricky (like the ones that use ENUM) but most of them should be rather easy [04:22:19] so my answer: most of them: pretty soon like a month or two, the long tail: might take even a year [04:22:33] wooow :) [04:22:36] ok [04:22:57] no problem I think it is a win anyways in the long run [04:23:40] I also want to make the ALTER TABLEs auto generated too, hope that comes soon [04:24:07] it's just I'm doing it in my volunteer capacity and it's pretty limited with a million other things I'm excited to do [04:24:32] hahaha [04:24:50] the auto generated alters will be a pretty cool thing indeed [04:28:27] Fun thing: the sqlite schema is built from the mysql using this beauty: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/libs/rdbms/database/DatabaseSqlite.php#894 [04:28:27] But at least, it's consistent with mysql. Postgres has basically one or two drifts with mysql in every table. One table is missing!!! [04:28:49] ahahaha [04:29:03] I forgot that you'd have to do generated tables for those two as well [04:31:26] yeah, that's one of the biggest reasons of abstracting. Generating them is just running a maintenance script. I tried to document as much as possible in https://www.mediawiki.org/wiki/Manual:Schema_changes [04:31:33] Feel free to edit/change [04:34:01] Will take a look [04:34:04] Thank you [04:49:46] 10DBA, 10Analytics, 10Patch-For-Review: Upgrade analytics dbstore databases to Buster and Mariadb 10.4 - https://phabricator.wikimedia.org/T254870 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by marostegui on cumin1001.eqiad.wmnet for hosts: ` ['dbstore1004.eqiad.wmnet'] ` The log can be found... [05:10:19] 10DBA, 10Analytics, 10Patch-For-Review: Upgrade analytics dbstore databases to Buster and Mariadb 10.4 - https://phabricator.wikimedia.org/T254870 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['dbstore1004.eqiad.wmnet'] ` and were **ALL** successful. [05:12:47] 10DBA, 10Analytics: Upgrade analytics dbstore databases to Buster and Mariadb 10.4 - https://phabricator.wikimedia.org/T254870 (10Marostegui) [07:09:52] Amir1: very cool work :) [07:10:19] 10Blocked-on-schema-change, 10DBA, 10MachineVision, 10SDC-Statements (Machine-vision-depicts), and 2 others: Review & apply schema changes for T250748 - https://phabricator.wikimedia.org/T255003 (10Marostegui) [07:17:04] 10Blocked-on-schema-change, 10DBA, 10MachineVision, 10Patch-For-Review, and 3 others: Review & apply schema changes for T250748 - https://phabricator.wikimedia.org/T255003 (10Marostegui) [07:17:14] 10Blocked-on-schema-change, 10DBA, 10MachineVision, 10Patch-For-Review, and 3 others: Review & apply schema changes for T250748 - https://phabricator.wikimedia.org/T255003 (10Marostegui) 05Open→03Resolved All done! [07:18:50] 10DBA, 10Cloud-Services, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Apply updates for MCR, actor migration, and content migration, to production wikis. - https://phabricator.wikimedia.org/T238966 (10Marostegui) 05Stalled→03Open Thanks for... [07:34:39] kormat: thanks. Beware, this means making schema changes in core will be easier (= more work for our DBAs :D) [07:37:25] in that case i'd like to retract my statement ;) [07:37:43] 10DBA, 10Upstream, 10cloud-services-team (Kanban): Reimage labsdb1011 to Buster and MariaDB 10.4 - https://phabricator.wikimedia.org/T249188 (10doctaxon) @Marostegui: After the declining of ths task - have you guessed to take something better than MariaDB, if possible? Is our DB running with full capacity ag... [07:42:45] 10DBA, 10Upstream, 10cloud-services-team (Kanban): Reimage labsdb1011 to Buster and MariaDB 10.4 - https://phabricator.wikimedia.org/T249188 (10Marostegui) @doctaxon all the thoughts and future next steps are at T249188#6204681 Our labsdb hosts are running at full capacity now, and with two hosts on the Anal... [07:49:43] mwhahaha too late [07:50:00] damnit :) [08:07:06] good morning, as part of the testing stuff on buster on cumin hosts, could you try to use dbctl (RW) from cumin2001 when you get a chance? I've tried some RO operations and seems to work fine. [08:25:30] volans: I did this morning already [08:25:32] so far so good [08:25:34] I will keep doing it [08:26:31] great, thanks a lot! <3 [08:28:08] 10DBA: Upgrade dbproxyXXXX to Buster - https://phabricator.wikimedia.org/T255408 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by marostegui on cumin2001.codfw.wmnet for hosts: ` ['dbproxy2001.codfw.wmnet'] ` The log can be found in `/var/log/wmf-auto-reimage/202006160828_marostegui_19144.log`. [08:48:39] 10DBA: Upgrade dbproxyXXXX to Buster - https://phabricator.wikimedia.org/T255408 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['dbproxy2001.codfw.wmnet'] ` and were **ALL** successful. [08:52:46] 10DBA: Upgrade dbproxyXXXX to Buster - https://phabricator.wikimedia.org/T255408 (10Marostegui) [12:45:15] 10DBA: Setup a global admin account that can only read/have limited privileges to databases for safer debugging - https://phabricator.wikimedia.org/T254756 (10Marostegui) I do agree that having a separate account is something desirable, implementation is yet to be defined. While roles are probably what we want t...