[12:12:22] andre__: Hi [12:14:24] tinajohnson__, hey [12:15:44] for https://phabricator.wikimedia.org/T108937 (GCI task), the student has submitted what he was asked to but if I want him to add some more.. as in add OOjs..is that okay ? [12:17:32] tinajohnson__, Basically up to your judgement. How did you define the scope of the task? :) If it's "suddenly additional work" that the student could not guess before claiming the task, it would feel a bit unfair. If it's work that is *required* to properly fix the task, then you should [12:18:10] (and if it's additional and "separate", you could also create another separate task and encourage the student to claim that one) [12:19:18] andre__: The problem was to add a confirmation box and yes, he has done that. I had mentioned about OOjs dialogue boxes in the description actually. [12:19:34] andre__: I think another task would be okay [12:22:23] if in doubt, be generous. :) [12:22:35] (GCI should be fun for young students) [12:23:59] okay! creating another GCI task [12:33:12] addshore: Could you review and +2 https://gerrit.wikimedia.org/r/#/c/257494/7 whenever you get time ? I've tested and added my review ( it works fine, just few syntax errors ). [13:20:18] tinajohnson__: can you resolve https://phabricator.wikimedia.org/T120516, by making a new instance ? [13:20:37] so that we can get things deployed and ( might be easy for GCI students too to take a look at ) [13:20:58] just delete this one, and create a new one with bit more instance size [13:32:47] tonythomas: yup! thanks for reminding :) [13:32:56] yeah ! welcome [16:27:33] tinajohnson__: it works right? :) [16:33:32] tinajohnson__: and yes, GCI will be a great time to get lots of those small bit for newsletter done! [16:34:05] addshore: yeah, checking the patch once more to confirm [16:34:19] I already clicked the button ;) [16:36:49] Enjoy GCI and make the best out of it. :) [16:37:19] addshore: oh :) [16:37:47] tinajohnson__: feel free to adds newsletter tasks to the GCi thing and say I will also mentor them ;) [16:37:48] andre__: Yup! sure is amazing how fast these students are at fixing bugs [16:38:00] tinajohnson__: thats because there are so many :D [16:38:23] addshore: hehe :) [16:47:51] addshore: There were some 'adding space' before and after parenthesis left to do [16:48:35] indeed, although the code style was actually already bad in the current master version $( 'input[type=button]') [16:49:11] Should I push a patch since this patch is merged already? [16:49:21] yeh! [16:49:32] and ping me :) but do it in the next 10 mins! else I will be gone or a bit! [16:49:40] sure! [16:54:34] addshore: https://gerrit.wikimedia.org/r/257639 [16:55:30] done [16:55:38] Thanks! [16:59:51] hi tinajohnson__ (laate reply!) [17:02:08] Glaisher: Hey! [17:02:16] if you could find time to fill up what needs to be done here https://phabricator.wikimedia.org/T119487 , we could make this a GCI task :) [17:03:02] Glaisher: hey. I've wondered if you might also be interested in being a potential mentor in Google Code-In. But I admit I'm pretty clueless about your activity across codebases. :) Just pointing out: If you're interested, tell me. :) [17:03:52] tinajohnson__: will do later.. I've been away for a few days and my inbox is over 1000 messages atm! :P [17:04:18] andre__: will take a look at it later :) [17:04:42] Glaisher: sure! [17:06:25] I wonder how andre__ manages his inbox while being cc'd to all the tasks on phab :P [17:10:00] Ignorance and booze! :D [17:11:56] haha :D [17:13:11] :P [17:51:40] andre__, there is definitely no quorum in our team meeting today. If you want, we can skip it. [17:54:25] qgil, let's skip it then [17:55:06] while we could have a chat for 10min, I wouldn't really have any good input to potential items anyway [17:57:49] ok [18:00:07] ACK