[10:23:14] Glaisher: Hi! [11:32:26] hi tinajohnson__ [11:32:59] hi qgil ! [11:33:14] Fancy a chat about Newsletter extension? :) [11:33:27] sure :) [11:33:51] I was working on those bugs which have patches but still not merged [11:34:08] I saw progress in the validation task https://phabricator.wikimedia.org/T110491 [11:34:27] yeah, 2 patches [11:34:44] Do you see the end of the tunnel? [11:34:45] some more patches will be needed though [11:35:07] kind of [11:35:37] https://phabricator.wikimedia.org/T124527 [11:35:42] violetto's review [11:35:56] I wonder, do you need to work on that validation from scratch or is there a frameword, documentation, others' code to look at? [11:36:19] A big portuion of the problem is common to other web apps: there is a form and people shouldn't mess with it. [11:36:51] I think I've to look into newsletter's API and I don't think looking into other code will help me [11:37:00] ok [11:37:16] But there is a lot of documentation out there to help out [11:37:25] ok, good [11:37:36] violetto's review, I left my comments [11:37:42] Good, very useful. :) [11:37:57] Should we move that task to feature complete? [11:38:06] yeah [11:38:08] let's [11:38:36] (ah, about the validation task, just a reminder that I will request security review as soon as it is resolved, and we need to consider that then there will be still a queue...) [11:38:41] Glaisher has submitted 4 or 5 patches after her review [11:38:47] moved [11:39:05] yeah, okay [11:39:25] validation task needs to resolved ASAP [11:39:40] https://phabricator.wikimedia.org/T120519 before or after deplopyment? [11:39:55] We could ask violetto actually [11:40:08] I think after [11:40:14] but let's ask violetto [11:41:19] asked [11:41:24] most of the tasks in Feature complete do have a patch uploaded actually [11:41:32] just need to fix them completely [11:41:42] https://phabricator.wikimedia.org/T119060 I wonder whether Glaisher wants to have that before or after the deployment [11:41:50] ah [11:41:56] it says "ideally before" [11:42:04] Moving to feature complete then [11:42:17] okay [11:42:22] if we see that maybe it is not that ideal, we can move it for later [11:42:56] yeah [11:43:34] I think https://phabricator.wikimedia.org/T119060 can be a blocker of violetto's review, she also asked about thuis [11:44:01] oh okay [11:44:03] https://phabricator.wikimedia.org/T119059 [11:44:17] this has to be before deployment ? [11:44:48] If you ask me, not really. [11:45:15] yeah, I think the same [11:45:25] move out of Feature complete then ? [11:46:40] yes [11:46:44] moved [11:47:47] Oh, I had mised this comment from violetto https://phabricator.wikimedia.org/T124527#1983100 [11:48:52] Everyone is confused with the remove button :) [11:49:49] Do you think the checkboxes need to be removed? [11:50:05] the ones near 'Publisher' [11:50:23] I don't know what the checkboxes mean right now... [11:50:31] (and I'm kind of embarrassed to tell) [11:51:04] :) [11:51:14] it shows if the user is a publisher or not [11:51:25] if there's a tick he/she is a publisher [11:52:07] hm... I think the check boxes needs to be taken off :) [11:52:18] But how can Tinaj1234 appear in the "Publisher" column of "New newsletter" but then not have the box "Publisher" checked? [11:53:05] And what is perhaps more important: why in my "Manager newsletters" page do I see details about newsletters I cannot manage? [11:53:11] right [11:53:34] I can't find the logic behind the check boxes either :\ [11:54:27] I think the other one is fixed [11:54:53] From what I remember that was a bug which was fixed [11:55:11] I also don't know whether what I am seeing is whatb a normal publisher would see, because I believe I was made admin... [11:55:34] Anyway, let's discuss in violetto's task [11:55:58] I will follow up there, but I need to think a bit about this Manage page [11:56:23] yeah [11:56:56] alright, anything else? [11:57:11] hm, no [11:57:20] so much to do before security review [11:57:24] good, we stuck to our natural ,30 mins limit :) [11:57:38] the validation? [11:57:43] hehe [11:58:01] all the rest doesn't need to be finished for the security review, I believe [11:58:17] hmm [11:58:27] we need to be preparing for deployment though [11:59:00] anyways! security review comes first and let's try to pass that [11:59:01] yes, I think we will need to make some choinces about what to finish and what to leave for later [11:59:10] that [11:59:38] also, I'm thinking we need other people to review the extension ? [12:00:12] because it's always nice to see through other person's eyes [12:00:18] like when violetto reviewed [12:00:38] maybe after security review [12:01:07] yes, but we also need to think that "first deployment" is also a way to get more feedback [12:01:15] Not everybodty will jump in there on the first day. [12:01:26] right [12:01:29] And not everybody will check Labs or test [12:01:51] hmm, let's look forward to first deployment then ! [12:01:58] As long as the extension is functuonal and secure, I would not dely much for UI improvements [12:02:17] ... even if I think those UI improvements are badly needed [12:02:27] OK, lunch time here. :) [12:02:36] okay [12:02:43] catch you later, bye [12:03:18] bye, thank you for the chat [12:03:38] sure! [15:34:10] qgil: re https://phabricator.wikimedia.org/T119060 - This is not really needed as of now. We don't do any heavy processing to the data from the DB atm [15:34:15] (but I am not a performance expert and could be wrong!)