[10:33:13] tinajohnson___, tonythomas addshore Glaisher hi! Newsletter time. :) [10:33:38] Hi :) [10:36:15] https://phabricator.wikimedia.org/T135668 [10:36:23] Alright, it looks like today is going to be a quick one [10:36:39] I think it's just us [10:37:18] ^^was filed because I and tonythomas were having a hard time figuring out https://phabricator.wikimedia.org/T132022 [10:37:21] tinajohnson___, I just made that task a blocker of T135668 [10:37:22] T135668: Need documentation on How to integrate AbuseFilter with xyz extension - https://phabricator.wikimedia.org/T135668 [10:37:36] er... of https://phabricator.wikimedia.org/T132022 I mean [10:37:49] (oh my, we have a bot) [10:38:04] yeah! I just noticed ! [10:38:33] (two, in fact, hi wm-bot2 ) [10:38:46] ok, back to Newsletter [10:38:49] yeah [10:39:00] we 3 tasks awaiting review or under progress [10:39:08] *we have [10:40:31] tinajohnson___, about AbuseFilter integration documentation, would it help to see at least another extensioin with AF integrated? [10:40:46] we found one actually [10:40:54] ContentTranslation [10:41:05] I'm looking at the code as we speak [10:41:18] Ah, cool, that is under active development and fresh. [10:41:21] https://github.com/wikimedia/mediawiki-extensions-ContentTranslation/blob/3bd193097555cb0edb7fde201293b3b9da0ed5c6/includes/AbuseFilterCheck.php#L29 [10:41:28] yeah [10:41:29] OK, then there is hope. [10:41:48] yeah, some documentation would surely help though [10:41:51] I was looking at the list of authors at https://www.mediawiki.org/wiki/Extension:AbuseFilter [10:42:01] oh yeah, we tried that too :) [10:42:03] To ask for help [10:42:24] I couldn't find werdna or the others online [10:42:36] Marius Hock == hooman, he is as helpful as busy, poor him. :) [10:42:44] Hoch [10:43:00] yeah :) [10:43:34] I'll try my luck some time later [10:43:41] hope he'll be online [10:44:10] If hooman is online, he should be in the wikidata channel at least [10:44:43] the other three... might more difficult to find, I think they are pretty distant these days (but I haven't checked) [10:44:52] okay, will try in that channel [10:45:14] Seeing who did the integration in CX should be useful too. Chances are that it is someone in your timezone :) [10:45:48] okay [10:45:58] checking that [10:46:11] OK, let's look at the other blockers of the security review [10:46:23] https://phabricator.wikimedia.org/T119058 [10:46:30] okay [10:46:38] (no bot now?) [10:46:49] T119058 [10:46:49] T119058: Special:Newsletter fatals if the newsletter main page is deleted - https://phabricator.wikimedia.org/T119058 [10:46:52] ah :) [10:47:07] hehe [10:47:34] There are some discussions still pending I guess [10:47:44] There is an on discussion there, inactive since Friday. Mmmok. [10:47:50] I cannot help further there. [10:48:16] T132018 [10:48:16] T132018: Add newsletter description to log messages - https://phabricator.wikimedia.org/T132018 [10:49:01] hmm [10:49:09] Glaisher: has discussed a method [10:49:28] and there's a patch too [10:49:32] Ah, also blocked by T132016, which is the other remaining blocker of the security review. [10:49:32] T132016: Add CheckUser integration to Extension:Newsletter - https://phabricator.wikimedia.org/T132016 [10:49:35] but need to be reworked [10:50:08] Well, it looks like we have cleaned the little things, and we are fighting now with tough bones. Good, this is still progress. [10:50:32] (and again, I am saying "we" as an euphemism for "all you", thank you!) :) [10:50:39] https://phabricator.wikimedia.org/T132016 is blocked by T132018 [10:50:39] T132018: Add newsletter description to log messages - https://phabricator.wikimedia.org/T132018 [10:51:17] hmm [10:51:29] lots of inter dependent tasks :) [10:51:46] yeah, a bit of a mesh [10:51:51] *interdependent [10:53:37] Well, ok. in any case there has been good progress between last Thursday and this one. [10:53:51] Looking forward to next Thursday, then. :) [10:54:00] yeah :) [10:54:05] How are you doing tinajohnson___ with studies and everything? [10:54:12] I'll go looking for hoo then :) [10:54:28] I'm great. My course ends in a month [10:54:58] SUMMER! :) [10:55:14] My final exams are done as well !! I've some time in my hand :) [10:55:31] hehe! Monsoon actually [10:56:03] Well, yes, I need to be less euro-centric when talking about seasons. [10:56:31] yup! hehe [10:59:14] no luck find hoo :\ [10:59:20] *finding [11:46:26] Hrm. Not sure how we could do AbuseFilter checks for Newsletter changes because abuse filter works only for pages. [11:47:39] Oh.. Maybe we could emit an event/hook whenever there is a newsletter change and then add a handler in AbuseFilter [11:47:56] and have a separate group for newsletters like in flow [11:48:07] and introduce newsletter_* variables [11:48:18] tinajohnson___: qgil ^ That would work, I think. [12:04:04] tonythomas: Can you expand on what you meant by https://phabricator.wikimedia.org/T132018#2308449 ? [12:05:35] Glaisher: oh :\ my bad - we are not talking about a page here [12:06:06] removed :D [12:06:41] We'll probably have to introduce a history table [12:07:16] It would have fields like user, timestamp, content(?) etc. [12:07:23] okey - is there something http://php.net/manual/en/function.xdiff-string-diff.php [12:07:40] the content field would have the description stored in a json serialized blob [12:07:54] so that we can store other stuff in the future if we need to [12:08:40] tonythomas: We can use the diff engines in core [12:08:54] Glaisher: okey. Looks good. [12:09:00] I will paste this over there in the comment [12:09:03] That php function returns only a text diff, no? [12:09:12] Glaisher: we are talking about description ? [12:09:18] yes [12:09:25] so - text diff ? [12:09:56] I meant that it would return ugly diffs with all +++ and ---s [12:10:00] which isn't very human friendly [12:10:11] (excluding people like us!) [12:10:19] hehe. agreed [12:12:06] pasted. I will take a look at it next time I'm infront of my machine [12:12:20] ok great :) [12:13:36] andre__, if/when you have time, could help processing the Processing section at T135327 [12:13:36] T135327: Decide Phabricator improvements to be funded by WMF Technical Collaboration - https://phabricator.wikimedia.org/T135327 [12:13:42] please? [12:13:57] Especially filing upstream the tasks that you think deserve to be reported. [12:14:41] More specifically: the ones that you would like to see included in our selection of tasks to be funded, if any [12:26:11] on the list [16:22:07] Glaisher: you around ? was thinking of approaching https://phabricator.wikimedia.org/T132018! [16:22:29] yes here [16:23:10] wow. okey. - so this one 'It should add a log entry linking to a page showing the diff of the full description. ' [16:23:23] so - we are creating a page for description ? [16:23:43] and editing this description box acts like editing that page ? [16:24:30] Glaisher: that was from https://phabricator.wikimedia.org/T132018#2292269 [16:24:56] Why introduce another page? The /manage form works, no? [16:25:07] qgil: uhm, I went through T135327 but my input will have to wait until tomorrow, sorry :( [16:25:07] T135327: Decide Phabricator improvements to be funded by WMF Technical Collaboration - https://phabricator.wikimedia.org/T135327 [16:25:24] tonythomas: I meant to introduce another page for viewing the diff [16:25:34] no problem, thank you! [16:25:38] For eg. Special:Newsletter/id/history/diff-id [16:25:55] Glaisher: okey - another page to see the revisions of description .. .hmm [16:25:56] okey [16:26:08] You can take a look at Special:AbuseFilter [16:26:14] https://meta.wikimedia.org/wiki/Special:AbuseFilter/history/106/diff/prev/1187 [16:26:14] let me check [16:27:32] I personally feel its an overkill for the description :P ( as we are allowing only people with right to create and edit a a newsletter anyway ) -- but this looks like the right way of doing it [16:29:12] Well, we can have stuff other than description too [16:30:21] true. let me try coding this thing down [16:30:28] :D [18:32:11] Glaisher: should the db handling code and etc of the new nl_history thing go to the Logger class [18:32:31] or do you recommend creating a new something like ContentHIstory or something like that ?