[10:26:07] <Niharika>	 tonythomas: Thank you so much for reviewing Devi's patch. :)
[10:26:22] <tonythomas>	 Niharika: heh. oojs-ui conversion is my fav!
[10:26:36] <Niharika>	 tonythomas: :D I know nothing about it. :P
[10:26:41] <tonythomas>	 I have personally submitted couple of patchsets in that direction, (#showoff)
[10:27:07] <tonythomas>	 Niharika: well - its not that documented. had loads of trouble bringing in the first few patchsets
[10:28:38] <Niharika>	 tonythomas: Nice! I should give it a try sometime.
[13:07:26] <tonythomas>	 Glaisher: hey
[13:07:32] <tonythomas>	 you around ?
[13:07:50] <Glaisher>	 here now but have to leave soon
[13:08:08] <tonythomas>	 oops. it was to review https://www.irccloud.com/#!/ircs://irc.freenode.net:6697/%23wikimedia-devrel
[13:08:09] <tonythomas>	 err
[13:08:11] <tonythomas>	 https://gerrit.wikimedia.org/r/#/c/289720/
[13:09:25] <tonythomas>	 the thing is, I am storing the changed item as 'item' : { 'old' : "old version", "updated": "updated version" }
[13:09:34] <tonythomas>	 Glaisher: is there a better way of storing ?
[13:09:50] <Glaisher>	 changed item?
[13:10:28] <tonythomas>	 in the history table
[13:10:45] <tonythomas>	 nlh_contents in https://gerrit.wikimedia.org/r/#/c/289720/6/sql/nl_history.sql
[13:11:04] <Glaisher>	 Oh, you're storing both old and new descriptions?
[13:11:17] <tonythomas>	 had to :\
[13:11:36] <Glaisher>	 Can't you just insert a row for each version?
[13:12:11] <Glaisher>	 You can query the previous row in addition to the current row to generate a diff
[13:12:29] <tonythomas>	 if we are only storing changes in history, then that would be alright
[13:12:41] <tonythomas>	 err. changes in description
[13:13:12] <tonythomas>	 Later if we want to store other updations too, this will create an issue ?
[13:13:52] <tonythomas>	 and how do I ' generate a diff ' ?
[13:14:03] <Glaisher>	 No, as I said previously, you can store like { "description": "blabla", "name": "name-stuff" }
[13:14:16] <Glaisher>	 You can use core's DiffEngine?
[13:14:25] <tonythomas>	 havent used that :\
[13:14:38] <tonythomas>	 have got some example for me somewhere ?
[13:14:57] <Glaisher>	 You can look at the API documentation for it. :)
[13:15:09] <Glaisher>	 And you can also look at what core does too!
[13:16:05] <tonythomas>	 Alright. and one more thing - what is "name": "name-stuff"  doing there ?
[13:17:02] <Glaisher>	 That's just an example. I meant you can store different stuff, not just description, that way
[13:17:09] <Glaisher>	 ok, I need to leave now
[13:17:11] <Glaisher>	 bye
[13:17:20] <Glaisher>	 Hope to review the patch soon
[13:17:21] <tonythomas>	 Glaisher: alright. Thank you!
[13:17:23] <tonythomas>	 yeah