[13:03:32] tonythomas: What's the evaluations deadline? Wondering if I should postpone. [13:03:50] Niharika: its this 27th afaik [13:04:11] Due: June 27, 2016 at 20:59 (CEST) to be very sharp :D [13:04:23] Okay, I'll trick addshore into doing it. ;) [13:04:42] Niharika: yeah. he should be super busy :D [13:11:43] It's in my calander ;) [13:18:30] * Niharika points out that the e and a are swapped :P [13:30:26] Glaisher, hi, I have left a comment at https://gerrit.wikimedia.org/r/#/c/289720/ [13:31:18] Glaisher, tonythomas and I are at the Wikimania Hackathon willing to work on the remaining issues pending from the security review, and we are a bit overwhelmed about the changes requested to We are at the Wikimania [13:31:51] If you could help us keeping it as simple as possible to pass the security review, that would be great. [13:34:32] Niharika: https://chrome.google.com/webstore/detail/gerrit-be-nice-to-me/oafiggfcmbkeopoihflmjkhlligaefcd [14:52:39] addshore: you around ? [14:58:45] yes [15:18:16] ping tonythomas [15:20:36] addshore: can you review this one ? https://gerrit.wikimedia.org/r/#/c/295503 -- this is the minor implementation of description change, and do you think it would suffice ? [15:23:00] tonythomas: have you verified it? :) [15:23:21] addshore: well. I was writing in my local, and I can see the log in Special:Log :D [15:23:36] if you can call that verification, then Yeah! [15:24:04] I keep the original one in the entry 'comment, and the modified one in the entry itself [15:25:05] hmmmmmm [15:25:24] might get bulky if we have a large description ? [15:25:31] Yeh :/ [15:25:58] For exmaple: [15:25:58] The Signpost is a community-written and edited newspaper that covers stories, events, and reports related to the English Wikipedia, its sister projects, the Wikimedia Foundation, and the Wikimedia movement at large. A new issue is published each week, and you can subscribe via talk page delivery (also available on sister projects), RSS Feed Feed-icon.svg, [15:25:58] and template transclusion. We also have social media accounts on Facebook and Twitter. For more on subscribing see our subscriptions page. [15:26:13] yeah. This can be pretty long :D [15:26:20] That would be super long there, and changing 1 word would result in a log line which is then 2 times that length? [15:26:30] exactly! [15:26:37] :( [15:26:42] the same motivation behind we going for diffs [15:26:57] I have a patch that does it halfway, and if it gets some of your help, maybe we can complete it [15:27:13] but I need to know where you are as of now :D [15:27:24] ( and you should be free for like 10 mins ) [15:27:28] maybe the descript should be stored on a subpage of the main newsletter page or something? [15:28:13] well. I thought about a separate history page after https://gerrit.wikimedia.org/r/#/c/289720/ [15:28:32] which does something like abusefilter changes log [15:28:56] I could create the table which lists down everything, and later when I try to examine it, I am not able to produce the diff correctly [15:30:44] addshore: we were trying to make something like https://meta.wikimedia.org/w/index.php?title=Special%3ALog&limit=1&offset=20160430174915&type=abusefilter&user=Glaisher [15:31:58] oooh, okay, I'd have to go and look at how abuse filter does that :P [15:32:05] does it just have a history table for itself then? [15:32:29] addshore: abuse filter has one. I have things changed a bit from the original change in Gerrit though [15:32:55] Its this one https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/Views/AbuseFilterViewDiff.php we are trying to get hold on [15:33:05] hmm, okay, abuse filter often isnt a great email to follow [15:33:13] can you link me to your patch doing that then and I'll have a look [15:33:27] oh wait its https://gerrit.wikimedia.org/r/#/c/289720/ right? [15:34:56] addshore: yeah. I have made couple of more changes too, removing the existing table and stuff [15:35:33] I will push that soon, or if you can **reveal** your location, I can come over there, when you are free! [15:35:50] * addshore is not in italy :P [15:36:15] addshore: what. Ah. sad :( [15:36:31] yeh, but feel free to poke me about all the wikimania things still throughout this week :) [15:36:59] addshore: I will :D let me just push what all I can get done. [15:38:16] :) [15:46:22] Niharika: tonythomas o/ [15:46:34] codezee: hello! [15:47:38] tonythomas: how's everything? I've not been in touch for quite a while... [15:49:12] codezee: well. its going smooth afaik. Right now we got to bug rest of the mentors to get the mid-term evals done [15:49:23] yes :P [16:10:41] addshore: around ? I got something with the table pager class