[12:05:14] Glaisher: it would be great if you can review that one https://gerrit.wikimedia.org/r/#/c/295670 :) [12:05:52] tonythomas: I'm taking a quick look at it right now [12:06:00] Glaisher: Thank you :) [12:13:57] tonythomas: Added some comments. I only took a look at the code, not tested [12:14:35] Glaisher: thank you. the onSkinTemplateNavigation was directly copied with little modification from MassMessage :D [12:14:45] oh :) [12:14:45] just asked legoktm if we really need all those inside though [12:15:02] its one part of the patch which I got no clue about :D [12:15:14] will try removing them by part, and see how things break :) [13:20:05] Glaisher: its ready for another round of review ;) [13:20:09] https://gerrit.wikimedia.org/r/#/c/295670/ [16:28:18] tonythomas: I just tested it. It breaks all the existing newsletters [16:30:13] Also I don't understand what the difference is supposed to be between the special page and the newsletter page now [21:48:12] Glaisher: break of all existing newsletters are expected as per legoktm [21:48:39] and also, I have to remove all those lines of code from Special:Newsletter/id [21:48:48] as its no more useful.