[16:05:41] <tonythomas>	 Glaisher: hey!
[16:05:57] <tonythomas>	 Glaisher: have time to take a look at our contenthandler patch ?
[16:06:20] <tonythomas>	 https://gerrit.wikimedia.org/r/#/c/295670/
[16:06:21] <Glaisher>	 tonythomas: I thought it was still not complete?
[16:06:27] <Glaisher>	 is*
[16:06:37] <tonythomas>	 Glaisher: it is ?
[16:12:50] <Glaisher>	 tonythomas: It still has a WIP tag :)
[16:13:02] <tonythomas>	 Glaisher: removing it now :D
[16:13:05] <Glaisher>	 tonythomas: Also, did you remove the unused code?
[16:13:12] <tonythomas>	 Glaisher: not yet :o
[16:13:34] <Glaisher>	 Yeah, I don't see the unused code in Special:Newsletter removed
[16:13:50] <Glaisher>	 the main view, that is
[16:15:06] <Glaisher>	 I will try to test it soon and see whether everything works as expected
[16:15:24] <tonythomas>	 Glaisher: Thank you! I will try removing that files shortyl!
[16:19:00] <Glaisher>	 tonythomas: Is NewsletterDeletionUpdate actually used anywhere?
[16:19:48] <tonythomas>	 Glaisher: just a minute. I need to grep
[16:20:41] <tonythomas>	 I do not see it used!
[16:20:51] <Glaisher>	 I think I'll do some reviewing right now :)
[16:21:57] <tonythomas>	 Glaisher: great. can you just comment it over there, so that I do not miss it
[16:22:45] <Glaisher>	 added
[16:22:50] <tonythomas>	 once you finish reviewing, I can send in an updated patch (otherwise, might miss the comments, the new gerrit is not that cool with me, yet)
[16:27:55] <Glaisher>	 tonythomas: Since this breaks all the previous newsletters, should I delete them all before testing this? or do you have any plans for migration?
[16:28:17] <tonythomas>	 Glaisher: we will have to delete them all :( legoktm was telling me the same thing
[16:28:39] <Glaisher>	 ok
[16:41:02] <tonythomas>	 Glaisher: one thing I miss is the rights and etc
[16:41:20] <Glaisher>	 What do you mean?
[16:41:26] <Glaisher>	 Rights are no longer used?
[16:41:33] <tonythomas>	 it seems not :(
[16:42:01] <Glaisher>	 It should be fixed.
[16:42:11] <Glaisher>	 I'm currently doing testing instead of code review.
[16:43:01] <tonythomas>	 and Glaisher it seems like the deletionUpdate gets called on page deletion
[16:43:14] <tonythomas>	 content/NewsletterContent.php on line 340
[16:44:16] <Glaisher>	 I'll look at the code in detail once we fix the actual user visible issues
[16:45:17] <tonythomas>	 Glaisher: true. I hope the functionalities are not affected that much!
[16:45:46] <Glaisher>	 I've already noted several issues - will post them in a while
[16:46:11] <tonythomas>	 great :)
[16:49:56] <Glaisher>	 tonythomas: Hmm, maybe we should remove the main page field now and make the description be parseable, seems a little weird to have a real page for a newsletter now and then ask for another page again. Thoughts?
[16:50:12] <Glaisher>	 (but they can be done later too if we want to do that)
[16:51:00] <tonythomas>	 and I wish we could directly make a new wiki page if not exist with the newsletter name and the description right there from Special:Newsletters
[16:51:10] <tonythomas>	 but that would make people with already a newsletter to connect to it difficult
[16:55:08] <Glaisher>	 tonythomas: Added them to gerrit
[16:55:27] <Glaisher>	 I haven't tested thoroughly - just some obvious issues for now :)
[17:10:01] <tonythomas>	 Glaisher: true. Thanks