[06:20:40] Glaisher: any chance you are around ? [06:21:05] hi [06:21:07] we have the newsletter thingy to complete. Sorry for not being around these two days! [06:21:26] hmm [06:21:30] I also haven't worked on it [06:21:48] Glaisher: okey. have time today ? [06:21:57] maybe we can decide on splitting, and then work on it! [06:22:02] not right now I have to leave soon [06:22:12] You can work on the ContentHandler part [06:22:22] Okey - that should go as a patch over this one, https://gerrit.wikimedia.org/r/#/c/303984/ right ? [06:22:23] I can work on the UI that's already in progress [06:22:32] great. will do that then. [06:22:47] yeah, but this means it will have to be rebased every now and then which might be a pain :S [06:22:56] Glaisher: true :\ [06:23:07] so - something more is to be done with the original https://gerrit.wikimedia.org/r/#/c/303984/ ? [06:23:16] yeah, that's not complete yet [06:23:16] in that case, I can maybe wait [06:23:39] I don't think it would be that hard if you just did what was done in the original patch [06:24:01] In the existing patch, it will most likely only conflict in the submit callback part [06:29:08] Glaisher: okey. Then I will go for the contenthandler thing rightnow. [06:29:51] yeah, thanks [07:15:54] Glaisher: one more thing, I will have to replace that EditPage you wrote, right ? [12:22:10] tonythomas: Replace it with what? [12:22:12] You will need to add ContentHandler code to it. [12:24:00] Glaisher: yeah. I got it. now changing it :) [12:25:01] just now made the edit one work fine. Let me just push it! I wont be here for another 12 hours ( travelling ) [12:27:53] ok [12:32:18] Glaisher: https://gerrit.wikimedia.org/r/#/c/304692/ is up! [12:32:25] I was already looking. :) [12:32:45] Why did you add an AlternateEdit hook handler? [12:33:16] CustomEditor already does that work [12:34:36] Ah, make sense because I haven't made EditPage work for edits yet! [12:34:38] Only creations [12:34:47] yeah - on edits it seems like I would need it! [12:35:12] Once I finish doing the EditPage code it shouldn't be needed. [12:38:02] great. If you comment, I can take a look at it early tomorrow!