[06:34:17] <tonythomas>	 legoktm: hey. you around ?
[06:34:25] <tonythomas>	 had something with the contenthandler stuff again!
[06:34:29] <legoktm>	 hey
[06:34:31] <legoktm>	 what's up?
[06:35:09] <tonythomas>	 legoktm: great. so addshore was asking me why we are not storing the publishers list as an array, and then a json list - as currently we are storing it as a string, then imploding with "\n"
[06:35:18] <tonythomas>	 I think I copied that logic from MassMessage ?
[06:35:31] <tonythomas>	 is there any specific reason why the JSON list might not work ?
[06:35:38] <legoktm>	 heh
[06:35:40] <legoktm>	 don't think so
[06:36:02] <tonythomas>	 legoktm: alright. I think that would make the code look more clean
[06:36:04] <tonythomas>	 changing it then.
[06:37:17] <tonythomas>	 ah. I think massmessage is storing it as a list too https://github.com/wikimedia/mediawiki-extensions-MassMessage/blob/master/includes/SpecialCreateMassMessageList.php#L134
[06:37:24] <tonythomas>	 hmm. dont know where I got the other thing one :\
[06:38:01] <legoktm>	 also, one of the cool things is that you don't have to make the format perfect immediately
[06:38:10] <legoktm>	 you can (kind of) change it as you move forward
[06:38:21] <tonythomas>	 legoktm: oh. that is true
[06:38:25] <legoktm>	 there's a function called Content::preSaveTransform()
[06:38:42] <legoktm>	 before something is saved, it is called, and you can change the internal strucutre of the content before it is saved
[06:38:52] <tonythomas>	 oh. that is nice.
[06:39:01] <legoktm>	 you just have to make sure that when you read from the database, you are always compatible with the old way (string or array)
[06:39:12] <tonythomas>	 anyway, I think the current saving as string and later implode is ineffecient
[06:39:20] <tonythomas>	 legoktm: true.
[06:40:07] <tonythomas>	 let me try changing it anyway. Our patch has been in gerrit for so looooong
[07:35:57] <addshore>	 :D
[07:36:12] <addshore>	 tonythomas: if you were in Berlin now we could just sit down and get it all merged ;)
[07:52:12] <tonythomas>	 addshore: argh. I miss the hackathon days :( Hope this one gets merged before I hit berlin.
[08:01:51] <addshore>	 :D
[08:02:10] <addshore>	 I dont think I asked, or maybe I did and I forgot, where are you staying in berlin?
[08:03:15] <tonythomas>	 addshore: landing there on Oct 11th!
[08:03:47] <addshore>	 I might be around on the 29th of oct
[08:03:58] <addshore>	  / that weekend ish
[08:05:15] <tonythomas>	 addshore: yay - there is some FOSS event happening over there, I guess ?
[08:05:20] <addshore>	 yup
[08:05:21] <tonythomas>	 https://gerrit.wikimedia.org/r/#/c/304692 is updated too.
[08:05:49] <tonythomas>	 addshore: thats going to be great. Oct 29th is the same day when the Google Mentor summit too happens :\
[08:05:56] <addshore>	 oh.. :P
[08:06:01] <tonythomas>	 so I would be leaving the city (if everything goes like this)
[08:15:41] <addshore>	 ahh
[08:15:42] <addshore>	 okay!
[09:19:26] <tonythomas>	 addshore: and that patch would want one more review :D
[09:19:33] <tonythomas>	 (in case that got missed)
[09:52:35] <addshore>	 :D
[09:52:39] <addshore>	 I'll see if I can look today!
[12:25:15] <tonythomas>	 andre__: hey. I found something more
[12:25:53] <tonythomas>	 in https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch  -- it is said just to clone the Mediawiki core, and I see people just execute that command straightaway, while it should be actually done from the webserver DocumentRoot
[12:26:02] <tonythomas>	 this can be like /var/www/html/ in most apache installs
[12:26:31] <tonythomas>	 all my attendees (I guess), gets stuck here, and just clone the thing from where the terminal is at that point, and then wonders
[12:26:55] <tonythomas>	 but its an expected knowledge for someone who have done something with php, apache etc, that the app should rest in the documentroot, though
[12:30:55] <andre__>	 tonythomas: thanks! could you add an additional comment to the task so I don't forget?
[12:31:03] <andre__>	 IRC stuff gets lost too easily...
[12:31:08] <tonythomas>	 andre__: adding in now
[12:32:38] <andre__>	 thx
[12:32:42] <tonythomas>	 done