[05:51:33] <tonythomas>	 addshore: hope you get more time today :)
[09:06:28] <addshore>	 tonythomas: around now?
[09:06:41] <tonythomas>	 addshore: I am!
[09:06:43] <tonythomas>	 :)
[09:06:53] <addshore>	 right, lets do a big review push for newsletter then :0
[09:06:58] <addshore>	 reviewing https://gerrit.wikimedia.org/r/#/c/303984/ first
[09:07:01] <tonythomas>	 addshore: amazing.
[09:07:05] <tonythomas>	 I'm all set
[09:08:19] <tonythomas>	 so there are some things here - we do not have written code for making the manage page call the contenthanlder etc. its just for the new page creations - like - action=edit in a Newsletter namespace
[09:08:33] <tonythomas>	 the manage still just takes in the data, and stores it into the db, and nothing much
[09:08:46] <tonythomas>	 that should go to the next patchset, as per Glaisher's plan
[09:11:42] <addshore>	 okay
[09:11:56] <addshore>	 tonythomas: want to remove the WIP from that first patch?
[09:12:05] <tonythomas>	 addshore: removing now
[09:12:44] <addshore>	 also tonythomas there is an evil tab on line 13 of https://gerrit.wikimedia.org/r/#/c/303984/6/includes/NewsletterEditPage.php
[09:12:59] <addshore>	 also in the edit method of that class, what are with all of the comments? are they todos?
[09:13:03] <tonythomas>	 alright. I will dowload and change it. sec
[09:13:11] <tonythomas>	 addshore: yeah!
[09:13:22] <addshore>	 can you add a //TODO line? :)
[09:13:31] <tonythomas>	 alright. on it
[09:13:35] <addshore>	 (also it looks like some of them are already done)
[09:15:07] <tonythomas>	 addshore: in the follow up one, right
[09:15:23] <tonythomas>	 I fear a merge conflict :o
[09:15:24] <addshore>	 well some are done in that one, like readme and the permissions check
[09:15:28] <addshore>	 ahhh, okay
[09:16:38] <addshore>	 so what is the planned workflow? Go to something like Newsletter:Foo, create a newsletter and have the wikipage in some other namespace (project namespace probably?>
[09:17:13] <addshore>	 Then navigating to Newsletter:Foo will show you the details of the newsletter?
[09:18:12] <tonythomas>	 addshore: done.
[09:18:33] <addshore>	 mwahaaa, there is indeed apparently a merge conflict ;)
[09:18:42] <tonythomas>	 addshore: argh :/
[09:18:44] <tonythomas>	 let me correct
[09:19:31] <tonythomas>	 addshore: you sure about that one - https://gerrit.wikimedia.org/r/#/c/304692/5 shows nothing strange ?
[09:19:39] <addshore>	 I cant click rebase
[09:20:09] <tonythomas>	 for https://gerrit.wikimedia.org/r/#/c/304692/5  right -- let me check
[09:20:22] <tonythomas>	 argh. https://gerrit.wikimedia.org/r/#/c/304692/5
[09:20:27] <tonythomas>	 yeah. I see that. let me check
[09:27:50] <tonythomas>	 argh. it seems to be messy :
[09:30:08] <addshore>	 :D
[09:31:17] <tonythomas>	 addshore: do you see this - https://gerrit.wikimedia.org/r/#/c/304692/5/includes/NewsletterEditPage.php  and https://gerrit.wikimedia.org/r/#/c/303984/7/includes/NewsletterEditPage.php ?
[09:31:29] <tonythomas>	 I dont even think they were built over one another
[09:36:19] <addshore>	 oooh, tonythomas maybe they were not....
[09:36:28] <tonythomas>	 addshore: oh. really ?
[09:36:29] <addshore>	 but geerr ti says they were? O_o
[09:36:33] <tonythomas>	 yeah ?
[09:36:55] <addshore>	 yeh, they are based on each other!
[09:38:22] <tonythomas>	 addshore: yeah. I just cant get which one was the base one here :\
[09:39:10] <addshore>	 tonythomas: the easies was to solve is would likely be copy out the chunk that was added to https://gerrit.wikimedia.org/r/#/c/304692/5/includes/NewsletterEditPage.php then just use the whole of https://gerrit.wikimedia.org/r/#/c/303984/7/includes/NewsletterEditPage.php and paste that chunk back in
[09:40:17] <tonythomas>	 if that sounds easy, let me try
[09:48:25] <tonythomas>	 I'm doing something. hope it might work out. let me check
[09:48:45] <tonythomas>	 yay. rebased now.
[09:48:48] <tonythomas>	 now pasting our new contents.
[09:51:58] <tonythomas>	 argh. no no
[09:54:46] <tonythomas>	 addshore: yay. https://gerrit.wikimedia.org/r/#/c/304692/ loosk good ?":
[09:55:06] <tonythomas>	 git is just a mystery :/
[09:55:11] <tonythomas>	 = )
[11:20:57] <addshore>	 tonythomas: I went out to lunch ;)
[13:24:35] <addshore>	 but im back now
[13:24:52] <addshore>	 so tonythomas did the workflow I described fit what we are aiming for?
[13:25:06] <addshore>	 Go to something like Newsletter:Foo, create a newsletter and have the wikipage in some other namespace (project namespace probably?>
[13:25:06] <addshore>	 11:17 AM Then navigating to Newsletter:Foo will show you the details of the newsletter?
[13:47:19] <tonythomas>	 addshore: hey. I got here
[13:47:29] <tonythomas>	 youre here ?
[14:17:55] <addshore>	 tonythomas: yes!
[14:18:47] <tonythomas>	 addshore: alright. so after creating Newsletter:Foo, yeah - it should show its details. true
[14:22:41] <addshore>	 so, all of the special page logic should be put in the edit pgae thing
[14:23:11] <tonythomas>	 addshore: exactly. That should be next step.
[14:23:15] <tonythomas>	 let me fix those comments.
[14:23:22] <addshore>	 :)
[14:30:26] <tonythomas>	 addshore: done.
[14:30:32] <tonythomas>	 phpstorm took its time to load up.
[14:31:04] <addshore>	 I think instead of merging anything now though we should keep building the patches up until it is all ready :)
[14:31:33] <tonythomas>	 addshore: exactly.  I can go for the next one, then ?
[14:31:39] <tonythomas>	 like pasting things into the editpage ?
[14:31:39] <addshore>	 yeh! :D
[14:32:00] <tonythomas>	 alright. so this one would be to make the manage thing use the EditPage, right
[14:40:26] <tonythomas>	 addshore: just to confirm - we would need to move the editing logic too to the EditPage ?
[14:40:39] <addshore>	 i believe so!
[14:40:49] <tonythomas>	 addshore: alright - so every editing is gonna happen there. nice
[14:41:00] <tonythomas>	 so that would mean more params passed to Editpage()
[15:40:21] <tonythomas>	 addshore: hey. Looks like I am getting a validator error
[15:40:27] <addshore>	 =o
[15:40:35] <tonythomas>	 on editing, as it expects a newsletter 'Name' too in edit page
[15:40:42] <tonythomas>	 but in Edit page, we are not allowing that one afaik
[15:43:36] <tonythomas>	 alright. looks like Glaisher or me added that extra filed in one of our commits. removing it
[15:44:50] <tonythomas>	 hmm. but I dont feel like throwing off that one either. Let me make two different required fields, then
[15:48:07] <tonythomas>	 aha. now we have Catchable fatal error: Argument 1 passed to NewsletterContent::doLinkCacheQuery() must implement interface Iterator, instance of Status given, called in /var/www/core/core/extensions/Newsletter/includes/content/NewsletterContent.php on line 161 and defined in /var/www/core/core/extensions/Newsletter/includes/content/NewsletterContent.php on
[15:48:07] <tonythomas>	 line 301
[15:57:26] <tonythomas>	 addshore: yay. fixed it. will be pushing in soon
[15:57:32] <tonythomas>	 have some qqq and i18n
[15:58:03] <addshore>	 =]
[16:01:18] <tonythomas>	 addshore: pushing in now.
[16:04:34] <tonythomas>	 addshore: https://gerrit.wikimedia.org/r/#/c/309849/