[05:29:37] <qgil>	 Hi tonythomas, is there a date for the hackathon in Amrita university?
[05:30:12] <tonythomas>	 01 - 02 October, https://www.mediawiki.org/wiki/Wikimedia_Hackathon_Amrita_University ?
[05:30:23] <tonythomas>	 ** close **
[05:30:37] <qgil>	 OK, thank you!
[05:31:15] <tonythomas>	 qgil: welcome!
[09:35:40] <tonythomas>	 addshore: hey! Hows the day ? Got some minutes for the contenthandler ?
[09:38:15] <addshore>	 tonythomas: yes
[09:38:26] <addshore>	 so, where did we get to?
[09:39:24] <tonythomas>	 addshore: great.
[09:39:34] <tonythomas>	 so we could make the manage form too work with the contenthandler
[09:39:38] <tonythomas>	 let me take the latest patch
[09:40:17] <tonythomas>	 addshore: https://gerrit.wikimedia.org/r/309849 is the one, which immediately needs your review
[09:40:34] <tonythomas>	 we have to remove the code from the special page too, which should be done as part of this patch ( I guess ? )
[09:40:34] <addshore>	 well, it works :P
[09:40:37] <addshore>	 what is next!? ;)
[09:40:42] <tonythomas>	 addshore: yeah. it works :P
[09:40:58] <tonythomas>	 okey - so removing that code from the special page ?
[09:41:08] <tonythomas>	 should I amend that too to this change ?
[09:41:35] <addshore>	 yeh, do it in this change too I think :)
[09:41:37] <tonythomas>	 Glaisher: was telling something about it, I guess
[09:41:41] <addshore>	 then, what is next?
[09:41:45] <tonythomas>	 addshore: alright. Let me amend it now, then
[09:41:49] <tonythomas>	 okey - what is next -- :D
[09:42:04] <tonythomas>	 looks like right now we have creating and editing handled by the contenthandler
[09:42:07] <tonythomas>	 next would be deleting ?
[09:42:10] <tonythomas>	 and restoring, etc ?
[09:43:02] <addshore>	 yes, so it looks like you need to fix some links too, for example, when I unsubscribe, I still get linked tot he special page
[09:44:16] <tonythomas>	 addshore: yeah. those too.
[09:45:16] <tonythomas>	 killing those now
[09:45:18] <addshore>	 so, right now as well it is storing stuff both in the page content and in the newsletter dbs right?
[09:45:36] <tonythomas>	 addshore: yeah - I too noticed that
[09:45:39] <tonythomas>	 we might not need that ?
[09:45:47] <addshore>	 so I think that would probably be the next step
[09:45:57] <tonythomas>	 (that might be a tricky, and fat change, I did not have it in my original one)
[09:47:15] <tonythomas>	 addshore: and the links from the table still redirects to Special:Newsletter/id - which should nto happen too, right
[09:47:25] <tonythomas>	 we should just point it to Newsletter:Foo
[09:47:32] <addshore>	 thought i guess we will still need a few db tables, like the index of newsletters, and because Special:Newsletters has filters for newsletters that you are subscribed to I guess we will need toe subscriber table too
[09:47:53] <tonythomas>	 addshore: yeah - we might need that.
[09:47:56] <addshore>	 but
[09:48:07] <addshore>	 we might just be able to store that in the page_props table?
[09:48:21] <addshore>	 and or user props.
[09:48:41] <addshore>	 who was it that proposed using contenthandler stuff again? and did they have a plan for what should stay in the db etc?
[09:48:55] <tonythomas>	 it was legoktm !
[09:48:58] <tonythomas>	 hope he is around ?
[09:49:07] <addshore>	 probably not right now :P
[09:49:16] <legoktm>	 yep, definitely not still awake
[09:49:20] <addshore>	 ..
[09:49:22] <tonythomas>	 heh
[09:49:33] <addshore>	 2:49 am ;)
[09:49:46] <tonythomas>	 orly ? :o
[09:49:57] <legoktm>	 how is subscription stored?
[09:50:07] <tonythomas>	 in a table with newsletter id, user_id
[09:52:44] <addshore>	 publishers and subscriptions can probably be in user props? and general newsletter flags, like is_active can be in page_props... Issues could be subpages of the newsletter? Though I am now sure, can content models be mixed in a namespace ?
[09:53:35] <legoktm>	 yes, you can mix them
[09:53:42] <legoktm>	 just use the ContentHandlerGetDefaultFor hook
[09:53:53] <legoktm>	 er, ContentHandlerDefaultModelFor
[09:54:40] <addshore>	 cool, then tonythomas I think that might be a good plan to push for!
[09:56:05] <tonythomas>	 ... alright. these are things which I do not understand fully, but ready to give a try ...
[10:03:04] <tonythomas>	 addshore: pushed the change which kills manage things
[10:03:12] <tonythomas>	 and also fix redirection from table
[10:03:28] <tonythomas>	 let me try finding out why addshore> yes, so it looks like you need to fix some links too, for example, when I unsubscribe, I still get linked tot he special page is happening
[10:51:28] <tonythomas>	 legoktm: any chance you are still awake ?
[10:51:37] <legoktm>	 nope
[10:51:46] <legoktm>	 I mean :P
[10:52:54] <tonythomas>	 legoktm: heh. alright - so this one is with Newsletter:Lala6/announce -- I am just not getting where to put the code to extract the subpage from and provide something custom (like the manage form)
[10:53:10] <tonythomas>	 err. let it be Newsletter:Foo (:/)
[10:53:27] <tonythomas>	 I can get Newsletter:Edit from the 'Edit' one though
[10:54:04] <tonythomas>	 so this announce and unsubscribe/subscribe should still need a special page ?
[10:54:23] <tonythomas>	 or is there a way I can get the subpage edited in some sort of way ? No, I guess
[10:54:44] <tonythomas>	 as Newsletter:Foo/subpage is actually expected to be Newsletter issues
[10:55:26] <tonythomas>	 or can I have something like action=subscribe, and provide a custom page there ?
[10:55:37] <legoktm>	 I would suggest doing a special page
[10:57:19] <tonythomas>	 legoktm: alright.
[10:57:42] <tonythomas>	 so this special page will still show the newsletter id, etc on the top
[10:57:42] <tonythomas>	 alright
[12:33:35] <tonythomas>	 addshore: https://gerrit.wikimedia.org/r/309849 should be ready for review now
[12:33:46] <tonythomas>	 had some trouble connecting the subtitles, but it should work now.
[16:41:42] <tonythomas>	 addshore: looks like jenkins had already given it a -1 :\ Noticed only now
[16:44:41] <addshore>	 :/
[16:44:56] <addshore>	 probably wont have any time to look at it for a while now, at a conference and travelling till monday
[16:45:34] <tonythomas>	 addshore: I think I fixed it though.
[16:45:43] <tonythomas>	 was some problem with me not checking if $data->publishers is set
[16:45:54] <tonythomas>	 addshore: oh. where is it ?
[16:51:53] <addshore>	 belgium
[16:52:01] <addshore>	 then heading back to the uk
[16:52:12] <addshore>	 about to go and meet a friend i just found is in Berlin today though!
[16:56:33] <tonythomas>	 addshore: wow. Sounds fun. Hope to see more pics in facebook :)