[04:39:34] addshore: Glaisher : in case you people are around! https://gerrit.wikimedia.org/r/#/q/topic:shiftToContentHandler still needs your review :) [10:13:18] andre__: do you think that the pushing something to example doc in Gerrit is like misguiding ? [10:13:42] I see couple of applicants who filled my prerequisites spamming Gerrit :( [10:13:45] sorry for that [10:14:31] tonythomas: I don't think spamming Gerrit in the Examples repository is necessarily bad. [10:14:47] plus I'm watching that one, so I can add a stock answer to new contributors' patches [10:14:54] andre__: heh. in that case, its okey ;) [10:15:22] tonythomas: see e.g. my comment in https://gerrit.wikimedia.org/r/#/c/313359/ - that's my boilerplate text [10:15:39] tonythomas: hopefully soon to be replaced by an automatic text, see https://phabricator.wikimedia.org/T73357 - your input is welcome :) [10:15:50] and thanks for your edits on mw:Gerrit/Tutorial - very very welcome! [10:17:44] andre__: wow. that one phab task looks nice. Heh Gerrit tutorial, I see people making mistakes pushing in stuff, and I correct :D [10:23:42] tonythomas: thank you * a lot* for that. Because I don't have the opportunity to take a look over other people's shoulders [10:24:58] petan: Re terminology: Subtasks need to get fixed first to resolve a parent task. hence subtasks block a parent task. [10:31:42] andre__: welcome. its more or less fun :) the thing is people use Gerrit tutorial to clone and setup mediawiki + push patchsets. [10:32:25] I think the order of things over there in the tutorial do not support that one though (like cloning an example extension in between, when they do not even have MW installed ) [10:32:32] will change it in future :D [10:40:35] qgil: addshore, Glaisher: anyone up for the Newsletter meeting ? [10:40:42] (atleast, for a review ?:P ) [10:42:33] Hi tonythomas I'm here. [10:51:48] While I cannot review code, I want to insist that this extension keeps being very important for our plans around the Technical Collaboration Guideline. And I have no doubt that many community projects will find it useful as soon as we deploy it in Wikimedia. [10:53:20] qgil: true. Its just because the patchsets are huge, and we are limitted by a very small pool of reviewers [10:53:41] in the worst case, I can test the basic functionalities myself, merge it - and let it go through the sec and other reviews again [10:54:02] At this point, this doesn't sound like a bad idea. [10:54:03] but it would look like I merging mine own patchsets . [10:54:10] legoktm: you are around ? [10:54:18] Hopefully legoktm is sleeping [10:54:29] even if legoktm can spend some time taking a look at the contenthandler usages, it would be good enough [10:54:53] Are these large patchsets all your code, or have you borrowed cunckus from somewhere else already reviewed? [10:55:01] chunks [10:55:28] qgil: most of them are our own, but the functionality, and sometimes parts of it are copied form massmessage, which already use contenthandler [10:56:00] tonythomas, I think you cannot be blamed for trying to squeeze some code to Wikimedia while nobody was looking. [10:56:11] tonythomas: links? [10:56:15] legoktm: wow. [10:56:23] https://gerrit.wikimedia.org/r/#/q/topic:shiftToContentHandler [10:56:28] Gosh, this legoktm has reached singularity by now. ;)\ [10:57:01] is the extension deployed anywhere? [10:57:12] as in, do we need to care about migrating existing data? [10:57:22] legoktm: the bottom one - https://gerrit.wikimedia.org/r/295670 - is meant to be abandoned, as we split it to the following ones [10:57:24] qgil: yeah, school started and now my sleep schedule is totally gone [10:57:37] legoktm: its just deployed in beta, but nothing on it, I guess - isnt it qgil ? [10:58:06] https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:Newsletter [10:58:13] no need to care about migrating anything [10:58:17] true. [10:58:23] This extension is starting from scratch [10:58:45] apparently, it is :D [11:07:35] left some comments [11:07:38] night [11:10:11] legoktm: Thank you! [11:10:19] 'night [11:10:58] legoktm, thank you very much [11:11:06] yay. we got one merged too :) [11:11:44] I can fix the other ones fast, but I do not have my `own` laptop with me :( [11:12:35] I'm on a temporary one, as mine had to go through trackpad failure [11:13:54] There is no lack of anecdotes in this project... :) [11:17:18] qgil: heh. true. anyway, will get mine back tonight :D